summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
Diffstat (limited to 'tests')
-rw-r--r--tests/lib/autoloader.php2
-rw-r--r--tests/lib/share20/defaultshareprovidertest.php188
-rw-r--r--tests/lib/share20/managertest.php1204
-rw-r--r--tests/lib/updater.php38
4 files changed, 1406 insertions, 26 deletions
diff --git a/tests/lib/autoloader.php b/tests/lib/autoloader.php
index 9fb717c4f63..6443d87a2e5 100644
--- a/tests/lib/autoloader.php
+++ b/tests/lib/autoloader.php
@@ -90,7 +90,7 @@ class AutoLoader extends TestCase {
public function testLoadCoreNamespaceRepair() {
$this->assertEquals([
- \OC::$SERVERROOT . '/lib/repair/foo/bar.php',
+ \OC::$SERVERROOT . '/lib/private/repair/foo/bar.php',
], $this->loader->findClass('OC\Repair\Foo\Bar'));
}
}
diff --git a/tests/lib/share20/defaultshareprovidertest.php b/tests/lib/share20/defaultshareprovidertest.php
index dc45bc7c085..beef4c9ef53 100644
--- a/tests/lib/share20/defaultshareprovidertest.php
+++ b/tests/lib/share20/defaultshareprovidertest.php
@@ -26,6 +26,12 @@ use OCP\IGroupManager;
use OCP\Files\IRootFolder;
use OC\Share20\DefaultShareProvider;
+/**
+ * Class DefaultShareProviderTest
+ *
+ * @package Test\Share20
+ * @group DB
+ */
class DefaultShareProviderTest extends \Test\TestCase {
/** @var IDBConnection */
@@ -533,4 +539,186 @@ class DefaultShareProviderTest extends \Test\TestCase {
$this->assertEquals(null, $children[1]->getExpirationDate());
$this->assertEquals('myTarget2', $children[1]->getTarget());
}
+
+ public function testCreateUserShare() {
+ $share = new \OC\Share20\Share();
+
+ $sharedWith = $this->getMock('OCP\IUser');
+ $sharedWith->method('getUID')->willReturn('sharedWith');
+ $sharedBy = $this->getMock('OCP\IUser');
+ $sharedBy->method('getUID')->willReturn('sharedBy');
+ $shareOwner = $this->getMock('OCP\IUser');
+ $shareOwner->method('getUID')->WillReturn('shareOwner');
+
+ $this->userManager
+ ->method('get')
+ ->will($this->returnValueMap([
+ ['sharedWith', $sharedWith],
+ ['sharedBy', $sharedBy],
+ ['shareOwner', $shareOwner],
+ ]));
+
+ $path = $this->getMock('\OCP\Files\File');
+ $path->method('getId')->willReturn(100);
+ $path->method('getOwner')->willReturn($shareOwner);
+
+ $ownerFolder = $this->getMock('OCP\Files\Folder');
+ $userFolder = $this->getMock('OCP\Files\Folder');
+ $this->rootFolder
+ ->method('getUserFolder')
+ ->will($this->returnValueMap([
+ ['sharedBy', $userFolder],
+ ['shareOwner', $ownerFolder],
+ ]));
+
+ $userFolder->method('getById')
+ ->with(100)
+ ->willReturn([$path]);
+ $ownerFolder->method('getById')
+ ->with(100)
+ ->willReturn([$path]);
+
+ $share->setShareType(\OCP\Share::SHARE_TYPE_USER);
+ $share->setSharedWith($sharedWith);
+ $share->setSharedBy($sharedBy);
+ $share->setShareOwner($shareOwner);
+ $share->setPath($path);
+ $share->setPermissions(1);
+ $share->setTarget('/target');
+
+ $share2 = $this->provider->create($share);
+
+ $this->assertNotNull($share2->getId());
+ $this->assertSame(\OCP\Share::SHARE_TYPE_USER, $share2->getShareType());
+ $this->assertSame($sharedWith, $share2->getSharedWith());
+ $this->assertSame($sharedBy, $share2->getSharedBy());
+ $this->assertSame($shareOwner, $share2->getShareOwner());
+ $this->assertSame(1, $share2->getPermissions());
+ $this->assertSame('/target', $share2->getTarget());
+ $this->assertLessThanOrEqual(time(), $share2->getSharetime());
+ $this->assertSame($path, $share2->getPath());
+ }
+
+ public function testCreateGroupShare() {
+ $share = new \OC\Share20\Share();
+
+ $sharedWith = $this->getMock('OCP\IGroup');
+ $sharedWith->method('getGID')->willReturn('sharedWith');
+ $sharedBy = $this->getMock('OCP\IUser');
+ $sharedBy->method('getUID')->willReturn('sharedBy');
+ $shareOwner = $this->getMock('OCP\IUser');
+ $shareOwner->method('getUID')->WillReturn('shareOwner');
+
+ $this->userManager
+ ->method('get')
+ ->will($this->returnValueMap([
+ ['sharedBy', $sharedBy],
+ ['shareOwner', $shareOwner],
+ ]));
+ $this->groupManager
+ ->method('get')
+ ->with('sharedWith')
+ ->willReturn($sharedWith);
+
+ $path = $this->getMock('\OCP\Files\Folder');
+ $path->method('getId')->willReturn(100);
+ $path->method('getOwner')->willReturn($shareOwner);
+
+ $ownerFolder = $this->getMock('OCP\Files\Folder');
+ $userFolder = $this->getMock('OCP\Files\Folder');
+ $this->rootFolder
+ ->method('getUserFolder')
+ ->will($this->returnValueMap([
+ ['sharedBy', $userFolder],
+ ['shareOwner', $ownerFolder],
+ ]));
+
+ $userFolder->method('getById')
+ ->with(100)
+ ->willReturn([$path]);
+ $ownerFolder->method('getById')
+ ->with(100)
+ ->willReturn([$path]);
+
+ $share->setShareType(\OCP\Share::SHARE_TYPE_GROUP);
+ $share->setSharedWith($sharedWith);
+ $share->setSharedBy($sharedBy);
+ $share->setShareOwner($shareOwner);
+ $share->setPath($path);
+ $share->setPermissions(1);
+ $share->setTarget('/target');
+
+ $share2 = $this->provider->create($share);
+
+ $this->assertNotNull($share2->getId());
+ $this->assertSame(\OCP\Share::SHARE_TYPE_GROUP, $share2->getShareType());
+ $this->assertSame($sharedWith, $share2->getSharedWith());
+ $this->assertSame($sharedBy, $share2->getSharedBy());
+ $this->assertSame($shareOwner, $share2->getShareOwner());
+ $this->assertSame(1, $share2->getPermissions());
+ $this->assertSame('/target', $share2->getTarget());
+ $this->assertLessThanOrEqual(time(), $share2->getSharetime());
+ $this->assertSame($path, $share2->getPath());
+ }
+
+ public function testCreateLinkShare() {
+ $share = new \OC\Share20\Share();
+
+ $sharedBy = $this->getMock('OCP\IUser');
+ $sharedBy->method('getUID')->willReturn('sharedBy');
+ $shareOwner = $this->getMock('OCP\IUser');
+ $shareOwner->method('getUID')->WillReturn('shareOwner');
+
+ $this->userManager
+ ->method('get')
+ ->will($this->returnValueMap([
+ ['sharedBy', $sharedBy],
+ ['shareOwner', $shareOwner],
+ ]));
+
+ $path = $this->getMock('\OCP\Files\Folder');
+ $path->method('getId')->willReturn(100);
+ $path->method('getOwner')->willReturn($shareOwner);
+
+ $ownerFolder = $this->getMock('OCP\Files\Folder');
+ $userFolder = $this->getMock('OCP\Files\Folder');
+ $this->rootFolder
+ ->method('getUserFolder')
+ ->will($this->returnValueMap([
+ ['sharedBy', $userFolder],
+ ['shareOwner', $ownerFolder],
+ ]));
+
+ $userFolder->method('getById')
+ ->with(100)
+ ->willReturn([$path]);
+ $ownerFolder->method('getById')
+ ->with(100)
+ ->willReturn([$path]);
+
+ $share->setShareType(\OCP\Share::SHARE_TYPE_LINK);
+ $share->setSharedBy($sharedBy);
+ $share->setShareOwner($shareOwner);
+ $share->setPath($path);
+ $share->setPermissions(1);
+ $share->setPassword('password');
+ $share->setToken('token');
+ $expireDate = new \DateTime();
+ $share->setExpirationDate($expireDate);
+ $share->setTarget('/target');
+
+ $share2 = $this->provider->create($share);
+
+ $this->assertNotNull($share2->getId());
+ $this->assertSame(\OCP\Share::SHARE_TYPE_LINK, $share2->getShareType());
+ $this->assertSame($sharedBy, $share2->getSharedBy());
+ $this->assertSame($shareOwner, $share2->getShareOwner());
+ $this->assertSame(1, $share2->getPermissions());
+ $this->assertSame('/target', $share2->getTarget());
+ $this->assertLessThanOrEqual(time(), $share2->getSharetime());
+ $this->assertSame($path, $share2->getPath());
+ $this->assertSame('password', $share2->getPassword());
+ $this->assertSame('token', $share2->getToken());
+ $this->assertEquals($expireDate, $share2->getExpirationDate());
+ }
}
diff --git a/tests/lib/share20/managertest.php b/tests/lib/share20/managertest.php
index e4d0bfad584..57e7e110712 100644
--- a/tests/lib/share20/managertest.php
+++ b/tests/lib/share20/managertest.php
@@ -23,10 +23,21 @@ namespace Test\Share20;
use OC\Share20\Manager;
use OC\Share20\Exception;
+use OCP\IL10N;
use OCP\ILogger;
-use OCP\IAppConfig;
+use OCP\IConfig;
use OC\Share20\IShareProvider;
+use OCP\Security\ISecureRandom;
+use OCP\Security\IHasher;
+use OCP\Files\Mount\IMountManager;
+use OCP\IGroupManager;
+/**
+ * Class ManagerTest
+ *
+ * @package Test\Share20
+ * @group DB
+ */
class ManagerTest extends \Test\TestCase {
/** @var Manager */
@@ -35,22 +46,52 @@ class ManagerTest extends \Test\TestCase {
/** @var ILogger */
protected $logger;
- /** @var IAppConfig */
- protected $appConfig;
+ /** @var IConfig */
+ protected $config;
+
+ /** @var ISecureRandom */
+ protected $secureRandom;
+
+ /** @var IHasher */
+ protected $hasher;
/** @var IShareProvider */
protected $defaultProvider;
+ /** @var IMountManager */
+ protected $mountManager;
+
+ /** @var IGroupManager */
+ protected $groupManager;
+
+ /** @var IL10N */
+ protected $l;
+
public function setUp() {
$this->logger = $this->getMock('\OCP\ILogger');
- $this->appConfig = $this->getMock('\OCP\IAppConfig');
+ $this->config = $this->getMock('\OCP\IConfig');
$this->defaultProvider = $this->getMock('\OC\Share20\IShareProvider');
+ $this->secureRandom = $this->getMock('\OCP\Security\ISecureRandom');
+ $this->hasher = $this->getMock('\OCP\Security\IHasher');
+ $this->mountManager = $this->getMock('\OCP\Files\Mount\IMountManager');
+ $this->groupManager = $this->getMock('\OCP\IGroupManager');
+
+ $this->l = $this->getMock('\OCP\IL10N');
+ $this->l->method('t')
+ ->will($this->returnCallback(function($text, $parameters = []) {
+ return vsprintf($text, $parameters);
+ }));
$this->manager = new Manager(
$this->logger,
- $this->appConfig,
- $this->defaultProvider
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l
);
}
@@ -91,8 +132,13 @@ class ManagerTest extends \Test\TestCase {
$manager = $this->getMockBuilder('\OC\Share20\Manager')
->setConstructorArgs([
$this->logger,
- $this->appConfig,
- $this->defaultProvider
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l
])
->setMethods(['getShareById', 'deleteChildren'])
->getMock();
@@ -177,8 +223,13 @@ class ManagerTest extends \Test\TestCase {
$manager = $this->getMockBuilder('\OC\Share20\Manager')
->setConstructorArgs([
$this->logger,
- $this->appConfig,
- $this->defaultProvider
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l,
])
->setMethods(['getShareById'])
->getMock();
@@ -317,8 +368,13 @@ class ManagerTest extends \Test\TestCase {
$manager = $this->getMockBuilder('\OC\Share20\Manager')
->setConstructorArgs([
$this->logger,
- $this->appConfig,
- $this->defaultProvider
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l,
])
->setMethods(['deleteShare'])
->getMock();
@@ -365,4 +421,1128 @@ class ManagerTest extends \Test\TestCase {
$this->assertEquals($share, $this->manager->getShareById(42));
}
+
+ /**
+ * @expectedException InvalidArgumentException
+ * @expectedExceptionMessage Passwords are enforced for link shares
+ */
+ public function testVerifyPasswordNullButEnforced() {
+ $this->config->method('getAppValue')->will($this->returnValueMap([
+ ['core', 'shareapi_enforce_links_password', 'no', 'yes'],
+ ]));
+
+ $this->invokePrivate($this->manager, 'verifyPassword', [null]);
+ }
+
+ public function testVerifyPasswordNull() {
+ $this->config->method('getAppValue')->will($this->returnValueMap([
+ ['core', 'shareapi_enforce_links_password', 'no', 'no'],
+ ]));
+
+ $result = $this->invokePrivate($this->manager, 'verifyPassword', [null]);
+ $this->assertNull($result);
+ }
+
+ public function testVerifyPasswordHook() {
+ $this->config->method('getAppValue')->will($this->returnValueMap([
+ ['core', 'shareapi_enforce_links_password', 'no', 'no'],
+ ]));
+
+ $hookListner = $this->getMockBuilder('Dummy')->setMethods(['listner'])->getMock();
+ \OCP\Util::connectHook('\OC\Share', 'verifyPassword', $hookListner, 'listner');
+
+ $hookListner->expects($this->once())
+ ->method('listner')
+ ->with([
+ 'password' => 'password',
+ 'accepted' => true,
+ 'message' => ''
+ ]);
+
+ $result = $this->invokePrivate($this->manager, 'verifyPassword', ['password']);
+ $this->assertNull($result);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage password not accepted
+ */
+ public function testVerifyPasswordHookFails() {
+ $this->config->method('getAppValue')->will($this->returnValueMap([
+ ['core', 'shareapi_enforce_links_password', 'no', 'no'],
+ ]));
+
+ $dummy = new DummyPassword();
+ \OCP\Util::connectHook('\OC\Share', 'verifyPassword', $dummy, 'listner');
+ $this->invokePrivate($this->manager, 'verifyPassword', ['password']);
+ }
+
+ public function createShare($id, $type, $path, $sharedWith, $sharedBy, $shareOwner,
+ $permissions, $expireDate = null, $password = null) {
+ $share = $this->getMock('\OC\Share20\IShare');
+
+ $share->method('getShareType')->willReturn($type);
+ $share->method('getSharedWith')->willReturn($sharedWith);
+ $share->method('getSharedBy')->willReturn($sharedBy);
+ $share->method('getSharedOwner')->willReturn($shareOwner);
+ $share->method('getPath')->willReturn($path);
+ $share->method('getPermissions')->willReturn($permissions);
+ $share->method('getExpirationDate')->willReturn($expireDate);
+ $share->method('getPassword')->willReturn($password);
+
+ return $share;
+ }
+
+ public function dataGeneralChecks() {
+ $user = $this->getMock('\OCP\IUser');
+ $user2 = $this->getMock('\OCP\IUser');
+ $group = $this->getMock('\OCP\IGroup');
+
+ $file = $this->getMock('\OCP\Files\File');
+ $node = $this->getMock('\OCP\Files\Node');
+
+ $data = [
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, null, $user, $user, 31, null, null), 'SharedWith should be an IUser', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, $group, $user, $user, 31, null, null), 'SharedWith should be an IUser', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, 'foo@bar.com', $user, $user, 31, null, null), 'SharedWith should be an IUser', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $file, null, $user, $user, 31, null, null), 'SharedWith should be an IGroup', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $file, $user2, $user, $user, 31, null, null), 'SharedWith should be an IGroup', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $file, 'foo@bar.com', $user, $user, 31, null, null), 'SharedWith should be an IGroup', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $file, $user2, $user, $user, 31, null, null), 'SharedWith should be empty', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $file, $group, $user, $user, 31, null, null), 'SharedWith should be empty', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $file, 'foo@bar.com', $user, $user, 31, null, null), 'SharedWith should be empty', true],
+ [$this->createShare(null, -1, $file, null, $user, $user, 31, null, null), 'unkown share type', true],
+
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, $user2, null, $user, 31, null, null), 'SharedBy should be set', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $file, $group, null, $user, 31, null, null), 'SharedBy should be set', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $file, null, null, $user, 31, null, null), 'SharedBy should be set', true],
+
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $file, $user, $user, $user, 31, null, null), 'Can\'t share with yourself', true],
+
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, null, $user2, $user, $user, 31, null, null), 'Path should be set', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, null, $group, $user, $user, 31, null, null), 'Path should be set', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, null, null, $user, $user, 31, null, null), 'Path should be set', true],
+
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $node, $user2, $user, $user, 31, null, null), 'Path should be either a file or a folder', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $node, $group, $user, $user, 31, null, null), 'Path should be either a file or a folder', true],
+ [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $node, null, $user, $user, 31, null, null), 'Path should be either a file or a folder', true],
+ ];
+
+ $nonShareAble = $this->getMock('\OCP\Files\Folder');
+ $nonShareAble->method('isShareable')->willReturn(false);
+ $nonShareAble->method('getPath')->willReturn('path');
+
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $nonShareAble, $user2, $user, $user, 31, null, null), 'You are not allowed to share path', true];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $nonShareAble, $group, $user, $user, 31, null, null), 'You are not allowed to share path', true];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $nonShareAble, null, $user, $user, 31, null, null), 'You are not allowed to share path', true];
+
+ $limitedPermssions = $this->getMock('\OCP\Files\File');
+ $limitedPermssions->method('isShareable')->willReturn(true);
+ $limitedPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_READ);
+ $limitedPermssions->method('getPath')->willReturn('path');
+
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $limitedPermssions, $user2, $user, $user, null, null, null), 'A share requires permissions', true];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $limitedPermssions, $group, $user, $user, null, null, null), 'A share requires permissions', true];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $limitedPermssions, null, $user, $user, null, null, null), 'A share requires permissions', true];
+
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $limitedPermssions, $user2, $user, $user, 31, null, null), 'Cannot increase permissions of path', true];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $limitedPermssions, $group, $user, $user, 17, null, null), 'Cannot increase permissions of path', true];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $limitedPermssions, null, $user, $user, 3, null, null), 'Cannot increase permissions of path', true];
+
+ $allPermssions = $this->getMock('\OCP\Files\Folder');
+ $allPermssions->method('isShareable')->willReturn(true);
+ $allPermssions->method('getPermissions')->willReturn(\OCP\Constants::PERMISSION_ALL);
+
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $allPermssions, $user2, $user, $user, 30, null, null), 'Shares need at least read permissions', true];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $allPermssions, $group, $user, $user, 2, null, null), 'Shares need at least read permissions', true];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $allPermssions, null, $user, $user, 16, null, null), 'Shares need at least read permissions', true];
+
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_USER, $allPermssions, $user2, $user, $user, 31, null, null), null, false];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_GROUP, $allPermssions, $group, $user, $user, 3, null, null), null, false];
+ $data[] = [$this->createShare(null, \OCP\Share::SHARE_TYPE_LINK, $allPermssions, null, $user, $user, 17, null, null), null, false];
+
+ return $data;
+ }
+
+ /**
+ * @dataProvider dataGeneralChecks
+ *
+ * @param $share
+ * @param $exceptionMessage
+ */
+ public function testGeneralChecks($share, $exceptionMessage, $exception) {
+ $thrown = null;
+
+ try {
+ $this->invokePrivate($this->manager, 'generalCreateChecks', [$share]);
+ $thrown = false;
+ } catch (\OC\HintException $e) {
+ $this->assertEquals($exceptionMessage, $e->getHint());
+ $thrown = true;
+ } catch(\InvalidArgumentException $e) {
+ $this->assertEquals($exceptionMessage, $e->getMessage());
+ $thrown = true;
+ }
+
+ $this->assertSame($exception, $thrown);
+ }
+
+ /**
+ * @expectedException \OC\HintException
+ * @expectedExceptionMessage Expiration date is in the past
+ */
+ public function testValidateExpiredateInPast() {
+
+ // Expire date in the past
+ $past = new \DateTime();
+ $past->sub(new \DateInterval('P1D'));
+
+ $this->invokePrivate($this->manager, 'validateExpiredate', [$past]);
+ }
+
+ /**
+ * @expectedException InvalidArgumentException
+ * @expectedExceptionMessage Expiration date is enforced
+ */
+ public function testValidateExpiredateEnforceButNotSet() {
+ $this->config->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+ ]));
+
+ $this->invokePrivate($this->manager, 'validateExpiredate', [null]);
+ }
+
+ public function testValidateExpiredateEnforceToFarIntoFuture() {
+ // Expire date in the past
+ $future = new \DateTime();
+ $future->add(new \DateInterval('P7D'));
+
+ $this->config->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+ ['core', 'shareapi_expire_after_n_days', '7', '3'],
+ ]));
+
+ try {
+ $this->invokePrivate($this->manager, 'validateExpiredate', [$future]);
+ } catch (\OC\HintException $e) {
+ $this->assertEquals('Cannot set expiration date more than 3 days in the future', $e->getMessage());
+ $this->assertEquals('Cannot set expiration date more than 3 days in the future', $e->getHint());
+ $this->assertEquals(404, $e->getCode());
+ }
+ }
+
+ public function testValidateExpiredateEnforceValid() {
+ // Expire date in the past
+ $future = new \DateTime();
+ $future->add(new \DateInterval('P2D'));
+ $future->setTime(0,0,0);
+ $expected = $future->format(\DateTime::ISO8601);
+ $future->setTime(1,2,3);
+
+ $this->config->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_enforce_expire_date', 'no', 'yes'],
+ ['core', 'shareapi_expire_after_n_days', '7', '3'],
+ ]));
+
+ $future = $this->invokePrivate($this->manager, 'validateExpiredate', [$future]);
+
+ $this->assertEquals($expected, $future->format(\DateTime::ISO8601));
+ }
+
+ public function testValidateExpiredateNoDateNoDefaultNull() {
+ $date = new \DateTime();
+ $date->add(new \DateInterval('P5D'));
+
+ $res = $this->invokePrivate($this->manager, 'validateExpiredate', [$date]);
+
+ $this->assertEquals($date, $res);
+ }
+
+ public function testValidateExpiredateNoDateNoDefault() {
+ $date = $this->invokePrivate($this->manager, 'validateExpiredate', [null]);
+
+ $this->assertNull($date);
+ }
+
+ public function testValidateExpiredateNoDateDefault() {
+ $future = new \DateTime();
+ $future->add(new \DateInterval('P3D'));
+ $future->setTime(0,0,0);
+
+ $this->config->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_default_expire_date', 'no', 'yes'],
+ ['core', 'shareapi_expire_after_n_days', '7', '3'],
+ ]));
+
+ $date = $this->invokePrivate($this->manager, 'validateExpiredate', [null]);
+
+ $this->assertEquals($future->format(\DateTime::ISO8601), $date->format(\DateTime::ISO8601));
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Only sharing with group members is allowed
+ */
+ public function testUserCreateChecksShareWithGroupMembersOnlyDifferentGroups() {
+ $share = new \OC\Share20\Share();
+
+ $sharedBy = $this->getMock('\OCP\IUser');
+ $sharedWith = $this->getMock('\OCP\IUser');
+ $share->setSharedBy($sharedBy)->setSharedWith($sharedWith);
+
+ $this->groupManager
+ ->method('getUserGroupIds')
+ ->will(
+ $this->returnValueMap([
+ [$sharedBy, ['group1']],
+ [$sharedWith, ['group2']],
+ ])
+ );
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+ ]));
+
+ $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
+ }
+
+ public function testUserCreateChecksShareWithGroupMembersOnlySharedGroup() {
+ $share = new \OC\Share20\Share();
+
+ $sharedBy = $this->getMock('\OCP\IUser');
+ $sharedWith = $this->getMock('\OCP\IUser');
+ $share->setSharedBy($sharedBy)->setSharedWith($sharedWith);
+
+ $path = $this->getMock('\OCP\Files\Node');
+ $share->setPath($path);
+
+ $this->groupManager
+ ->method('getUserGroupIds')
+ ->will(
+ $this->returnValueMap([
+ [$sharedBy, ['group1', 'group3']],
+ [$sharedWith, ['group2', 'group3']],
+ ])
+ );
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+ ]));
+
+ $this->defaultProvider
+ ->method('getSharesByPath')
+ ->with($path)
+ ->willReturn([]);
+
+ $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Path already shared with this user
+ */
+ public function testUserCreateChecksIdenticalShareExists() {
+ $share = new \OC\Share20\Share();
+
+ $sharedWith = $this->getMock('\OCP\IUser');
+ $share->setSharedWith($sharedWith);
+
+ $path = $this->getMock('\OCP\Files\Node');
+ $share->setPath($path);
+
+ $this->defaultProvider
+ ->method('getSharesByPath')
+ ->with($path)
+ ->willReturn([$share]);
+
+ $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Path already shared with this user
+ */
+ public function testUserCreateChecksIdenticalPathSharedViaGroup() {
+ $share = new \OC\Share20\Share();
+ $sharedWith = $this->getMock('\OCP\IUser');
+ $owner = $this->getMock('\OCP\IUser');
+ $path = $this->getMock('\OCP\Files\Node');
+ $share->setSharedWith($sharedWith)
+ ->setPath($path)
+ ->setShareOwner($owner);
+
+ $share2 = new \OC\Share20\Share();
+ $owner2 = $this->getMock('\OCP\IUser');
+ $share2->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
+ ->setShareOwner($owner2);
+
+ $group = $this->getMock('\OCP\IGroup');
+ $group->method('inGroup')
+ ->with($sharedWith)
+ ->willReturn(true);
+
+ $share2->setSharedWith($group);
+
+ $this->defaultProvider
+ ->method('getSharesByPath')
+ ->with($path)
+ ->willReturn([$share2]);
+
+ $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
+ }
+
+ public function testUserCreateChecksIdenticalPathNotSharedWithUser() {
+ $share = new \OC\Share20\Share();
+ $sharedWith = $this->getMock('\OCP\IUser');
+ $owner = $this->getMock('\OCP\IUser');
+ $path = $this->getMock('\OCP\Files\Node');
+ $share->setSharedWith($sharedWith)
+ ->setPath($path)
+ ->setShareOwner($owner);
+
+ $share2 = new \OC\Share20\Share();
+ $owner2 = $this->getMock('\OCP\IUser');
+ $share2->setShareType(\OCP\Share::SHARE_TYPE_GROUP)
+ ->setShareOwner($owner2);
+
+ $group = $this->getMock('\OCP\IGroup');
+ $group->method('inGroup')
+ ->with($sharedWith)
+ ->willReturn(false);
+
+ $share2->setSharedWith($group);
+
+ $this->defaultProvider
+ ->method('getSharesByPath')
+ ->with($path)
+ ->willReturn([$share2]);
+
+ $this->invokePrivate($this->manager, 'userCreateChecks', [$share]);
+ }
+
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Only sharing within your own groups is allowed
+ */
+ public function testGroupCreateChecksShareWithGroupMembersOnlyNotInGroup() {
+ $share = new \OC\Share20\Share();
+
+ $sharedBy = $this->getMock('\OCP\IUser');
+ $sharedWith = $this->getMock('\OCP\IGroup');
+ $share->setSharedBy($sharedBy)->setSharedWith($sharedWith);
+
+ $sharedWith->method('inGroup')->with($sharedBy)->willReturn(false);
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+ ]));
+
+ $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+ }
+
+ public function testGroupCreateChecksShareWithGroupMembersOnlyInGroup() {
+ $share = new \OC\Share20\Share();
+
+ $sharedBy = $this->getMock('\OCP\IUser');
+ $sharedWith = $this->getMock('\OCP\IGroup');
+ $share->setSharedBy($sharedBy)->setSharedWith($sharedWith);
+
+ $sharedWith->method('inGroup')->with($sharedBy)->willReturn(true);
+
+ $path = $this->getMock('\OCP\Files\Node');
+ $share->setPath($path);
+
+ $this->defaultProvider->method('getSharesByPath')
+ ->with($path)
+ ->willReturn([]);
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_only_share_with_group_members', 'no', 'yes'],
+ ]));
+
+ $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Path already shared with this group
+ */
+ public function testGroupCreateChecksPathAlreadySharedWithSameGroup() {
+ $share = new \OC\Share20\Share();
+
+ $sharedWith = $this->getMock('\OCP\IGroup');
+ $share->setSharedWith($sharedWith);
+
+ $path = $this->getMock('\OCP\Files\Node');
+ $share->setPath($path);
+
+ $share2 = new \OC\Share20\Share();
+ $share2->setSharedWith($sharedWith);
+
+ $this->defaultProvider->method('getSharesByPath')
+ ->with($path)
+ ->willReturn([$share2]);
+
+ $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+ }
+
+ public function testGroupCreateChecksPathAlreadySharedWithDifferentGroup() {
+ $share = new \OC\Share20\Share();
+
+ $sharedWith = $this->getMock('\OCP\IGroup');
+ $share->setSharedWith($sharedWith);
+
+ $path = $this->getMock('\OCP\Files\Node');
+ $share->setPath($path);
+
+ $share2 = new \OC\Share20\Share();
+ $sharedWith2 = $this->getMock('\OCP\IGroup');
+ $share2->setSharedWith($sharedWith2);
+
+ $this->defaultProvider->method('getSharesByPath')
+ ->with($path)
+ ->willReturn([$share2]);
+
+ $this->invokePrivate($this->manager, 'groupCreateChecks', [$share]);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Link sharing not allowed
+ */
+ public function testLinkCreateChecksNoLinkSharesAllowed() {
+ $share = new \OC\Share20\Share();
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_allow_links', 'yes', 'no'],
+ ]));
+
+ $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Link shares can't have reshare permissions
+ */
+ public function testLinkCreateChecksSharePermissions() {
+ $share = new \OC\Share20\Share();
+
+ $share->setPermissions(\OCP\Constants::PERMISSION_SHARE);
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_allow_links', 'yes', 'yes'],
+ ]));
+
+ $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Link shares can't have delete permissions
+ */
+ public function testLinkCreateChecksDeletePermissions() {
+ $share = new \OC\Share20\Share();
+
+ $share->setPermissions(\OCP\Constants::PERMISSION_DELETE);
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_allow_links', 'yes', 'yes'],
+ ]));
+
+ $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage Public upload not allowed
+ */
+ public function testLinkCreateChecksNoPublicUpload() {
+ $share = new \OC\Share20\Share();
+
+ $share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_allow_links', 'yes', 'yes'],
+ ['core', 'shareapi_allow_public_upload', 'yes', 'no']
+ ]));
+
+ $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+ }
+
+
+ public function testLinkCreateChecksPublicUpload() {
+ $share = new \OC\Share20\Share();
+
+ $share->setPermissions(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE);
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_allow_links', 'yes', 'yes'],
+ ['core', 'shareapi_allow_public_upload', 'yes', 'yes']
+ ]));
+
+ $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+ }
+
+ public function testLinkCreateChecksReadOnly() {
+ $share = new \OC\Share20\Share();
+
+ $share->setPermissions(\OCP\Constants::PERMISSION_READ);
+
+ $this->config
+ ->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_allow_links', 'yes', 'yes'],
+ ['core', 'shareapi_allow_public_upload', 'yes', 'no']
+ ]));
+
+ $this->invokePrivate($this->manager, 'linkCreateChecks', [$share]);
+ }
+
+ /**
+ * @expectedException \InvalidArgumentException
+ * @expectedExceptionMessage Path contains files shared with you
+ */
+ public function testPathCreateChecksContainsSharedMount() {
+ $path = $this->getMock('\OCP\Files\Folder');
+ $path->method('getPath')->willReturn('path');
+
+ $mount = $this->getMock('\OCP\Files\Mount\IMountPoint');
+ $storage = $this->getMock('\OCP\Files\Storage');
+ $mount->method('getStorage')->willReturn($storage);
+ $storage->method('instanceOfStorage')->with('\OCA\Files_Sharing\ISharedStorage')->willReturn(true);
+
+ $this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
+
+ $this->invokePrivate($this->manager, 'pathCreateChecks', [$path]);
+ }
+
+ public function testPathCreateChecksContainsNoSharedMount() {
+ $path = $this->getMock('\OCP\Files\Folder');
+ $path->method('getPath')->willReturn('path');
+
+ $mount = $this->getMock('\OCP\Files\Mount\IMountPoint');
+ $storage = $this->getMock('\OCP\Files\Storage');
+ $mount->method('getStorage')->willReturn($storage);
+ $storage->method('instanceOfStorage')->with('\OCA\Files_Sharing\ISharedStorage')->willReturn(false);
+
+ $this->mountManager->method('findIn')->with('path')->willReturn([$mount]);
+
+ $this->invokePrivate($this->manager, 'pathCreateChecks', [$path]);
+ }
+
+ public function testPathCreateChecksContainsNoFolder() {
+ $path = $this->getMock('\OCP\Files\File');
+
+ $this->invokePrivate($this->manager, 'pathCreateChecks', [$path]);
+ }
+
+ public function dataIsSharingDisabledForUser() {
+ $data = [];
+
+ // No exclude groups
+ $data[] = ['no', null, null, null, false];
+
+ // empty exclude list, user no groups
+ $data[] = ['yes', '', json_encode(['']), [], false];
+
+ // empty exclude list, user groups
+ $data[] = ['yes', '', json_encode(['']), ['group1', 'group2'], false];
+
+ // Convert old list to json
+ $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), [], false];
+
+ // Old list partly groups in common
+ $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), ['group1', 'group3'], false];
+
+ // Old list only groups in common
+ $data[] = ['yes', 'group1,group2', json_encode(['group1', 'group2']), ['group1'], true];
+
+ // New list partly in common
+ $data[] = ['yes', json_encode(['group1', 'group2']), null, ['group1', 'group3'], false];
+
+ // New list only groups in common
+ $data[] = ['yes', json_encode(['group1', 'group2']), null, ['group2'], true];
+
+ return $data;
+ }
+
+ /**
+ * @dataProvider dataIsSharingDisabledForUser
+ *
+ * @param string $excludeGroups
+ * @param string $groupList
+ * @param string $setList
+ * @param string[] $groupIds
+ * @param bool $expected
+ */
+ public function testIsSharingDisabledForUser($excludeGroups, $groupList, $setList, $groupIds, $expected) {
+ $user = $this->getMock('\OCP\IUser');
+
+ $this->config->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_exclude_groups', 'no', $excludeGroups],
+ ['core', 'shareapi_exclude_groups_list', '', $groupList],
+ ]));
+
+ if ($setList !== null) {
+ $this->config->expects($this->once())
+ ->method('setAppValue')
+ ->with('core', 'shareapi_exclude_groups_list', $setList);
+ } else {
+ $this->config->expects($this->never())
+ ->method('setAppValue');
+ }
+
+ $this->groupManager->method('getUserGroupIds')
+ ->with($user)
+ ->willReturn($groupIds);
+
+ $res = $this->manager->isSharingDisabledForUser($user);
+ $this->assertEquals($expected, $res);
+ }
+
+ public function dataCanShare() {
+ $data = [];
+
+ /*
+ * [expected, sharing enabled, disabled for user]
+ */
+
+ $data[] = [false, 'no', false];
+ $data[] = [false, 'no', true];
+ $data[] = [true, 'yes', false];
+ $data[] = [false, 'yes', true];
+
+ return $data;
+ }
+
+ /**
+ * @dataProvider dataCanShare
+ *
+ * @param bool $expected
+ * @param string $sharingEnabled
+ * @param bool $disabledForUser
+ */
+ public function testCanShare($expected, $sharingEnabled, $disabledForUser) {
+ $this->config->method('getAppValue')
+ ->will($this->returnValueMap([
+ ['core', 'shareapi_enabled', 'yes', $sharingEnabled],
+ ]));
+
+ $manager = $this->getMockBuilder('\OC\Share20\Manager')
+ ->setConstructorArgs([
+ $this->logger,
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l,
+ ])
+ ->setMethods(['isSharingDisabledForUser'])
+ ->getMock();
+
+ $manager->method('isSharingDisabledForUser')->willReturn($disabledForUser);
+
+ $user = $this->getMock('\OCP\IUser');
+ $share = new \OC\Share20\Share();
+ $share->setSharedBy($user);
+
+ $res = $this->invokePrivate($manager, 'canShare', [$share]);
+ $this->assertEquals($expected, $res);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage The Share API is disabled
+ */
+ public function testCreateShareCantShare() {
+ $manager = $this->getMockBuilder('\OC\Share20\Manager')
+ ->setConstructorArgs([
+ $this->logger,
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l,
+ ])
+ ->setMethods(['canShare'])
+ ->getMock();
+
+ $manager->expects($this->once())->method('canShare')->willReturn(false);
+ $share = new \OC\Share20\Share();
+ $manager->createShare($share);
+ }
+
+ public function testCreateShareUser() {
+ $manager = $this->getMockBuilder('\OC\Share20\Manager')
+ ->setConstructorArgs([
+ $this->logger,
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l,
+ ])
+ ->setMethods(['canShare', 'generalCreateChecks', 'userCreateChecks', 'pathCreateChecks'])
+ ->getMock();
+
+ $sharedWith = $this->getMock('\OCP\IUser');
+ $sharedBy = $this->getMock('\OCP\IUser');
+ $shareOwner = $this->getMock('\OCP\IUser');
+
+ $path = $this->getMock('\OCP\Files\File');
+ $path->method('getOwner')->willReturn($shareOwner);
+ $path->method('getName')->willReturn('target');
+
+ $share = $this->createShare(
+ null,
+ \OCP\Share::SHARE_TYPE_USER,
+ $path,
+ $sharedWith,
+ $sharedBy,
+ null,
+ \OCP\Constants::PERMISSION_ALL);
+
+ $manager->expects($this->once())
+ ->method('canShare')
+ ->with($share)
+ ->willReturn(true);
+ $manager->expects($this->once())
+ ->method('generalCreateChecks')
+ ->with($share);;
+ $manager->expects($this->once())
+ ->method('userCreateChecks')
+ ->with($share);;
+ $manager->expects($this->once())
+ ->method('pathCreateChecks')
+ ->with($path);
+
+ $this->defaultProvider
+ ->expects($this->once())
+ ->method('create')
+ ->with($share)
+ ->will($this->returnArgument(0));
+
+ $share->expects($this->once())
+ ->method('setShareOwner')
+ ->with($shareOwner);
+ $share->expects($this->once())
+ ->method('setTarget')
+ ->with('/target');
+
+ $manager->createShare($share);
+ }
+
+ public function testCreateShareGroup() {
+ $manager = $this->getMockBuilder('\OC\Share20\Manager')
+ ->setConstructorArgs([
+ $this->logger,
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l,
+ ])
+ ->setMethods(['canShare', 'generalCreateChecks', 'groupCreateChecks', 'pathCreateChecks'])
+ ->getMock();
+
+ $sharedWith = $this->getMock('\OCP\IGroup');
+ $sharedBy = $this->getMock('\OCP\IUser');
+ $shareOwner = $this->getMock('\OCP\IUser');
+
+ $path = $this->getMock('\OCP\Files\File');
+ $path->method('getOwner')->willReturn($shareOwner);
+ $path->method('getName')->willReturn('target');
+
+ $share = $this->createShare(
+ null,
+ \OCP\Share::SHARE_TYPE_GROUP,
+ $path,
+ $sharedWith,
+ $sharedBy,
+ null,
+ \OCP\Constants::PERMISSION_ALL);
+
+ $manager->expects($this->once())
+ ->method('canShare')
+ ->with($share)
+ ->willReturn(true);
+ $manager->expects($this->once())
+ ->method('generalCreateChecks')
+ ->with($share);;
+ $manager->expects($this->once())
+ ->method('groupCreateChecks')
+ ->with($share);;
+ $manager->expects($this->once())
+ ->method('pathCreateChecks')
+ ->with($path);
+
+ $this->defaultProvider
+ ->expects($this->once())
+ ->method('create')
+ ->with($share)
+ ->will($this->returnArgument(0));
+
+ $share->expects($this->once())
+ ->method('setShareOwner')
+ ->with($shareOwner);
+ $share->expects($this->once())
+ ->method('setTarget')
+ ->with('/target');
+
+ $manager->createShare($share);
+ }
+
+ public function testCreateShareLink() {
+ $manager = $this->getMockBuilder('\OC\Share20\Manager')
+ ->setConstructorArgs([
+ $this->logger,
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l,
+ ])
+ ->setMethods([
+ 'canShare',
+ 'generalCreateChecks',
+ 'linkCreateChecks',
+ 'pathCreateChecks',
+ 'validateExpiredate',
+ 'verifyPassword',
+ ])
+ ->getMock();
+
+ $sharedBy = $this->getMock('\OCP\IUser');
+ $sharedBy->method('getUID')->willReturn('sharedBy');
+ $shareOwner = $this->getMock('\OCP\IUser');
+
+ $path = $this->getMock('\OCP\Files\File');
+ $path->method('getOwner')->willReturn($shareOwner);
+ $path->method('getName')->willReturn('target');
+ $path->method('getId')->willReturn(1);
+
+ $date = new \DateTime();
+
+ $share = $this->createShare(
+ null,
+ \OCP\Share::SHARE_TYPE_LINK,
+ $path,
+ null,
+ $sharedBy,
+ null,
+ \OCP\Constants::PERMISSION_ALL,
+ $date,
+ 'password');
+
+ $manager->expects($this->once())
+ ->method('canShare')
+ ->with($share)
+ ->willReturn(true);
+ $manager->expects($this->once())
+ ->method('generalCreateChecks')
+ ->with($share);;
+ $manager->expects($this->once())
+ ->method('linkCreateChecks')
+ ->with($share);;
+ $manager->expects($this->once())
+ ->method('pathCreateChecks')
+ ->with($path);
+ $manager->expects($this->once())
+ ->method('validateExpiredate')
+ ->with($date)
+ ->will($this->returnArgument(0));
+ $manager->expects($this->once())
+ ->method('verifyPassword')
+ ->with('password');
+
+ $this->hasher->expects($this->once())
+ ->method('hash')
+ ->with('password')
+ ->willReturn('hashed');
+
+ $this->secureRandom->method('getMediumStrengthGenerator')
+ ->will($this->returnSelf());
+ $this->secureRandom->method('generate')
+ ->willReturn('token');
+
+ $this->defaultProvider
+ ->expects($this->once())
+ ->method('create')
+ ->with($share)
+ ->will($this->returnArgument(0));
+
+ $share->expects($this->once())
+ ->method('setShareOwner')
+ ->with($shareOwner);
+ $share->expects($this->once())
+ ->method('setTarget')
+ ->with('/target');
+ $share->expects($this->once())
+ ->method('setExpirationDate')
+ ->with($date);
+ $share->expects($this->once())
+ ->method('setPassword')
+ ->with('hashed');
+ $share->method('getToken')
+ ->willReturn('token');
+
+ $hookListner = $this->getMockBuilder('Dummy')->setMethods(['pre', 'post'])->getMock();
+ \OCP\Util::connectHook('OCP\Share', 'pre_shared', $hookListner, 'pre');
+ \OCP\Util::connectHook('OCP\Share', 'post_shared', $hookListner, 'post');
+
+ $hookListnerExpectsPre = [
+ 'itemType' => 'file',
+ 'itemSource' => 1,
+ 'shareType' => \OCP\Share::SHARE_TYPE_LINK,
+ 'uidOwner' => 'sharedBy',
+ 'permissions' => 31,
+ 'fileSource' => 1,
+ 'expiration' => $date,
+ 'token' => 'token',
+ 'run' => true,
+ 'error' => '',
+ ];
+
+ $hookListnerExpectsPost = [
+ 'itemType' => 'file',
+ 'itemSource' => 1,
+ 'shareType' => \OCP\Share::SHARE_TYPE_LINK,
+ 'uidOwner' => 'sharedBy',
+ 'permissions' => 31,
+ 'fileSource' => 1,
+ 'expiration' => $date,
+ 'token' => 'token',
+ 'id' => 42,
+ ];
+
+ $share->method('getId')->willReturn(42);
+
+ $hookListner->expects($this->once())
+ ->method('pre')
+ ->with($this->equalTo($hookListnerExpectsPre));
+ $hookListner->expects($this->once())
+ ->method('post')
+ ->with($this->equalTo($hookListnerExpectsPost));
+
+ $manager->createShare($share);
+ }
+
+ /**
+ * @expectedException Exception
+ * @expectedExceptionMessage I won't let you share
+ */
+ public function testCreateShareHookError() {
+ $manager = $this->getMockBuilder('\OC\Share20\Manager')
+ ->setConstructorArgs([
+ $this->logger,
+ $this->config,
+ $this->defaultProvider,
+ $this->secureRandom,
+ $this->hasher,
+ $this->mountManager,
+ $this->groupManager,
+ $this->l,
+ ])
+ ->setMethods([
+ 'canShare',
+ 'generalCreateChecks',
+ 'userCreateChecks',
+ 'pathCreateChecks',
+ ])
+ ->getMock();
+
+ $sharedWith = $this->getMock('\OCP\IUser');
+ $sharedBy = $this->getMock('\OCP\IUser');
+ $shareOwner = $this->getMock('\OCP\IUser');
+
+ $path = $this->getMock('\OCP\Files\File');
+ $path->method('getOwner')->willReturn($shareOwner);
+ $path->method('getName')->willReturn('target');
+
+ $date = new \DateTime();
+
+ $share = $this->createShare(
+ null,
+ \OCP\Share::SHARE_TYPE_USER,
+ $path,
+ $sharedWith,
+ $sharedBy,
+ null,
+ \OCP\Constants::PERMISSION_ALL);
+
+ $manager->expects($this->once())
+ ->method('canShare')
+ ->with($share)
+ ->willReturn(true);
+ $manager->expects($this->once())
+ ->method('generalCreateChecks')
+ ->with($share);;
+ $manager->expects($this->once())
+ ->method('userCreateChecks')
+ ->with($share);;
+ $manager->expects($this->once())
+ ->method('pathCreateChecks')
+ ->with($path);
+
+ $share->expects($this->once())
+ ->method('setShareOwner')
+ ->with($shareOwner);
+ $share->expects($this->once())
+ ->method('setTarget')
+ ->with('/target');
+
+ $dummy = new DummyCreate();
+ \OCP\Util::connectHook('OCP\Share', 'pre_shared', $dummy, 'listner');
+
+ $manager->createShare($share);
+ }
}
+
+class DummyPassword {
+ public function listner($array) {
+ $array['accepted'] = false;
+ $array['message'] = 'password not accepted';
+ }
+}
+
+class DummyCreate {
+ public function listner($array) {
+ $array['run'] = false;
+ $array['error'] = 'I won\'t let you share!';
+ }
+}
+
diff --git a/tests/lib/updater.php b/tests/lib/updater.php
index 313ffb65738..8ee77b9f81e 100644
--- a/tests/lib/updater.php
+++ b/tests/lib/updater.php
@@ -27,7 +27,7 @@ use OCP\ILogger;
use OC\IntegrityCheck\Checker;
class UpdaterTest extends \Test\TestCase {
- /** @var IConfig */
+ /** @var IConfig|\PHPUnit_Framework_MockObject_MockObject */
private $config;
/** @var HTTPHelper */
private $httpHelper;
@@ -136,9 +136,33 @@ class UpdaterTest extends \Test\TestCase {
['9.0.0.0', '8.0.0.0', '7.0', false],
['9.1.0.0', '8.0.0.0', '7.0', false],
['8.2.0.0', '8.1.0.0', '8.0', false],
+
+ // With debug enabled
+ ['8.0.0.0', '8.2.0.0', '8.1', false, true],
+ ['8.1.0.0', '8.2.0.0', '8.1', true, true],
+ ['8.2.0.1', '8.2.0.1', '8.1', true, true],
+ ['8.3.0.0', '8.2.0.0', '8.1', true, true],
];
}
+ /**
+ * @dataProvider versionCompatibilityTestData
+ *
+ * @param string $oldVersion
+ * @param string $newVersion
+ * @param string $allowedVersion
+ * @param bool $result
+ * @param bool $debug
+ */
+ public function testIsUpgradePossible($oldVersion, $newVersion, $allowedVersion, $result, $debug = false) {
+ $this->config->expects($this->any())
+ ->method('getSystemValue')
+ ->with('debug', false)
+ ->willReturn($debug);
+
+ $this->assertSame($result, $this->updater->isUpgradePossible($oldVersion, $newVersion, $allowedVersion));
+ }
+
public function testSetSimulateStepEnabled() {
$this->updater->setSimulateStepEnabled(true);
$this->assertSame(true, $this->invokePrivate($this->updater, 'simulateStepEnabled'));
@@ -160,18 +184,6 @@ class UpdaterTest extends \Test\TestCase {
$this->assertSame(false, $this->invokePrivate($this->updater, 'skip3rdPartyAppsDisable'));
}
- /**
- * @dataProvider versionCompatibilityTestData
- *
- * @param string $oldVersion
- * @param string $newVersion
- * @param string $allowedVersion
- * @param bool $result
- */
- public function testIsUpgradePossible($oldVersion, $newVersion, $allowedVersion, $result) {
- $this->assertSame($result, $this->updater->isUpgradePossible($oldVersion, $newVersion, $allowedVersion));
- }
-
public function testCheckInCache() {
$expectedResult = [
'version' => '8.0.4.2',
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-18 03:10:39 +0000