aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #34688 from ↵Simon L2022-10-201-7/+32
|\ | | | | | | | | nextcloud/bugfix/34673/dont-crash-with-outdated-share-providers Don't crash with outdated share provider on update with the web updater
| * Fix PHP CSJoas Schilling2022-10-201-1/+0
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Also catch in getProviderJoas Schilling2022-10-201-3/+10
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Don't crash with outdated share providerJoas Schilling2022-10-201-4/+23
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #34703 from ↵Pytal2022-10-209-282/+11
|\ \ | | | | | | | | | nextcloud/bugfix/noid/use-vue-lib-multiselect-tags-component
| * | RecompileJoas Schilling2022-10-205-6/+8
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | Use @nextcloud/vue MultiselectTags componentJoas Schilling2022-10-204-276/+3
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #34685 from nextcloud/fix-alt-login-classSimon L2022-10-201-1/+1
|\ \ \ | | | | | | | | Fix alternative logins custom css class
| * | | Fix alternative logins custom css classzorn-v2022-10-201-1/+1
| | |/ | |/| | | | | | | | | | | | | In NC 25 login page was changed, and alternative login css class get from `class` prop but not `style`. It is correct change in my opinion, so just add backend fix. Signed-off-by: zorn-v <zorn7@yandex.ru>
* | | Merge pull request #34502 from nextcloud/fix/correct-attribute-resharingCarl Schwan2022-10-202-185/+106
|\ \ \ | |_|/ |/| | Propagate attributes when resharing
| * | More fixesCarl Schwan2022-10-181-8/+18
| | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | Small progress with fixing unit testsCarl Schwan2022-10-112-169/+87
| | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | Propagate attributes when resharingCarl Schwan2022-10-101-27/+20
| | | | | | | | | | | | | | | | | | | | | When updating a share, load the node from the initiator instead of the owner similar to how this is done when creating the share. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* | | Merge pull request #34624 from nextcloud/fix/files_external_psalmCarl Schwan2022-10-2055-768/+539
|\ \ \ | | | | | | | | Multiple fix for files external
| * | | Rename file1 and file2 to source and target in Storage abstractionCarl Schwan2022-10-1826-295/+284
| | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Additional type hinting found by psalmCarl Schwan2022-10-188-17/+27
| | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Specify type to internal storage classCarl Schwan2022-10-171-0/+1
| | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Fix returning null when getMessage return nullCarl Schwan2022-10-171-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | Don't overwrite $message but instead create another temporary variable Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | More type safetyCarl Schwan2022-10-175-25/+15
| | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Update psalm baseline following previous fixesCarl Schwan2022-10-171-180/+0
| | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Fix type of getVisibilityTypeCarl Schwan2022-10-173-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | This is a int not a string Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Fix usage of streamsCarl Schwan2022-10-172-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | always return a bool and type the handle as a string Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Use argument name from parent classCarl Schwan2022-10-172-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | This will be an issue with php 8, so best to fix it now Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Add corresponding interface to traitCarl Schwan2022-10-177-80/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we can't specify that we want a class implementing a trait yet in PHP Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Add more typing to FilesExternal commandsCarl Schwan2022-10-1711-139/+52
| | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Port away from deprecated clearBucket callCarl Schwan2022-10-161-9/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was removed a long time ago in the library that we use, but never detected since this was inside a try catch block... Remove the call for now and we should investigate newer api in the future. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Port to LoggerInterfaceCarl Schwan2022-10-161-10/+44
| | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Force cast getCode to intCarl Schwan2022-10-162-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | Otherwise psalm complains that the type can also be a non-falsy-string Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Specify that userId can be nullCarl Schwan2022-10-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a psalm false-positive where the method is called with null, since the method actually handle this correctly already Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Fix return value of updateParentCarl Schwan2022-10-161-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Port to executeStatement to guarantee that we will return an int and remove a deprecated method call at the same time Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Port away from removed IDBConnection->isConnected methodCarl Schwan2022-10-161-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead track if the reconnection was successful with return value of connect method Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | Fix too many arguments in LegacyDependencyCheckPolyfillCarl Schwan2022-10-161-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* | | | Merge pull request #30223 from nextcloud/nested_ldap_groupsCôme Chilliet2022-10-205-235/+244
|\ \ \ \ | | | | | | | | | | Nested ldap groups
| * | | | Fix psalmCarl Schwan2022-10-202-12/+5
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | | Check if cache is present with issetCarl Schwan2022-10-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise we get false for empty array Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | | Bring back small fixes by CarlCôme Chilliet2022-10-201-8/+6
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Fix LDAP recursive nested group supportCôme Chilliet2022-10-202-19/+21
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Revert Carl changes on apps/user_ldap/lib/Group_LDAP.phpCarl Schwan2022-10-201-27/+12
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | | Fix user_ldap testsCarl Schwan2022-10-203-22/+17
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | | Add back runtime cache for intermediate ldap read resultsCarl Schwan2022-10-201-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a small optimization that save a few LDAP queries Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | | Only cache base inGroup searchCarl Schwan2022-10-201-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And not intermediate search for nested groups, this is causing issues othewise with nested groups Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| * | | | Add missing copyright author in Group_LDAPCôme Chilliet2022-10-201-0/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Removed unused use declarationCôme Chilliet2022-10-201-1/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Fix types in docblocksCôme Chilliet2022-10-201-0/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Add testing of nested group membershipCôme Chilliet2022-10-201-11/+31
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Refactor group membership listing for nested groupsCôme Chilliet2022-10-202-148/+70
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Add tests for nested groupsCôme Chilliet2022-10-201-8/+45
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Small optimisation of _groupMembersCôme Chilliet2022-10-201-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will not change the result as users are check to be existing afterwards but avoids this check when we know it’s a group. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Refactor _groupMembers to correctly use cache on intermediate resultsCôme Chilliet2022-10-201-35/+28
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | Fix merging list with nullCarl Schwan2022-10-201-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes some cases observed with the debugger where we end up merging a non empty list with null. The result is then null and the looping over the items would then end. Signed-off-by: Carl Schwan <carl@carlschwan.eu>