aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* fix(config): Throw PreconditionException always when it didn't matchbackport/47933/stable29Joas Schilling2024-09-132-3/+39
| | | | | | | | Previously even when the precondition did not match, the call "passed" when the after value was the expected one. This however can lead to race conditions, duplicate code excutions and other things. Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #47922 from nextcloud/backport/47527/stable29Ferdinand Thiessen2024-09-131-0/+2
|\ | | | | [stable29] fix(files_external): Handling in SFTP UI for custom ports
| * fix: custom port handling in UI for SFTPJosh Richards2024-09-131-0/+2
|/ | | | Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
* Fix(l10n): Update translations from TransifexNextcloud bot2024-09-1332-8/+118
| | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* Merge pull request #47887 from nextcloud/release/29.0.7v29.0.7Benjamin Gaussorgues2024-09-121-2/+2
|\
| * build(hub): 29.0.7Benjamin Gaussorgues2024-09-111-2/+2
| | | | | | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | Fix(l10n): Update translations from TransifexNextcloud bot2024-09-1258-84/+150
|/ | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* Fix(l10n): Update translations from TransifexNextcloud bot2024-09-11358-6716/+6394
| | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* Merge pull request #47843 from nextcloud/backport/47805/stable29Stephan Orbaugh2024-09-101-1/+1
|\ | | | | [stable29] fix: Replace conflicting tags in `xml_exception` template
| * fix: Replace conflicting tags in `xml_exception` templateFerdinand Thiessen2024-09-091-1/+1
| | | | | | | | | | | | | | The `<?xml` tag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | Fix(l10n): Update translations from TransifexNextcloud bot2024-09-10152-140/+582
|/ | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* Fix(l10n): Update translations from TransifexNextcloud bot2024-09-0934-12/+114
| | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* Fix(l10n): Update translations from TransifexNextcloud bot2024-09-0842-28/+166
| | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* Fix(l10n): Update translations from TransifexNextcloud bot2024-09-07240-8980/+9460
| | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* Fix(l10n): Update translations from TransifexNextcloud bot2024-09-0654-18/+528
| | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* Merge pull request #47786 from nextcloud/backport/47770/stable29Louis2024-09-0510-75/+113
|\ | | | | [stable29] fix(dav): Always respond custom error page on exceptions
| * fix(dav): Always respond custom error page on exceptionsLouis Chemineau2024-09-0510-75/+113
| | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* | Merge pull request #47758 from nextcloud/release/29.0.7_rc1v29.0.7rc1Arthur Schiwon2024-09-051-2/+2
|\ \ | | | | | | 29.0.7 RC1
| * | build(hub): 29.0.7 RC1Arthur Schiwon2024-09-041-2/+2
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | Merge pull request #47777 from nextcloud/backport/47769/stable29Arthur Schiwon2024-09-054-5/+85
|\ \ \ | | | | | | | | [stable29] fix: Use sha256 to hash arguments of background jobs
| * | | fix: missing use statementsArthur Schiwon2024-09-051-0/+2
| | | | | | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | | fix: Migrate existing bg jobs to use sha256Louis Chemineau2024-09-053-0/+79
| | | | | | | | | | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
| * | | fix: Use sha256 to hash arguments of background jobsLouis Chemineau2024-09-051-5/+4
| | |/ | |/| | | | | | | | | | | | | This is to prevent collision as we are sometime hashing user input, yet using that hash to target the background job in the database. Signed-off-by: Louis Chemineau <louis@chmn.me>
* | | Merge pull request #47780 from nextcloud/backport/47519/stable29Andy Scherzinger2024-09-051-20/+43
|\ \ \ | | | | | | | | [stable29] feat(transfer-ownership): Correctly react to encrypted files
| * | | fix(transfer-ownership): Improve comments according to code reviewCôme Chilliet2024-09-051-3/+3
| | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | feat(transfer-ownership): Correctly react to encrypted filesCôme Chilliet2024-09-051-20/+43
| |/ / | | | | | | | | | | | | | | | | | | | | | For E2EE encrypted files, we abort the transfer. For SSE encrypted files, we abort only if not using master key. Also fixed the check for when the path to a single file is used. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | Merge pull request #47774 from nextcloud/backport/46255/stable29Andy Scherzinger2024-09-053-12/+51
|\ \ \ | |/ / |/| | [stable29] fix: add option to remove the webroot for setup checks and don't chec…
| * | fix(setupchecks): Test overwrite.cli url first, then generated one, andCôme Chilliet2024-09-051-16/+30
| | | | | | | | | | | | | | | | | | trusted domains as last fallback. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | fix: add option to remove the webroot for setup checks and don't check ↵Daniel Kesselberg2024-09-053-13/+38
|/ / | | | | | | | | | | | | | | | | | | trusted_domains. 1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot. 2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | Merge pull request #47486 from nextcloud/backport/46013/stable29Andy Scherzinger2024-09-051-0/+25
|\ \ | | | | | | [stable29] fix: write object to the correct urn when moving from another storage to object store
| * | fix: write object to the correct urn when moving from another storage to ↵Robin Appelman2024-08-261-0/+25
| | | | | | | | | | | | | | | | | | object store Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | Merge pull request #47284 from nextcloud/backport/47038/stable29Arthur Schiwon2024-09-051-1/+2
|\ \ \ | | | | | | | | [stable29] fix: check for correct storage class when checking for link parent
| * | | fix: check for correct storage class when checking for link parentRobin Appelman2024-09-041-1/+2
| | |/ | |/| | | | | | | | | | | | | fixes #39123 Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | Merge pull request #47337 from nextcloud/backport/47332/stable29Arthur Schiwon2024-09-053-4/+8
|\ \ \ | | | | | | | | [stable29] fix(caldav): allow renaming of birthday calendars
| * | | fix(caldav): allow renaming of birthday calendarsAnna Larch2024-09-043-4/+8
| |/ / | | | | | | | | | Signed-off-by: Anna Larch <anna@nextcloud.com>
* | | Merge pull request #47765 from nextcloud/backport/47754/stable29Marcel Müller2024-09-051-8/+9
|\ \ \ | | | | | | | | [stable29] fix(appstore): Cache apps.json also on dev instances
| * | | fix(appstore): Cache apps.json also on dev instancesMarcel Müller2024-09-051-8/+9
|/ / / | | | | | | | | | Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
* | | Merge pull request #47734 from nextcloud/backport/46859/stable29Daniel Calviño Sánchez2024-09-0512-16/+214
|\ \ \ | | | | | | | | [stable29] Fix status check and saving of external storages
| * | | fix: Hide status tooltip in row to add a new mount pointDaniel Calviño Sánchez2024-09-043-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The row to add a new mount point is cloned when a new mountpoint is added, so it is expected that it includes a status span. However, it should not be displayed in that row, only in the cloned row when its status is updated. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
| * | | fix: Fix unmodified placeholder replacing the actual value when updatingDaniel Calviño Sánchez2024-09-043-0/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When updating global storages and user storages a property is not updated by "StoragesService::updateStorage()" if the value matches the unmodified placeholder. However, userglobal storages are not updated through the "StoragesService"; as only the authentication mechanism is updated it is directly done with "saveBackendOptions()" in "IUserProvided" or "UserGlobalAuth". Due to this the unmodified placeholder value needs to be explicitly checked in those cases and replaced by the actual value (note that in this case it is not possible to just skip updating a specific property). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | test: Add integration tests for saving external userglobal storagesDaniel Calviño Sánchez2024-09-045-2/+136
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As the external storage uses the Nextcloud server itself the number of workers of the PHP process running the Nextcloud server had to be increased. Otherwise if a request is sent for the external storage while handling a request from the integration tests a deadlock would occur. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | fix: Reset selected backend when adding a new storageDaniel Calviño Sánchez2024-09-041-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a new storage is added by selecting a backend the selected backend needs to be reset. Otherwise it is not possible to add another storage with the same backend. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | fix: Add missing translation for UI stringDaniel Calviño Sánchez2024-09-041-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | fix: Restore default status tooltip when no status message is providedDaniel Calviño Sánchez2024-09-041-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the status is updated but no explicit message is provided (for example, if the status check succeeded) the default tooltip (from the template) is now set to prevent a mismatch between the status and the tooltip (for example, if the configuration is fixed after a failed status check). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | fix: Set status tooltip to error message on failed actionsDaniel Calviño Sánchez2024-09-041-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When saving, updating and rechecking an storage fails (which is different to the soft-fail when the action itself succeeds but the status check does not) further details are provided in the error message of the response, which is now set as the tooltip. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | fix: Set status tooltip to status message when saving an storageDaniel Calviño Sánchez2024-09-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a storage is saved the status check can fail even if saving the storage succeeds. In those cases further details are provided in the status message of the storage, which is now set as the tooltip, similarly to how it is done when rechecking the storage. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | fix: Remove status check when configuration was changedDaniel Calviño Sánchez2024-09-042-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Setting a null status was supposed to remove the status check, but nothing was changed in that case. Now the status check is properly removed, and doing that by hiding the element rather than just turning it invisible also prevents that clicking on the invisible status triggers a check, as until the new configuration is saved the check will still be performed with the old configuration, which could be misleading for the user. Additionally, an explicit width is set to the parent of the span element to prevent its width from changing when the span is shown and hidden. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | fix: Recheck userglobal storages when loadedDaniel Calviño Sánchez2024-09-041-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Userglobal storages are now automatically recheck when loaded, similarly to how it is done for global storages. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | refactor: Store result in its own variableDaniel Calviño Sánchez2024-09-041-1/+2
| |/ / | | | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* / / Fix(l10n): Update translations from TransifexNextcloud bot2024-09-05310-116/+546
|/ / | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>