aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #26591 from nextcloud/techdebt/noid/less-iloggerChristoph Wurst2021-04-2752-318/+254
|\ | | | | Less ILogger
| * Fix PHP CSJoas Schilling2021-04-271-1/+0
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Fix PHP CSJoas Schilling2021-04-271-1/+0
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Fix psalm errorsJoas Schilling2021-04-276-24/+29
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Fix unit testsJoas Schilling2021-04-2725-93/+98
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Less ILoggerJoas Schilling2021-04-2723-199/+127
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #26718 from nextcloud/bugfix/noid/fix-ratelimit-templateJoas Schilling2021-04-273-26/+19
|\ \ | | | | | | Fix ratelimit template
| * | Do not allow to overwrite some variablesJoas Schilling2021-04-271-1/+3
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | Fix ratelimit templateJoas Schilling2021-04-272-25/+16
| |/ | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #26572 from ↵Joas Schilling2021-04-274-6/+16
|\ \ | |/ |/| | | | | nextcloud/bugfix/noid/throw-401-when-authentication-is-provided-and-invalid Throw "401 Unauthenticated" when authentication is provided but invalid
| * Adjust integration testJoas Schilling2021-04-222-2/+9
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Fix Authentication testJoas Schilling2021-04-221-4/+5
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Throw "401 Unauthenticated" when authentication is provided but invalidJoas Schilling2021-04-221-0/+2
| | | | | | | | | | | | E.g. with an AppToken that has been revoked Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #26764 from ↵Joas Schilling2021-04-271-0/+31
|\ \ | | | | | | | | | | | | nextcloud/feature/noid/add-geo-location-as-ROS-type Add geo location as ROS type
| * | Add geo location as ROS typeJoas Schilling2021-04-261-0/+31
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #26774 from ↵Julius Härtl2021-04-274-137/+1
|\ \ \ | | | | | | | | | | | | nextcloud/techdebt/noid/ldap-remove-pre73-paged-results
| * | | removes PagedResults adapter for PHP < 7.3Arthur Schiwon2021-04-264-137/+1
| | | | | | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | | Merge pull request #26765 from nextcloud/td/no_more_add_auto_trustedJoas Schilling2021-04-278-104/+7
|\ \ \ \ | | | | | | | | | | No longer add trusted servers on federated share creation
| * | | | No longer add trusted servers on federated share creationRoeland Jago Douma2021-04-268-104/+7
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | It was disabled by default for ages. And often resulted in unwanted behavior. If admins want trusted servers they just have to do it manually. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | Merge pull request #26775 from robottod/patch-1John Molakvoæ2021-04-271-14/+14
|\ \ \ \ | | | | | | | | | | Remove some deprecated calls from ShareByMailProvider.php
| * | | | Remove some deprecated calls from ShareByMailProvider.phprobottod2021-04-261-14/+14
| | |/ / | |/| | | | | | | | | | | | | | | | | | This moves the execute calls to the executeQuery and executeUpdate calls Resulting in less calls to deprecated functions Signed-off-by: rtod <robottod@protonmail.com>
* / | | [tx-robot] updated from transifexNextcloud bot2021-04-2718-130/+132
|/ / /
* | | Merge pull request #26763 from nextcloud/enh/federation/improve_permissionsRoeland Jago Douma2021-04-261-18/+2
|\ \ \ | | | | | | | | Improve federated permission handling
| * | | Improve federated permission handlingRoeland Jago Douma2021-04-261-18/+2
| |/ / | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | Merge pull request #26762 from ↵Joas Schilling2021-04-261-2/+19
|\ \ \ | |/ / |/| | | | | | | | nextcloud/bugfix/noid/respect-the-error-level-on-logging Respect the error level when logging
| * | Log deprecation only as debugJoas Schilling2021-04-261-0/+2
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | Respect the error level when loggingJoas Schilling2021-04-261-2/+17
|/ / | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #26259 from ↵Joas Schilling2021-04-263-0/+59
|\ \ | | | | | | | | | | | | nextcloud/feature/noid/validate-website-to-be-valid Validate the website field input to be a valid URL
| * | Validate the website field input to be a valid URLJoas Schilling2021-04-223-0/+59
| |/ | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #26747 from nextcloud/php8-libxmlLukas Reschke2021-04-261-4/+11
|\ \ | | | | | | Fix installer deprecation warnings for PHP 8
| * | PHP 8+ deprecates openssl_free_keyacsfer2021-04-251-1/+4
| | |
| * | Only use libxml_disable_entity_loader on PHP<8acsfer2021-04-251-3/+7
| | |
* | | Merge pull request #26755 from yan12125/bugfix/yan12125/caldav-truncationChristoph Wurst2021-04-262-4/+4
|\ \ \ | | | | | | | | Correctly truncate multibyte strings to fit into the database
| * | | Correctly truncate multibyte strings to fit into the databaseChih-Hsuan Yen2021-04-262-4/+4
|/ / / | | | | | | | | | | | | | | | Closes: #26174 Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
* | | Merge pull request #26721 from nextcloud/fix/noid/final-privateRoeland Jago Douma2021-04-261-1/+1
|\ \ \ | | | | | | | | private cannot be final
| * | | private cannot be finalMaxence Lange2021-04-231-1/+1
| | | | | | | | | | | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* | | | Merge pull request #26750 from ↵Roeland Jago Douma2021-04-261-4/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | nextcloud-pr-bot/automated/noid/psalm-baseline-update [Automated] Update psalm-baseline.xml
| * | | | Update psalm baselineNextcloud-PR-Bot2021-04-261-4/+1
|/ / / / | | | | | | | | | | | | Signed-off-by: GitHub <noreply@github.com>
* | | | [tx-robot] updated from transifexNextcloud bot2021-04-2618-6/+62
| | | |
* | | | Merge pull request #26749 from nextcloud/dependabot/composer/vimeo/psalm-4.7.1dependabot-preview[bot]2021-04-261-28/+34
|\ \ \ \ | |_|/ / |/| | |
| * | | Bump vimeo/psalm from 4.7.0 to 4.7.1dependabot-preview[bot]2021-04-261-28/+34
|/ / / | | | | | | | | | | | | | | | | | | Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.7.0 to 4.7.1. - [Release notes](https://github.com/vimeo/psalm/releases) - [Commits](https://github.com/vimeo/psalm/compare/4.7.0...4.7.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* | | [tx-robot] updated from transifexNextcloud bot2021-04-2532-16/+210
| | |
* | | [tx-robot] updated from transifexNextcloud bot2021-04-2430-6/+44
| | |
* | | Merge pull request #25417 from ↵Daniel Calviño Sánchez2021-04-2312-82/+740
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/fix-account-data-visibility-after-disabling-public-addressbook-upload Fix account data visibility after disabling public addressbook upload
| * | | Fix active scope not visible in the menu if excludedDaniel Calviño Sánchez2021-04-235-24/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depending on some settings (for example, if lookup server upload is disabled) some items can be hidden in the scope menu. However, if the user selected an scope in the past once the settings were changed the scope was no longer visible in the menu. Now the active scope will be always visible in the menu, although if it is an excluded scope it will be disabled. Selecting any other scope will then hide the excluded and no longer active one. When upload to the lookup server is disabled the scope menu was hidden for display name and email in the personal information settings; now the menu will be always shown to enable the above described behaviour. Note that the menu will be shown even if there is a single available scope so the user can read its description. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | Guard against null phone number valueDaniel Calviño Sánchez2021-04-231-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | "parsePhoneNumber()" expects a string, so a TypeError would be thrown if the phone number value is null. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | Add integration tests for searching users in contacts menuDaniel Calviño Sánchez2021-04-234-0/+283
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | Fix deleting properties of user settings when not given explicitlyDaniel Calviño Sánchez2021-04-232-13/+159
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The controller can receive an optional subset of the properties of the user settings; values not given are set to "null" by default. However, those null values overwrote the previously existing values, so in practice any value not given was deleted from the user settings. Now only non null values overwrite the previous values. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | Fix TypeError when "email" is not given in the controller requestDaniel Calviño Sánchez2021-04-231-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | Respect additional user settings not covered by the controllerDaniel Calviño Sánchez2021-04-232-17/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "AccountManager::updateUser()" wipes previous user data with whichever user data is given (except for some adjustments, like resetting the verified status when needed). As the controller overrode the properties those properties would lose some of their attributes even if they are not affected by the changes made by the controller. Now the controller only modifies the attributes set ("value" and "scope") to prevent that. Note that with this change the controller no longer removes the "verified" status, but this is not a problem because, as mentioned, "AccountManager::updateUser()" resets them when needed (for example, when the value of the website property changes). This change is a previous step to fix overwritting properties with null values, and it will prevent the controller from making unexpected changes if more attributes are added in the future. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>