aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add unit tests for "validateExpirationDateInternal"Daniel Calviño Sánchez2020-11-161-0/+284
| | | | | | | They were copied and adjusted as needed from the tests for "validateExpirationDate". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix default internal expiration dateDaniel Calviño Sánchez2020-11-161-3/+3
| | | | | | | The default expiration date for internal shares was set from the default link expiration date instead of the internal one. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add explicit time to test date for clarityDaniel Calviño Sánchez2020-11-121-3/+5
| | | | | | | This shows in a clearer way that the expected expiration date is the original one, but without time. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add unit test for expiration date with date and with defaultDaniel Calviño Sánchez2020-11-121-0/+28
| | | | | | | This adds back what was being actually tested in the unit test fixed in the previous commit. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix unit test for expiration date without date but with defaultDaniel Calviño Sánchez2020-11-121-7/+5
| | | | | | | | | The expiration date was explicitly given, so it was not testing what it should. Moreover, "link_defaultExpDays" needs to be mapped when testing the default value (even if it will just fallback to the value of "shareapi_expire_after_n_days"). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix unit test method nameDaniel Calviño Sánchez2020-11-121-1/+1
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix unit test for verifying enforced valid expiration date.Daniel Calviño Sánchez2020-11-121-0/+1
| | | | | | | The enforced expiration date was not actually enabled, as for that "shareapi_default_expire_date" needs to be explicitly set to "yes". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix unit test for verifying enforced expire date too far in the futureDaniel Calviño Sánchez2020-11-121-8/+5
| | | | | | | | | | | | The test should fail if no exception was thrown, and no exception was thrown due to a missing configuration parameter. However, the use of "addToAssertionCount(1)" made the test pass even if no exception was thrown and, therefore, to silently fail. Now the missing configuration parameter was added and the test will fail if the expected exception is not thrown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add unit tests to enforce a relaxed default share expiration dateDaniel Calviño Sánchez2020-11-121-0/+21
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Remove wrong and misleading commentDaniel Calviño Sánchez2020-11-121-2/+0
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Remove extra spacesDaniel Calviño Sánchez2020-11-121-10/+6
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix typo in variable nameDaniel Calviño Sánchez2020-11-121-129/+129
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix typos in method namesDaniel Calviño Sánchez2020-11-121-9/+9
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Merge pull request #24065 from nextcloud/enh/pimp_accessibilitycontrollerChristoph Wurst2020-11-121-31/+4
|\ | | | | Pimp the accesibility controller
| * Pimp the accesibility controllerRoeland Jago Douma2020-11-111-31/+4
| | | | | | | | | | | | | | | | * No usused members * appRoot member * less constructor args Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | [tx-robot] updated from transifexNextcloud bot2020-11-1228-388/+60
| |
* | Merge pull request #24063 from ↵Morris Jobke2020-11-112-46/+46
|\ \ | | | | | | | | | | | | nextcloud/techdebt/noid/switch-to-class-names-for-encryption-DI Change to full class names for the encryption app DI in preparation of auto-wiring
| * | Change to full class names for the encryption app DI in preparation of ↵Morris Jobke2020-11-112-46/+46
| | | | | | | | | | | | | | | | | | auto-wiring Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | Merge pull request #24037 from ↵Roeland Jago Douma2020-11-111-6/+6
|\ \ \ | |_|/ |/| | | | | | | | nextcloud/enh/reflectionparamter_getclass_deprecatred ReflectionParamter::getClass is deprecated
| * | ReflectionParamter::getClass is deprecatedRoeland Jago Douma2020-11-111-6/+6
|/ / | | | | | | | | | | | | | | In php8 this starts throwing warnings. And since we use it quite often we flood the log. This moves it to getType which does the same. Only non deprecated now. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Merge pull request #24060 from nextcloud/revert-24039-faster-installationMorris Jobke2020-11-113-49/+3
|\ \ | | | | | | Revert "Installation goes brrrr"
| * | Revert "Installation goes brrrr"Christoph Wurst2020-11-113-49/+3
|/ /
* | Merge pull request #24054 from nextcloud/bugfix/noid/calendar-repair-oracleMorris Jobke2020-11-111-0/+32
|\ \ | |/ |/| Manually iterate over calendardata when oracle is used
| * Manually iterate over calendardata when oracle is usedJulius Härtl2020-11-111-0/+32
| | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | Merge pull request #24039 from nextcloud/faster-installationJoas Schilling2020-11-113-3/+49
|\ \ | | | | | | Installation goes brrrr
| * | Don't create a schema to check if the migrations table existsJoas Schilling2020-11-111-0/+5
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | Reduce the number of schemas we generate when we just run all migrations anywayJoas Schilling2020-11-111-0/+41
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | Only update the schema when we install anywayJoas Schilling2020-11-112-3/+3
| |/ | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #23915 from ↵Morris Jobke2020-11-116-8/+8
|\ \ | | | | | | | | | | | | st3iny/fix/noid/png-icons-in-caldav-reminder-emails Use png icons in caldav reminder emails
| * | Use png icons in caldav reminder emailsRichard Steinmetz2020-11-076-8/+8
| | | | | | | | | | | | Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
* | | Merge pull request #24038 from ↵Morris Jobke2020-11-111-49/+0
|\ \ \ | |_|/ |/| | | | | | | | nextcloud/techdebt/noid/remove-unused-static-methods-files_external Remove unused and deprecated methods from files_external MountConfig
| * | Remove unused and deprecated methods from files_external MountConfigMorris Jobke2020-11-101-49/+0
| | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | Merge pull request #24041 from ↵Julius Härtl2020-11-111-14/+0
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/techdebt/noid/remove-oc_hooks-for-group-management Remove old OC_Hook for OC_Group events
| * | | Remove old OC_Hook for OC_Group eventsMorris Jobke2020-11-101-14/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Those mappings exist and we will remove the first ones (labeled as `old`): old: `\OC_Hook::listen('OC_Group', 'pre_createGroup', array('run' => true, 'gid' => $gid));` since OC 8 (owncloud/core#12618): `$groupManager->listen('\OC\Group', 'preCreate', function ($gid) { ... });` since NC 17 (#18350): `OCP\Group\Events\BeforeGroupCreatedEvent` old: `\OC_Hook::emit('OC_User', 'post_createGroup', array('gid' => $gid->getGID()));` since OC 8 (owncloud/core#12618): `$groupManager->listen('\OC\Group', 'postCreate', function (\OC\Group\Group $gid) { ... });` since NC 17 (#18350): `OCP\Group\Events\GroupCreatedEvent` old: `\OC_Hook::emit('OC_Group', 'pre_deleteGroup', array('run' => true, 'gid' => $group->getGID()));` since OC 8 (owncloud/core#12618): `$groupManager->listen('\OC\Group', 'preDelete', function (\OC\Group\Group $group) { ... });` since NC 17 (#18350): `OCP\Group\Events\BeforeGroupDeletedEvent` old: `\OC_Hook::emit('OC_User', 'post_deleteGroup', array('gid' => $group->getGID()));` since OC 8 (owncloud/core#12618): `$groupManager->listen('\OC\Group', 'postDelete', function (\OC\Group\Group $group) { ... });` since NC 17 (#18350): `OCP\Group\Events\GroupDeletedEvent` old: `\OC_Hook::emit('OC_Group', 'pre_addToGroup', array('run' => true, 'uid' => $user->getUID(), 'gid' => $group->getGID()));` since OC 8 (owncloud/core#12618): `$groupManager->listen('\OC\Group', 'preAddUser', function (\OC\Group\Group $group, \OC\User\User $user) { ... });` since NC 17 (#18350): `OCP\Group\Events\BeforeUserAddedEvent` old: `\OC_Hook::emit('OC_Group', 'post_addToGroup', array('uid' => $user->getUID(), 'gid' => $group->getGID()));` since OC 8 (owncloud/core#12618): `$groupManager->listen('\OC\Group', 'postAddUser', function (\OC\Group\Group $group, \OC\User\User $user) { ... });` since NC 17 (#18350): `OCP\Group\Events\UserAddedEvent` Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | | Merge pull request #23882 from nextcloud/tests/oracleJoas Schilling2020-11-1141-91/+905
|\ \ \ \ | | | | | | | | | | Run unit tests against oracle
| * | | | Fix unique key in test tableJoas Schilling2020-11-101-4/+8
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Fix naming of jobs and stepsJoas Schilling2020-11-101-17/+20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Update baseline, I'm sorryJoas Schilling2020-11-101-5/+19
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Fix CSJoas Schilling2020-11-104-0/+4
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Create primary keys on all tables and add a command to create the afterwardsJoas Schilling2020-11-1016-8/+347
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Replace the credentials table with one that can have empty userJoas Schilling2020-11-108-19/+182
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Primary key columns on Oracle can not have empty strings Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Don't try to update on NotNullConstraintViolationException, only on unique ↵Joas Schilling2020-11-101-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | or foreign key Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Fix comparing the empty string for global credentialsJoas Schilling2020-11-102-11/+26
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Empty string is returned as null, but empty string in file cache is the root ↵Joas Schilling2020-11-102-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and exists Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Fix public calendars as they are stored with null on oracleJoas Schilling2020-11-101-12/+34
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Make sure columns with an empty default are nullable for OracleJoas Schilling2020-11-1015-9/+138
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Fix "Invalid fetch style: 12" on OracleJoas Schilling2020-11-101-2/+5
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Make the test pass on repeating callsJoas Schilling2020-11-101-2/+7
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Skip the insertIfNotExists() tests on Oracle because it doesn't work with clobJoas Schilling2020-11-101-0/+20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Easier debugging and spell fixJoas Schilling2020-11-101-6/+9
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-06-03 11:19:19 +0000