aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use DOMContentLoaded and fix sharebymail loading issueJohn Molakvoæ (skjnldsv)2020-07-2068-3657/+4221
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* Merge pull request #21916 from nextcloud/tests/remove-ui-regressionRoeland Jago Douma2020-07-2011-1179/+0
|\ | | | | Remove outdated ui-regression tests
| * Remove outdated ui-regression testsJulius Härtl2020-07-2011-1179/+0
| | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | Merge pull request #21880 from nextcloud/webauthn/discourage_user_authMorris Jobke2020-07-201-2/+7
|\ \ | |/ |/| Discourage webauthn user interaction
| * Discourage webauthn user interactionRoeland Jago Douma2020-07-161-2/+7
| | | | | | | | | | | | | | | | | | | | Else people might have the feeling this is also doing 2FA. And since it is only prefered it can be ignored and hacked around. Once we have proper 2FA with webauthn in one go this probably needs to be revisted. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | [tx-robot] updated from transifexNextcloud bot2020-07-202-0/+6
| |
* | Merge pull request #21891 from ↵Morris Jobke2020-07-192-19/+20
|\ \ | | | | | | | | | | | | nextcloud/techdebt/undeprecate-iappcontainer-iservercontainer Undeprecate IAppContainer and IServerContainer
| * | Undeprecate IAppContainer and IServerContainerChristoph Wurst2020-07-172-19/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With 4152216bd8cf9d49e6749d26bb8b491dd49b089b these two interfaces got deprecated with the reasoning that we only need the base PSR interface. However, there are cases where in Nextcloud you still want to have a specific container (the one for the app vs the one for the server) when you either have a container injected or query one from a container. With a single interface that would not be possible. So it's probably better if we leave the two interfaces, but only have them extend the PSR interface. IContainer – with the custom methods – shall still be phased out, but the two other sub interfaces can stay for tagging purposes. Tagging means that no methods shall be added. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | [tx-robot] updated from transifexNextcloud bot2020-07-1920-86/+86
| | |
* | | [tx-robot] updated from transifexNextcloud bot2020-07-188-0/+342
| | |
* | | Merge pull request #21887 from ↵Christoph Wurst2020-07-171-0/+3
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/techdebt/deprecate-server-container-query Deprecate the query mothod on the server container
| * | | Deprecate the query mothod on the server containerChristoph Wurst2020-07-171-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The interface method has already been deprecated, but if some code uses the concrete type instead, the deprecation is not shown (by phpstorm), so I think it's better to have this method tagged as well. The "fix" for this deprecation is to simply use `get` instead of `query`. Right now this will work 100% the same, but the goal is to slim down the interface and only use what PSR-11 offers. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | Merge pull request #21889 from ↵Joas Schilling2020-07-172-15/+15
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | nextcloud/techdebt/noid/make-magic-strings-publicly-available Make magic strings of ClientFlowLogin and v2 publicly available
| * | | Make magic strings of ClientFlowLogin and v2 publicly availableJoas Schilling2020-07-172-15/+15
|/ / / | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #21859 from nextcloud/techdebt/dav-psr-containerRoeland Jago Douma2020-07-171-7/+4
|\ \ \ | |/ / |/| | Migrate DAV to the PSR container
| * | Migrate DAV to the PSR containerChristoph Wurst2020-07-161-7/+4
| | | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | [tx-robot] updated from transifexNextcloud bot2020-07-1728-10/+804
| | |
* | | Merge pull request #21869 from ↵Joas Schilling2020-07-163-11/+44
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/techdebt/noid/add-constants-for-magic-strings Add constants for the magic strings of template rendering
| * | | Add constants for the magic strings of template renderingJoas Schilling2020-07-163-11/+44
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #21873 from ↵Roeland Jago Douma2020-07-162-0/+156
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | nextcloud/techdebt/deprecate-server-container-getters Deprecate the server container getters
| * | | | Deprecate the server container gettersChristoph Wurst2020-07-162-0/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Service locators are an anti pattern. These getters just make it more appealing to do the wrong thing. If you want to locate a service the bad way, just use the `get` method on a container – it will do the same in also one line of code. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | | Merge pull request #21874 from nextcloud/feature/scoped-psr-loggerRoeland Jago Douma2020-07-164-1/+164
|\ \ \ \ \ | | | | | | | | | | | | Add a scoped PSR logger for apps
| * | | | | Add a scoped PSR logger for appsChristoph Wurst2020-07-164-1/+164
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Just like for ILogger we should have a version that has the app ID pre-set for the context (unless overwritten) so that each log entry can be traced back to the app that produced it. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | | Merge pull request #21855 from p5n/masterRoeland Jago Douma2020-07-161-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | fix typo in revokeShare()
| * | | | fix typoSergej Pupykin2020-07-161-1/+1
| | | | |
* | | | | Merge pull request #21863 from ↵Christoph Wurst2020-07-161-2/+1
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | nextcloud/techdebt/files-trashbin-container-cleanup Clean up container usage in files trashbin
| * | | | Clean up container usage in files trashbinChristoph Wurst2020-07-161-2/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | | Merge pull request #21809 from nextcloud/techdebt/di-container-cleanupChristoph Wurst2020-07-1610-140/+244
|\ \ \ \ \ | |_|_|/ / |/| | | | Use PSR container interface and deprecate our own abstraction
| * | | | Use PSR container interface and deprecate our own abstractionChristoph Wurst2020-07-1610-140/+244
|/ / / / | | | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | Merge pull request #21858 from ↵Roeland Jago Douma2020-07-161-17/+3
|\ \ \ \ | |/ / / |/| | | | | | | | | | | nextcloud/dependabot/npm_and_yarn/build/lodash-4.17.19 Bump lodash from 4.17.14 to 4.17.19 in /build
| * | | Bump lodash from 4.17.14 to 4.17.19 in /builddependabot[bot]2020-07-161-17/+3
|/ / / | | | | | | | | | | | | | | | | | | Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>
* / / [tx-robot] updated from transifexNextcloud bot2020-07-1636-70/+132
|/ /
* | Merge pull request #21853 from nextcloud/enh/noid/better-event-descriptionMorris Jobke2020-07-152-2/+20
|\ \ | | | | | | Better event description for BeforeTemplateRenderedEvent in files and files_sharing
| * | Better event description for BeforeTemplateRenderedEvent in files and ↵Morris Jobke2020-07-152-2/+20
|/ / | | | | | | | | | | files_sharing Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #21815 from ↵Morris Jobke2020-07-157-24/+138
|\ \ | | | | | | | | | | | | nextcloud/enh/noid/sharing-additional-scripts-event Add LoadAdditionalScriptsEvent for files_sharing
| * | Add BeforeTemplateRenderedEvent for files_sharingJulius Härtl2020-07-157-24/+138
| | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | | Merge pull request #21822 from nextcloud/enh/events/additionalscriptsMorris Jobke2020-07-156-14/+125
|\ \ \ | | | | | | | | Add real events to load additionalscripts
| * | | Add real events to load additionalscriptsRoeland Jago Douma2020-07-156-14/+125
| | |/ | |/| | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | Merge pull request #21843 from ↵Morris Jobke2020-07-151-8/+5
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/debt/noid/less-verbose-translation-checker Make translation-checker.php less verbose
| * | | Make translation-checker.php less verbose.Daniel Kesselberg2020-07-151-8/+5
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | | | Merge pull request #21844 from ↵Morris Jobke2020-07-151-6/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | bladewing/bladewing-harden-against-mimetype-mismatch Avoid substr() error when strpos returns false
| * | | | Extra white space to follow other ifslui87kw2020-07-151-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
| * | | | Avoid substr() error when strpos returns falsebladewing2020-07-151-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "Exception: substr() expects parameter 3 to be int, bool given" can occur on Line 378 $mimePart = substr($icon, 0, strpos($icon, '-')); This happens, when '-' is not found and strpos returns false instead of an int. When this occurs, e.g., Activity hangs. Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
* | | | | Merge pull request #21728 from nextcloud/bugfix/noid/s3-external-mtime-cacheMorris Jobke2020-07-151-0/+6
|\ \ \ \ \ | | | | | | | | | | | | Reuse cache for directory mtime/size if filesystem changes can be ignored
| * | | | | Reuse cache for directory mtime/size if filesystem changes can be ignoredJulius Härtl2020-07-071-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | | | | | Merge pull request #21837 from nextcloud/enh/noid/also-show-cs-diffMorris Jobke2020-07-151-1/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | Run cs:check a second time to show diff
| * | | | | | Run cs:check a second time to show diffDaniel Kesselberg2020-07-151-1/+4
| | |_|/ / / | |/| | | | | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | | | | | Merge pull request #21848 from ↵Morris Jobke2020-07-152-0/+17
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/techdebt/deprecate-internal-symfony-dispatcher-adapter Deprecate the internal Symfony dispatcher adapter
| * | | | | | Deprecate the internal Symfony dispatcher adapterChristoph Wurst2020-07-152-0/+17
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This type is not known on the public API, yet we should make sure that any usage of this class is noticed and migrated as soon as possible. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | | | Merge pull request #21849 from nextcloud/fix/noid/integration-testsMorris Jobke2020-07-151-0/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Fix integration test due to new dashboard app