aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Solve acceptance test failure due to clicks on covered elementsDaniel Calviño Sánchez2017-10-192-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Firefox and Chrome drivers for Selenium refuse to click on an element if the point to be clicked is covered by a different element, throwing an UnknownError exception with message "Element is not clickable at point ({x}, {y}). Other element would receive the click: {element}". Although in general that would be a legit error (as the user would not be able to click on the element) due to a bad layout, sometimes this can be just a temporal issue caused by an animation, in which case there would be no problem once the animation finished and the elements are all in their final location. Unfortunately, automatically handling those situations in which the problem is caused by an animation by just retrying a few times if the element to be clicked is covered before giving up would probably cause confusion instead of easing test writing. The reason is that if the center of the element is covered by another one the Firefox driver for Selenium tries to click on the corners of the element instead. The problem is that the coordinates used for the click are integer values, but Firefox has sub-pixel accuracy, so sometimes (depending on which corner is not covered and whether the left, top, width or height properties of the element to be clicked have a decimal component or not) the clicks silently land on a different HTML element (and that is with squared borders; with round borders they always land on a different HTML element. That was partially addressed for Selenium 3.0 by clicking first on the edges, but it would still fail if the middle point of the edges is covered but not the corners). It is not possible to fix or even detect all that from the tests (except maybe with some extreme hacks involving accessing private PHP members from Mink and bypassing or replacing the standard JavaScript executed by the Firefox driver with a custom implementation...), so it is not possible to ensure that clicks during an animation will land on the right element (in fact it is not possible even on static elements, although except when the layout is wrong there should be no problem); sometimes retrying a click when the element is covered would solve the problem, sometimes it would cause a different element to be clicked (and sometimes there would be even no retry, as the first click would have silently landed on a different element than the expected one). Therefore, a different approach must be used. Instead of trying to automatically handle clicks during animations the tests must be written being aware of the problem and thus waiting somehow for the animations that can cause a problem to end before performing the clicks. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Extend the clickable area of the file name to include the thumbnailDaniel Calviño Sánchez2017-10-191-1/+2
| | | | | | | | | | Now that the checkbox was moved to its own column clicking on the thumbnail should behave like clicking on the file name. To achieve this the left position was replaced with a padding, so the element is kept at the same place while extending its clickable area to cover the thumbnail. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Move checkboxes to their own columnDaniel Calviño Sánchez2017-10-197-63/+77
| | | | | | | | | | | | | | | | | | | | | | | | The selection column is not only a visual column, but also a real column of the file list table. Unlike other columns whose width is reduced in space constrained screens the selection column must stay the same so the tapping area is large enough to be easily usable The selection column does not appear in the search results table, so its contents have to be explicitly aligned with those of the main table based on whether the main table has a selection column or not (using the "has-selection" CSS class in the same way as the "has-favorite" CSS class was being used when there was a column for favorite actions). In the tests the ":visible" selector can no longer be used. That selector matches elements with a width or height that is greater than zero, but the dimensions calculated in the unit tests are not reliable; the width of the link was zero before these changes, and now moving the checkbox to its own column causes the height of the link to become zero too, so it no longer matches the ":visible" selector even if it is not hidden. As hidding and showing the link is based on its "display" CSS property its value is the one checked now. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Remove "has-favorites" class from file list tableDaniel Calviño Sánchez2017-10-192-4/+0
| | | | | | | | The "has-favorites" CSS class is no longer used after moving the favorite mark to the top right corner of the thumbnail, so there is no need to add it to the table. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Move favorite mark to the top right corner of the thumbnailDaniel Calviño Sánchez2017-10-195-38/+22
| | | | | | | | | | | | | | | | | | | | | The favorite icon was shown on its own "column" (not a real column in the table, but a visual column achieved through margins and left positions). Now the icon was moved to the top right corner of the file thumbnail, and the thumbnail and file name were moved to the left to fill the space left by the "column". To keep the markup in line with its visual representation (and to ease the placing through CSS), the favorite mark is no longer prepended to the row, but appended to the thumbnail instead. In the same way, the thumbnail is no longer appended to the checkbox label, but to the link with the name of the file instead (although the checkbox is still shown at the bottom right corner of the thumbnail, and clicking on the thumbnail still selects the file). In order to show the "busy" state on a file the "icon-loading-small" CSS class is set to the parent element of the thumbnail, so the thumbnail is also wrapped now by another div with the same size and position as the label. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Set background size for thumbnail in CSS instead of JavaScriptDaniel Calviño Sánchez2017-10-192-2/+3
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Show always the checkboxDaniel Calviño Sánchez2017-10-191-2/+2
| | | | | | | | The checkbox is not shown always with full opacity, though, in order to reduce the visual noise (specially later, once the checkbox is moved to its own column). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Replace inline favorite action with just a favorite iconDaniel Calviño Sánchez2017-10-194-147/+60
| | | | | | | | | | | | | | | | This is a preparatory step for a following commit in which the position of the favorite icon and the checkbox will be swapped; in that new design the favorite icon is no longer expected to be an action but just a simple mark on whether the file is favorited or not (the action is expected to be triggered then only from the file actions menu). The favorite icon is now fully shown or completely hidden depending on whether the file is favorited or not. As the icon is just informative but no longer an action now it does not change when hovered or focus. In the same way, the alternative text when the file is not favorited now it is not "Favorite" (an action) but "Not favorited" instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Update acceptance tests to favorite files through the file actions menuDaniel Calviño Sánchez2017-10-191-2/+20
| | | | | | | | | Currently a file can be favorited either through the inline action or through the file actions menu. However, the inline action will be removed in a following commit and then it will be possible to do it only through the file actions menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add "Favorite" action to the file actions menuDaniel Calviño Sánchez2017-10-193-2/+131
| | | | | | | | | | | The new FileAction for the menu is essentially the same as the old inline FileAction, except for the rendering; in this case the FileAction is shown in the menu in a standard way, so there is no need to provide a custom renderer (although the menu entry text and icon change depending on whether the file is currently a favorite or not, but that can be done just with displayName and iconClass functions). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add support to FileActionsMenu for icon class functionsDaniel Calviño Sánchez2017-10-193-1/+45
| | | | | | | | | | | | Icon class function properties make possible to render a different icon class depending on the context of the file action. Inline file actions had support for them already and called them passing the file name and context of the file action as parameters. Due to this the FileActionsMenu passes those parameters too to icon class functions instead of just the context like done for display name functions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Merge pull request #6515 from nextcloud/templating-of-email-subjectsJoas Schilling2017-10-1817-127/+204
|\ | | | | Allow templating of email subjects
| * Fix autoloadingJoas Schilling2017-10-182-0/+2
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Set the data from the templateJoas Schilling2017-10-189-113/+46
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Introduce a public interface for MessageJoas Schilling2017-10-184-9/+106
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Set the subject with the email template to allow themingJoas Schilling2017-10-186-14/+21
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Allow templating of email subjectsJoas Schilling2017-10-182-0/+38
|/ | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* [tx-robot] updated from transifexNextcloud bot2017-10-1828-8/+224
|
* Merge pull request #6854 from nextcloud/s3-multipart-propagate-exceptionRoeland Jago Douma2017-10-171-0/+1
|\ | | | | propagate multipart upload exception when aborting upload
| * propagate multipart upload exception when aborting uploadRobin Appelman2017-10-171-0/+1
|/ | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix urlBjoern Schiessle2017-10-172-4/+4
| | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* Merge pull request #5673 from tbille/gui-bug-authenticationJulius Härtl2017-10-171-1/+3
|\ | | | | Destroy modal when closed
| * Destroy modal when closedThomas Bille2017-10-171-1/+3
|/ | | | Signed-off-by: Thomas Bille <contact@tbille.fr>
* [tx-robot] updated from transifexNextcloud bot2017-10-1722-32/+198
|
* Merge pull request #6844 from nextcloud/phan-repoRoeland Jago Douma2017-10-162-3/+3
|\ | | | | Phan is moved to a new repo
| * Phan is moved to a new repoRoeland Jago Douma2017-10-162-3/+3
| | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Merge pull request #6837 from nextcloud/timespan-check-3blizzz2017-10-161-12/+49
|\ \ | | | | | | Fix future time spans
| * | Fix future time spansdartcafe2017-10-151-12/+49
| |/ | | | | | | Signed-off-by: dartcafe <github@dartcafe.de>
* | [tx-robot] updated from transifexNextcloud bot2017-10-162-30/+42
| |
* | Merge pull request #6585 from nextcloud/theming-fileupload-errorhandlingRoeland Jago Douma2017-10-154-22/+222
|\ \ | | | | | | Theming: Handle errors on uploaded files properly
| * | Theming: Add tests for mimetype and upload error checksJulius Härtl2017-10-032-15/+170
| | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
| * | Theming: Fix message/loading display on errorsJulius Härtl2017-10-032-0/+3
| | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
| * | Theming: Check valid image format also for logoJulius Härtl2017-10-031-0/+12
| | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
| * | Theming: Handle errors on uploaded files properlyJulius Härtl2017-10-032-17/+47
| | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | | Merge pull request #6812 from nextcloud/upload-cache-pathRoeland Jago Douma2017-10-151-1/+3
|\ \ \ | | | | | | | | also use configured 'cache_path' for new chunking
| * | | also use configured 'cache_path' for new chunkingRobin Appelman2017-10-111-1/+3
| | | | | | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | Merge pull request #6791 from nextcloud/fix-test-warningsRoeland Jago Douma2017-10-152-3/+3
|\ \ \ \ | | | | | | | | | | Fix test warnings
| * | | | Don't use deprecated $this->getMock() methodJoas Schilling2017-10-091-2/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Fix tests with group managerJoas Schilling2017-10-091-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | Merge pull request #6813 from nextcloud/exclude-avatar-from-same-site-cookieRoeland Jago Douma2017-10-151-0/+1
|\ \ \ \ \ | |_|_|_|/ |/| | | | Exclude avatar from Same-Site Cookie requirement
| * | | | Exclude avatar from Same-Site Cookie requirementLukas Reschke2017-10-111-0/+1
| | |/ / | |/| | | | | | | | | | | | | | | | | | Required to work with the upcoming Collabora avatar integration. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | | | Merge pull request #6761 from nextcloud/fix-avatar-loading-stateJohn Molakvoæ2017-10-143-36/+51
|\ \ \ \ | | | | | | | | | | Fix popover position and avatar loading
| * | | | EllipsisJohn Molakvoæ (skjnldsv)2017-10-141-0/+5
| | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | Fix popover position and avatar loadingJohn Molakvoæ (skjnldsv)2017-10-143-36/+46
|/ / / / | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* | | | Merge pull request #6829 from nextcloud/fix-app-nav-edit-inputsJohn Molakvoæ2017-10-141-1/+0
|\ \ \ \ | | | | | | | | | | Fix app-navigation editable entry input colors
| * | | | Fix app-navigation editable entry input colorsJohn Molakvoæ (skjnldsv)2017-10-131-1/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* | | | | [tx-robot] updated from transifexNextcloud bot2017-10-1426-38/+552
| | | | |
* | | | | Merge pull request #6826 from ↵Joas Schilling2017-10-131-6/+12
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | nextcloud/fix-class-name-in-exception-logger-plugin Fix class name in exception logger plugin
| * | | | Use ::class to avoid errorsJoas Schilling2017-10-131-6/+12
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Fix class name, regression from 44cf67accdc294f46bf82b3f8661f353dc5e22f0Joas Schilling2017-10-131-1/+1
|/ / / / | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-19 13:07:56 +0000