aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [tx-robot] updated from transifexNextcloud bot2021-04-2532-16/+210
|
* [tx-robot] updated from transifexNextcloud bot2021-04-2430-6/+44
|
* Merge pull request #25417 from ↵Daniel Calviño Sánchez2021-04-2312-82/+740
|\ | | | | | | | | nextcloud/fix-account-data-visibility-after-disabling-public-addressbook-upload Fix account data visibility after disabling public addressbook upload
| * Fix active scope not visible in the menu if excludedDaniel Calviño Sánchez2021-04-235-24/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depending on some settings (for example, if lookup server upload is disabled) some items can be hidden in the scope menu. However, if the user selected an scope in the past once the settings were changed the scope was no longer visible in the menu. Now the active scope will be always visible in the menu, although if it is an excluded scope it will be disabled. Selecting any other scope will then hide the excluded and no longer active one. When upload to the lookup server is disabled the scope menu was hidden for display name and email in the personal information settings; now the menu will be always shown to enable the above described behaviour. Note that the menu will be shown even if there is a single available scope so the user can read its description. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Guard against null phone number valueDaniel Calviño Sánchez2021-04-231-0/+3
| | | | | | | | | | | | | | "parsePhoneNumber()" expects a string, so a TypeError would be thrown if the phone number value is null. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Add integration tests for searching users in contacts menuDaniel Calviño Sánchez2021-04-234-0/+283
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix deleting properties of user settings when not given explicitlyDaniel Calviño Sánchez2021-04-232-13/+159
| | | | | | | | | | | | | | | | | | | | The controller can receive an optional subset of the properties of the user settings; values not given are set to "null" by default. However, those null values overwrote the previously existing values, so in practice any value not given was deleted from the user settings. Now only non null values overwrite the previous values. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix TypeError when "email" is not given in the controller requestDaniel Calviño Sánchez2021-04-231-1/+1
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Respect additional user settings not covered by the controllerDaniel Calviño Sánchez2021-04-232-17/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "AccountManager::updateUser()" wipes previous user data with whichever user data is given (except for some adjustments, like resetting the verified status when needed). As the controller overrode the properties those properties would lose some of their attributes even if they are not affected by the changes made by the controller. Now the controller only modifies the attributes set ("value" and "scope") to prevent that. Note that with this change the controller no longer removes the "verified" status, but this is not a problem because, as mentioned, "AccountManager::updateUser()" resets them when needed (for example, when the value of the website property changes). This change is a previous step to fix overwritting properties with null values, and it will prevent the controller from making unexpected changes if more attributes are added in the future. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Add more unit tests for setting user settingsDaniel Calviño Sánchez2021-04-231-0/+160
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Change default test data to values less similar to empty valuesDaniel Calviño Sánchez2021-04-231-12/+12
| | | | | | | | | | | | | | Right now it makes no difference, but this should make future tests clearer, specially in case of failure. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Extract default test data to a helper getterDaniel Calviño Sánchez2021-04-231-42/+46
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Use constants from interface rather than classDaniel Calviño Sánchez2021-04-232-21/+21
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Merge pull request #26719 from nextcloud/chore/dav-cleanup-query-usageJoas Schilling2021-04-231-71/+73
|\ \ | | | | | | Clean up DB code in the CalDAV backend
| * | Close open cursorsChristoph Wurst2021-04-231-3/+5
| | | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
| * | Use the new executeQuery and executeUpdate methodsChristoph Wurst2021-04-231-54/+54
| | | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
| * | Drop default fetch mode parameterChristoph Wurst2021-04-231-15/+15
|/ / | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Merge pull request #26717 from nextcloud/fix/copy-etag-node-not-foundChristoph Wurst2021-04-232-1/+22
|\ \ | |/ |/| Only set copy etag if the destination source can be found
| * Only set copy etag if the destination source can be foundChristoph Wurst2021-04-232-1/+22
|/ | | | | | | | | | The etag is only set for files, but it's also possible that in edge cases the copy destination node can't be found. In that case we don't need to set any etag. Required for #26083 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Merge pull request #26715 from ↵Roeland Jago Douma2021-04-231-9/+0
|\ | | | | | | | | nextcloud-pr-bot/automated/noid/psalm-baseline-update [Automated] Update psalm-baseline.xml
| * Update psalm baselineNextcloud-PR-Bot2021-04-231-9/+0
|/ | | | Signed-off-by: GitHub <noreply@github.com>
* [tx-robot] updated from transifexNextcloud bot2021-04-23194-272/+298
|
* Merge pull request #26375 from ↵Morris Jobke2021-04-227-40/+70
|\ | | | | | | | | nextcloud/techdebt/noid/symfony-component-translation-pluralization-rules-is-deprecated "Symfony\Component\Translation\PluralizationRules" is deprecated
| * Fix test by defining pluralsJoas Schilling2021-04-201-1/+5
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Only check translations insteda of the full fileJoas Schilling2021-04-201-1/+1
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Fix PHP CSJoas Schilling2021-04-201-1/+1
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Correclty use plural for share exceptionJoas Schilling2021-04-201-2/+2
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Correctly replace all PHP placeholders with the parametersJoas Schilling2021-04-203-6/+29
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Fix languages that miss a string in the translationJoas Schilling2021-04-201-7/+16
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Add a check for the pipe characterJoas Schilling2021-04-202-0/+11
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * "Symfony\Component\Translation\PluralizationRules" is deprecatedJoas Schilling2021-04-202-40/+23
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #26627 from nextcloud/smb-341blizzz2021-04-2211-37/+52
|\ \ | | | | | | update icewind/smb to 3.4.1
| * | update icewind/smb to 3.4.1Robin Appelman2021-04-1911-37/+52
| | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | Merge pull request #26700 from nextcloud/bugfix/noid/fix-oci-ciblizzz2021-04-221-1/+1
|\ \ \ | | | | | | | | FIx Oracle by testing on Ubuntu 20.04 until oci8.so is available for …
| * | | FIx Oracle by testing on Ubuntu 20.04 until oci8.so is available for 21.04Joas Schilling2021-04-221-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #26699 from nextcloud/fix/noid/iresult-php-docblizzz2021-04-221-1/+1
|\ \ \ \ | |/ / / |/| | | remove undefined parameter, add description
| * | | remove undefined parameter, add descriptionArthur Schiwon2021-04-221-1/+1
|/ / / | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | Merge pull request #26586 from ↵Joas Schilling2021-04-228-24/+51
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/bugfix/noid/handle-device-login-like-an-alternative-login Handle device login like an alternative login
| * | | Handle device login like an alternative loginJoas Schilling2021-04-208-24/+51
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #26692 from nextcloud/redirect-forumMorris Jobke2021-04-221-3/+3
|\ \ \ \ | | | | | | | | | | Redirect users to forum for questions
| * | | | Typoacsfer2021-04-221-1/+1
| | | | |
| * | | | Redirect users to forum for questionsacsfer2021-04-221-3/+3
| | | | | | | | | | | | | | | Be more specific so more users will go directly to the forum instead using Github for non-bug reports.
* | | | | Merge pull request #25714 from ↵Morris Jobke2021-04-221-3/+19
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | nextcloud/fix/23197/explicitly_check_hex2bin_input Explicitly check hex2bin input
| * | | | Explicitly check hex2bin inputRoeland Jago Douma2021-02-181-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For #23197 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | [tx-robot] updated from transifexNextcloud bot2021-04-22398-764/+884
| | | | |
* | | | | Merge pull request #26609 from nextcloud/Valdnet-patch-6Roeland Jago Douma2021-04-211-1/+1
|\ \ \ \ \ | | | | | | | | | | | | l10n: Improve styling
| * | | | | l10n: Improve stylingValdnet2021-04-181-1/+1
| | | | | | | | | | | | | | | | | | "Empty field" information shifted to the end of the sentence. It looks more stylistic.
* | | | | | Merge pull request #23529 from Simounet/feat/23397-settings-new-user-modalJohn Molakvoæ2021-04-2115-154/+177
|\ \ \ \ \ \ | | | | | | | | | | | | | | Settings: new user row replaced by a modal
| * | | | | | Settings: new user row replaced by a modalSimounet2021-04-2115-154/+177
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Simounet <contact@simounet.net>
* | | | | | | Merge pull request #26474 from ↵Morris Jobke2021-04-211-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/caugner-patch-mariadb-in-mysql-support-warning Mention MariaDB in MySQL support warning