summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix icon rendering in apps management for IE11Julius Härtl2018-01-032-6/+4
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Invert app icons on IE11 as wellJulius Härtl2018-01-033-20/+40
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Merge pull request #7678 from nextcloud/fix-share-logoMorris Jobke2018-01-032-0/+2
|\ | | | | Use guest css on sharing authentication page
| * Use guest css on sharing authentication pageJulius Härtl2018-01-032-0/+2
| | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | Merge pull request #7668 from ↵Morris Jobke2018-01-031-1/+2
|\ \ | | | | | | | | | | | | nextcloud/fix-popover-menu-not-closing-in-user-settings Fix popover menu not closing in user settings
| * | Close menu on "mouseup" instead of on "click" events in the documentDaniel Calviño Sánchez2018-01-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "click" events are handled by several elements in user settings, and some of them (like the edit icon in the user name) stop the propagation of the event. Due to this the event never reaches the document and thus the menu was not closed in those cases. "click" events are always preceded by "mouseup" events (as "click" events are generated when "mousedown" and "mouseup" events occur in the same element), so now the menu is closed when a "mouseup" is received in the document. The described problem would happen too if an element stopped the propagation of the "mouseup" event; currently no element does that in the user settings, so now the menu is always closed as expected. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | Fix popover menu not closing in user settingsDaniel Calviño Sánchez2018-01-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A popover menu is displayed when its element has the "open" CSS class. That class is added when clicking on the menu toggle, but it was removed only when clicking again on the toggle, so the popover menu in user settings could be closed only by clicking again on the menu toggle. Now the "open" CSS class is removed too when clicking on the body, either directly or through event propagation. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | Merge pull request #7676 from nextcloud/fix-slash-in-filenameRoeland Jago Douma2018-01-032-0/+6
|\ \ \ | | | | | | | | Show warning if slash is entered as filename
| * | | Do not log user errors as log level 4Morris Jobke2018-01-031-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | * hides log entries for the case the parent folder does not exist Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| * | | Show warning if slash is entered as filenameMorris Jobke2018-01-031-0/+2
| | |/ | |/| | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | Merge pull request #7487 from nextcloud/no-password-confirm-with-ssoblizzz2018-01-039-21/+236
|\ \ \ | |/ / |/| | disable password confirmation with SSO
| * | Move passwordconfirmation to its own midlewareRoeland Jago Douma2018-01-027-41/+228
| | | | | | | | | | | | | | | | | | Add tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * | disable password confirmation with SSOBjoern Schiessle2018-01-025-5/+33
| | | | | | | | | | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* | | Merge pull request #7670 from nextcloud/fix-logo-urlRoeland Jago Douma2018-01-031-1/+1
|\ \ \ | | | | | | | | Fix logo URL in SCSS variables
| * | | Fix logo URL in SCSS variablesJulius Härtl2018-01-031-1/+1
|/ / / | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | | Merge pull request #7634 from Abijeet/bug-7539Roeland Jago Douma2018-01-034-1/+33
|\ \ \ | | | | | | | | Fixes the delete button not appearing on certain lower resolutions
| * | | Remove margin for selected files summaryDaniel Calviño Sánchez2018-01-031-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The selected files summary shown in the multiselect header has a margin to align it with the names of the files in the contents of the file list. However, on very narrow screens, and depending on the verbosity of the language, the summary can overlap with the actions when the selection contains files and folders. To try to mitigate this, besides showing only the icons for the actions, the summary margin is removed too in very narrow screens. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | Increase touch area for header iconsDaniel Calviño Sánchez2018-01-031-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On narrow screens only the action icons are shown in the multiselect header of the file list. In that case the padding of those icons is increased to provide a larger touch area (the padding used is the same as in the inline actions of the file list). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | Fixes the delete icon not appearing on certain resolutions.Abijeet2018-01-024-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7539 Also fixes overlap of text on mobile devices by resorting to just icons on lower resolutions. Signed-off-by: Abijeet <abijeetpatro@gmail.com>
* | | | Merge pull request #7665 from nextcloud/bugreport-from-customerRoeland Jago Douma2018-01-031-0/+4
|\ \ \ \ | | | | | | | | | | Note about enterprise users
| * | | | Note about enterprise usersJos Poortvliet2018-01-021-0/+4
| | |_|/ | |/| | | | | | It is sometimes annoying to have users come here and complain about wrong priorities, especially when they are clearly running a (large) corporate instance. They should either contribute themselves or get a support contract...
* | | | Merge pull request #7599 from nextcloud/quieter-debug-logMorris Jobke2018-01-032-3/+6
|\ \ \ \ | | | | | | | | | | don't show recurring log msg when paged result was turned off
| * | | | don't show recurring msg when pages result was turned offArthur Schiwon2017-12-212-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and only as debug level otherwise. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | | | Merge pull request #7658 from ↵Morris Jobke2018-01-032-6/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/update-external-storages-to-current-file-list-layout Update "External storages" to current file list layout
| * | | | | Disable selection in "External storages" file listDaniel Calviño Sánchez2017-12-271-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the checkbox was moved to where the favourite icon was shown before the layout of the file list was modified. The checkbox is no longer a descendant of the ".filename" element, so it is no longer removed by the "External storages" file list. However, even before the checkbox was moved, explicitly removing it was not the best approach, as file list rows could still be selected using "Ctrl/Shift+click". This did not provide much value, as the selection header has no actions; it simply states the number of selected elements. The proper way to disable the selection is by setting "_allowSelection" to false in the file list instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | | Fix selectors for file list elementsDaniel Calviño Sánchez2017-12-271-5/+5
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the checkbox was moved to where the favourite icon was shown before the layout of the file list was modified. The first column is no longer the file name, so neither the thumbnail nor the name link were found. Due to this the thumbnail was not set to the appropriate icon, and the dummy event handler was not removed from the name link, so clicks on the name were basically ignored. Now the selectors are based on the ".filename" CSS class instead of relying on the column position. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | Merge pull request #7526 from ↵Morris Jobke2018-01-036-4/+475
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | nextcloud/make-possible-for-apps-to-disable-the-navigation-bar-slide-gesture Make possible for apps to disable the navigation bar slide gesture
| * | | | Force the drag to end when the navigation bar Snap is disabled by an appDaniel Calviño Sánchez2017-12-144-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a Snap was disabled it stopped listening to the events, but if a drag gesture was being performed it was kept as active. Thus, when the Snap was enabled again move events were handled as if the Snap had never been disabled, causing the gesture handling to continue where it was left. When the Snap for the navigation bar is disabled by an app it could be as a result of a different gesture being recognized by the app (for example, a vertical swipe) once both gestures have started. In that case when the other gesture ends and the Snap is enabled again any pointer movement will cause the navigation bar to slide until an "up" event is triggered again (obviously not the desired behaviour). Due to all this now when the Snap for the navigation bar is disabled by an app the current drag gesture for the navigation bar is ended. Note that this was added as a parameter to "Snap.disable()" instead of done unconditionally to keep back-compatibility with the previous behaviour (probably not really needed as it is unlikely that any app is using the Snap library relying on that behaviour... but just in case). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | Make possible for apps to disallow the navigation bar slide gestureDaniel Calviño Sánchez2017-12-142-1/+353
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On narrow screens a slide gesture can be used to open or close the navigation bar. However that gesture could conflict at times with the gestures used by certain apps (for example, if the right sidebar is open the user may expect to close it by dragging it to the right, but that could open the navigation bar instead depending on how the events are handled). This commit makes possible for apps to disallow and allow again that slide gesture. In any case, note that applications can only disallow the gesture, but they can not enable it. That is, they can prevent the gesture from being used on narrow screens, but they can not make the gesture work on wide screens; they are always limited by the base rules set by the core. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | Add unit tests for the navigation bar slide gestureDaniel Calviño Sánchez2017-12-143-1/+106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The slide gesture is enabled or disabled depending on the width of the browser window. In order to easily control that width the karma-viewport plugin is now used in the unit tests. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | Merge pull request #7663 from ↵Roeland Jago Douma2018-01-021-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/fix-file-list-visible-behind-the-multiselect-header Fix file list visible behind the multiselect header
| * | | | | Fix file list visible behind the multiselect headerDaniel Calviño Sánchez2018-01-021-1/+1
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some parts of the file list contents (file name and actions) had a higher z-index than the file list multiselect header. That header is fixed in place, so when the file list contents were scrolled and those parts with a higher z-index overlapped the multiselect header they were fully visible. Now the z-index for the multiselect header has a higher value (the same used in the controls bar) to ensure that the contents are shown behind the header. Fixes #7540 Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | Merge pull request #7662 from nextcloud/ldap-shutdownRoeland Jago Douma2018-01-021-7/+10
|\ \ \ \ \ | | | | | | | | | | | | throw ServerNotAvailableException when LDAP is caught shutting down
| * | | | | throw ServerNotAvailableException when LDAP is caught shutting downArthur Schiwon2018-01-021-7/+10
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | | | Merge pull request #7598 from ↵Morris Jobke2018-01-021-2/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/fix-closing-menu-on-second-click-in-sharing-page Fix closing menu on second click in sharing page
| * | | | | Fix closing menu on second click in sharing pageDaniel Calviño Sánchez2017-12-211-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a "mouseup" event was triggered on any element except on the share menu or its descendants the share menu was closed. The share menu toggle is not a descendant of the share menu, so clicking on it when the share menu was shown closed it by removing its "open" CSS class. However, once that happened the click event was then handled by the share menu toggle, which toggled the "open" CSS class in the share menu and thus added it again. So, from the user point of view, nothing happened when clicking on the share menu toggle if the share menu was open. Now a "mouseup" event on the share menu toggle no longer closes the share menu, and thus toggling the "open" CSS class when handling the "click" event works as expected. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | | Merge pull request #7660 from nextcloud/fix-7646Morris Jobke2018-01-021-1/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Also log exception for failed appstore request
| * | | | | | Also log exception for failed appstore requestMorris Jobke2018-01-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | | | | | Merge pull request #7631 from nextcloud/fix-scss-webroot-and-url-rewriteMorris Jobke2018-01-025-24/+96
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | Fix scss webroot and url rewrite
| * | | | | | Fixed testsJohn Molakvoæ (skjnldsv)2017-12-304-14/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Correctly remove temp test directory treeJohn Molakvoæ (skjnldsv)2017-12-301-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Added tests for various installations typesJohn Molakvoæ (skjnldsv)2017-12-302-8/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - With root installation - Core css - App inside server root - Secondary apps directory outside server root - With an installation in a sub directory - Core css - App inside server root - Secondary apps directory outside server root Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Fixup! getWebdir returnJohn Molakvoæ (skjnldsv)2017-12-301-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Use OC_Util function for app web pathJohn Molakvoæ (skjnldsv)2017-12-301-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | getWebDir functionJohn Molakvoæ (skjnldsv)2017-12-301-15/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Fixed webroot for scss filesJohn Molakvoæ (skjnldsv)2017-12-303-20/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Fixed scss url rewritingJohn Molakvoæ (skjnldsv)2017-12-301-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* | | | | | | Merge pull request #7583 from nextcloud/comradekingu-patch-1Morris Jobke2018-01-021-6/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Spelling: No ...., upgrades and email.
| * | | | | | | Fix mail attributeRoeland Jago Douma2018-01-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * | | | | | | Spelling: No ...., upgrades and email.Allan Nordhøy2018-01-021-8/+8
| | |/ / / / / | |/| | | | |