| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Fix reshare permission change to not impair other deletion code
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A recent change that prevents reshare permission changes to delete group
share children had the side-effect of also preventing group share
children deletion when it needed to be done.
This fix adds an extra flag to isolate the "reshare permission change"
deletion case and keep the other ones as they were before, not only to
fix the regression but also fix other potential regressions in code that
uses this method.
Also updated the comment because now Helper::delete() is no longer
limited to reshares but also applies to group share children.
|
| | |
|
|\ \
| | |
| | | |
Bypass the view when storing encryption keys
|
| | | |
|
|\ \ \
| | | |
| | | | |
[ignore] delete all server-to-server shares if a user gets deleted
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Make naming of encryption app consistent
|
|/ / / /
| | | |
| | | |
| | | | |
Fixes https://github.com/owncloud/core/issues/13580
|
|\ \ \ \
| | | | |
| | | | | |
Remove duplicated slashes from the requested url
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Do not clear fields until request return success in users admin page on user creation
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
add margin to log table - fixes #13558
|
| | |/ / /
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
show animated gifs on public sharing page
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
use title instead of name
|
| | |/ / / /
| |/| | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
External share dialog must properly read entered password
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Moved external share JS code into a small plugin to make it testable.
Added unit test for the external share dialog logic + ajax calls.
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Set the debugoutput channel to error_log instead of echoing it
|
| | |/ / / / /
| |/| | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Fix webdav mkdir for remote shares
|
| | | | | | | |
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Unit tests are a must have for any changed code
|
|/ / / / / |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
this must be larger then (>), since buggy behaviour occurs when the para...
|
| | |/ / /
| |/| | |
| | | | |
| | | | | |
parameter is a small number
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
avoid $this->cache being null
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Issue/13451 redis json encode
|
| | | | | |
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
kill ancient code
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
add a Windows warning
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Fix WebDAV auth for session authentication only
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
\Sabre\DAV\Auth\Backend\AbstractBasic::authenticate was only calling \OC_Connector_Sabre_Auth::validateUserPass when the response of \Sabre\HTTP\BasicAuth::getUserPass was not null.
However, there is a case where the value can be null and the user could be authenticated anyways: The authentication via ownCloud web-interface and then accessing WebDAV resources. This was not possible anymore with this patch because it never reached the code path in this scenario.
This patchs allows authenticating with a session without isDavAuthenticated value stored (this is for ugly WebDAV clients that send the cookie in any case) and thus the functionality should work again.
To test this go to the admin settings and test if the WebDAV check works fine. Furthermore all the usual stuff (WebDAV / Shibboleth / etc...) needs testing as well.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
also show message for empty display name if change of it isn't allowed
|
| | | | | |
|
| |/ / /
|/| | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
owncloud/reauthenticate-if-session-differs-from-basic-auth
Prioritise Basic Auth header over Cookie
|
| | | | | |
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There are a lot of clients that support multiple WebDAV accounts in the same application. However, they resent all the cookies they received from one of the accounts also to the other one. In the case of ownCloud this means that we will always show the user from the session and not the user that is specified in the basic authentication header.
This patch adds a workaround the following way:
1. If the user authenticates via the Sabre Auth Connector add a hint to the session that this was authorized via Basic Auth (this is to prevent logout CSRF)
2. If the request contains this hint and the username specified in the basic auth header differs from the one in the session relogin the user using basic auth
Fixes https://github.com/owncloud/core/issues/11400 and https://github.com/owncloud/core/issues/13245 and probably some other issues as well.
This requires proper testing also considering LDAP / Shibboleth and whatever instances.
|