summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #29431 from nextcloud/release/23.0.0beta2v23.0.0beta2John Molakvoæ2021-10-281-2/+2
|\
| * 23.0.0 beta 2John Molakvoæ2021-10-251-2/+2
| | | | | | | | Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
* | Merge pull request #29115 from ↵Carl Schwan2021-10-282-1/+9
|\ \ | | | | | | | | | | | | nextcloud/work/carl/correct-permissions-when-copying Fix permissions when copying from ObjectStorage
| * | Fix permissions when copying from ObjectStorageCarl Schwan2021-10-282-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure that when a user copy a file from a directory they don't have all permissions to a directory where they have more permissions, the permissions are correctly set to the one from the parent taget folder. This was caused by the ObjectStoreStorage::copyFromStorage using the jailed storage and cache entry instead of the unjailed one like other storages (the local one). Steps to reproduce + Use object storage + Create a groupfolder with one group having full permission and another one who can just read files. + With an user who is in the second group, copy a file from the groupfolder to the home folder of this user. + The file in the home folder of the user will be read only and can't be deleted even though it is in their home folder and they are the owner. In oc_filecache, the permissions stored for this file are 1 (READ) Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* | | Merge pull request #29444 from ↵Joas Schilling2021-10-285-23/+100
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/bugfix/noid/public-api-for-trusted-domain-helpers Add an OCP for trusted domain helper
| * | | Add an OCP for trusted domain helperJoas Schilling2021-10-285-23/+100
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | [tx-robot] updated from transifexNextcloud bot2021-10-282-0/+72
| | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | Merge pull request #29454 from ↵blizzz2021-10-271-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | nextcloud/bugfix/noid/detect-mimetype-by-content-only-with-content Detect mimetype by content only with content
| * | | | Detect mimetype by content only with contentJoas Schilling2021-10-271-1/+1
| |/ / / | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #29453 from nextcloud/bugfix/noid/improve-wordingJohn Molakvoæ2021-10-272-4/+2
|\ \ \ \
| * | | | Improve wordingJoas Schilling2021-10-272-4/+2
| |/ / / | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #29327 from ↵John Molakvoæ2021-10-271-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | nextcloud/bugfix/noid/do-not-make-actionbuttons-spans-too-transparent
| * | | | Do notr make action icons too transparentmarco2021-10-191-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: marco <marcoambrosini@pm.me>
* | | | | [tx-robot] updated from transifexNextcloud bot2021-10-2710-4/+18
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | | Merge pull request #29436 from nextcloud/fix/profile-link-action-registrationJohn Molakvoæ2021-10-261-11/+20
|\ \ \ \ \
| * | | | | Prevent unnecesary profile action registrationsChristopher Ng2021-10-261-11/+20
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Christopher Ng <chrng8@gmail.com>
* | | | | Merge pull request #29435 from nextcloud/explicitly-name-profile-link-actionJohn Molakvoæ2021-10-263-11/+11
|\ \ \ \ \
| * | | | | Use more explicit naming for profile link actionChristopher Ng2021-10-253-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Christopher Ng <chrng8@gmail.com>
* | | | | | Merge pull request #26841 from nextcloud/bugfix/files-search-filterVincent Petry2021-10-2619-424/+478
|\ \ \ \ \ \ | | | | | | | | | | | | | | Implement local filtering in file list
| * | | | | | Move to combined files entrypointJulius Härtl2021-10-2515-422/+432
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
| * | | | | | Fix "No entries in this …" templateJoas Schilling2021-10-254-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | | | Implement local filtering in file listJulius Härtl2021-10-252-0/+44
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | | | | | [tx-robot] updated from transifexNextcloud bot2021-10-2642-2/+308
| |/ / / / |/| | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | | Merge pull request #29318 from ↵Christoph Wurst2021-10-258-23/+61
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | nextcloud/fix/dav-availability-settings-timezone-id Read and write time zone ID when updating CalDAV availability
| * | | | Get VTIMEZONE data from a time zone database libChristoph Wurst2021-10-257-22/+44
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
| * | | | Read and write time zone ID when updating CalDAV availabilityChristoph Wurst2021-10-254-7/+23
| | |/ / | |/| | | | | | | | | | | | | | | | | | Tiny bug/limitation of #27466 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | Merge pull request #29021 from nextcloud/work/smb/additional-loggingJulius Härtl2021-10-251-0/+1
|\ \ \ \
| * | | | Add additional logging on SMB failure to read folder contentCarl Schwan2021-10-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we discard the error comming from the SMB library and create a new exception for nextcloud. This patch makes sure that the access/permission exception from the SMB library are logged correctly. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* | | | | Merge pull request #27949 from CarlSchwan/work/carl/password-reset-autocompleteLouis2021-10-255-6/+12
|\ \ \ \ \ | |_|/ / / |/| | | | Add autocompletion for password reset
| * | | | Add autocompletion for password resetCarl Schwan2021-10-225-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using autocomplete="current-password" and autocomplete="new-password" will help browser with integrated password managers to generate safe password for the users. See https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/password#allowing_autocomplete. Also unify autocapitalize="none" autocorrect="off" behavior in a few other places for password input fields. Close #27885 Signed-off-by: Carl Schwan <carl@carlschwan.eu> Co-Authored-By: Julien Veyssier <eneiluj@posteo.net> Co-Authored-By: Pytal <24800714+Pytal@users.noreply.github.com>
* | | | | Merge pull request #29425 from nextcloud/revert-28138-zorn-v-patch-2John Molakvoæ2021-10-251-1/+0
|\ \ \ \ \
| * | | | | Revert "Fix "never catch" catches in OC_App"Joas Schilling2021-10-251-1/+0
| | | | | |
* | | | | | Merge pull request #26531 from J0WI/refactor-preview-execJohn Molakvoæ2021-10-257-80/+94
|\ \ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Use findBinaryPath for previewsJ0WI2021-10-237-80/+94
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: J0WI <J0WI@users.noreply.github.com>
* | | | | | [tx-robot] updated from transifexNextcloud bot2021-10-2536-82/+280
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | | | [tx-robot] updated from transifexNextcloud bot2021-10-2414-432/+38
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | | Merge pull request #28389 from alanmeeson/bugfix/22077/default-encryption-moduleJohn Molakvoæ2021-10-231-2/+30
|\ \ \ \ \
| * | | | | Add type hint to fread_block $blockSize param & apply cs:fix.alanmeeson2021-10-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: alanmeeson <alan@carefullycalculated.co.uk>
| * | | | | Fix truncation of files upon read when using object store and encryption.Alan Meeson2021-10-231-2/+30
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using and object store as primary storage and using the default encryption module at the same time, any encrypted file would be truncated when read, and a text error message added to the end. This was caused by a combination of the reliance of the read functions on on knowing the unencrypted file size, and a bug in the function which calculated the unencrypted file size for a given file. In order to calculate the unencrypted file size, the function would first skip the header block, then use fseek to skip to the last encrypted block in the file. Because there was a corresponence between the encrypted and unencrypted blocks, this would also be the last encrypted block. It would then read the final block and decrypt it to get the unencrypted length of the last block. With that, the number of blocks, and the unencrypted block size, it could calculate the unencrypted file size. The trouble was that when using an object store, an fread call doesn't always get you the number of bytes you asked for, even if they are available. To resolve this I adapted the stream_read_block function from lib/private/Files/Streams/Encryption.php to work here. This function wraps the fread call in a loop and repeats until it has the entire set of bytes that were requested, or there are no more to get. This fixes the imediate bug, and should (with luck) allow people to get their encrypted files out of Nextcloud now. (The problem was purely on the decryption side). In the future it would be nice to do some refactoring here. I have tested this with image files ranging from 1kb to 10mb using Nextcloud version 22.1.0 (the nextcloud:22.1-apache docker image), with sqlite and a Linode object store as the primary storage. Signed-off-by: Alan Meeson <alan@carefullycalculated.co.uk>
* | | | | Merge pull request #29400 from nextcloud/fix/noid/undef-index-errorJulius Härtl2021-10-231-1/+1
|\ \ \ \ \ | | | | | | | | | | | | fixes an undefined index when getAccessList returns an empty array
| * | | | | fixes an undefined index when getAccessList returns an empty arrayArthur Schiwon2021-10-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - [] is a valid return value that should be honored as having no access Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | | | | Merge pull request #27440 from nextcloud/is-file-handleJohn Molakvoæ2021-10-232-6/+6
|\ \ \ \ \ \
| * | | | | | Update Testsacsfer2021-10-221-1/+1
| | | | | | |
| * | | | | | Tests updateacsfer2021-08-151-1/+1
| | | | | | |
| * | | | | | Handle files with is_file instead of file_existsacsfer2021-08-151-4/+4
| | | | | | | | | | | | | | | | | | | | | Should fix things like `fread(): read of 8192 bytes failed with errno=21 Is a directory`
* | | | | | | Merge pull request #28138 from nextcloud/zorn-v-patch-2John Molakvoæ2021-10-231-0/+1
|\ \ \ \ \ \ \
| * | | | | | | Fix "never catch" catches in OC_Appzorn-v2021-10-221-0/+1
| | |_|/ / / / | |/| | | | | | | | | | | | Need to check another legacy. Need to explicitly add to use or do not forget add slash `\`
* | | | | | | Merge pull request #29363 from nextcloud/fair-use-pushJohn Molakvoæ2021-10-2315-52/+285
|\ \ \ \ \ \ \
| * | | | | | | show warning on personal settings pageVitor Mattos2021-10-232-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Vitor Mattos <vitor@php.rio>
| * | | | | | | Show warning on admin settings pageVitor Mattos2021-10-233-1/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Vitor Mattos <vitor@php.rio>
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-27 09:49:59 +0000