aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Merge pull request #7526 from ↵Morris Jobke2018-01-036-4/+475
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | nextcloud/make-possible-for-apps-to-disable-the-navigation-bar-slide-gesture Make possible for apps to disable the navigation bar slide gesture
| * | | | | Force the drag to end when the navigation bar Snap is disabled by an appDaniel Calviño Sánchez2017-12-144-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a Snap was disabled it stopped listening to the events, but if a drag gesture was being performed it was kept as active. Thus, when the Snap was enabled again move events were handled as if the Snap had never been disabled, causing the gesture handling to continue where it was left. When the Snap for the navigation bar is disabled by an app it could be as a result of a different gesture being recognized by the app (for example, a vertical swipe) once both gestures have started. In that case when the other gesture ends and the Snap is enabled again any pointer movement will cause the navigation bar to slide until an "up" event is triggered again (obviously not the desired behaviour). Due to all this now when the Snap for the navigation bar is disabled by an app the current drag gesture for the navigation bar is ended. Note that this was added as a parameter to "Snap.disable()" instead of done unconditionally to keep back-compatibility with the previous behaviour (probably not really needed as it is unlikely that any app is using the Snap library relying on that behaviour... but just in case). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | | Make possible for apps to disallow the navigation bar slide gestureDaniel Calviño Sánchez2017-12-142-1/+353
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On narrow screens a slide gesture can be used to open or close the navigation bar. However that gesture could conflict at times with the gestures used by certain apps (for example, if the right sidebar is open the user may expect to close it by dragging it to the right, but that could open the navigation bar instead depending on how the events are handled). This commit makes possible for apps to disallow and allow again that slide gesture. In any case, note that applications can only disallow the gesture, but they can not enable it. That is, they can prevent the gesture from being used on narrow screens, but they can not make the gesture work on wide screens; they are always limited by the base rules set by the core. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | | Add unit tests for the navigation bar slide gestureDaniel Calviño Sánchez2017-12-143-1/+106
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The slide gesture is enabled or disabled depending on the width of the browser window. In order to easily control that width the karma-viewport plugin is now used in the unit tests. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | Merge pull request #7663 from ↵Roeland Jago Douma2018-01-021-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/fix-file-list-visible-behind-the-multiselect-header Fix file list visible behind the multiselect header
| * | | | | Fix file list visible behind the multiselect headerDaniel Calviño Sánchez2018-01-021-1/+1
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some parts of the file list contents (file name and actions) had a higher z-index than the file list multiselect header. That header is fixed in place, so when the file list contents were scrolled and those parts with a higher z-index overlapped the multiselect header they were fully visible. Now the z-index for the multiselect header has a higher value (the same used in the controls bar) to ensure that the contents are shown behind the header. Fixes #7540 Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | Merge pull request #7662 from nextcloud/ldap-shutdownRoeland Jago Douma2018-01-021-7/+10
|\ \ \ \ \ | | | | | | | | | | | | throw ServerNotAvailableException when LDAP is caught shutting down
| * | | | | throw ServerNotAvailableException when LDAP is caught shutting downArthur Schiwon2018-01-021-7/+10
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | | | Merge pull request #7598 from ↵Morris Jobke2018-01-021-2/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/fix-closing-menu-on-second-click-in-sharing-page Fix closing menu on second click in sharing page
| * | | | | Fix closing menu on second click in sharing pageDaniel Calviño Sánchez2017-12-211-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a "mouseup" event was triggered on any element except on the share menu or its descendants the share menu was closed. The share menu toggle is not a descendant of the share menu, so clicking on it when the share menu was shown closed it by removing its "open" CSS class. However, once that happened the click event was then handled by the share menu toggle, which toggled the "open" CSS class in the share menu and thus added it again. So, from the user point of view, nothing happened when clicking on the share menu toggle if the share menu was open. Now a "mouseup" event on the share menu toggle no longer closes the share menu, and thus toggling the "open" CSS class when handling the "click" event works as expected. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | | Merge pull request #7660 from nextcloud/fix-7646Morris Jobke2018-01-021-1/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Also log exception for failed appstore request
| * | | | | | Also log exception for failed appstore requestMorris Jobke2018-01-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | | | | | Merge pull request #7631 from nextcloud/fix-scss-webroot-and-url-rewriteMorris Jobke2018-01-025-24/+96
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | Fix scss webroot and url rewrite
| * | | | | | Fixed testsJohn Molakvoæ (skjnldsv)2017-12-304-14/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Correctly remove temp test directory treeJohn Molakvoæ (skjnldsv)2017-12-301-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Added tests for various installations typesJohn Molakvoæ (skjnldsv)2017-12-302-8/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - With root installation - Core css - App inside server root - Secondary apps directory outside server root - With an installation in a sub directory - Core css - App inside server root - Secondary apps directory outside server root Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Fixup! getWebdir returnJohn Molakvoæ (skjnldsv)2017-12-301-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Use OC_Util function for app web pathJohn Molakvoæ (skjnldsv)2017-12-301-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | getWebDir functionJohn Molakvoæ (skjnldsv)2017-12-301-15/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Fixed webroot for scss filesJohn Molakvoæ (skjnldsv)2017-12-303-20/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | | Fixed scss url rewritingJohn Molakvoæ (skjnldsv)2017-12-301-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* | | | | | | Merge pull request #7583 from nextcloud/comradekingu-patch-1Morris Jobke2018-01-021-6/+6
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Spelling: No ...., upgrades and email.
| * | | | | | | Fix mail attributeRoeland Jago Douma2018-01-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * | | | | | | Spelling: No ...., upgrades and email.Allan Nordhøy2018-01-021-8/+8
| | |/ / / / / | |/| | | | |
* | | | | | | Merge pull request #7590 from nextcloud/flow-hide-stay-logged-inMorris Jobke2018-01-023-0/+36
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Hide stay logged in checkbox when flow authentication is used
| * | | | | | | Hide stay logged in checkbox when flow authentication is usedJulius Härtl2017-12-283-0/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | | | | | | | Merge pull request #7659 from nextcloud/fix_7657Roeland Jago Douma2018-01-022-3/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Get correct translations for SecurityProvider
| * | | | | | | | Get correct translations for SecurityProviderRoeland Jago Douma2018-01-022-3/+3
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7657 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | | | | Merge pull request #7644 from nextcloud/fix_7184Roeland Jago Douma2018-01-024-48/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Do not run SyncJob in cron
| * | | | | | | | Do no run SyncJob in cronRoeland Jago Douma2018-01-024-48/+1
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7184 The SyncJob can be very resource intensive. Since it requests all users on the system to create the system addressbook. In order to do this it creates a vcard for every user and updates the addressbook. There is no need for this job since the proper signals are emitted and handled in the carddav backend to update the addressbook live. Worst comes to worst there is always the occ command to bring the address book in sync again. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | | | | Merge pull request #7648 from nextcloud/fix_7414Roeland Jago Douma2018-01-022-3/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Show max warning comment lenth again
| * | | | | | | | Show max warning comment lenth againRoeland Jago Douma2018-01-022-3/+3
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7414 Since we no longer use an input field we have to use text instead of val. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | | | | Merge pull request #7624 from ↵Morris Jobke2018-01-022-0/+27
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | nextcloud/fix-fileActions-currentFile-not-set-before-using-it Fix "fileActions.currentFile" not set before using it
| * | | | | | | Fix "fileActions.currentFile" not set before using itDaniel Calviño Sánchez2017-12-262-0/+27
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When an empty area of a file row was clicked and the "Details" action was executed "fileActions.currentFile" was not guaranteed to be set to the appropriate object (it depended on the previous actions of the user), so when it was used by "getCurrentMimeType()" and other FileActions functions they may not work as expected. Now it is explicitly set to the appropriate value before its use. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | | | Merge pull request #7646 from nextcloud/no_exction_logging_appstore_timeoutRoeland Jago Douma2018-01-021-1/+1
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Don't spam the log when we could not properly connect to the appstore
| * | | | | | Don't spam the log when we could not properly connect to the appstoreRoeland Jago Douma2017-12-291-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we can't connect to the appstore for some reason we don't have to log the exception just an info entry is enough. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | | Merge pull request #7626 from nextcloud/fixed-files-multiselect-top-marginRoeland Jago Douma2017-12-281-1/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Fixed top position of multiselected files table
| * | | | | Fixed top position of multiselected files tableJohn Molakvoæ (skjnldsv)2017-12-261-1/+1
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* | | | | Merge pull request #7592 from nextcloud/update-quota-on-files-uploadRoeland Jago Douma2017-12-285-3/+31
|\ \ \ \ \ | | | | | | | | | | | | Update quota on files upload
| * | | | | Fixed testsJohn Molakvoæ (skjnldsv)2017-12-262-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | Update quota on file upload and deletionJohn Molakvoæ (skjnldsv)2017-12-214-1/+32
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| * | | | | Fixed pinned state of quota if no apps registered an app nav itemJohn Molakvoæ (skjnldsv)2017-12-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* | | | | | Merge pull request #7608 from nextcloud/pimp_timestampformatterRoeland Jago Douma2017-12-281-1/+5
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Fixes for TimestampFormatter
| * | | | | Fixup codeRoeland Jago Douma2017-12-221-1/+5
| | |_|_|/ | |/| | | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | Merge pull request #7591 from ↵Morris Jobke2017-12-224-14/+123
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/trigger-events-before-and-after-a-file-action-is-executed Trigger events before and after a file action is executed
| * | | | | Remove internal unused propertyDaniel Calviño Sánchez2017-12-211-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | | Trigger the "Details" action when clicking on an empty file row spaceDaniel Calviño Sánchez2017-12-211-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clicking on an empty space in a file row causes the details view to be shown. As it is a user initiated action on the file list now it is done by triggering the Details action instead of directly calling "_updateDetailsView"; the result is the same in both cases, but using the action is more consistent (clicking on the file name triggers the default action, and clicking on the inline actions triggers those actions) and also makes possible to use the "beforeTriggerAction" and "afterTriggerAction" listeners. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | | Trigger events before and after a file action is executedDaniel Calviño Sánchez2017-12-193-4/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the same way that other elements can know when a FileAction is registered or a default action is set this commit makes possible to be notified before and after a FileAction is executed. This is achieved by wrapping the registered action handler in a custom function that notifies the listeners before and after executing the handler itself. Due to this approach only FileActions registered through "registerAction" trigger the events, although that is not a problem as this is how the actions should be added to the FileActions anyway. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | | Merge pull request #7597 from ↵Roeland Jago Douma2017-12-221-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/fix-anchor-change-when-clicking-on-sharing-page-menu Fix anchor change when clicking on sharing page menu
| * | | | | | Fix anchor change when clicking on sharing page menuDaniel Calviño Sánchez2017-12-211-3/+3
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The share menu toggle and some share menu items included an 'href="#"' attribute, so they were handled as internal links by the browser, which changed the current anchor when they were clicked. However, there was no real need to change the anchor in those cases, and it could interfere with other apps (for example, the PDF viewer sets the current anchor to "#pdfviewer" when it is shown and it hides itself when that anchor is modified). According to the HTML 5 spec the "href" attribute is not mandatory for "a" elements, so they were removed. Other options would have been to change the elements from "a" to "div" or something like that, but that would have required changes to the CSS rules too, or to prevent the default event handling for those elements through JavaScript, which would have been a workaround instead of the proper solution. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>