summaryrefslogtreecommitdiffstats
path: root/apps/dav/lib/DAV
Commit message (Collapse)AuthorAgeFilesLines
* preload shares for calendars when listing calendarsRobin Appelman2023-08-142-0/+64
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* preload custom properties when propfinding foldersRobin Appelman2023-07-101-2/+42
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix(CalDAV/CardDAV): put every method from Cal/CardDAV backends that does ↵Thomas Citharel2023-04-171-10/+15
| | | | | | | | | | | | multiple DB calls in transactions In a lot of methods we're doing read-after-writes (for instance calling updateProperties after touching calendar objects). There's also a lot of deleting methods that do stuff sequentially which could cause trouble. This should avoid this kind of issues. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
* Fix DAV typesjld31032023-04-051-1/+1
| | | | Signed-off-by: jld3103 <jld3103yt@gmail.com>
* assign group share valueMaximilian Martin2023-02-201-1/+1
| | | | Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
* Extend ViewOnly DAV plugin to versions endpointVincent Petry2023-01-131-3/+7
| | | | Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* Do not output a warning when a file is not foundCôme Chilliet2022-09-121-6/+1
| | | | | | | This would spam log with warnings from Desktop client doing HEAD on non-existing path to test them. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Fix typos in apps/ subdirectoryluz paz2022-09-051-1/+1
| | | | | | | Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/` Signed-off-by: luz paz <luzpaz@github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Fix copy in view-only modeVincent Petry2022-08-261-0/+1
| | | | Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* Fix dynamic property creations in test filesCôme Chilliet2022-08-011-1/+1
| | | | | | This fixes warnings in PHP 8.2 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Multiple fixesCarl Schwan2022-07-311-22/+16
| | | | | | | | | | | - Fix tests - Use non deprecated event stuff - Add a bit of type hinting to the new stuff - More safe handling of instanceOfStorage (share might not be the first wrapper) - Fix resharing Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Fix view-only code after code review commentsVincent Petry2022-07-281-4/+4
| | | | Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* Fix share attribute related tests + code styleVincent Petry2022-07-281-0/+1
| | | | Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* Add share attributes + prevent download permissionVincent Petry2022-07-281-0/+113
| | | | | | Makes it possible to store download permission Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* Fix typos in apps/dav subdirectoryluz paz2022-07-262-2/+2
| | | | | | Found via `codespell -q 3 -S l10n -L jus ./apps/dav` Signed-off-by: luz paz <luzpaz@github.com>
* catch any exception for transaction controlArthur Schiwon2022-07-061-1/+1
| | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* DAV custom props: catch Exception and rollback transaction in caseArthur Schiwon2022-07-011-54/+76
| | | | | | | | - before exceptions were not caught, a started transaction might not have been finished - also resolve depractions and use IQueryBuilder Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Add typing to Sharing BackendCarl Schwan2022-06-222-64/+36
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Use {$var} instead of ${var} for PHP 8.2 compatibilityCôme Chilliet2022-06-141-1/+1
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Allow DAV Object propertiesThomas Citharel2022-05-161-12/+58
| | | | | | | | | | | | | | | | | | | The current implementation only saves them as string. It seems they can be more complex than that, and that objects were saved directly. You may find such objects saved in some production databases by executing: ```sql SELECT * from oc_properties where propertyvalue = 'Object'; ``` This commit adds a repair job to clean all of these "broken" properties values, adds a new database column to save the type of the property, and handles converting from and to correct values. Implementation is very similar to SabreDAV's own PDO backend: https://github.com/nextcloud/3rdparty/blob/4921806dfb1c5c309eac60195ed34e2749baf3c1/sabre/dav/lib/DAV/PropertyStorage/Backend/PDO.php Signed-off-by: Thomas Citharel <tcit@tcit.fr>
* Add known dav properties to ignore listJulius Härtl2022-04-211-0/+22
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Convert properties value to string before passing them to databaseCôme Chilliet2022-01-201-0/+5
| | | | | | | This avoids an error when passing a complex property to PROPPATCH under PHP >= 7.4. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Change return type to correct typeAnna Larch2021-10-141-1/+1
| | | | Signed-off-by: Anna Larch <anna@nextcloud.com>
* use specific email getter where necessaryArthur Schiwon2021-09-091-1/+1
| | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Allow certain custom DAV props to be readable by everyoneChristoph Wurst2021-06-081-14/+57
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Update php licensesJohn Molakvoæ (skjnldsv)2021-06-049-14/+4
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* Make dav respect disallowing sharing with groupsThomas Citharel2021-05-261-5/+10
| | | | | | Closes #25390 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
* Bump nextcloud/coding-standard from 0.3.0 to 0.5.0dependabot-preview[bot]2021-02-181-1/+1
| | | | | | | | | | Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* take into account that UNIQUE index might not work as expectedArthur Schiwon2021-01-291-0/+1
| | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Update license headersChristoph Wurst2020-12-301-0/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Merge pull request #24515 from nextcloud/fix/noid/dav-share-groups-special-charsChristoph Wurst2020-12-182-1/+2
|\ | | | | fixes sharing to group ids with characters that are being url encoded
| * fix finding of groups with decodable chars in their id via DAVArthur Schiwon2020-12-161-1/+1
| | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * fixes sharing to group ids with characters that are being url encodedArthur Schiwon2020-12-161-0/+1
| | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | Update all license headers for Nextcloud 21Christoph Wurst2020-12-161-0/+1
|/ | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* use a consistent default value for sharing.maxAutocompleteResultsArthur Schiwon2020-12-151-1/+5
| | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* dav search to honour sharing.maxAutocompleteResults settingArthur Schiwon2020-12-151-4/+12
| | | | | | | - it is being used on frontend by users - user and big instances benefit from quicker results and less load Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Format code to a single space around binary operatorsChristoph Wurst2020-10-052-5/+5
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Update the license headers for Nextcloud 20Christoph Wurst2020-08-241-0/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Add ability to limit sharing to ownerGeorg Ehrke2020-08-181-1/+13
| | | | Signed-off-by: Georg Ehrke <developer@georgehrke.com>
* Update license headers for 19Christoph Wurst2020-04-298-1/+8
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Add visibility to all constantsChristoph Wurst2020-04-103-6/+6
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Add visibility to all methods and position of static keywordChristoph Wurst2020-04-107-24/+24
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Format control structures, classes, methods and functionChristoph Wurst2020-04-109-32/+6
| | | | | | | | | | | | | | | To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Use elseif instead of else ifChristoph Wurst2020-04-101-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Remove space between switch case and colonChristoph Wurst2020-04-092-3/+3
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Unify function spacing to PSR2 recommendationChristoph Wurst2020-04-092-3/+3
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Use exactly one empty line after the namespace declarationChristoph Wurst2020-04-091-0/+1
| | | | | | For PSR2 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Fix (array) indent style to always use one tabChristoph Wurst2020-04-091-39/+39
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Update the license headers for Nextcloud 19Christoph Wurst2020-03-312-5/+3
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Remove unused importsChristoph Wurst2020-03-251-3/+0
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>