aboutsummaryrefslogtreecommitdiffstats
path: root/apps/files_external/lib/Lib
Commit message (Collapse)AuthorAgeFilesLines
* fix: custom port handling in UI for SFTPbackport/47527/stable30Josh Richards2024-09-121-0/+2
| | | | Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
* fix: Fix unmodified placeholder replacing the actual value when updatingDaniel Calviño Sánchez2024-09-042-0/+12
| | | | | | | | | | | | | | When updating global storages and user storages a property is not updated by "StoragesService::updateStorage()" if the value matches the unmodified placeholder. However, userglobal storages are not updated through the "StoragesService"; as only the authentication mechanism is updated it is directly done with "saveBackendOptions()" in "IUserProvided" or "UserGlobalAuth". Due to this the unmodified placeholder value needs to be explicitly checked in those cases and replaced by the actual value (note that in this case it is not possible to just skip updating a specific property). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* feat: add a specialized writeStream implementation for s3 external storageRobin Appelman2024-07-241-0/+21
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix: Do not log an error when connecting to SFTP without a logged in userDaniel Calviño Sánchez2024-06-181-5/+7
| | | | | | | | | | | | | | | | | | | | | When connecting to a SFTP server from a SFTP storage the host key is checked against the known host keys stored in a file in the data directory of the logged in Nextcloud user. The path to the file is (indirectly) got using "OC_App::getStorage", which logs an error if called when there is no logged in user; this can happen, for example, if the storage is used from a background job or a command. Not being able to read or write the file just causes the host key check to be skipped, but it has no other consequence. Moreover, even with logged in users it is likely that the file can not be read either and the check is also skipped, as the file needs to have been manually created by an admin. Due to all that now the path to the file is directly created using a View rather than relying on "OC_App::getStorage" to prevent the unneeded error from being logged. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* chore: Add SPDX headerAndy Scherzinger2024-06-0662-1301/+173
| | | | Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
* fix(files_external): Be extra safe with null handling to please psalmCôme Chilliet2024-04-301-0/+3
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix: Fix small psalm errors in FTP and LDAP connectionsCôme Chilliet2024-04-091-4/+1
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix: Remove obsolete resource typingCôme Chilliet2024-04-091-2/+2
| | | | | | In PHP>=8.1, LDAP and FTP resources are always typed objects Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* chore: Improve phpdoc typing to silence psalm errorsCôme Chilliet2024-04-0211-0/+31
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix: Apply new coding standard to all filesCôme Chilliet2024-04-0215-15/+15
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix: Allow to disable multipart copy on external s3 storageJulius Härtl2024-02-241-0/+3
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* mark MOUNT_TYPE_PERSONAl as deprecatedMaxence Lange2024-02-241-0/+2
| | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* full uppercase constMaxence Lange2024-02-241-4/+4
| | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* fix: replace `Account name` by `Login`John Molakvoæ2024-02-139-10/+10
| | | | Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
* feat: rename users to account or personVincent Petry2024-02-1311-13/+13
| | | | | | Replace translated text in most locations Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* fix(files_external): list root when using SMB case-insensitive optionBenjamin Gaussorgues2024-02-051-1/+2
| | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* Correct a typoValdnet2023-11-281-1/+1
| | | Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
* chore: apply changes from Nextcloud coding standards 1.1.1Joas Schilling2023-11-236-24/+20
| | | | | Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* refactor: Rename OpenAPI type aliases to their namespacesjld31032023-11-021-2/+2
| | | | Signed-off-by: jld3103 <jld3103yt@gmail.com>
* Merge pull request #41053 from nextcloud/bug/smb/in-place-case-renameBenjamin Gaussorgues2023-10-312-0/+24
|\ | | | | fix(files_external): on case insensitive system, block case change
| * fix(files_external): on case insensitive system, block case changeBenjamin Gaussorgues2023-10-232-0/+24
| | | | | | | | | | | | | | | | When a file/directory is renamed to the same name with only case change, the rename fail. We block this kind of rename. The user will have to rename to another name first. Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | Return correct status if touch failedLouis Chemineau2023-10-231-11/+13
|/ | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* use multipart copy for s3Robin Appelman2023-09-201-4/+1
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* sftp psalm fixesRobin Appelman2023-09-182-11/+15
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* psalm suppressRobin Appelman2023-09-041-0/+4
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* implement fseek for sftp read streamRobin Appelman2023-09-042-3/+30
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* more optimized getPermissions/getMetaDataRobin Appelman2023-09-041-0/+44
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* sftp optimize file_put_contents, writeStream and copyRobin Appelman2023-09-041-1/+55
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix error during sftp stream closeRobin Appelman2023-09-041-0/+7
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* clear sftp stat cache when opening a write streamRobin Appelman2023-09-041-3/+5
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Allow ext storage Local to go unavailableVincent Petry2023-08-291-0/+6
| | | | | | | | | | | | | Whenever an external storage of type Local points at a non-existing directory, process this as a StorageNotAvailable instead of returning 404. This makes desktop clients ignore the folder instead of deleting it when it becomes unavailable. The code change was limited to external storages to avoid issues during setup and with the default home storage. Signed-off-by: Vincent Petry <pvince81@yahoo.fr>
* files_external: Fix OpenAPIjld31032023-08-071-3/+7
| | | | Signed-off-by: jld3103 <jld3103yt@gmail.com>
* feat(files_external): migrate to vueJohn Molakvoæ2023-08-012-1/+26
| | | | Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
* Migrate files external to PSR LoggerInterfaceBenjamin Gaussorgues2023-08-012-19/+27
| | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* Merge pull request #39367 from nextcloud/s3-fopen-exceptionRobin Appelman2023-07-201-1/+1
|\ | | | | handle more exceptions in AmazonS3::fopen
| * handle more exceptions in AmazonS3::fopenRobin Appelman2023-07-131-1/+1
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | files_external: Add OpenAPI specjld31032023-07-111-1/+1
|/ | | | Signed-off-by: jld3103 <jld3103yt@gmail.com>
* Merge pull request #38591 from nextcloud/fix/caching/avoid-haskey-getSimon L2023-06-121-2/+3
|\ | | | | fix(caching): Avoid checking existence before fetching
| * fix(caching): Avoid checking existence before fetchingChristoph Wurst2023-06-121-2/+3
| | | | | | | | | | | | | | | | The cache might expire between checking for key existence and fetching the value. In this rare case the code continues with a null value when it doesn't expect one. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Update apps/files_external/lib/Lib/Storage/SMB.phpFaraz Samapoor2023-06-051-3/+1
| | | | | | | | Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
* | Refactors "strpos" calls in /apps/files_external to improve code readability.Faraz Samapoor2023-06-024-8/+10
|/ | | | Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
* Merge pull request #38115 from DerGenaue/patch-1Simon L2023-05-161-6/+6
|\ | | | | Rename `numericStorageId` to `numericExternalStorageId` in PersonalMount.php
| * Rename `numericStorageId` to `numericExternalStorageId` in PersonalMount.phpDaniel2023-05-071-6/+6
| | | | | | | | | | | | | | | | so that it doesn't override `numericStorageId` in the `MountPoint` baseclass fixes https://github.com/nextcloud/server/issues/37473 fixes https://github.com/nextcloud/server/issues/37414 Signed-off-by: Daniel <7558512+DerGenaue@users.noreply.github.com>
* | check the username when doing external storage session authRobin Appelman2023-05-111-0/+5
|/ | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Update AmazonS3.phpJames Guo2023-04-061-1/+1
| | | Signed-off-by: James Guo <i@ze3kr.com>
* improve handling of files we can't access in the scannerRobin Appelman2023-04-051-8/+16
| | | | | | | | instead of erroring, remove the items from the cache. this situation can be triggered if a user has access to a file but looses it afterwards Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix ftp external storage with filezilla serverRobin Appelman2023-03-302-7/+15
| | | | | | | - filezilla doesn't like "" as parameter for `mdtm` (all others seem fine) - filezilla sends fractional modified date Signed-off-by: Robin Appelman <robin@icewind.nl>
* Respect OCP interface in private classesCôme Chilliet2023-02-071-1/+1
| | | | | | | Because the parameter type was moved to phpdoc it needs to be removed from implementations Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Strong type filesize related methods to ease 32bits problem findingsCôme Chilliet2023-02-071-1/+1
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Merge pull request #36089 from nextcloud/enh/noid/ext-storage-default-valuesVincent Petry2023-01-165-24/+54
|\ | | | | Ext storage configs default value support + enable SSL by default