aboutsummaryrefslogtreecommitdiffstats
path: root/apps/files_external/lib
Commit message (Collapse)AuthorAgeFilesLines
* fix(OpenAPI): Adjust array syntax to avoid ambiguitiesfix/openapi/array-syntaxprovokateurin2024-11-053-9/+9
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix: add PasswordConfirmationRequired to saveGlobalCredentialsfix/add-password-confirmation-to-save-global-credsyemkareems2024-10-301-0/+2
| | | | | Co-authored-by: yemkareems <yemkareems@gmail.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Merge pull request #48788 from ↵John Molakvoæ2024-10-293-0/+7
|\ | | | | | | nextcloud/fix/788/add-password-required-to-external-storages
| * fix: cs fix namespacefix/788/add-password-required-to-external-storagesyemkareems2024-10-181-1/+1
| | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
| * fix: add PasswordConfirmationRequired to the eternal storages mentioned in ↵yemkareems2024-10-183-0/+7
| | | | | | | | | | | | review Signed-off-by: yemkareems <yemkareems@gmail.com>
* | refactor(Storage): Align all Storage constructorsrefactor/storage/constructorsprovokateurin2024-10-237-78/+77
| | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | fix(psalm): Fix some newly detected issuesrefactor/apps/constructor-property-promotionprovokateurin2024-10-211-1/+1
| | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | refactor(apps): Use constructor property promotion when possibleprovokateurin2024-10-2133-315/+142
| | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | chore(db): Correctly apply query typesGit'Fellow2024-10-171-32/+17
|/ | | | | | | | | | | | | | | | | | | | | | | | | | fix: psalm fix: error fix: add batch fix: fatal error fix: add batch chore: add batch chore: add batch fix: psalm fix: typo fix: psalm fix: return bool fix: revert Manager
* fix: add PasswordConfirmationRequired to update and delete methodyemkareems2024-10-161-0/+2
| | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
* fix: add PasswordConfirmationRequired to create user storages endpointyemkareems2024-10-161-0/+2
| | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
* chore(apps): Apply new rector configuration to autouse classesCôme Chilliet2024-10-1517-37/+61
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Merge pull request #48494 from nextcloud/refactor/storage/strong-param-typesKate2024-10-088-175/+116
|\
| * refactor(files_external): Add Storage parameter strong typesrefactor/storage/strong-param-typesprovokateurin2024-10-078-175/+116
| | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | fix(BackgroundJobs): Adjust intervals and time sensitivitiesprovokateurin2024-10-081-2/+1
|/ | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix: Ensure we only pass string to writeln()Joas Schilling2024-10-072-2/+2
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* ci: Fix psalm by typing the QuestionHelperJoas Schilling2024-10-071-0/+3
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix: use nc's binary finding logic for smbsmb-systembridgeRobin Appelman2024-10-042-7/+34
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix(filesexternal): Remove unneeded 3rdparty library usebugfix/noid/remove-3rdparty-useJoas Schilling2024-10-025-13/+13
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix: Fix test of IConstructableStorage implentation by storage classesfix/fix-storage-interface-checkCôme Chilliet2024-09-301-1/+1
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix(files_external): Fix all IStorage return typesprovokateurin2024-09-267-232/+130
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* Merge pull request #48359 from ↵Louis2024-09-261-0/+8
|\ | | | | | | | | nextcloud/artonge/feat/compare_hashed_password_when_updating_global_cred_in_files_external fix: Use placeholder for external storage password
| * fix: Use hashed password in files_external settingsartonge/feat/compare_hashed_password_when_updating_global_cred_in_files_externalLouis Chemineau2024-09-251-0/+8
| | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* | fix(files_external): Catch correct exceptionfix/files_external/forbidden-exceptionMarcel Klehr2024-09-261-7/+9
|/ | | | | | SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception. Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* Merge pull request #48111 from ↵Côme Chilliet2024-09-231-0/+5
|\ | | | | | | | | nextcloud/fix/move-storage-constructor-to-specific-interface fix: Move storage constructor to specific interface
| * fix: Move storage constructor to specific interfaceCôme Chilliet2024-09-231-0/+5
| | | | | | | | | | | | That allows Wrappers to use DI and not care about the constructor Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | chore: Apply rector configuration to apps folderCôme Chilliet2024-09-209-15/+15
|/ | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* chore(deps): Update nextcloud/coding-standard to v1.3.1provokateurin2024-09-1918-25/+25
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix: Remove OCP\Files\Storage interface deprecated since version 9Côme Chilliet2024-09-163-21/+15
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* refactor: Use the elvis operatorChristoph Wurst2024-09-151-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* fix(files_external): Check key exists before accessing itfixKeyExFileExtGit'Fellow2024-09-141-4/+8
| | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* fix(files_external): broken credentials dialogJohn Molakvoæ (skjnldsv)2024-09-131-28/+0
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* Merge pull request #47526 from nextcloud/jtr/fix-ftp-custom-port-uiJosh2024-09-121-0/+2
|\ | | | | fix(files_external): Handling in FTP UI for custom ports
| * fix: custom port handling in UI for FTP External StorageJosh2024-08-271-0/+2
| | | | | | Signed-off-by: Josh <josh.t.richards@gmail.com>
* | Merge pull request #47527 from nextcloud/fix-sftp-custom-port-uiJosh2024-09-121-0/+2
|\ \ | | | | | | fix(files_external): Handling in SFTP UI for custom ports
| * | fix: custom port handling in UI for SFTPJosh Richards2024-08-271-0/+2
| |/ | | | | | | Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
* / fix: Fix unmodified placeholder replacing the actual value when updatingDaniel Calviño Sánchez2024-09-042-0/+12
|/ | | | | | | | | | | | | | When updating global storages and user storages a property is not updated by "StoragesService::updateStorage()" if the value matches the unmodified placeholder. However, userglobal storages are not updated through the "StoragesService"; as only the authentication mechanism is updated it is directly done with "saveBackendOptions()" in "IUserProvided" or "UserGlobalAuth". Due to this the unmodified placeholder value needs to be explicitly checked in those cases and replaced by the actual value (note that in this case it is not possible to just skip updating a specific property). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* style: update codestyle for coding-standard 1.2.3Daniel Kesselberg2024-08-2516-43/+43
| | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* Merge branch 'master' into jr-readdir-false-falseJohn Molakvoæ2024-08-16115-2953/+1319
|\ | | | | Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
| * refactor(files_external): Replace security annotations with respective ↵provokateurin2024-08-144-24/+16
| | | | | | | | | | | | attributes Signed-off-by: provokateurin <kate@provokateurin.de>
| * feat: add a specialized writeStream implementation for s3 external storageRobin Appelman2024-07-241-0/+21
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
| * Merge pull request #46073 from nextcloud/fix/save_global_credentialsBenjamin Gaussorgues2024-06-251-3/+9
| |\
| | * fix: allows admin to edit global credentialsBenjamin Gaussorgues2024-06-241-3/+9
| | | | | | | | | | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
| * | fix: Do not log an error when connecting to SFTP without a logged in userDaniel Calviño Sánchez2024-06-181-5/+7
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When connecting to a SFTP server from a SFTP storage the host key is checked against the known host keys stored in a file in the data directory of the logged in Nextcloud user. The path to the file is (indirectly) got using "OC_App::getStorage", which logs an error if called when there is no logged in user; this can happen, for example, if the storage is used from a background job or a command. Not being able to read or write the file just causes the host key check to be skipped, but it has no other consequence. Moreover, even with logged in users it is likely that the file can not be read either and the check is also skipped, as the file needs to have been manually created by an admin. Due to all that now the path to the file is directly created using a View rather than relying on "OC_App::getStorage" to prevent the unneeded error from being logged. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * chore: Add SPDX headerAndy Scherzinger2024-06-06115-2433/+308
| | | | | | | | Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
| * fix(files_external): Be extra safe with null handling to please psalmCôme Chilliet2024-04-301-0/+3
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * Merge pull request #44658 from nextcloud/fix/migrate-away-from-resource-typeCôme Chilliet2024-04-161-6/+3
| |\ | | | | | | fix: Remove obsolete resource typing
| | * fix: Fix small psalm errors in FTP and LDAP connectionsCôme Chilliet2024-04-091-4/+1
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| | * fix: Remove obsolete resource typingCôme Chilliet2024-04-091-2/+2
| | | | | | | | | | | | | | | | | | In PHP>=8.1, LDAP and FTP resources are always typed objects Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | fix: Pass the mountpoint target user to storages without ownerJulius Härtl2024-04-091-0/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | Storages that do not have a dedicated owner (e.g. groupfolders, external storages) currently always assume the current session user as the owner. This leads to several issues when there is no user session but a node is obtained through a user folder. In order to have the correct user available we need to pass the user that is used to setup a mountpoint along to the storage layer as we generally assume that an owner is available for those. Signed-off-by: Julius Härtl <jus@bitgrid.net>
generated by cgit v1.2.3 (git 2.39.1) at 2025-05-02 13:15:00 +0000