aboutsummaryrefslogtreecommitdiffstats
path: root/apps/files_external/lib
Commit message (Collapse)AuthorAgeFilesLines
* getStorage before removeMaxence Lange2023-07-111-0/+6
| | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* Merge pull request #38591 from nextcloud/fix/caching/avoid-haskey-getSimon L2023-06-121-2/+3
|\ | | | | fix(caching): Avoid checking existence before fetching
| * fix(caching): Avoid checking existence before fetchingChristoph Wurst2023-06-121-2/+3
| | | | | | | | | | | | | | | | The cache might expire between checking for key existence and fetching the value. In this rare case the code continues with a null value when it doesn't expect one. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Update apps/files_external/lib/Lib/Storage/SMB.phpFaraz Samapoor2023-06-051-3/+1
| | | | | | | | Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
* | Refactors "strpos" calls in /apps/files_external to improve code readability.Faraz Samapoor2023-06-025-9/+11
|/ | | | Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
* Merge pull request #38115 from DerGenaue/patch-1Simon L2023-05-161-6/+6
|\ | | | | Rename `numericStorageId` to `numericExternalStorageId` in PersonalMount.php
| * Rename `numericStorageId` to `numericExternalStorageId` in PersonalMount.phpDaniel2023-05-071-6/+6
| | | | | | | | | | | | | | | | so that it doesn't override `numericStorageId` in the `MountPoint` baseclass fixes https://github.com/nextcloud/server/issues/37473 fixes https://github.com/nextcloud/server/issues/37414 Signed-off-by: Daniel <7558512+DerGenaue@users.noreply.github.com>
* | check the username when doing external storage session authRobin Appelman2023-05-111-0/+5
|/ | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Merge pull request #37717 from ↵Louis2023-04-241-2/+2
|\ | | | | | | | | nextcloud/artonge/fix/dont_override_stored_credentials_with_saml Do not override stored credentials when login in with SAML
| * Do not override stored credentials when login in with SAMLLouis Chemineau2023-04-131-2/+2
| | | | | | | | | | | | | | | | | | | | When login in with SAML, the password from `$event->getPassword()` is `null`. This PR makes sure that this `null` value won't be used to override the stored password even though it is different. This PR also allow for the password and user to be updated even though they were not set before. Signed-off-by: Louis Chemineau <louis@chmn.me>
* | add command for getting fileinfo for debuggingRobin Appelman2023-04-171-0/+4
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | Merge pull request #37611 from ZE3kr/patch-1Julius Härtl2023-04-141-1/+1
|\ \ | |/ |/| Unquote S3 ETag stored in oc_filecache
| * Update AmazonS3.phpJames Guo2023-04-061-1/+1
| | | | | | Signed-off-by: James Guo <i@ze3kr.com>
* | handle not being able to write file for notify self-testRobin Appelman2023-04-061-1/+4
|/ | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* improve handling of files we can't access in the scannerRobin Appelman2023-04-051-8/+16
| | | | | | | | instead of erroring, remove the items from the cache. this situation can be triggered if a user has access to a file but looses it afterwards Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix ftp external storage with filezilla serverRobin Appelman2023-03-302-7/+15
| | | | | | | - filezilla doesn't like "" as parameter for `mdtm` (all others seem fine) - filezilla sends fractional modified date Signed-off-by: Robin Appelman <robin@icewind.nl>
* Respect OCP interface in private classesCôme Chilliet2023-02-071-1/+1
| | | | | | | Because the parameter type was moved to phpdoc it needs to be removed from implementations Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Strong type filesize related methods to ease 32bits problem findingsCôme Chilliet2023-02-071-1/+1
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Attempt at reducing psalm errorsCôme Chilliet2023-01-201-4/+7
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Merge pull request #36089 from nextcloud/enh/noid/ext-storage-default-valuesVincent Petry2023-01-165-24/+54
|\ | | | | Ext storage configs default value support + enable SSL by default
| * Enable SSL by default in ext storage configsVincent Petry2023-01-134-4/+8
| | | | | | | | Signed-off-by: Vincent Petry <vincent@nextcloud.com>
| * Extend ext storage params to contain default valueVincent Petry2023-01-131-20/+46
| | | | | | | | | | | | | | Extend the external storage configuration parameters definition to allow to specify a default value Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* | Support of s3 storage class in External Storage applicationFrançois Ménabé2023-01-122-1/+4
|/ | | | Signed-off-by: François Ménabé <francois.menabe@gmail.com>
* Fix psalm issues related to signature changes from PHP 8.0Côme Chilliet2022-12-291-3/+0
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Add commentsCarl Schwan2022-12-052-0/+2
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Fix migration to non-empty secretCarl Schwan2022-12-052-2/+8
| | | | | | Add a fallback for empty keys Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* fix s3 directory copyRobin Appelman2022-11-151-3/+3
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Make sure to not pass null to DateTime::createFromFormatCôme Chilliet2022-11-141-2/+2
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Rename file1 and file2 to source and target in Storage abstractionCarl Schwan2022-10-187-67/+67
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Additional type hinting found by psalmCarl Schwan2022-10-186-16/+16
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Specify type to internal storage classCarl Schwan2022-10-171-0/+1
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Fix returning null when getMessage return nullCarl Schwan2022-10-171-11/+6
| | | | | | Don't overwrite $message but instead create another temporary variable Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* More type safetyCarl Schwan2022-10-175-25/+15
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Fix type of getVisibilityTypeCarl Schwan2022-10-173-3/+3
| | | | | | This is a int not a string Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Fix usage of streamsCarl Schwan2022-10-172-4/+4
| | | | | | always return a bool and type the handle as a string Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Use argument name from parent classCarl Schwan2022-10-172-15/+15
| | | | | | This will be an issue with php 8, so best to fix it now Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Add corresponding interface to traitCarl Schwan2022-10-177-80/+112
| | | | | | | Since we can't specify that we want a class implementing a trait yet in PHP Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Add more typing to FilesExternal commandsCarl Schwan2022-10-1711-139/+52
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Port away from deprecated clearBucket callCarl Schwan2022-10-161-9/+2
| | | | | | | | | | This was removed a long time ago in the library that we use, but never detected since this was inside a try catch block... Remove the call for now and we should investigate newer api in the future. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Port to LoggerInterfaceCarl Schwan2022-10-161-10/+44
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Force cast getCode to intCarl Schwan2022-10-162-9/+9
| | | | | | Otherwise psalm complains that the type can also be a non-falsy-string Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Specify that userId can be nullCarl Schwan2022-10-161-1/+1
| | | | | | | This fixes a psalm false-positive where the method is called with null, since the method actually handle this correctly already Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Fix return value of updateParentCarl Schwan2022-10-161-8/+3
| | | | | | | Port to executeStatement to guarantee that we will return an int and remove a deprecated method call at the same time Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Port away from removed IDBConnection->isConnected methodCarl Schwan2022-10-161-6/+4
| | | | | | | Instead track if the reconnection was successful with return value of connect method Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Fix too many arguments in LegacyDependencyCheckPolyfillCarl Schwan2022-10-161-1/+1
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Fix typos in apps/ subdirectoryluz paz2022-09-055-5/+5
| | | | | | | Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/` Signed-off-by: luz paz <luzpaz@github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* add marker interface to mark system mount points for encryptionRobin Appelman2022-08-252-1/+31
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* handle AccessDenied error when checking if external s3 support versionsMatthieu Gallien2022-07-281-1/+1
| | | | Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
* Move CappedMemoryCache to OCPCarl Schwan2022-07-143-3/+3
| | | | | | | | This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Merge pull request #32016 from nextcloud/fix/PasswordUpdatedEvent_handlingLouis2022-05-161-10/+18
|\ | | | | Use stored user for PasswordUpdatedEvent
generated by cgit v1.2.3 (git 2.39.1) at 2025-05-22 21:07:29 +0000