aboutsummaryrefslogtreecommitdiffstats
path: root/apps/files_sharing/lib/Controller
Commit message (Collapse)AuthorAgeFilesLines
* fix: Adjust preview for view-only sharesfix/view-only-previewFerdinand Thiessen2024-10-281-2/+14
| | | | | | | | | | | | | | | | | Previously there was a different behavior for public shares (link-shares) and internal shares, if the user disabled the view permission. The legacy UI for public shares simply "disabled" the context menu and hided all download actions. With Nextcloud 31 all share types use the consistent permissions attributes, which simplifies code, but caused a regression: Images can no longer been viewed. Because on 30 and before the attribute was not set, previews for view-only files were still allowed. Now with 31 we need a new way to allow "viewing" shares. So this is allowing previews for those files, but only for internal usage. This is done by settin a special header, which only works with custom requests, and not by opening the URL directly. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(files_sharing): Cleanup error messagesfix/files_sharing/cleanup-error-messagesprovokateurin2024-10-281-9/+9
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* refactor(ShareApiController): Check for null and empty strings with empty()safety-net-null-checkfenn-cs2024-10-241-7/+4
| | | | | | Proactive measure to avoid warnings in higher php versions as well possible type errors Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* fix(ShareAPI): Send mails for mail shares by defaultfix/48012/fix-share-email-send-mail-sharefenn-cs2024-10-241-1/+10
| | | | | | | | | | | | | | It looks like, the frontend it needs to provide the `sendMail` param for the backend to decide wether mails would be sent. Our UI does not have that at the moment so it should default to sending emails always for mail shares. Not exactly sure how this was handled earlier but this is a good starting point. Resolves : https://github.com/nextcloud/server/issues/48012 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* refactor(apps): Use constructor property promotion when possibleprovokateurin2024-10-217-166/+114
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* chore(apps): Apply new rector configuration to autouse classesCôme Chilliet2024-10-155-30/+40
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* feat(files_sharing): Make `ShareController` download route use the DAV ↵Ferdinand Thiessen2024-09-281-91/+24
| | | | | | `ZipFolderPlugin` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* chore(deps): Update nextcloud/coding-standard to v1.3.1provokateurin2024-09-192-5/+5
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix(files_sharing): adjust permissions from custom edit and delete check methodsskjnldsv2024-09-111-0/+17
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix: Display 'Leave share' instead of 'Delete'Marcel Klehr2024-09-061-0/+4
| | | | Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* fix(files_sharing): Handle download permission the same way for public and ↵Ferdinand Thiessen2024-09-061-0/+5
| | | | | | internal shares Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* chore: adjust code to adhere to coding standardAnna Larch2024-09-051-1/+1
| | | | Signed-off-by: Anna Larch <anna@nextcloud.com>
* style: update codestyle for coding-standard 1.2.3Daniel Kesselberg2024-08-253-12/+13
| | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* feat: Use new password context in sharing APIFerdinand Thiessen2024-08-221-2/+3
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Merge pull request #47070 from nextcloud/circToTeamAndy Scherzinger2024-08-061-5/+5
|\ | | | | fix(share): Rename Circle to Team
| * fix(share): Rename Circle to TeamGit'Fellow2024-08-061-5/+5
| | | | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* | fix(files_sharing): show proper share not found error messageskjnldsv2024-08-061-4/+4
|/ | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* Merge pull request #47043 from ↵Maxence Lange2024-08-061-1/+4
|\ | | | | | | | | nextcloud/fix/noid/ignore-root-on-inherited-shares fix(inherited-shares): ignore top root folder
| * fix(inherited-shares): ignore top root folderMaxence Lange2024-08-051-1/+4
| | | | | | | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* | fix(files_sharing): filter out invalid shareWith in sharee APIskjnldsv2024-08-051-1/+1
|/ | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* refactor(files_sharing): Replace security annotations with respective attributesprovokateurin2024-07-2710-75/+57
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix(files_sharing): file request creation permissions and link copy displayskjnldsv2024-07-181-2/+4
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix(files_sharing): remove undesirable translations from ShareAPIControllerskjnldsv2024-07-161-2/+2
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* chore(files_sharing): lint & refactor fixesskjnldsv2024-07-121-1/+1
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix(files_sharing): adjust IAttributes API and files_versionsskjnldsv2024-07-121-17/+10
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix(files_sharing): phpunit & openapi fixesskjnldsv2024-07-121-2/+8
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* chore(files_sharing): cleanup NewFileRequestDialog vueskjnldsv2024-07-121-1/+1
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix: psalm, cs, autoloader and lintskjnldsv2024-07-121-16/+19
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* chore(files_sharing): refactor share password mailskjnldsv2024-07-121-9/+29
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* feat(files_sharing): allow mixed values in share attributes and allow ↵skjnldsv2024-07-121-1/+8
| | | | | | storing email arrays Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* chore(files_sharing): refactor mail handlingskjnldsv2024-07-121-1/+32
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* feat(files_sharing): implement IShareProviderWithNotification and refactor ↵skjnldsv2024-07-121-36/+20
| | | | | | sendMailNotification Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* feat(files_sharing): add `new file request` optionskjnldsv2024-07-121-0/+49
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* docs(ShareApiController): Correct note about expiry date timezonefenn-cs2024-07-011-1/+1
| | | | Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* fix(files_sharing): Store the expiration date relative to the server's timezoneLouis Chemineau2024-06-261-3/+0
| | | | | | This is needed as we want to store the difference between the server's and the user's timezones. Signed-off-by: Louis Chemineau <louis@chmn.me>
* chore: Add SPDX headerAndy Scherzinger2024-06-0610-264/+25
| | | | Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
* fix(ShareApiClients): Maintain meaning of `''` and null for share api clientsfenn-cs2024-05-291-3/+3
| | | | Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* fix(shareManager): Respect empty `expireDate` in serverfenn-cs2024-05-231-8/+15
| | | | | | If `expireDate` is an empty string and not `null` then the server should not set a default. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* fix(sharing): Don't change the type of the controller argumentJoas Schilling2024-04-181-2/+2
| | | | | | [EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives. Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix(shareApiController): avoid duplicated expiryDate operationsfenn-cs2024-04-181-27/+10
| | | | | | | | `expireDate` can be set once and used anywhere needed, the current implementation, duplicates this behavior which leads to `parseDate` receiving an a date object it parsed and returend earlier in the createShare method. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* refactor(shareApiController): use contrusctor property promotion & DI loggerfenn-cs2024-04-181-56/+20
| | | | Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* fix: Apply new coding standard to all filesCôme Chilliet2024-04-022-17/+17
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix(files_sharing): ShareesAPI - Return empty response when user is not ↵Ferdinand Thiessen2024-03-151-24/+9
| | | | | | | | allowed to share Resolves: https://github.com/nextcloud/server/issues/20950 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* perf: switch places that always use the first getById result to getFirstNodeByIdRobin Appelman2024-03-043-24/+15
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Merge pull request #43428 from nextcloud/feat/share-expiration-with-timeBenjamin Gaussorgues2024-02-261-1/+4
|\
| * feat(share): save date and time for expirationBenjamin Gaussorgues2024-02-221-1/+4
| | | | | | | | | | | | | | | | Because of timezones, not saving time can lead to unexpected behaviour when sharing an item sooner than timezone offset Example: sharing a file before 9am when in UTC+9 Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | fix truncated circleId returned from Share APIAragon Gouveia2024-02-231-3/+4
|/
* Merge pull request #43461 from nextcloud/fix/get-rid-of-getloggerF. E Noel Nfebe2024-02-141-2/+2
|\ | | | | chore: Migrate away from OC::$server->getLogger
| * chore: Migrate away from OC::$server->getLoggerCôme Chilliet2024-02-131-2/+2
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | feat: rename users to account or personVincent Petry2024-02-131-2/+2
|/ | | | | | Replace translated text in most locations Signed-off-by: Vincent Petry <vincent@nextcloud.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-28 23:29:49 +0000