aboutsummaryrefslogtreecommitdiffstats
path: root/apps/files_sharing/src
Commit message (Collapse)AuthorAgeFilesLines
* fix(files_sharing): fallback self.crypto.getRandomValuesbackport/53635/stable30skjnldsv6 days1-1/+20
| | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* fix(files_sharing): restore state when updating share failedFerdinand Thiessen11 days3-27/+37
| | | | | | | | | | | | | | | | | | | | We need to save the previous state - here the password - so that if the update fails we can revert the shown state. This happens e.g. if you have the password policy app and try to add an unsecure password. To reproduce (with password policy): 1. Create new link share 2. enable password protection 3. use insecure password like `1234` 4. save share Now you see that the update failed, but the password protection is still enabled. This happened because `password` and `newPassword` were misused. `password` was already set when `newPassword` was not saved so we could not know to what we need to reset when the update failed. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(files_sharing): Stop hiding delete share button in advanced settings menuprovokateurin2025-06-301-13/+13
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix(files_sharing): show message when nickname is not validskjnldsv2025-06-051-1/+18
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix(files_sharing): Show note if note exists on sharenfebe2025-05-261-1/+2
| | | | | | | | | When a share includes a note, ensure the note checkbox is checked and the note is displayed when reopening the share sidebar. Fixes: #52794. Signed-off-by: nfebe <fenn25.fn@gmail.com>
* fix(files_sharing): Create `download` attribute when toggling checkbox if ↵fix/stable30/create-download-attribute-if-missingnfebe2025-05-161-5/+25
| | | | | | | | | | missing Previously, toggling the checkbox did not create the 'download' attribute if it was missing, causing it to become unresponsive after a page reload. Now, setShareAttribute ensures the attribute is updated or created correctly. Signed-off-by: nfebe <fenn25.fn@gmail.com>
* fix(dav): check the owner displayName scope before giving attributeskjnldsv2025-04-301-3/+3
| | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com> [skip ci]
* fix(files_sharing): Prevent create/delete permissions on file sharesbackport/52526/stable30nfebe2025-04-292-3/+34
| | | | | | | | | | File shares can't support create or delete permissions. This change ensures those permissions are stripped or ignored when the shared item is not a folder. Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* fix(files_sharing): Improve expiration date input change handlingbackport/52364/stable30nfebe2025-04-242-6/+12
| | | | | | | | | | | | | | | | | | If the time picker component is emitting a Date object already, then there is redundant call of `new Date(new Date())` and therefore introduces subtle bugs, for example on chrome users could not enter expiration date with keyboard. - Use @update:model-value instead of @change/@input for more reliable date updates - Ensure null and invalid dates are handled correctly in onExpirationChange - Validate date input before updating defaultExpirationDateEnabled Resolves : https://github.com/nextcloud/server/issues/51875 Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* fix(files_sharing): file request pass empty string if password or expiration ↵skjnldsv2025-04-221-2/+2
| | | | | | | | is disabled Signed-off-by: skjnldsv <skjnldsv@protonmail.com> [skip ci]
* Merge pull request #52002 from nextcloud/backport/51937/stable30Ferdinand Thiessen2025-04-182-69/+81
|\ | | | | [stable30] perf(files_sharing): do not emit second propfind for account filter
| * perf(files_sharing): do not require second propfind for account filterFerdinand Thiessen2025-04-142-69/+81
| | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix(files_sharing): Apply default password setting in SharingDetailsTabnfebe2025-04-153-39/+23
|/ | | | Signed-off-by: nfebe <fenn25.fn@gmail.com>
* fix(files_sharing): fix share creation error handlingskjnldsv2025-04-092-4/+16
| | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com> [skip ci]
* fix(files_sharing): make sure IDs are unique for HTML elementsFerdinand Thiessen2025-04-021-2/+8
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(files_sharing): ugly hacks to update permissions on share creationFerdinand Thiessen2025-04-024-9/+26
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix: pass hide download attribute while creating the share to fix github ↵yemkareems2025-04-022-5/+8
| | | | | | issue 50788 Signed-off-by: yemkareems <yemkareems@gmail.com>
* fix(files_sharing): ensure share status action works also in grid viewFerdinand Thiessen2025-03-191-0/+9
| | | | | | | | | | | | Remove some hacks from files app about the *files_sharing* status action, in general not sure why this hack was there instead of being in the correct app - but it broke the grid view. So now the sharing information is also available in grid view. Moreover the icon is fixed in size to not overflow the actions menu. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(files_sharing): Map sharee information for `shared-by-you` viewFerdinand Thiessen2025-03-032-1/+20
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(eslint): Strings must use singlequotebackport/51142/stable30John Molakvoæ2025-03-021-1/+1
| | | Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
* fix(l10n): use `do not` instead of `don't`Valdnet2025-03-021-1/+1
| | | | Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
* chore(deps): Update `@nextcloud/vue` to v8.23.1Ferdinand Thiessen2025-02-211-0/+1
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(files_sharing): Fix public share expiration being set when toggle is not ↵Christopher Ng2025-02-191-2/+7
| | | | | | enabled Signed-off-by: Christopher Ng <chrng8@gmail.com>
* fix(files): Properly reset all file list filters on view changeFerdinand Thiessen2025-02-181-0/+4
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(files_sharing): Update `QuickShareSelect` if share is modifiednfebe2025-02-062-1/+13
| | | | Signed-off-by: nfebe <fenn25.fn@gmail.com>
* test(files_sharing): Check that default expiration date is shown b4 create sharenfebe2025-02-061-0/+1
| | | | Signed-off-by: nfebe <fenn25.fn@gmail.com>
* fix: Show default expiration date before create link sharenfebe2025-02-063-18/+17
| | | | | | | | | Since `ShareEntryLink` component is used to both create and display/list the share links, we should only set default expiration date on `share.expireDate` when we know is a new share. Otherwise, we overidding data from the backend. Signed-off-by: nfebe <fenn25.fn@gmail.com>
* fix(files_sharing): Adjust wrong labeling identified by testnfebe2025-02-031-1/+1
| | | | Signed-off-by: nfebe <fenn25.fn@gmail.com>
* fix(files_sharing): Only clear permissions of pending federated sharesprovokateurin2025-01-312-29/+82
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix(files_sharing): file request form validity check resetbackport/50524/stable30skjnldsv2025-01-301-4/+9
| | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* fix(files_sharing): Remove debounce from expiration date formattingFerdinand Thiessen2025-01-162-4/+6
| | | | | | | | This should be done as soon as changed, as the value is not passed to API but needs to be tracked internally (e.g. if you quickly press "save"). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(files_sharing): Stop overwriting the share expiration date with the ↵provokateurin2025-01-161-4/+1
| | | | | | default expiration date Signed-off-by: provokateurin <kate@provokateurin.de>
* fix: remove references to non-existent ShareTypesnfebe2025-01-062-5/+5
| | | | | | | A refactor was done to remove ShareTypes and an incomplete backport of 00c2b94391819eda77ddc7ab347972383c6319c0 left incorrect references to shareTypes. Signed-off-by: nfebe <fenn25.fn@gmail.com>
* fix(files_sharing): List of share type during recipient lookupLouis Chemineau2025-01-021-1/+11
| | | | | | | | ShareType lists both names and ids so Object.entries return too much. This was also making useless the following condition adding ShareType.Email Signed-off-by: Louis Chemineau <louis@chmn.me>
* fix: Only show share permission if re-sharablenfebe2025-01-021-2/+5
| | | | | | Signed-off-by: nfebe <fenn25.fn@gmail.com> [skip ci]
* refactor: Use new `ShareType` across file_sharingnfebe2025-01-0216-130/+104
| | | | Signed-off-by: nfebe <fenn25.fn@gmail.com>
* chore(i18n): Improved grammarrakekniven2024-12-121-1/+1
| | | | | | Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com> [skip ci]
* fix(SharingEntryQuickShareSelect): Disable quick share select if user can ↵backport/49747/stable30provokateurin2024-12-121-0/+1
| | | | | | | | not edit share Signed-off-by: provokateurin <kate@provokateurin.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* fix(SharingEntry): Hide edit button if user can not edit shareprovokateurin2024-12-121-1/+2
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix(files_sharing): also submit new share on password submitskjnldsv2024-12-121-1/+1
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix(files_sharing): Correct property enforced property namesnfebe2024-12-111-8/+7
| | | | Signed-off-by: nfebe <fenn25.fn@gmail.com>
* fix(files_sharing): Stop infinite loop blocking link share requestsnfebe2024-12-091-13/+22
| | | | | | | | Fixes infinite loop preventing share link creation requests from being sent to the backend. Signed-off-by: nfebe <fenn25.fn@gmail.com>
* chore(assets): Recompile assets + lint fixnextcloud-command2024-11-202-1/+2
| | | | Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* fix(files_sharing): share assignment issue in SharingEntryLinkskjnldsv2024-11-081-2/+4
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix(SharingEntryLink): Show default password before create if anyfenn-cs2024-11-081-9/+41
| | | | | | | | | | | | Prevent silent addition of expiration date to shares. Prevent silent addition for password to shares. Both now have a `shareRequiresReview` check Resolves : https://github.com/nextcloud/server/issues/48860 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* fix(ShareEntryLinkList): Append new links to the end of listbackport/49017/stable30fenn-cs2024-10-311-1/+1
| | | | | | | | | | | | | | | Currently new shares are added to beginning of the share list in the UI messing up the ordering with the original (first) looking like the most recent and the most recent looking like the original share. This error disappears on refresh. Resolves : https://github.com/nextcloud/server/issues/48415 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Merge pull request #49013 from nextcloud/backport/48991/stable30Ferdinand Thiessen2024-10-301-3/+15
|\ | | | | [stable30] fix(files_sharing): Password field must not be required if already set
| * fix(files_sharing): Password field must not be required if already setbackport/48991/stable30Ferdinand Thiessen2024-10-301-3/+15
| | | | | | | | | | | | | | If there is already a password, there is no need to require the password in the setting ('newPassword'). It is only required for new shares. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix(Federation): Show some icon for federated users on sharesfenn-cs2024-10-302-1/+2
|/ | | | Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* fix(files_sharing): federated shares avatarskjnldsv2024-10-292-4/+54
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>