summaryrefslogtreecommitdiffstats
path: root/apps/files_sharing/src
Commit message (Collapse)AuthorAgeFilesLines
* sharing-entry__reshare needs ul or ol around itSimon L2024-01-111-7/+9
| | | | Signed-off-by: Simon L <szaimen@e.mail.de>
* fix(files): group duplicate sharesJohn Molakvoæ2024-01-112-1/+44
| | | | Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
* fix(files_sharing): Add one string for every share type to not assume any ↵Ferdinand Thiessen2023-12-131-17/+17
| | | | | | language Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Allow user to finish typing date before formattingfenn-cs2023-12-111-3/+2
| | | | | | | Debounce `onExpirationChange` to avoid calling `formatDateToString` on invalid on uncompletely inputed date strings. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Tooltip outside click, should abort share creationfenn-cs2023-12-111-1/+1
| | | | | | | It's unexpected that click outside a tooltip would proceed with the action that could be carried out inside the tooltip. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Replace input filed with password field and added password error messagejulia.kirschenheuter2023-12-081-5/+11
| | | | | | Remove unneeded NcDateTimePicker Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
* Remove `newPassword` from share model, if disabledfenn-cs2023-12-061-3/+7
| | | | | | | | | | It's important to delete the `newPassword` prop from the share model, if the user unchecks the isPasswordProtected checkbox. This clearer and allows for the unchecking to actually work as `this.$set()` fails with the falsy value `''`. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Create element reference inside $nextTick()fenn-cs2023-12-061-7/+6
| | | | | | | | Accessing `this.$refs.shareList` outside $nextTick() could lead to the holder (`listComponent`) being undefined as the ref is yet to exist. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* fix(files_sharing): fix sharing status indicator side after component updateJohn Molakvoæ2023-12-051-1/+3
| | | | | | Seems like the components now have max-height/width set too Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
* Improve share logic for enforced password & expiry datefenn-cs2023-11-303-36/+35
| | | | | | | | | | | | | | * It's possible for the admin to enforce and expiry date after, some shares have been created. This commit makes possible to update the share with the new admin constraints. * This commit would users to modify enforced expiry to anything within range and less than the enforced limit in the pre-create dialog for public shares. * This commit fixes, unable to update share without updating password. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Replace "Update" with "Edit"Jérôme Herbinet2023-11-231-2/+2
| | | Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
* fix: Avoid invisible areas through keyboard navigationJulius Härtl2023-11-171-0/+1
| | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Replace ActionLink with ActionButton on sharing tabjulia.kirschenheuter2023-11-172-11/+6
| | | | | Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com> So-authored-by: Grigorii K. Shartsev <me@shgk.me>
* fix(a11y): Focus on sharing quick permission radioChristopher Ng2023-11-161-1/+6
| | | | Signed-off-by: Christopher Ng <chrng8@gmail.com>
* Move delete share button into the scrolling containerjulia.kirschenheuter2023-11-151-13/+13
| | | | Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
* Adapt "advanced settings" button for accordion buttonjulia.kirschenheuter2023-11-151-2/+12
| | | | Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
* fix: Change scroll container for sharing detailsJulius Härtl2023-11-132-173/+183
| | | | | | | | | | | | In order to meet accessibility requirements we cannot use a sticky footer that overlaps important interactable content. Therefore this moves to a scroll container for the details which does not include the action buttons at the bottom. Larger indentation change in SharingDetailsTab was required to have a wrapping container for the scroll area. Signed-off-by: Julius Härtl <jus@bitgrid.net>
* fix description of sharing toggleSimon L2023-11-071-1/+1
| | | | Signed-off-by: Simon L <szaimen@e.mail.de>
* fix(files_sharing): permissions translationGrigorii K. Shartsev2023-11-061-19/+16
| | | | Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
* fix: Share select search globally iconChristopher Ng2023-10-231-1/+1
| | | | Signed-off-by: Christopher Ng <chrng8@gmail.com>
* Do not treat `isDefaultExpireDateEnforced` as fallbackfenn-cs2023-10-221-2/+2
| | | | | | | | | | | | | | | | `isDefaultExpireDateEnforced` and its corresponding `defaultExpirationDate` is currently treated as the enforcement fallback when share type enforcements are not set. However, `isDefaultExpireDateEnforced` and `defaultExpirationDate` are actually more like `isDefaultPublicExpireDateEnforced` and `defaultPublicExpirationDate` and therefore only applies to public shares. It might be ideal to rename this variables all the way from the backend config to the way we use them in the frontend code. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Fix has expiration date logicfenn-cs2023-10-221-15/+12
| | | | | | | | | | | Current expiration date errorneously assumes that `defaultExpirationDate` applies to all kinds of shares. But it only really applies to public shares despite its name. This commit, fixes that by paring expiration dates with the correct share types during new share initialization and simplifying the `hasExpirationDate` (check) property. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Check expiry enforcement for all share typesfenn-cs2023-10-221-7/+7
| | | | | | | | We should check that a maximum expiry date has been enforced for all shares and NOT JUST FOR internal shares before enforcing a UI max date, like in commit 9757e680e2f643fe19432255c4142e96fbc88df5 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* refactor: remove remaining usage of OC::getCapabilitiesVarun Patil2023-10-203-8/+12
| | | | Signed-off-by: Varun Patil <varunpatil@ucla.edu>
* Reduce width of sharing entryjulia.kirschenheuter2023-10-192-4/+4
| | | | | Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Allow share expiry dates lower than enforced limitsfenn-cs2023-10-161-8/+12
| | | | | | | | | | | | | | | Previously, users could change the share expiry date up to the enforced maximum. The new share flow imposed the enforced share expiry date maximum literally and did not allow even dates lower than the maximum enforced. That does not make much sense, if the enforced expiry date is 30 days from creation date, then it's logical to allow users set the date to anything less than 30 days from the creation date. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Fixed mixed translations in sharing detailsfenn-cs2023-10-091-17/+17
| | | | | | | | | | Due to a typo in the app passed to the translation method, some strings translations don't work. This commit corrects the spelling `file_sharing` to `files_sharing` and hence resolves : https://github.com/nextcloud/server/issues/40801 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* chore: Adapt to breaking DateTime renameChristopher Ng2023-10-061-2/+2
| | | | Signed-off-by: Christopher Ng <chrng8@gmail.com>
* show loading icon in 'save share' button when creating a shareJulien Veyssier2023-10-031-0/+8
| | | | Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
* Correct check for enabled expiration datefenn-cs2023-10-021-3/+9
| | | | | | | | | | | | | | The default expiration date cannot be enforced if it is not enabled in the first place. Hence, the check for whether a share has an expiration date should not consider enforcements but only where the share expiry type is enabled. For example : Using `this.config.isDefaultExpireDateEnabled` instead of `this.config.isDefaultExpireDateEnforced` which can be verified by checking `isExpiryDateEnforced`. Resolves : https://github.com/nextcloud/server/issues/40612 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Updates to sharing flowfenn-cs2023-10-022-32/+30
| | | | | | | | | | | | | | - Show enforced expiry date for new shares. - Improve quick share dropdown visibility in dark mode. - Prevent expiry date from showing expire for incoming shares. by updating the check for `share.passwordExpirationTime` to equally check for `undefined`. - Move "Download permission/attribute" from custom setting (as it is just another advanced setting and not an actual permission). - Show correct text for upload/editing when "allow public uploads" is enabled or disabled by admin. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* enh(a11y): Add label to share note textboxChristopher Ng2023-09-271-1/+4
| | | | Signed-off-by: Christopher Ng <chrng8@gmail.com>
* Auto set password for new email sharesfenn-cs2023-09-261-3/+9
| | | | | | | | | Suggest auto generated password for new public share (mail share). Resolves : https://github.com/nextcloud/server/issues/40493 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* fix(files): title and inline actionsJohn Molakvoæ (skjnldsv)2023-09-211-2/+13
| | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Consider share type for enforced share expiry datesfenn-cs2023-09-203-28/+18
| | | | | | | | | | | | | | | | | | | | | We have three kind of share expiry date enforcements. - `isDefaultExpireDateEnforced` - `isDefaultInternalExpireDateEnforced` - `isDefaultRemoteExpireDateEnforced` Before these commit, `isExpiryDateEnforced` that is used to disable/enable the set expiry date checkbox does not take those into consideration which is problematic as those have different applications. In addition, this commit now uses `isExpiryDateEnforced` to disable/enable the input for expiry date that shows up before the creation of link shares. Here, `hasExpirationDate` is also removed from 'SharingEntryLink` component as it is not used. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* feat(files): add files_sharing indicatorJohn Molakvoæ (skjnldsv)2023-09-203-0/+153
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* Consider link shares in removeShare method in SharingTabfenn-cs2023-09-151-3/+10
| | | | | | | | | | | | | Currently, the `removeShare` method in the `SharingTab` view, does not take into account `linkShares`. Since link shares now shares thesame detail view with other share types, it should therefore be considered hence this commit. Resolves : https://github.com/nextcloud/server/issues/40396 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Correctly switch/revert from custom to bundled permsfenn-cs2023-09-151-3/+5
| | | | | | | | | | | | | | | | | We have a set custom permissions checkbox, that when selected should set the quick permissions settings to custom as well as show the custom permission settings. When the checkbox is unchecked the quick permissions have to be reset to the default, `bundledPermissions.ALL` but also users can switch from custom permissions to `bundled` by just changing the radio select, hence we need a mechanism to set the permissions back to the correct fallback depending on where the user has toggled the the custom permission from. The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly set upon toggle. Resolves : https://github.com/nextcloud/server/issues/40431 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Properly align all sharing-entry typesfenn-cs2023-09-144-47/+56
| | | | | | | | SharingEntryLink and regular ShareEntry were not properly visually aligned before this commit. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Fix invite guest for new sharing flowfenn-cs2023-09-142-13/+22
| | | | | | | | Call external handlers such as the one in the guess app https://github.com/nextcloud/guests/blob/master/src/main.js#L30 if present. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Hide additional content when share details is openLouis Chemineau2023-09-131-55/+57
| | | | | Signed-off-by: Louis Chemineau <louis@chmn.me> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Ellipsize user status in sharing entryfenn-cs2023-09-131-28/+25
| | | | | Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Non sticky delete buttonfenn-cs2023-09-131-6/+10
| | | | | | Removes button from footer and removes button background. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Display user status by the side in sharing flowfenn-cs2023-09-131-6/+10
| | | | | | | | | | | The quick share drop down now takes the place where the user status would show in the past, so we have the option of removing it (as it's available in the profile dropdown) or putting it at the side as such. It's put on the side without the icon, as the status icon appears on the avatar when set. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Consistent delete button in share detailsfenn-cs2023-09-121-1/+0
| | | | | | | Delete button text should have same size as other buttons. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Enfore allowPublicShares admin settingfenn-cs2023-09-123-4/+9
| | | | | | | Use the the modern intial-state library to pass data about `allowPublicUploads` to the sharing frontend. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Refactor migrated addShare methodfenn-cs2023-09-121-18/+15
| | | | Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Add accesibility features to quick share dropdownfenn-cs2023-09-071-16/+98
| | | | | | | | | - Adds appropriate aria attributes - Uses button element for dropdown items as it's more semantically correct - Uses trap-focus lib to trap focus when the drowpdown is active - Adds custom handling for arrow up and down Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Close quickshare dropdown on outside clickfenn-cs2023-09-071-1/+13
| | | | | | | If a user clicks anywhere outside of the quickshare dropdown, it should be closed. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
* Do not toggle custom permissionsfenn-cs2023-09-071-9/+7
| | | | | | | | | | | | | Currently, swithcing between permissions in the sharing permissions details view would toggle the custom permissions view. We think, it's better for the custom permission option to simple expand the custom permissions view and never close it gain even if the user is switching between bundled permissions. The user can always collapse the view by using the "Advanced settings" toggle. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-12 15:25:59 +0000