summaryrefslogtreecommitdiffstats
path: root/apps/files_sharing
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #11967 from ↵Morris Jobke2018-10-232-11/+25
|\ | | | | | | | | nextcloud/fix-opening-a-section-again-in-the-files-app Fix opening a section again in the Files app
| * Remove event handler no longer neededDaniel Calviño Sánchez2018-10-211-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The custom handler for "URL changed" events were added to reload the file list whenever the sections for favorites and shares were opened; this was used to fix the problem of not reloading the file lists when opening them for a second time. However, besides that the handlers were not really necessary, and as the root of the bug was fixed in the previous commit those handlers are now removed. The file list for tags uses the handler for a different purpose, though, so that one was kept. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix opening a section again in the Files appDaniel Calviño Sánchez2018-10-211-5/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a section is open in the Files app a "show" event is triggered. File list objects handle that event by reloading themselves, but only if the file list was shown at least once. However, the file list objects of plugins are created when the "show" event is triggered for the first time for their section; as the file list objects register their handler for the "show" event when they are created they never handle the first triggered "show" event, as the handler is set while that event is being already handled. Therefore, from the point of view of the handler, the second time that a "show" event was triggered it was seen as if the file list was shown for the first time, and thus it was not reloaded. Now the "shown" property is explicitly set for those file lists that are created while handling a "show" event, which causes them to be reloaded as expected when opening their section again. Note that it is not possible to just reload the file list whenever it is shown; the file list is reloaded also when the directory changes, and this can happen when the web page is initially loaded and the URL is parsed. In that case, if file lists were reloaded when shown for the first time then it could be reloaded twice, one with the default parameters due to the "show" event and another one with the proper parameters once the URL was parsed, and the files that appeard in the list would depend on which response from the server was received the last. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Use lax CSP when the share is a talk shareJoas Schilling2018-10-221-2/+21
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #11927 from stweil/cleanRoeland Jago Douma2018-10-191-5/+5
|\ \ | | | | | | Remove duplicate condition
| * | Remove duplicate conditionStefan Weil2018-10-191-6/+6
| |/ | | | | | | | | | | | | | | This fixes a warning from LGTM: Operands additionnalShares and additionnalShares are identical. Fix also the typo in the parameter name.
* / Add missing variable declarationsStefan Weil2018-10-191-1/+3
|/ | | | | | | | | This fixes errors from LGTM like the following one: Variable i is used like a local variable, but is missing a declaration. Signed-off-by: Stefan Weil <sw@weilnetz.de>
* Merge pull request #11905 from nextcloud/design/noid/tab-iconsRoeland Jago Douma2018-10-191-0/+4
|\ | | | | Add icon to file sidebar tabs
| * Add icon to file sidebar tabsJulius Härtl2018-10-181-0/+4
| | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | Add missing semicolonsStefan Weil2018-10-191-1/+1
|/ | | | | | | | | This fixes some recommendations from LGTM: Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon). Signed-off-by: Stefan Weil <sw@weilnetz.de>
* Merge pull request #11862 from nextcloud/bugfix/ensure_cache_it_initblizzz2018-10-171-1/+3
|\ | | | | Double check for failed cache with a shared storage
| * Double check for failed cache with a shared storageRoeland Jago Douma2018-10-161-1/+3
| | | | | | | | | | | | | | | | | | | | | | When obtaining the SourceRootInfo we can call init. If this fails the cache is set to a failed cache and the storage to a failed storage. However we did not check for this. Which means that if the storage was invalid it would fail later on. Now we will properly error out. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Merge pull request #11870 from nextcloud/fix/noid/proper-column-name-escapingMorris Jobke2018-10-161-1/+1
|\ \ | | | | | | Properly quote column name in "createFunction" call
| * | Properly escape column name in "createFunction" callMorris Jobke2018-10-161-1/+1
| |/ | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* / Move files_drop to compiled handlebarsRoeland Jago Douma2018-10-164-12/+38
|/ | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* [tx-robot] updated from transifexNextcloud bot2018-10-10100-100/+100
|
* Merge pull request #11716 from ↵Morris Jobke2018-10-091-2/+2
|\ | | | | | | | | nextcloud/bugfix/noid/use-numeric-placeholders-for-rtl-translations Use numeric placeholders if there are multiple, so that RTL languages…
| * Use numeric placeholders if there are multiple, so that RTL languages can ↵Joas Schilling2018-10-091-2/+2
| | | | | | | | | | | | operate better Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Fix usage of deprecated OC.webrootChristoph Wurst2018-10-093-17/+17
|/ | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* [tx-robot] updated from transifexNextcloud bot2018-10-092-4/+4
|
* Remove deprecated SVG helpers for old IEsChristoph Wurst2018-10-081-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* [tx-robot] updated from transifexNextcloud bot2018-10-074-20/+20
|
* [tx-robot] updated from transifexNextcloud bot2018-10-052-0/+6
|
* Allow userId to be nullRoeland Jago Douma2018-10-041-1/+1
| | | | | | | | | | | | Fixes #10852 A quick hack. Still ensures some type safety however now also accepts null. Else we'd need to add a whole new layer of middlewares. This can only happen when a guest user wants to access a controller that requries the user_id. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Move sharetabview to compiled handlebarsRoeland Jago Douma2018-10-041-4/+1
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #11538 from nextcloud/heading-boldMarin Treselj2018-10-031-1/+0
|\ | | | | Set headings to Semibold for better information architecture
| * Change heading weights from Light to Semibold for better information ↵Jan-Christoph Borchardt2018-10-011-1/+0
| | | | | | | | | | | | architecture Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
* | Fix header overflow, fix more apps menu, fix #11552Jan-Christoph Borchardt2018-10-021-0/+6
|/ | | | Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
* Move to 1 template file for filesRoeland Jago Douma2018-10-011-1/+1
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Ellipsize long filenames and sharee names in public share page headerJan-Christoph Borchardt2018-10-011-1/+3
| | | | Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
* [tx-robot] updated from transifexNextcloud bot2018-09-302-2/+2
|
* [tx-robot] updated from transifexNextcloud bot2018-09-292-2/+2
|
* Compile filesummary handlebarsRoeland Jago Douma2018-09-271-0/+2
| | | | | | | | | | Fixes #11030 For https://github.com/orgs/nextcloud/projects/18 This template is now compiled so this no longer has to happen in the browser. Another step towards a stricter CSP. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* [tx-robot] updated from transifexNextcloud bot2018-09-272-2/+2
|
* do not explode when getting permissions from a FailedStorageArthur Schiwon2018-09-261-1/+9
| | | | | | | for instance if a user of an external user backend is not available currently, the whole Files UI would be frozen. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* [tx-robot] updated from transifexNextcloud bot2018-09-262-2/+2
|
* [tx-robot] updated from transifexNextcloud bot2018-09-254-6/+34
|
* [tx-robot] updated from transifexNextcloud bot2018-09-232-8/+22
|
* [tx-robot] updated from transifexNextcloud bot2018-09-226-22/+24
|
* [tx-robot] updated from transifexNextcloud bot2018-09-214-0/+10
|
* Merge pull request #11041 from ↵Joas Schilling2018-09-193-11/+18
|\ | | | | | | | | nextcloud/fix/noid/get_permission_of_storage_for_shares Check the permission of the underlying storage
| * Update test now that we check permissions properlyRoeland Jago Douma2018-09-061-7/+7
| | | | | | | | | | | | | | | | | | | | | | Now that we actually check thepermissions properly we have to update the tests. * We checked an invalid path * We checked from wrong permissions (files never have CREATE permissions for example) Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * Properly check share permissionsRoeland Jago Douma2018-09-061-2/+8
| | | | | | | | | | | | | | | | isCreatable only works on folders isUpdatable if the file is not there but it is a part file also has to be checked on the folder Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * Fix shared cacheRoeland Jago Douma2018-09-061-1/+1
| | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * Check the permission of the underlying storageRoeland Jago Douma2018-09-061-1/+2
| | | | | | | | | | | | | | Else shares might expose more permissions than the storage actually providers. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | [tx-robot] updated from transifexNextcloud bot2018-09-176-0/+14
| |
* | [tx-robot] updated from transifexNextcloud bot2018-09-162-0/+140
| |
* | [tx-robot] updated from transifexNextcloud bot2018-09-142-0/+28
| |
* | [tx-robot] updated from transifexNextcloud bot2018-09-134-6/+22
| |
* | [tx-robot] updated from transifexNextcloud bot2018-09-122-0/+6
| |