aboutsummaryrefslogtreecommitdiffstats
path: root/apps/settings/lib/Controller
Commit message (Collapse)AuthorAgeFilesLines
...
* | Merge pull request #31470 from nextcloud/enh/13099/allow-disable-imagick-warningJohn Molakvoæ2022-03-081-14/+21
|\ \
| * | allow to disable the imagick warningszaimen2022-03-071-14/+21
| | | | | | | | | | | | | | | Signed-off-by: szaimen <szaimen@e.mail.de> Co-Authored-By: MichaIng <micha@dietpi.com>
* | | allow adding protocol to domains in 'connectivity_check_domains' configJulien Veyssier2022-03-071-8/+13
|/ / | | | | | | Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
* | Merge pull request #31267 from nextcloud/enh/docs-link-for-opcache-recommendsMichaIng2022-03-041-1/+1
|\ \ | | | | | | Add Nextcloud docs link to OPcache recommends
| * | Add Nextcloud docs link to OPcache recommendsMichaIng2022-03-031-1/+1
| |/ | | | | | | | | | | | | | | A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list. Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend. Signed-off-by: MichaIng <micha@dietpi.com>
* / Fix permittedPath comparisonMickey Knox2022-03-021-1/+1
|/ | | | Signed-off-by: Mickey Knox <mickey@netfreaks.org>
* Cleanup admin settings js filesCarl Schwan2022-02-171-1/+0
| | | | | | | | | | | | | * Move admin.js to webpack, so that this use the bundled jquery files instead of the deprecated window.$ Also fixing formatting * Remove log.js that seems to be from a time where logreader was bundled with server and I couldn't find an usage of it anymore * Fix recent regression in rebuild navigation function (now not depending on jquery anymore and bundled by webpack). Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Setup warning for invalid LDAP user or group UUIDs.Arthur Schiwon2022-02-101-2/+16
| | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* show if the mail server settings are not set or verifiedszaimen2022-02-032-1/+31
| | | | Signed-off-by: szaimen <szaimen@e.mail.de>
* Avoid zero division in setup checksMichaIng2022-01-111-3/+12
| | | | | | Fixes: https://github.com/nextcloud/server/issues/30532 Signed-off-by: MichaIng <micha@dietpi.com>
* Enhance and complement OPcache setup checksMichaIng2021-12-191-24/+49
| | | | | | | | | | | | | | The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage. With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used. The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded. A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks. OPcache usage based checks are skipped when Nextcloud is not permitted to use the API. Signed-off-by: MichaIng <micha@dietpi.com>
* Make sure trusted_proxies is an arrayJoas Schilling2021-11-091-3/+7
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Show warning on admin settings pageVitor Mattos2021-10-231-1/+15
| | | | Signed-off-by: Vitor Mattos <vitor@php.rio>
* fix appstoreenabled check in Fetcher so it's coherent with AppSettingsControllerJulien Veyssier2021-10-181-1/+1
| | | | Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
* Deprecate PHP7.3 for Nextcloud 23Christoph Wurst2021-10-181-1/+1
| | | | | | | * 7.3 reaches EOL shortly after the release of 23.0.0 * Nextcloud 24 will require PHP7.4 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* add 'supported'-label to all supported apps, also if they are not downloaded yetBjoern Schiessle2021-10-061-0/+5
| | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* Add admin privilege delegation for admin settingsCarl Schwan2021-09-296-32/+108
| | | | | | | This makes it possible for selected groups to access some settings pages. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Issue 16719: CheckSetupController.php: now injecting reference to ↵Stefan2021-09-171-2/+7
| | | | | | ITempManager, rather than obtaining using it manually Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
* Issue 16719: CheckSetupController.php now checks configured temporary ↵Stefan2021-09-171-0/+11
| | | | | | directory for existence and if it's writable Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
* use specific email getter where necessaryArthur Schiwon2021-09-091-2/+2
| | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Only recommand for php-sodium on >= PHP 7.4Carl Schwan2021-08-061-1/+5
| | | | | | | | | | | | This is because php-sodium will solve the missing PASSWORD_ARGON2I constant problem only on >= php 7.4, previously argon2 wasn't part of the standard extension and was disabled on Centos/RHEL. So installing php-sodium on php 7.2 for example wouldn't hide the message. Tested on Fedora with php 7.4, Centos 7 with php 7.2, Centos 8 with php 7.2 and openSUSE with php 7.4. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Merge pull request #28259 from nextcloud/work/carl/sodium-checkChristoph Wurst2021-07-301-0/+4
|\ | | | | Check that php was compiled with argon2 support or that the php-sodium extensions is installed
| * Check that php was compiled with argon2 support or that the php-sodiumCarl Schwan2021-07-301-0/+4
| | | | | | | | | | | | extensions is installed Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* | refs #21045 add app config to disable unlimited quota and to set max quotaJulien Veyssier2021-07-291-1/+7
|/ | | | | | | | | avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed avoid getting/setting/displaying unlimited default quota if not allowed implement tests for unlimited quota restrictions Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
* Migrate HintException to OCPGary Kim2021-06-301-1/+1
| | | | Signed-off-by: Gary Kim <gary@garykim.dev>
* Update php licensesJohn Molakvoæ (skjnldsv)2021-06-0414-29/+19
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* l10n: Spelling unificationValdnet2021-06-021-1/+1
| | | | | | Spelling unification in Transifex. Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
* do not use private AccountManager in UsersControllerArthur Schiwon2021-05-251-98/+68
| | | | | | | | - extends IAccountProperty for verificationData getters and setters - implementation thereof ^ - and of course adaption of UsersController Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Harden apptoken checkRoeland Jago Douma2021-05-171-0/+20
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #26259 from ↵Joas Schilling2021-04-261-0/+3
|\ | | | | | | | | nextcloud/feature/noid/validate-website-to-be-valid Validate the website field input to be a valid URL
| * Validate the website field input to be a valid URLJoas Schilling2021-04-221-0/+3
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Fix deleting properties of user settings when not given explicitlyDaniel Calviño Sánchez2021-04-231-13/+39
| | | | | | | | | | | | | | | | | | | | The controller can receive an optional subset of the properties of the user settings; values not given are set to "null" by default. However, those null values overwrote the previously existing values, so in practice any value not given was deleted from the user settings. Now only non null values overwrite the previous values. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Fix TypeError when "email" is not given in the controller requestDaniel Calviño Sánchez2021-04-231-1/+1
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Respect additional user settings not covered by the controllerDaniel Calviño Sánchez2021-04-231-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "AccountManager::updateUser()" wipes previous user data with whichever user data is given (except for some adjustments, like resetting the verified status when needed). As the controller overrode the properties those properties would lose some of their attributes even if they are not affected by the changes made by the controller. Now the controller only modifies the attributes set ("value" and "scope") to prevent that. Note that with this change the controller no longer removes the "verified" status, but this is not a problem because, as mentioned, "AccountManager::updateUser()" resets them when needed (for example, when the value of the website property changes). This change is a previous step to fix overwritting properties with null values, and it will prevent the controller from making unexpected changes if more attributes are added in the future. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Use constants from interface rather than classDaniel Calviño Sánchez2021-04-231-2/+2
|/ | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhostRoeland Jago Douma2021-04-011-1/+1
|\ | | | | dont show trusted proxy warning when the proxy and remote are both localhost
| * dont show trusted proxy warning when the proxy and remote are both localhostRobin Appelman2021-02-121-1/+1
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | Make extra user profile fields always editableVincent Petry2021-03-261-10/+5
| | | | | | | | | | | | | | | | The fields for phone number, address, website and twitter are now editable regardless whether federated sharing and the lookup server are enabled or not. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* | Rename some parameters and methods to make the API more clearJoas Schilling2021-03-101-1/+1
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Also clear the knownUser when changing via the settings endpointJoas Schilling2021-03-101-1/+23
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #25862 from nextcloud/techdept/psalm/some_loggersRoeland Jago Douma2021-03-023-17/+22
|\ \ | | | | | | Move away some ILoggers
| * | Move away some ILoggersRoeland Jago Douma2021-03-023-17/+22
| | | | | | | | | | | | | | | | | | Makes psalm happier Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | Fix lying docblocksRoeland Jago Douma2021-03-011-5/+2
|/ / | | | | | | | | | | | | * typed the return * removed unneeded temp variable Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Bump nextcloud/coding-standard from 0.3.0 to 0.5.0dependabot-preview[bot]2021-02-181-1/+1
| | | | | | | | | | | | | | | | | | | | Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Some psalm fixes in the settings appRoeland Jago Douma2021-02-151-1/+1
| | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Revert "use the configured forwarded headers for the setup check"Roeland Jago Douma2021-02-131-8/+1
| |
* | use the configured forwarded headers for the setup checkRobin Appelman2021-02-121-1/+8
|/ | | | | | instead of always checking against the same header Signed-off-by: Robin Appelman <robin@icewind.nl>
* Migrate internal classes to the OCP db col typesChristoph Wurst2021-01-121-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-dbRoeland Jago Douma2021-01-111-1/+8
|\ | | | | Add setup check to verify that the used DB version is still supported…
| * Add setup check to verify that the used DB version is still supported in the ↵Morris Jobke2021-01-081-1/+8
| | | | | | | | | | | | next major release Signed-off-by: Morris Jobke <hey@morrisjobke.de>