aboutsummaryrefslogtreecommitdiffstats
path: root/apps/settings/lib
Commit message (Collapse)AuthorAgeFilesLines
* feat: add toggle for AI guest restrictionJana Peper2025-07-032-1/+3
| | | | Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
* chore: apply new CSFixer rulesFerdinand Thiessen2025-07-0130-23/+43
| | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
* Merge pull request #53671 from nextcloud/fix/read-only-share-downloadJohn Molakvoæ2025-07-011-0/+1
|\
| * feat(files_sharing): allow viewing files with download disabledskjnldsv2025-06-261-0/+1
| | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | Merge pull request #53429 from nextcloud/enh/opcache-checksFerdinand Thiessen2025-07-011-14/+12
|\ \ | | | | | | feat(settings): simplify OPcache checks
| * | feat(settings): simplify OPcache checksenh/opcache-checksMichaIng2025-06-251-14/+12
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For the overall OPcache size check, we currently compare used memory with free memory. However, `opcache.memory_consumption` is split into `used_memory`, `free_memory` and `wasted_memory`. When cached files change on disk, old entries are not replaced or removed, but remain as wasted memory, until the cache is actually full, and if their percentage is above `opcache.max_wasted_percentage`, which is 5% by default. When this happens, the engine is restarted, resetting the cache completely, like a `opcache_reset()` call. As long as we do not consider wasted cache, recommendations based on free memory can be false. To solve this, we could count wasted memory as free memory, if it is above `opcache.max_wasted_percentage`, as the engine will be restarted as soon as needed, freeing up this wasted space. On the other hand, wasted memory below the threshold permanently blocks the OPcache, which supports counting it as used memory. Depending on the situation, instead of raising OPcache size, it could be also advised to reduce `opcache.max_wasted_percentage`. But too frequent cache resets break its purpose as well. In my opinion, the matter is too complex to consider wasted cache correctly, and do precise recommendations, but we should focus on reducing false positives instead. What we know for sure is: if the cache is full (`$status['cache_full'] === true`), and the limit for cached keys has not been reached, the OPcache was too small to maintain free space, with wasted memory below the configured threshold, where it consumes memory permanently. Recommending to raise the OPcache size in this case, is hence as accurate as it gets. Even if 5% wasted cache could be freed, 95% used memory is still above the previous threshold for the setup check warning. And if `opcache.max_wasted_percentage` is above 5%, then the admin must have decided to change the default, deciding that system memory consumption has lower priority than preventing OPcache engine restarts. `cache_full` can be true as well if the limit for cached keys has been reached, hence we need to merge both checks. In this case `num_cached_keys` equals `max_cached_keys` exactly, hence it is easy to differentiale whether `opcache.max_accelerated_files` or `opcache.memory_consumption` needs to be raised to address the `cache_full` state. In practice, this change relaxes the checks: the respective limit needs to be reached 100% instead of 90%, to trigger a warning, eliminating also false alarms if a large share of the cache is consumed by wasted memory, which would be automatically freed once cache is 100% full. Additionally, the recommendation for raising `opcache.max_accelerated_files` now says "a value higher than `max_cached_keys`", instead of "higher than `opcache.max_accelerated_files`". The actual limit, reflected by `max_cached_keys` from `opcache_get_status()`, [is a next higher value from a set of prime numbers](https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.max-accelerated-files). E.g. if `opcache.max_accelerated_files` is set to 10,000 (PHP default), the effective limit is 16,229 OPcache keys. Recommending "higher than 10000" could hence lead to a settings change without effect. For an effective change, the new value needs to be "higher than 16229" instead, which is what the setup check will show in this situation, with this change applied. Signed-off-by: MichaIng <micha@dietpi.com>
* | Merge branch 'master' into remove-x-xss-protectionJoas Schilling2025-06-301-4/+1
|\ \
| * | fix(settings): use correct scope for translationsfix/settings-l10nFerdinand Thiessen2025-06-261-4/+1
| |/ | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* / Fix: Remove X-XSS-Protection use, check and recommendationinvario2025-06-131-5/+0
|/ | | | | Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: invario <67800603+invario@users.noreply.github.com>
* feat: add support for sensitive Declarative settings values encryptionAndrey Borysenko2025-05-283-0/+49
| | | | Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
* chore(18n): More natural english - fix plural typorakekniven-patch-2rakekniven2025-05-251-1/+1
| | | Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
* fix(l10n): Fix one more pluralJoas Schilling2025-05-231-1/+1
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix: Correct translation method useMarcel Klehr2025-05-231-2/+2
| | | | Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* fix(SetupChecks): Update TaskProcessingPickupSpeedrakekniven2025-05-231-1/+1
| | | | Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
* chore(18n): More natural englishrakekniven2025-05-231-2/+2
| | | | | Reported at Transifex. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
* feat(SetupChecks): Add check for TaskProcessing pickup speedfeat/setupcheck-task-pickup-speedMarcel Klehr2025-05-222-0/+65
| | | | Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* refactor: Extend rector to core/refactor/rector-coreprovokateurin2025-05-151-4/+1
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* refactor: Apply rector refactoringschore/deps/rector-2.0provokateurin2025-05-142-3/+5
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* chore: replace leagcy OC_Helper calls with OCP\Utilchore/oc-helper-filesizeFerdinand Thiessen2025-05-141-2/+2
| | | | | | | | - Replace legacy calls with OCP\Util - Add missing deprecation notices - Inline implementation in OCP\Util and call it from OC_Helper Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* chore: compile assetsfix/group-admin-new-userFerdinand Thiessen2025-04-271-2/+2
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(settings): group admins only can add users to their groupsFerdinand Thiessen2025-04-271-9/+12
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* feat(settings): provide user groups for accounts listFerdinand Thiessen2025-04-271-0/+7
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(settings): Handle email change restriction separately from display name ↵provokateurin2025-04-021-0/+1
| | | | | | | | | change restriction Co-authored-by: provokateurin <kate@provokateurin.de> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Louis <louis@chmn.me> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* chore(i18n): Aligned grammarrakekniven2025-03-311-1/+1
| | | Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
* perf(settings): Remove computation of all groupsChristopher Ng2025-03-281-3/+10
| | | | Signed-off-by: Christopher Ng <chrng8@gmail.com>
* fix(webauthn): do not require bcmath or gmp - not needed anymoreFerdinand Thiessen2025-03-192-5/+2
| | | | | | | | The extensions are not required anymore but only recommended for performance. See also: https://github.com/web-auth/webauthn-framework/issues/213 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Merge pull request #51378 from nextcloud/fix/lookup-server-connector-v2Ferdinand Thiessen2025-03-111-3/+5
|\ | | | | fix(lookup-server): disable when not using global scale
| * fix(lookup-server): disable lookup server for non-global scale setupsFerdinand Thiessen2025-03-111-3/+5
| | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
| * fix(lookup-server): do not upload data by defaultFerdinand Thiessen2025-03-111-1/+1
| | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix(AppDiscover): Ensure created cache folder is safe-chars onlyappStoreCacheFolderGit'Fellow2025-03-101-1/+3
|/ | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* chore: Move magic number into a documented constfix/fix-disabled-user-list-for-saml-subadminCôme Chilliet2025-03-101-1/+3
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix: Correctly count disabled users for SAML groups subadminsCôme Chilliet2025-03-101-12/+4
| | | | | | If too many users return -1 as for LDAP so that link is shown Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix(systemtags): unify restrict_creation_to_admin handlingskjnldsv2025-03-061-1/+1
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix: Change SQL query so that it is ansi safeJohan Bernhardsson2025-02-271-3/+3
| | | | Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>
* fix(l10n): Improve english source stringsJoas Schilling2025-02-262-2/+2
| | | | | | | - No leading/trailing whitespace - Use asci single quote Signed-off-by: Joas Schilling <coding@schilljs.com>
* feat(setupcheck): check logging level for validityfeat/setup-check-loggingFerdinand Thiessen2025-02-221-0/+55
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Merge pull request #50779 from nextcloud/chore/mailer-testsFerdinand Thiessen2025-02-181-2/+3
|\ | | | | test(Mailer): Align tests for mailer with stable30
| * test(Mailer): Align tests for mailer with stable30chore/mailer-testsJosh2025-02-121-2/+3
| | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix(settings): Inject subadmin manager and adapt tests, resolve a FIXME commentCôme Chilliet2025-02-132-23/+18
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | chore: Apply new rector configuration to apps folderCôme Chilliet2025-02-134-6/+12
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | chore: re-apply current rector configuration to apps folderCôme Chilliet2025-02-131-1/+2
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUserCôme Chilliet2025-02-131-2/+2
|/ | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix(emailTemplate): use instance Name instead of Url in subjectuseNameNotUrlGit'Fellow2025-02-121-1/+2
| | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* fix(setupcheck): Update setup check for PHP version to be more accuratebugfix/noid/bump-php-dependency-update-versionsJoas Schilling2025-02-101-1/+12
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix(provisioning_api): Correct limit for `editUser`Ferdinand Thiessen2025-02-061-0/+2
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Merge pull request #50281 from ↵Andy Scherzinger2025-01-301-1/+3
|\ | | | | | | | | nextcloud/fix/fix-email-setupcheck-with-null-smtpmode fix(settings): Fix setup check when mail_smptmode is set to "null"
| * fix(settings): Fix setup check when mail_smptmode is set to "null"fix/fix-email-setupcheck-with-null-smtpmodeCôme Chilliet2025-01-201-1/+3
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | Merge pull request #50425 from nextcloud/fix/openapi/outdated-specsAndy Scherzinger2025-01-261-0/+2
|\ \ | | | | | | Fix outdated OpenAPI specs
| * | fix(settings): Add back adminstration scope for LogSettingsControllerfix/openapi/outdated-specsprovokateurin2025-01-251-0/+2
| | | | | | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | | fix(settings): Add some context to the PHP memory limit errorjtr-settings-memory-limit-detailsJosh2025-01-261-1/+1
| | | | | | | | | Signed-off-by: Josh <josh.t.richards@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-08-07 13:26:52 +0000