summaryrefslogtreecommitdiffstats
path: root/apps
Commit message (Collapse)AuthorAgeFilesLines
* Do not run fragile TrashbinTestMorris Jobke2019-03-131-2/+4
| | | | | | | | | | | | | | | | | | | | Fails with: There was 1 failure: 1) TrashbinTest::testExpireOldFiles Failed asserting that null is identical to 'file2.txt'. /drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186 OR 1) TrashbinTest::testExpireOldFiles Failed asserting that null is identical to 'file2.txt'. /drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:193 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Merge pull request #6512 from coletivoEITA/add_circles_sharing_to_caldavMorris Jobke2019-03-1314-8/+114
|\ | | | | Change CALDAV to allow calendars be shared with circles.
| * Fix PHPUnitMorris Jobke2019-03-121-0/+2
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| * Fix PHPUnitMorris Jobke2019-03-121-0/+2
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| * Use proper dependency injection for app managerMorris Jobke2019-03-058-7/+26
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| * Fix whitespaceMorris Jobke2019-03-051-1/+1
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| * Suppress phan exceptions because they are catched by a class_existsMorris Jobke2019-03-051-0/+3
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| * use class_exists on correct class to please phanGeorg Ehrke2019-03-041-2/+2
| | | | | | | | Signed-off-by: Georg Ehrke <developer@georgehrke.com>
| * properly catch exceptions of detailsCircleGeorg Ehrke2019-03-031-1/+9
| | | | | | | | Signed-off-by: Georg Ehrke <developer@georgehrke.com>
| * Get user's circles without touching sessionVinicius Cubas Brand2019-03-011-6/+1
| | | | | | | | | | | | This works with nextcloud/circles#260 Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
| * allow sharing addressbooks with circlesGeorg Ehrke2019-03-012-3/+4
| | | | | | | | Signed-off-by: Georg Ehrke <developer@georgehrke.com>
| * Share calendar to circleVinicius Cubas Brand2019-03-014-2/+78
| | | | | | | | | | | | | | * Allow user to share calendar with a circle * Allow user to see calendars shared with his/her circles Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
* | Fix display of i in personal settingsMorris Jobke2019-03-111-0/+4
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Add hint to user documentation (Federation)Marius Blüm2019-03-111-0/+3
| | | | | | | | Signed-off-by: Marius Blüm <marius@lineone.io>
* | Merge pull request #14548 from ↵Morris Jobke2019-03-082-20/+3
|\ \ | | | | | | | | | | | | nextcloud/bugfix/noid/avoid-duplicate-container-creation Avoid duplicate App container creation
| * | "Fix" the unit testsJoas Schilling2019-03-062-20/+3
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #14585 from nextcloud/ocm-mention-federationMorris Jobke2019-03-081-1/+1
|\ \ \ | | | | | | | | Mention Open Cloud Mesh in Federated User Settings
| * | | Mention Open Cloud Mesh in Federated User SettingsMarius Blüm2019-03-071-1/+1
| | | | | | | | | | | | Signed-off-by: Marius Blüm <marius@lineone.io>
* | | | Merge pull request #14583 from nextcloud/remove-g+-federationMorris Jobke2019-03-083-8/+0
|\ \ \ \ | | | | | | | | | | Remove Google+ federation usersettings
| * | | | Remove G+ CSS rule (Feedback from Joas)Marius Blüm2019-03-071-3/+0
| | | | | | | | | | | | | | | Signed-off-by: Marius Blüm <marius@lineone.io>
| * | | | Remove G+ code from Federated Files Sharing-usersettingsMarius Blüm2019-03-071-4/+0
| | | | | | | | | | | | | | | Signed-off-by: Marius Blüm <marius@lineone.io>
| * | | | Remove G+ icon from Federated Files Sharing-usersettingsMarius Blüm2019-03-071-1/+0
| |/ / / | | | | | | | | Signed-off-by: Marius Blüm <marius@lineone.io>
* | | | Merge pull request #14464 from nextcloud/fix/noid/ldap-nested-group-filterblizzz2019-03-073-79/+121
|\ \ \ \ | |/ / / |/| | | resolve user and groups in nested groups first before filtering the results
| * | | remove unused use statementArthur Schiwon2019-03-061-1/+0
| | | | | | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | | fix nested group retrieval also for 2 other casesArthur Schiwon2019-03-053-84/+111
| | | | | | | | | | | | | | | | | | | | | | | | and also consolidate logic in one method Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | | Fixed unit test: groupsMatchFilter will not be called multiple times anymore.Roland Tapken2019-03-051-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
| * | | Reduce queries to LDAP by caching nested groupsRoland Tapken2019-03-051-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Nested groups are now cached in a CappedMemoryCache object to reduce queries to the LDAP backend. Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
| * | | user_ldap: really resolve nested groupsRoland Tapken2019-03-051-14/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous patch fixed the problem only for one level of indirection because groupsMatchFilter() had been applied on each recursive call (and thus there would be no second level if the first level fails the check). This new implementation replaces the recursive call with a stack that iterates all nested groups before filtering with groupsMatchFilter(). Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
| * | | user_ldap: Filter groups after nexted groupsRoland Tapken2019-03-051-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently groupsMatchFilter is called before nested groups are resolved. This basicly breaks this feature since it is not possible to inherit membership in a group from another group. Minimal example: Group filter: (&(objectClass=group),(cn=nextcloud)) Nested groups: enabled cn=nextcloud,ou=Nextcloud,ou=groups,dn=company,dn=local objectClass: group cn=IT,ou=groups,dn=company,dn=local objectClass: group memberOf: cn=nextcloud,ou=Nextcloud,ou=groups,dn=company,dn=local cn=John Doe,ou=users,dn=company,dn=local objectClass: person memberOf: cn=IT,ou=groups,dn=company,dn=local Since 'cn=IT,ou=groups,dn=company,dn=local' doesn't match the group filter, John wouldn't be a member of group 'nextcloud'. This patch fixes this by filtering the groups after all nested groups have been collected. If nested groups is disabled the result will be the same as without this patch. Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
* | | | Merge pull request #14579 from nextcloud/fix/bump_streams_files_externalRoeland Jago Douma2019-03-074-16/+28
|\ \ \ \ | | | | | | | | | | Have streams of files_external in sync
| * | | | Have streams of files_external in syncRoeland Jago Douma2019-03-074-16/+28
| | |/ / | |/| | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | Fix transifex sync for files_sharingMorris Jobke2019-03-061-2/+2
| | | | | | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | | Update generated webpack files to .l10nignoreMorris Jobke2019-03-061-0/+4
| | | | | | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | | Merge pull request #14558 from nextcloud/fix/13790/fix-commentMorris Jobke2019-03-061-1/+1
|\ \ \ \ | | | | | | | | | | Fix unnecessary boolean cast
| * | | | Fix unnecessary boolean castMorris Jobke2019-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | | | Merge pull request #14553 from ↵Morris Jobke2019-03-067-2/+223
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | nextcloud/fix/14125/clear_backupcode_reminder_when_no_2fa Clear backupcode reminder when no 2fa
| * | | | Do not send notification if no active 2faRoeland Jago Douma2019-03-052-2/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the job is still present we should also not fire it off if there is not a single active 2FA provider. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * | | | Clear backupcodes reminder if no 2FA is enabledRoeland Jago Douma2019-03-055-0/+184
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #14125 Listen to 2FA disable event. If a provider is disabled for a user. We check if there are no more providers. If there are no more providers we Remove the backupcode reminder notification (if still present). Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | Merge pull request #13790 from fretn/masterMorris Jobke2019-03-061-1/+1
|\ \ \ \ | |/ / / |/| | | Fix for crashing occ files:scan
| * | | Fix for crashing occ files:scanfretn2019-01-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when $share === false then (int)$share['share_type'] will always be equal to (int)0 which results in following crash: [root@server nextcloud] sudo -u apache php occ files:scan someuser The current PHP memory limit is below the recommended value of 512MB. Starting scan for user 1 out of 1 (someuser) An unhandled exception has been thrown: TypeError: Argument 1 passed to OC\OCS\DiscoveryService::discover() must be of the type string, null given, called in /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php on line 382 and defined in /var/www/html/nextcloud/lib/private/OCS/DiscoveryService.php:65 Stack trace: 0 /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php(382): OC\OCS\DiscoveryService->discover(NULL, 'FEDERATED_SHARI...') 1 /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php(527): OCA\Files_Sharing\External\Manager->sendFeedbackToRemote(NULL, NULL, NULL, 'decline') 2 /var/www/html/nextcloud/apps/files_sharing/lib/External/Storage.php(216): OCA\Files_Sharing\External\Manager->removeShare('files/Someth...') 3 [internal function]: OCA\Files_Sharing\External\Storage->checkStorageAvailability() 4 /var/www/html/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php(505): call_user_func_array(Array, Array) 5 [internal function]: OC\Files\Storage\Wrapper\Wrapper->__call('checkStorageAva...', Array) 6 /var/www/html/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php(505): call_user_func_array(Array, Array) 7 /var/www/html/nextcloud/apps/files_sharing/lib/External/Scanner.php(89): OC\Files\Storage\Wrapper\Wrapper->__call('checkStorageAva...', Array) 8 /var/www/html/nextcloud/apps/files_sharing/lib/External/Scanner.php(44): OCA\Files_Sharing\External\Scanner->scanAll() 9 /var/www/html/nextcloud/lib/private/Files/Utils/Scanner.php(245): OCA\Files_Sharing\External\Scanner->scan('', true, 3) 10 /var/www/html/nextcloud/apps/files/lib/Command/Scan.php(172): OC\Files\Utils\Scanner->scan('/someuser', true, NULL) 11 /var/www/html/nextcloud/apps/files/lib/Command/Scan.php(249): OCA\Files\Command\Scan->scanFiles('someuser', '/someuser', false, Object(Symfony\Component\Console\Output\ConsoleOutput), false, true, false) 12 /var/www/html/nextcloud/3rdparty/symfony/console/Command/Command.php(251): OCA\Files\Command\Scan->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) 13 /var/www/html/nextcloud/core/Command/Base.php(162): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) 14 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(946): OC\Core\Command\Base->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) 15 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(248): Symfony\Component\Console\Application->doRunCommand(Object(OCA\Files\Command\Scan), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) 16 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(148): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) 17 /var/www/html/nextcloud/lib/private/Console/Application.php(213): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) 18 /var/www/html/nextcloud/console.php(96): OC\Console\Application->run() 19 /var/www/html/nextcloud/occ(11): require_once('/var/www/html/n...') 20 {main}[root@server nextcloud] Signed-off-by: fretn <frederikdelaere+github@gmail.com>
* | | | Check if password can be changed for the users backend in OCS apiJulius Härtl2019-03-052-0/+7
| |/ / |/| | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | | Fix missing $config dependency in RetryJobMorris Jobke2019-03-051-0/+3
| | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | Merge pull request #14519 from nextcloud/feature/config-undefinedMorris Jobke2019-03-051-1/+1
|\ \ \ | | | | | | | | Fix Undefined property: OCA\LookupServerConnector\UpdateLookupServer::$config
| * | | Fix Undefined property: OCA\LookupServerConnector\UpdateLookupServer::$configDaniel Kesselberg2019-03-041-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | | | Merge pull request #14470 from felixn/masterMorris Jobke2019-03-051-6/+9
|\ \ \ \ | | | | | | | | | | use node API for free space calculation in versions app
| * | | | set availableSpace to 0 if userFolder not foundFelix Nieuwenhuizen2019-03-021-6/+7
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Felix Nieuwenhuizen <felix@tdlrali.com>
| * | | | use node API for free space calculation in versions app (same method as ↵Felix Nieuwenhuizen2019-03-021-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | trashbin app) Signed-off-by: Felix Nieuwenhuizen <felix@tdlrali.com>
* | | | | Merge pull request #14480 from cowai/reconnect-db-notifyRoeland Jago Douma2019-03-041-11/+56
|\ \ \ \ \ | | | | | | | | | | | | Reconnect to DB after timeout for Notify command. Fixes #14479
| * | | | | Correct log attributeAri Selseng2019-03-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Ari Selseng <ari@selseng.net>
| * | | | | Added logging to Notify command.Ari Selseng2019-03-041-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Ari Selseng <ari@selseng.net>