summaryrefslogtreecommitdiffstats
path: root/core/ajax
Commit message (Collapse)AuthorAgeFilesLines
* Happy new year!Thomas Müller2016-01-124-6/+5
|
* don't show previous log level in upgrade messageBjörn Schießle2016-01-041-2/+2
|
* User IUser::getEMailAddress() all over the placeThomas Müller2015-12-021-7/+13
|
* Add code integrity checkLukas Reschke2015-12-011-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository. Furthermore, there is a basic implementation to display problems with the code integrity on the update screen. Code signing basically happens the following way: - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates. - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID. - The command generates a signature.json file of the following format: ```json { "hashes": { "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d", "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9" }, "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----", "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl" } ``` `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`. Steps to do in other PRs, this is already a quite huge one: - Add nag screen in case the code check fails to ensure that administrators are aware of this. - Add code verification also to OCC upgrade and unify display code more. - Add enforced code verification to apps shipped from the appstore with a level of "official" - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release - Add some developer documentation on how devs can request their own certificate - Check when installing ownCloud - Add support for CRLs to allow revoking certificates **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature: ``` ➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt Successfully signed "core" ``` Then increase the version and you should see something like the following: ![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png) As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen. For packaging stable releases this requires the following additional steps as a last action before zipping: 1. Run `./occ integrity:sign-core` once 2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
* Replace some OC_Config calls with ILogger methodsMorris Jobke2015-10-301-3/+4
|
* Remove invalid type-castLukas Reschke2015-10-291-4/+4
| | | | | | This is an `is_array` operation and not a `in_array` one. Thus this typecast is not required. Fixes https://github.com/owncloud/core/issues/20095
* Revert "setting to skip migration tests by default"Morris Jobke2015-10-271-10/+1
| | | | This reverts commit 7cbdd9b90bcea3566b7d0198f23da3d427e6ef45.
* Update license headersLukas Reschke2015-10-262-1/+2
|
* Fix for broken ajax/share.php endpointRoeland Jago Douma2015-10-231-3/+23
| | | | | Even more code mess :( All tests pass again. But I'm really not happy with this endpoint.
* Merge pull request #19918 from owncloud/send-begin-messageThomas Müller2015-10-211-0/+12
|\ | | | | Update: state which step we are going to start and warn if it might b…
| * Update: state which step we are going to start and warn if it might be slowJoas Schilling2015-10-211-0/+12
| |
* | Update - Only add one section for disabled appsJoas Schilling2015-10-211-6/+9
|/
* update licence headers via scriptMorris Jobke2015-10-052-0/+2
|
* Merge pull request #19508 from owncloud/setting-to-skip-migration-testsThomas Müller2015-10-021-1/+10
|\ | | | | setting to skip migration tests by default
| * setting to skip migration tests by defaultMorris Jobke2015-10-011-1/+10
| | | | | | | | | | | | | | * if you install owncloud via package it is not possible to skip migration tests * this also allows to disable migration tests for an instance by default
* | allow passing the fileinfo to the preview managerRobin Appelman2015-10-011-1/+1
|/
* Change small thumbnails to 32 pxMorris Jobke2015-09-301-2/+2
| | | | | * fixes #16913 * fixes issues in IE8 where the thumbnail is too big
* [upgrade] switch to debug logging on upgradeMorris Jobke2015-09-291-0/+6
| | | | | * resets afterwards * adds output about the previous log level
* Merge pull request #13145 from owncloud/issue/11951-activity-sharing-emailThomas Müller2015-09-251-0/+31
|\ | | | | Publish an activity when sending a share link via email
| * Publish an activity when sending a share link via emailJoas Schilling2015-09-221-0/+31
| |
* | Add option to disable autocomplete in share dialogMorris Jobke2015-09-231-0/+10
|/
* Allow creating previewss that cover the specified dimensionsRobin Appelman2015-09-021-0/+2
|
* Properly show update exceptionVincent Petry2015-08-261-1/+7
|
* Properly show token errors in ajax/update.php event sourceVincent Petry2015-08-261-5/+13
|
* Merge pull request #17565 from owncloud/fix/remote_shareRoeland Douma2015-07-131-1/+1
|\ | | | | allow remote shares for users with email as usernames
| * allow remote shares for users with email as usernamesFelix Böhm2015-07-101-1/+1
| |
* | Remove 3rd party text for disabled apps on updateVincent Petry2015-07-071-1/+1
| |
* | Remove OC_LogThomas Müller2015-07-032-3/+4
| |
* | Merge pull request #17163 from owncloud/update-licensesLukas Reschke2015-06-273-2/+3
|\ \ | | | | | | Update license headers
| * | update license headers and authorsMorris Jobke2015-06-253-2/+3
| | |
* | | Merge pull request #17008 from owncloud/fix-17006Björn Schießle2015-06-261-0/+2
|\ \ \ | | | | | | | | Improve splitting of username and remote adress when username contains an `@`
| * | | Use \OC\HintException and translate the hintJoas Schilling2015-06-221-0/+2
| |/ /
* | | Merge pull request #17165 from ↵Thomas Müller2015-06-261-0/+16
|\ \ \ | | | | | | | | | | | | | | | | owncloud/federated_cloud_sharing_search_address_book Search address book for federated cloud id
| * | | search address book for federated cloud idBjoern Schiessle2015-06-251-0/+16
| |/ /
* / / Fix for #17178Roeland Jago Douma2015-06-251-2/+9
|/ / | | | | | | | | | | If no array of arrays is submitted make sure we still keep $sharedUsers and $sharedGroups as arrays so the rest of the code keeps functioning as it should.
* | Merge pull request #16434 from owncloud/persist-maintenance-stateThomas Müller2015-06-031-2/+5
|\ \ | | | | | | Persist the state of the maintenance after an upgrade
| * | Persist the state of the maintenance after an upgradeMorris Jobke2015-05-191-2/+5
| | | | | | | | | | | | | | | | | | * if maintenance mode was enabled before an upgrade it will be enabled afterwards too * fixes #16429
* | | add support for limit request parameter to getShareWithCraig Morrissey2015-05-151-3/+5
|/ /
* | Use internally \OCP\ILogger instead of \OC\LogMorris Jobke2015-04-301-1/+1
| | | | | | | | | | | | * this is the preparation for some upcoming logger related changes * also fixes an issue in the public interface where we request an internal class as parameter
* | Add "Reply-To" support to sharing mails and refactor codeLukas Reschke2015-04-101-2/+16
| |
* | Merge pull request #15182 from rullzer/fix-8231Thomas Müller2015-04-101-0/+17
|\ \ | | | | | | ajax/share.php should return correct list of suggestions
| * | Make sure we do not return people that we already shared withRoeland Jago Douma2015-03-251-0/+17
| | | | | | | | | | | | | | | We should use the provided list of users and groups that we already shared with to filter suggestions.
* | | Merge pull request #15169 from rullzer/fix_displayNamesInGroupMorris Jobke2015-03-301-1/+1
|\ \ \ | | | | | | | | Groupmanagers displayNamesInGroup should actually search in displaynames
| * | | Call the proper functionRoeland Jago Douma2015-03-241-1/+1
| |/ / | | | | | | | | | * Fix for #6967
* / / Update license headersJenkins for ownCloud2015-03-264-25/+99
|/ /
* / Use the PreviewManager where possibleJoas Schilling2015-03-161-3/+2
|/
* Merge pull request #13513 from owncloud/repair-legacystoragenofatalfailMorris Jobke2015-03-111-0/+6
|\ | | | | Do not abort when meeting unfixable legacy storages
| * Properly forward repair errors and warningsVincent Petry2015-02-271-0/+6
| | | | | | | | | | This makes repair errors and warnings visible for the user when upgrading on the command line or in the web UI.
* | Verify CSRF token already in update.php and not the EventSource codeLukas Reschke2015-03-091-0/+2
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Issue report: > Hum, well I upgraded the package then visited the web interface to trigger the update and it failed; the UI would say there was a possible CSRF attack and after that it'd be stuck in maintenance mode. Tried a few times (by editing maintenance to false in owncloud.conf) and same result each time. That smells partially like an issue caused by our EventSource implementation, due to legacy concerns the CSRF verification happens within the EventSource handling and not when the actual endpoint is called, what happens here then is: 1. User has somehow an invalid CSRF token in session (or none at all) 2. User clicks the update button 3. Invalid CSRF token is sent to update.php - no CSRF check there => Instance gets set in maintenance mode 4. Invalid CSRF token is processed by the EventSource code => Code Execution is stopped and ownCloud is stuck in maintenance mode I have a work-around for this problem, basically it verifies the CSRF token already in step 3 and cancels execution then. The same error will be shown to the user however he can work around it by refreshing the page – as stated by the error. I think that’s an acceptable behaviour for now: INSERT LINK To verify this test: 1. Delete your ownCloud cookies 2. Increment the version in version.php 3. Try to upgrade => Before the patch: Instance shows an error, is set to upgrade mode and a refresh does not help => After the patch: Instance shows an error, a refresh helps though. This is not really the best fix as a better solution would be to catch such situations when bootstrapping ownCloud, however, I don’t dare to touch base.php for this sake only, you never know what breaks then… That said: There might be other bugs as well, especially the stacktrace is somewhat confusing but then again it installing ownCloud under /usr/share/owncloud/ and I bet that is part of the whole issue ;-)
* Revert "Updating license headers"Morris Jobke2015-02-264-97/+27
| | | | This reverts commit 6a1a4880f0d556fb090f19a5019fec31916f5c36.
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-28 20:49:22 +0000