| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue report:
> Hum, well I upgraded the package then visited the web interface to
trigger the update and it failed; the UI would say there was a
possible CSRF attack and after that it'd be stuck in maintenance mode.
Tried a few times (by editing maintenance to false in owncloud.conf)
and same result each time.
That smells partially like an issue caused by our EventSource implementation, due to legacy concerns the CSRF verification happens within the EventSource handling and not when the actual endpoint is called, what happens here then is:
1. User has somehow an invalid CSRF token in session (or none at all)
2. User clicks the update button
3. Invalid CSRF token is sent to update.php - no CSRF check there => Instance gets set in maintenance mode
4. Invalid CSRF token is processed by the EventSource code => Code Execution is stopped and ownCloud is stuck in maintenance mode
I have a work-around for this problem, basically it verifies the CSRF token already in step 3 and cancels execution then. The same error will be shown to the user however he can work around it by refreshing the page – as stated by the error. I think that’s an acceptable behaviour for now: INSERT LINK
To verify this test:
1. Delete your ownCloud cookies
2. Increment the version in version.php
3. Try to upgrade
=> Before the patch: Instance shows an error, is set to upgrade mode and a refresh does not help
=> After the patch: Instance shows an error, a refresh helps though.
This is not really the best fix as a better solution would be to catch such situations when bootstrapping ownCloud, however, I don’t dare to touch base.php for this sake only, you never know what breaks then…
That said: There might be other bugs as well, especially the stacktrace is somewhat confusing but then again it installing ownCloud under /usr/share/owncloud/ and I bet that is part of the whole issue ;-)
|
|\
| |
| | |
Convert 'abcpassword' to 'abcpass' during setup
|
| |
| |
| |
| |
| | |
This allows autoconfig files to use 'dbpassword' instead of 'dbpass', which
is more consistent with config.php
|
| | |
|
|/ |
|
| |
|
| |
|
|\
| |
| | |
Avatars in share dialog fixes
|
| |
| |
| |
| |
| |
| |
| | |
* Avatar for "xxxx share with you..." to the left
* Avatars for groups and remote shares (use default placeholder)
* Modified and added unit tests
* Use the same css for all the avatars in the dropdown
|
|\ \
| | |
| | |
| | |
| | | |
owncloud/add-some-headers-to-htaccess-for-my-best-friend-jenkins
Let users configure security headers in their Webserver
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Doing this in the PHP code is not the right approach for multiple reasons:
1. A bug in the PHP code prevents them from being added to the response.
2. They are only added when something is served via PHP and not in other cases (that makes for example the newest IE UXSS which is not yet patched by Microsoft exploitable on ownCloud)
3. Some headers such as the Strict-Transport-Security might require custom modifications by administrators. This was not possible before and lead to buggy situations.
This pull request moves those headers out of the PHP code and adds a security check to the admin settings performed via JS.
|
| | | |
|
|\ \ \
| |_|/
|/| | |
fix for loading spinner reappearing after errors in db-connection
|
| |/ |
|
| | |
|
|\ \
| |/
|/| |
Allow configuring background job mode from the console
|
| | |
|
| | |
|
| | |
|
|/ |
|
| |
|
|\
| |
| | |
Use custom attribute instead of the div identifier
|
| |
| |
| |
| |
| |
| | |
Otherwise problems arrive when a username contains characters such as an `@`
Fixes https://github.com/owncloud/user_shibboleth/issues/38
|
|/ |
|
|\
| |
| | |
Revert "Updating license headers"
|
| |
| |
| |
| | |
This reverts commit 6a1a4880f0d556fb090f19a5019fec31916f5c36.
|
| | |
|
|\ \
| | |
| | | |
Append search results to custom container
|
| | | |
|
| | |
| | |
| | |
| | | |
fixes #13968
|
|\ \ \
| |_|/
|/| | |
Remove dependency from arbitrary data object structure for easier usage
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Message clean-up
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
**Changes:**
* In line 103, the middle "c" of "owncloud" is capitalised to "ownCloud".
* A space is inserted between value and unit in lines 177 and 187 ("4 GB" instead of "4GB").
|
| | | |
| | | |
| | | | |
Changed *"won't work"* to "will not work" (as proposed by @DeepDiver1975).
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
*Changes:*
* "… is not yet properly setup" in line 24 is changed to " … is not yet set up properly" (better word order and space in the middle of "set up", as it is a participle of the verb "to set up").
* "internet" is corrected to "Internet" with a capitalized "I" in lines 54 and 59.
* Also in line 54: "3rd party" is changed to "third-party" to for a more coherent spelling across the different ownCloud components.
* "… apps don´t work" is corrected to "… apps won't work" (with a proper (and hopefully correctly escaped) (apostrophe)[http://en.wikipedia.org/wiki/Apostrophe#Typographic_form] instead of the (acute accent)[http://en.wikipedia.org/wiki/Acute_accent]).
* Still in line 54: The negation is corrected from "… might also not work" to "… might not work, either".
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Make the password changed msg inline to fix #10242
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Setup command
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Make the search box filter apps
|