summaryrefslogtreecommitdiffstats
path: root/core
Commit message (Collapse)AuthorAgeFilesLines
* [tx-robot] updated from transifexJenkins for ownCloud2015-03-102-2/+50
|
* Verify CSRF token already in update.php and not the EventSource codeLukas Reschke2015-03-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Issue report: > Hum, well I upgraded the package then visited the web interface to trigger the update and it failed; the UI would say there was a possible CSRF attack and after that it'd be stuck in maintenance mode. Tried a few times (by editing maintenance to false in owncloud.conf) and same result each time. That smells partially like an issue caused by our EventSource implementation, due to legacy concerns the CSRF verification happens within the EventSource handling and not when the actual endpoint is called, what happens here then is: 1. User has somehow an invalid CSRF token in session (or none at all) 2. User clicks the update button 3. Invalid CSRF token is sent to update.php - no CSRF check there => Instance gets set in maintenance mode 4. Invalid CSRF token is processed by the EventSource code => Code Execution is stopped and ownCloud is stuck in maintenance mode I have a work-around for this problem, basically it verifies the CSRF token already in step 3 and cancels execution then. The same error will be shown to the user however he can work around it by refreshing the page – as stated by the error. I think that’s an acceptable behaviour for now: INSERT LINK To verify this test: 1. Delete your ownCloud cookies 2. Increment the version in version.php 3. Try to upgrade => Before the patch: Instance shows an error, is set to upgrade mode and a refresh does not help => After the patch: Instance shows an error, a refresh helps though. This is not really the best fix as a better solution would be to catch such situations when bootstrapping ownCloud, however, I don’t dare to touch base.php for this sake only, you never know what breaks then… That said: There might be other bugs as well, especially the stacktrace is somewhat confusing but then again it installing ownCloud under /usr/share/owncloud/ and I bet that is part of the whole issue ;-)
* Merge pull request #14743 from owncloud/autoconfig-passwordMorris Jobke2015-03-091-0/+8
|\ | | | | Convert 'abcpassword' to 'abcpass' during setup
| * Convert 'abcpassword' to 'abcpass' during setupRobin McCorkell2015-03-071-0/+8
| | | | | | | | | | This allows autoconfig files to use 'dbpassword' instead of 'dbpass', which is more consistent with config.php
* | [tx-robot] updated from transifexJenkins for ownCloud2015-03-098-54/+184
| |
* | [tx-robot] updated from transifexJenkins for ownCloud2015-03-0810-10/+30
|/
* [tx-robot] updated from transifexJenkins for ownCloud2015-03-0712-4/+24
|
* [tx-robot] updated from transifexJenkins for ownCloud2015-03-0616-0/+56
|
* Merge pull request #14582 from rullzer/avatar_fixesMorris Jobke2015-03-044-37/+72
|\ | | | | Avatars in share dialog fixes
| * Avatars in share dialog fixesRoeland Jago Douma2015-03-034-37/+72
| | | | | | | | | | | | | | * Avatar for "xxxx share with you..." to the left * Avatars for groups and remote shares (use default placeholder) * Modified and added unit tests * Use the same css for all the avatars in the dropdown
* | Merge pull request #14651 from ↵Morris Jobke2015-03-044-1/+441
|\ \ | | | | | | | | | | | | owncloud/add-some-headers-to-htaccess-for-my-best-friend-jenkins Let users configure security headers in their Webserver
| * | Added missing done() calls for async testsVincent Petry2015-03-031-20/+31
| | |
| * | Let users configure security headers in their WebserverLukas Reschke2015-03-024-1/+430
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doing this in the PHP code is not the right approach for multiple reasons: 1. A bug in the PHP code prevents them from being added to the response. 2. They are only added when something is served via PHP and not in other cases (that makes for example the newest IE UXSS which is not yet patched by Microsoft exploitable on ownCloud) 3. Some headers such as the Strict-Transport-Security might require custom modifications by administrators. This was not possible before and lead to buggy situations. This pull request moves those headers out of the PHP code and adds a security check to the admin settings performed via JS.
* | | [tx-robot] updated from transifexJenkins for ownCloud2015-03-0422-12/+90
| | |
* | | Merge pull request #14653 from sebomoto/fix_loading_feedbackMorris Jobke2015-03-031-0/+1
|\ \ \ | |_|/ |/| | fix for loading spinner reappearing after errors in db-connection
| * | fix for loading spinner reappearing after errors in db-connectionSebastian Bolt2015-03-021-0/+1
| |/
* | [tx-robot] updated from transifexJenkins for ownCloud2015-03-0370-82/+90
| |
* | Merge pull request #14615 from kampka/cron-commandLukas Reschke2015-03-025-0/+179
|\ \ | |/ |/| Allow configuring background job mode from the console
| * Allow configuring background job mode from the consoleChristian Kampka2015-03-025-0/+179
| |
* | Maintenance mode message might be misleadingJoas Schilling2015-03-021-1/+1
| |
* | [tx-robot] updated from transifexJenkins for ownCloud2015-03-022-0/+2
| |
* | [tx-robot] updated from transifexJenkins for ownCloud2015-03-018-0/+36
|/
* [tx-robot] updated from transifexJenkins for ownCloud2015-02-288-4/+58
|
* Merge pull request #14585 from owncloud/fix-avatars-for-users-with-atLukas Reschke2015-02-272-3/+3
|\ | | | | Use custom attribute instead of the div identifier
| * Use custom attribute instead of the div identifierLukas Reschke2015-02-272-3/+3
| | | | | | | | | | | | Otherwise problems arrive when a username contains characters such as an `@` Fixes https://github.com/owncloud/user_shibboleth/issues/38
* | Fix avatars in masterLukas Reschke2015-02-271-1/+1
|/
* Merge pull request #14530 from owncloud/revert-14403Thomas Müller2015-02-2733-665/+181
|\ | | | | Revert "Updating license headers"
| * Revert "Updating license headers"Morris Jobke2015-02-2633-665/+181
| | | | | | | | This reverts commit 6a1a4880f0d556fb090f19a5019fec31916f5c36.
* | [tx-robot] updated from transifexJenkins for ownCloud2015-02-2718-0/+94
| |
* | Merge pull request #13969 from raimund-schluessler/masterMorris Jobke2015-02-261-4/+11
|\ \ | | | | | | Append search results to custom container
| * | Fix variable already definedRaimund Schlüßler2015-02-091-1/+1
| | |
| * | Append search results to custom containerRaimund Schlüßler2015-02-081-4/+11
| | | | | | | | | | | | fixes #13968
* | | Merge pull request #14208 from owncloud/oc-msg-remove-object-dependencyMorris Jobke2015-02-261-36/+71
|\ \ \ | |_|/ |/| | Remove dependency from arbitrary data object structure for easier usage
| * | Remove dependency from arbitrary data object structure for easier usageJoas Schilling2015-02-201-36/+71
| | |
* | | [tx-robot] updated from transifexJenkins for ownCloud2015-02-26108-426/+100
| | |
* | | Merge pull request #14245 from cmeh/masterLukas Reschke2015-02-252-6/+6
|\ \ \ | | | | | | | | Message clean-up
| * | | Cleaning-up messagescmeh2015-02-181-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | **Changes:** * In line 103, the middle "c" of "owncloud" is capitalised to "ownCloud". * A space is inserted between value and unit in lines 177 and 187 ("4 GB" instead of "4GB").
| * | | Update setupchecks.jscmeh2015-02-161-1/+1
| | | | | | | | | | | | Changed *"won't work"* to "will not work" (as proposed by @DeepDiver1975).
| * | | Message clean-upcmeh2015-02-161-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *Changes:* * "… is not yet properly setup" in line 24 is changed to " … is not yet set up properly" (better word order and space in the middle of "set up", as it is a participle of the verb "to set up"). * "internet" is corrected to "Internet" with a capitalized "I" in lines 54 and 59. * Also in line 54: "3rd party" is changed to "third-party" to for a more coherent spelling across the different ownCloud components. * "… apps don´t work" is corrected to "… apps won't work" (with a proper (and hopefully correctly escaped) (apostrophe)[http://en.wikipedia.org/wiki/Apostrophe#Typographic_form] instead of the (acute accent)[http://en.wikipedia.org/wiki/Acute_accent]). * Still in line 54: The negation is corrected from "… might also not work" to "… might not work, either".
* | | | [tx-robot] updated from transifexJenkins for ownCloud2015-02-2586-84/+14
| | | |
* | | | print app upgrade information to console as wellThomas Müller2015-02-241-0/+6
| | | |
* | | | 3rd-party apps are disabled on upgrade - refs #14026Thomas Müller2015-02-243-11/+28
| | | |
* | | | Merge pull request #10599 from owncloud/move_passwordchange_textLukas Reschke2015-02-241-0/+4
|\ \ \ \ | | | | | | | | | | Make the password changed msg inline to fix #10242
| * | | | add fix for checkmark icon for IE8Morris Jobke2015-02-121-0/+4
| | | | |
* | | | | [tx-robot] updated from transifexJenkins for ownCloud2015-02-242-2/+2
| | | | |
* | | | | Merge pull request #14416 from owncloud/setup-commandThomas Müller2015-02-233-19/+153
|\ \ \ \ \ | | | | | | | | | | | | Setup command
| * | | | | Fix error handlingThomas Müller2015-02-231-1/+6
| | | | | |
| * | | | | implement command maintenance:installThomas Müller2015-02-232-16/+145
| | | | | |
| * | | | | Fix namespace of OC_Setup -> \OC\SetupThomas Müller2015-02-231-3/+3
| | | | | |
* | | | | | Merge pull request #13439 from owncloud/app-filterThomas Müller2015-02-231-0/+3
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Make the search box filter apps