| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a SAML scenario we don't get any strict or lax cookie send for
the ACS endpoint. Since we have some legacy code in Nextcloud
(direct PHP files) the enforcement of lax cookies is performed here
instead of the middleware.
This means we cannot exclude some routes from the cookie validation,
which normally is not a problem but is a little bit cumbersome for
this use-case.
Once the old legacy PHP endpoints have been removed we can move
the verification into a middleware and also adds some exemptions.
Not super awesome code to have but the best that I could come up
with that doesn't add another ton of technical debt.
|
| |
|
| |
|
|
|
|
|
| |
- Shows "Nextcloud will be updated" in the updater screen
- Shows "Nextcloud" if you add a bookmark on iOS instead of "ownCloud"
|
| |
|
|
|
|
|
| |
- old code used Response which attempted to use OC::$server which is not
and cannot be intialised at this part of the code.
|
| |
|
| |
|
|
|
|
|
|
| |
in order to create a 1:1 copy of a file if a version gets created
we need to store this information on copyBetweenStorage(). This
allows us to by-pass the encryption wrapper if we read the source file.
|
|
|
|
|
|
| |
PATH_INFO will be empty at this point and thus the logic in base.php did not catch this. Changing this to "getRawPathInfo" will ensure that the path info is properly read.
Fixes https://github.com/owncloud/core/issues/23199
|
|\
| |
| | |
[9.0] don't hide server not available exception, fixes #20536
|
| | |
|
|/ |
|
|
|
|
| |
Probably nice for the people that contributed to 9.0 to see themselves in the AUTHORS file :)
|
|
|
|
|
|
| |
If an app is getting enabled in the web UI, an ajax call is now made to
make sure the server still works. If it doesn't, it sends an emergency
app disabling call to disable the breaking app.
|
|
|
|
| |
Currently the "SERVER_NAME" is passed to the template, which in some cases doesn't match the host returned by "getInsecureServerHost" (or is empty).
|
|
|
|
| |
the dav app
|
|
|
| |
Fixes https://github.com/owncloud/core/issues/21873
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
I do not really consider this necessary or a real security addition. Let's get rid of it thus, cleans up the code and makes the logic easier.
|
|
|
|
| |
The native approach using the PHP calls will not work properly with the cryptowrapper and thus this code is effectively doing nothing at the moment.
|
| |
|
|
|
|
| |
There were code paths that nowadays call ISession::login directly thus bypassing the desired regeneration of the session ID. This moves the session regeneration deeper into the session handling and thus ensures that it is always called. Furthermore, I also added the session regeneration to the remember me cookie plus added some test case expectations for this.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
We were still using the lecagy class OC_Config all over the place. Which
was a wrapper around the new class OC\Config
|
|
|
|
|
| |
Private deprecated function => removed
Replaced all instances with suggested replacement
|
|
|
|
| |
Fixes https://github.com/owncloud/core/issues/20922
|
| |
|
| |
|
|
|
|
|
| |
* now uses the proper URLGenerator interface
* add comment about DI problems
|
| |
|
|
|
|
|
| |
This reduces a lot of the autoloader magic and makes sure that we
generate full paths in the autoloader.
|
| |
|
|
|
|
|
|
|
|
| |
PHP will handle session cookies with an empty values as an E_WARNING error. ([php/#68063](https://bugs.php.net/bug.php?id=68063))
ownCloud sets the cookie to an empty value in case the session expires, it however after this starts a new session. Due to potential race conditions this can in unlikely cases lead to the fact that the session never gets restarted and the user is left with an empty cookie. PHP tries then to use the empty cookie which makes the instance not usable.
To work around any race condition we now tell PHP to explicitly delete the value which can be done by using `null` as value, PHP will then send a cookie with the value "deleted". Also theepiration has been set to -1.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reduce calls of \OCP\Util::needUpgrade()
where \OCP\Util::needUpgrade() is called we can call as well
self::checkUpgrade and use the cached result
In line 877 the call way unnecessary anyway because of the first part of
the if statement
move caching to \OCP\Util::needUpgrade
renaming variable
fixing testNeedUpgradeCore()
cache result of checkUpgrade() in self::$needUpgrade
reduce calls of \OCP\Util::needUpgrade()
where \OCP\Util::needUpgrade() is called we can call as well
self::checkUpgrade and use the cached result
In line 877 the call way unnecessary anyway because of the first part of
the if statement
move caching to \OCP\Util::needUpgrade
renaming variable
fixing testNeedUpgradeCore()
fix typo in variable name
deleting tabs
|
|\
| |
| | |
[jenkins] do not load unnecessary code in case of webdav
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
changing from "protected static" to "protected"
as suggested by @nickvergessen
https://github.com/owncloud/core/pull/19114#discussion_r39719851
moving initTemplate() into template constr.
reduce to move initTemplate only
cleanup spaces
|
|\ \
| |/
|/| |
fix issue with version rollback and thumbnails
|