aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private/DB/Connection.php
Commit message (Collapse)AuthorAgeFilesLines
* fix DBAL exception handling in setValuesArthur Schiwon2023-03-311-7/+11
| | | | | | | | | This seems to be a left over after abstracting DBAL. Nowadays, IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where previously original DBAL exceptions where thrown. These are now wrapped, the orignal classes are now mapped to a reason. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Fix more psalm issues in OC\DBCôme Chilliet2022-11-211-2/+4
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Fix psalm issues following doctrine/dbal bumpCôme Chilliet2022-11-211-3/+4
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Migrate Repair events to OCP\EventDispatcher\EventCôme Chilliet2022-08-251-1/+1
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* record backtrace when profiling db requestsRobin Appelman2022-04-041-2/+1
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Add a built-in profiler inside NextcloudCarl Schwan2022-04-041-0/+15
| | | | | | The webui is provided by a seperate application named profiler Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Adapt more code to migration to LoggerInterfaceCôme Chilliet2022-03-241-35/+34
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Merge pull request #31235 from nextcloud/techdebt/noid/extract-request-idJoas Schilling2022-03-221-2/+8
|\ | | | | Extract request id handling to dedicated class so it can be injected without DB dependency
| * Allow to prefix the Query log with the request idJoas Schilling2022-02-231-2/+8
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Add event logging for db and redis connectionJulius Härtl2022-02-281-1/+11
| | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | Add --dry-run option for db:add-missing-* cmdLouis Chemineau2022-02-241-2/+10
|/ | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* Check if directoy is writable instead of possibly missing fileCarl Schwan2021-12-201-1/+1
| | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Allow to log DB, redis and LDAP requests into filesJoas Schilling2021-12-011-0/+14
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Allow NULL as well for limit, not integer onlyJoas Schilling2021-11-151-3/+8
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Update php licensesJohn Molakvoæ (skjnldsv)2021-06-041-1/+0
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* Cleanup unneeded code around database.xmlMorris Jobke2021-03-241-4/+24
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* remove ReconnectWrapperRobin Appelman2021-02-091-1/+4
| | | | | | dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed Signed-off-by: Robin Appelman <robin@icewind.nl>
* Add our own DB exception abstractionChristoph Wurst2021-01-121-1/+24
| | | | | | | | | | | | | | | | | | Right now our API exports the Doctrine/dbal exception. As we've seen with the dbal 3 upgrade, the leakage of 3rdparty types is problematic as a dependency update means lots of work in apps, due to the direct dependency of what Nextcloud ships. This breaks this dependency so that apps only need to depend on our public API. That API can then be vendor (db lib) agnostic and we can work around future deprecations/removals in dbal more easily. Right now the type of exception thrown is transported as "reason". For the more popular types of errors we can extend the new exception class and allow apps to catch specific errors only. Right now they have to catch-check-rethrow. This is not ideal, but better than the dependnecy on dbal. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Bump doctrine/dbal from 2.12.0 to 3.0.0Christoph Wurst2021-01-081-24/+34
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Update all license headers for Nextcloud 21Christoph Wurst2020-12-161-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Don't try to update on NotNullConstraintViolationException, only on unique ↵Joas Schilling2020-11-101-0/+3
| | | | | | or foreign key Signed-off-by: Joas Schilling <coding@schilljs.com>
* Fix comparing the empty string for global credentialsJoas Schilling2020-11-101-5/+11
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Replace prefix in executeUpdateJulius Härtl2020-11-031-0/+3
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Psalm fixesRoeland Jago Douma2020-10-301-10/+14
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Update internal connection classRoeland Jago Douma2020-10-301-2/+2
| | | | | | | executeUpdate is deprecated in favor of executeStatement. We overwrote the old one hence the prefix was no longer replaced. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fetch the logger and system config once for all query builder instancesMorris Jobke2020-10-291-8/+15
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Format code to a single space around binary operatorsChristoph Wurst2020-10-051-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Log the number of queries built and executedJoas Schilling2020-09-251-0/+18
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Remove @suppress SqlInjectionCheckerMorris Jobke2020-09-161-1/+0
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Format control structures, classes, methods and functionChristoph Wurst2020-04-101-7/+4
| | | | | | | | | | | | | | | To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Use elseif instead of else ifChristoph Wurst2020-04-101-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Remove trailing and in between spacesChristoph Wurst2020-04-091-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Unify function spacing to PSR2 recommendationChristoph Wurst2020-04-091-3/+3
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Update the license headers for Nextcloud 19Christoph Wurst2020-03-311-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Merge pull request #20170 from nextcloud/techdebt/remove-unused-importsChristoph Wurst2020-03-271-1/+0
|\ | | | | Remove unused imports
| * Remove unused importsChristoph Wurst2020-03-251-1/+0
| | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Use the short array syntax, everywhereChristoph Wurst2020-03-261-4/+4
|/ | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Add event subscriber for transaction isolation levelDaniel Kesselberg2020-02-211-2/+0
| | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* Update license headersChristoph Wurst2019-12-051-1/+4
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Merge pull request #17949 from nextcloud/debt/deprecated-constJoas Schilling2019-12-041-1/+2
|\ | | | | Connection::TRANSACTION_READ_COMMITTED is deprecated
| * Connection::TRANSACTION_READ_COMMITTED is deprecatedDaniel Kesselberg2019-11-141-1/+2
| | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | Some php-cs fixesRoeland Jago Douma2019-11-221-4/+4
|/ | | | | | | | | | | * Order the imports * No leading slash on imports * Empty line before namespace * One line per import * Empty after imports * Emmpty line at bottom of file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Code cleanup.Ole Ostergaard2019-03-211-2/+2
| | | | Signed-off-by: Ole Ostergaard <ole.c.ostergaard@gmail.com>
* Add insertIgnoreConflict to Adapter and use it for for executing the file ↵Ole Ostergaard2019-03-211-0/+4
| | | | | | locking. Signed-off-by: Ole Ostergaard <ole.c.ostergaard@gmail.com>
* Add deprecation message ofr insertIfNotExistMorris Jobke2018-11-091-0/+1
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Catch UniqueConstraintViolationException inside insertIfNotExistMorris Jobke2018-11-091-1/+3
| | | | | | | | This is the most common case for the usage of this method. See also https://github.com/nextcloud/server/issues/12369 and the linked tickets. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Check connection status and attempt to reconnect each each minuteRobin Appelman2018-05-081-1/+1
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* refactor user searchingRobin Appelman2017-12-201-1/+1
| | | | | | add additional user searching tests Signed-off-by: Robin Appelman <robin@icewind.nl>
* Update license headersMorris Jobke2017-11-061-0/+2
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Add Phan plugin to check for SQL injectionsLukas Reschke2017-07-201-0/+1
| | | | | | | | | | This adds a phan plugin which checks for SQL injections on code using our QueryBuilder, while it isn't perfect it should already catch most potential issues. As always, static analysis will sometimes have false positives and this is also here the case. So in some cases the analyzer just doesn't know if something is potential user input or not, thus I had to add some `@suppress SqlInjectionChecker` in front of those potential injections. The Phan plugin hasn't the most awesome code but it works and I also added a file with test cases. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
generated by cgit v1.2.3 (git 2.39.1) at 2025-06-07 22:46:53 +0000