summaryrefslogtreecommitdiffstats
path: root/lib/private/Share20
Commit message (Collapse)AuthorAgeFilesLines
* Use the correct mountpoint to calculateRoeland Jago Douma2020-07-091-1/+8
| | | | | | | If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix language in share notes email for usersJoas Schilling2020-06-242-27/+36
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #21158 from ↵Joas Schilling2020-06-081-5/+21
|\ | | | | | | | | nextcloud/backport/21143/stable17-fix-password-changes-in-link-and-mail-shares [stable17] Fix password changes in link and mail shares
| * Fix disabling send password by Talk without new password in mail sharesDaniel Calviño Sánchez2020-06-011-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When "send password by Talk" was disabled in a mail share it was possible to keep the same password as before, as it does not pose any security issue (unlike keeping it when "send password by Talk" is enabled, as in that case the password was already disclosed by mail). However, if a mail share is updated but the password is not set again only the hashed password will be available. In that case it would not make sense to send the password by mail, so now the password must be changed when disabling "send password by Talk". Note that, even if explicitly setting the same password again along with the "send password by Talk" property would work, this was also prevented for simplicity. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix enabling send password by Talk with same password in mail sharesDaniel Calviño Sánchez2020-06-011-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | When "send password by Talk" is enabled in a mail share a new password must be also set. However, when the passwords of the original and the new share were compared it was not taken into account that the original password is now hashed, while the new one is not (unless no new password was sent, in which case the password of the original share was set in the new share by the controller, but that was already prevented due to both passwords being literally the same), so it was possible to set the same password again. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix enabling send password by Talk with empty password in link sharesDaniel Calviño Sánchez2020-06-011-0/+6
| | | | | | | | | | | | | | When "send password by Talk" is enabled in a link share now a non empty password is enforced. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Prevent harder to share your rootJoas Schilling2020-06-041-3/+1
|/ | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Link shares have reshare permission if outgoing federated shares are enabledJulius Härtl2020-05-261-5/+0
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Provide the proper language to the mailerRoeland Jago Douma2020-04-201-2/+2
| | | | | | | Else we can't properly translate the footer in the recipients e-mail language. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Handle unset owner in sharingJoas Schilling2020-04-141-2/+6
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Update the target when it isempty after sharingRoeland Jago Douma2020-03-181-0/+5
| | | | | | | Hooks that listen to it (audit log) benefit from having the target properly set. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Strip of users home path from share api messageJoas Schilling2020-02-221-2/+4
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* using IShare::Maxence Lange2019-12-111-3/+3
| | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* adding share type circlesMaxence Lange2019-12-111-1/+2
| | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* Fix reshare with circleThibault Coupin2019-11-121-0/+1
| | | | Signed-off-by: Thibault Coupin <thibault.coupin@gmail.com>
* Fix l10n in federated file sharingChristoph Wurst2019-09-191-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Add expiration event for sharesJohn Molakvoæ (skjnldsv)2019-08-212-2/+9
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* Fix permission check on incoming federated sharesJulius Härtl2019-07-311-2/+3
| | | | | | | | Since federated shares have their permissions set on the node, we do not need to check for parent share permissions. Otherwise reshares of incoming federated have no permission variable defined and creating them will fail Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Always set the display name for user sharesJulius Härtl2019-07-031-0/+4
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Unify the permission checking in one place onlyJoas Schilling2019-07-031-9/+12
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Better check reshare permissions when creating a shareJoas Schilling2019-07-031-3/+22
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #15832 from ↵Roeland Jago Douma2019-06-251-0/+3
|\ | | | | | | | | nextcloud/bugfix/noid/fulltext-search-groupfolders Fix full text search for groupfolders
| * Fix full text search for groupfoldersMorris Jobke2019-06-171-0/+3
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Add event dispatcher to OCPChristoph Wurst2019-06-252-8/+11
|/ | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Update lib/private/Share20/Manager.php Morris Jobke2019-03-201-1/+1
| | | | | tabulator change Co-Authored-By: aignerat <46312655+aignerat@users.noreply.github.com>
* Update lib/private/Share20/Manager.php Morris Jobke2019-03-201-1/+1
| | | | | fixed tabulator Co-Authored-By: aignerat <46312655+aignerat@users.noreply.github.com>
* groupname like username - allow share with bothChristian Aigner2019-03-201-2/+2
| | | | Signed-off-by: Christian Aigner <christian.aigner@huemer-it.com>
* Fix getting the access list on external storageRoeland Jago Douma2019-03-191-1/+7
| | | | | | | If a file is on external storage there is no owner. WHich means we can't check. So just return an empty array then. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Cleanup some PHPDoc leftovers and unused variablesMorris Jobke2019-03-061-1/+1
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Correctly determinate the owner in case of shared external storagesJoas Schilling2019-02-181-2/+4
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Fix typos and unused return valuesChristoph Wurst2019-01-301-9/+9
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* fix typoBjoern Schiessle2019-01-301-2/+2
| | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* log full exceptionBjoern Schiessle2019-01-301-1/+1
| | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* handle mail send error gracefullyBjoern Schiessle2019-01-301-2/+13
| | | | | | | log the error in case a notification mail of a new share couldn't be send to the recipient and finish the share operation successfully Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* Do not update child all child shares on group share updateRoeland Jago Douma2018-12-041-0/+1
| | | | | | | Else we overwrite the whole share for link shares. Basically breaking them. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #12105 from nextcloud/using-resharing-right-to-display-sharesRoeland Jago Douma2018-11-041-6/+8
|\ | | | | Shares are displayed to users with resharing rights
| * revert testsMaxence Lange2018-11-021-5/+7
| | | | | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
| * shares are displayed to users with resharing rightsMaxence Lange2018-11-021-11/+11
| | | | | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* | Store "sendPasswordByTalk" property of link shares in the databaseDaniel Calviño Sánchez2018-11-021-0/+4
|/ | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* allow to update lables for public link sharesBjoern Schiessle2018-11-011-0/+1
| | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* allow to add labels to sharesBjoern Schiessle2018-11-012-1/+24
| | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* Propegate hide download state in share providerRoeland Jago Douma2018-10-301-0/+2
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Extend IShare to show hide download stateRoeland Jago Douma2018-10-301-0/+13
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Use numeric placeholders if there are multiple, so that RTL languages can ↵Joas Schilling2018-10-091-4/+4
| | | | | | operate better Signed-off-by: Joas Schilling <coding@schilljs.com>
* tokens can't be valid local user namesRobin Appelman2018-08-161-0/+4
| | | | | | this saves searching for shares on non-public link dav requests Signed-off-by: Robin Appelman <robin@icewind.nl>
* Add support for tokens in room sharesDaniel Calviño Sánchez2018-08-081-0/+9
| | | | | | | | | | Tokens will be used to give access to a share to guests in public rooms. Although the token itself is created in the provider of room shares and no changes are needed for that, due to the code structure it is necessary to explicitly call the provider from the manager when getting a room share by token. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add support for room shares to the share managerDaniel Calviño Sánchez2018-08-081-0/+1
| | | | | | | | | | | Room shares are implemented in an external app (Nextcloud Talk), so in order to keep the share manager as isolated as possible from room share specifics all the validity checks are done in the provider of room shares. However, due to the code structure it is necessary to explicitly check for room shares in "generalCreateChecks" to prevent an exception from being thrown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add provider for room sharesDaniel Calviño Sánchez2018-08-081-0/+34
| | | | | | | | | The RoomShareProvider is provided by the Talk app, so it is necessary to check whether the app is available or not, and also whether the class itself exists or not (just in case an older version of the app that did not have support yet for room shares is being used). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Honour "sendPasswordByTalk" property in mail sharesDaniel Calviño Sánchez2018-07-241-1/+11
| | | | | | | | | | | | | | | | | When a password was set for a mail share an e-mail was sent to the recipient with the password. Now the e-mail is no longer sent if the password is meant to be sent by Talk. However, before the e-mail was not sent when the share was updated but the password was not changed. Now an e-mail is sent in that case too if switching from a password sent by Talk to a password sent by mail. On the other hand, when switching from a password sent by mail to a password sent by Talk it is mandatory to change the password; otherwise the recipient would already have access to the share without having to call the sharer to verify her identity. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add "sendPasswordByTalk" property to sharesDaniel Calviño Sánchez2018-07-241-0/+17
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-12 19:52:11 +0000