summaryrefslogtreecommitdiffstats
path: root/lib/private/legacy
Commit message (Collapse)AuthorAgeFilesLines
* fix loading legacy app.php with multi app dirArthur Schiwon2022-07-191-1/+1
| | | | | | | | | | - requireAppFile() only appends /appinfo/app.php - without the absolute path, require_once looks into include_path - the first match in inlcude_path however migth be different from appPath - fixed by providing the tested(!), full path to the app Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Allow to disable password policy enforcement for selected groupsCarl Schwan2022-07-051-3/+4
| | | | | | Signed-off-by: Carl Schwan <carl@carlschwan.eu> Co-authored-by: Vincent Petry <vincent@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
* Merge pull request #32680 from nextcloud/backport/32510/stable23blizzz2022-06-111-2/+2
|\ | | | | [stable23] Properly calculate primary element based on background luminance
| * Properly calculate primary element based on background luminanceJohn Molakvoæ2022-06-011-2/+2
| | | | | | | | Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
* | allow use of rememberme cookies for IApacheAuth backendsArthur Schiwon2022-05-311-0/+1
|/ | | | | | - e.g. enables it for SAML backend Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Move Gd failed operations to debug levelGit'Fellow2022-05-271-20/+18
| | | Instead of error
* dont re-query fileinfo when getting dav quotaRobin Appelman2022-04-131-2/+2
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Log exceptionJoas Schilling2022-04-071-0/+1
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Fix \OC_App::getCurrentApp() when being called from CLI or phpunitJoas Schilling2022-04-071-1/+10
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #31098 from nextcloud/backport/30942/stable23Vincent Petry2022-03-012-28/+45
|\ | | | | [stable23] only setup part of the filesystem for appdata requests
| * handle setupFS with null userRobin Appelman2022-02-161-4/+4
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
| * dont mark fs as setup when no user is activeRobin Appelman2022-02-161-2/+2
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
| * pass user object during fs initRobin Appelman2022-02-161-1/+1
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
| * only setup part of the filesystem for appdata requestsRobin Appelman2022-02-162-28/+45
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | Use the unjailed-path in OC_Helper::getStorageInfo() for files located in ↵Claus-Justus Heine2022-02-181-1/+4
|/ | | | | | | | | | | | | | SharedStorage. The current implementation already switches the storage-backend to $storage->getSourceStorage(). However, it then calls $rootInfo->getInternalPath() which returns the internal path relative to the storage where the share is mounted. This is wrong, we need also to unjail the path. Compare, e.g., with OCA\Files_Sharing\SharedStorage::file_get/put_contents() for the "logic". Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
* Fix psalm not runningCarl Schwan2022-01-273-3/+4
| | | | | | | | | | The issue was that we were using psalm/phar instead of vimeo/psalm. This caused issue with the custom psalm plugin in buildd/psalm. This is using the opportunity to also update the psalm version from 3.8 to 3.17 and the php-cs-fixer too. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* Prevent loading images that would require too much memory.Joachim Bauch2022-01-111-1/+102
| | | | | | | | | | | | | For most image formats, the header specifies the width/height. PHP allocates an image object from that size, even if the actual image data is much smaller. This image object size is not limited by the limit configured in PHP. The memory limit can be configured through "config.php" setting "preview_max_memory" and defaults to 128 MBytes which should be enough for most images without filling up all memory. Signed-off-by: Joachim Bauch <bauch@struktur.de>
* [stable23] Remove iconv from dependencies and testsMichaIng2022-01-041-1/+0
| | | | | | which is not used anymore since: https://github.com/nextcloud/server/pull/29470 Signed-off-by: MichaIng <micha@dietpi.com>
* Avoid assignment in if clauseCôme Chilliet2021-12-061-8/+12
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Fix typing problems in OC_ImageCôme Chilliet2021-12-061-2/+10
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Avoid calling image* methods on booleanCôme Chilliet2021-12-061-14/+27
| | | | | | | This avoids fatal errors on PHP>=8, and warnings on older versions. Log should also be clearer. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* fix imagecreatetruecolor() errorszaimen2021-11-231-0/+4
| | | | Signed-off-by: szaimen <szaimen@e.mail.de>
* OC_Util::isNonUTF8Locale: fix lint errorNaoto Kobayashi2021-11-161-5/+5
| | | | Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
* OC_Util::isSetLocaleWorking: fix typoNaoto Kobayashi2021-11-161-1/+1
| | | | Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
* OC_Util: Add fallbacks to check if current locale is UTF8Naoto Kobayashi2021-11-161-2/+17
| | | | | | | | | Using escapeshellcmd to get current locale causes error if the function is disabled. Add fallbacks to prevent the error. Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
* Check whether setlocale works only after setlocaleNaoto Kobayashi2021-11-161-4/+5
| | | | Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
* Fix missing setlocale with php 8Naoto Kobayashi2021-11-161-2/+2
| | | | | | | | | When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale. This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8"). Fix it by using escapeshellcmd instead of basename. Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
* Fix resource usages in OC_ImageCôme Chilliet2021-10-281-17/+17
| | | | | | This makes sure using resource or GdImage (PHP>=8) behaves the same. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Revert "Fix "never catch" catches in OC_App"Joas Schilling2021-10-251-1/+0
|
* Fix "never catch" catches in OC_Appzorn-v2021-10-221-0/+1
| | | Need to check another legacy. Need to explicitly add to use or do not forget add slash `\`
* Merge pull request #29187 from ↵Julius Härtl2021-10-131-2/+2
|\ | | | | | | nextcloud/fix/noid/passwordless-app-password-generation
| * allow null password in UserLoggedInEventJulien Veyssier2021-10-131-1/+1
| | | | | | | | Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
| * fix login_credentials->password in session when loging in with apacheJulien Veyssier2021-10-131-1/+1
| | | | | | | | Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
* | Merge pull request #29004 from nextcloud/bugfix/noid/fix-translated-app-detailsJoas Schilling2021-10-131-2/+3
|\ \ | |/ |/| Fix translated app details
| * Fix translated app detailsJoas Schilling2021-09-301-2/+3
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | add 'supported'-label to all supported apps, also if they are not downloaded yetBjoern Schiessle2021-10-061-3/+13
| | | | | | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* | Merge pull request #27733 from ↵Julius Härtl2021-10-051-41/+4
|\ \ | | | | | | | | | PhrozenByte/enhancement/noid/IURLGenerator-linkToDefaultPageUrl
| * \ Merge branch 'master' into enhancement/noid/IURLGenerator-linkToDefaultPageUrlDaniel Rudolf2021-08-043-7/+23
| |\ \
| * | | Fix UtilTest::testDefaultApps()Daniel Rudolf2021-07-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Oh wow... This definitly was no best practice... :unamused: Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
| * | | Remove \OC::$server->getURLGenerator() usageDaniel Rudolf2021-07-011-1/+2
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
| * | | Remove unused importsDaniel Rudolf2021-06-301-1/+0
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
| * | | Add IUrlGenerator::linkToDefaultPageUrl()Daniel Rudolf2021-06-301-39/+1
| | | | | | | | | | | | | | | | | | | | | | | | Replaces the deprecated \OC_Util::getDefaultPageUrl() and makes this API public. Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
* | | | Merge pull request #28939 from nextcloud/bugfix/noid/dont-setup-disabled-usersLukas Reschke2021-10-041-0/+6
|\ \ \ \ | | | | | | | | | | Don't further setup disabled users when logging in with apache
| * | | | Don't further setup disabled users when logging in with apacheJoas Schilling2021-09-231-0/+6
| | |_|/ | |/| | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* / | | Add admin privilege delegation for admin settingsCarl Schwan2021-09-291-4/+5
|/ / / | | | | | | | | | | | | | | | | | | This makes it possible for selected groups to access some settings pages. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
* | | Merge pull request #28473 from nextcloud/fix-file-get-contentsChristoph Wurst2021-08-251-1/+1
|\ \ \ | | | | | | | | Fix path of `file_get_contents`
| * | | Avoid usage of Nextcloud API, use PHP functionacsfer2021-08-181-1/+1
| | | |
| * | | Fix path of `file_get_contents`acsfer2021-08-171-1/+1
| | |/ | |/| | | | | | | | | | Try to fix #28370 and #27441 Avoid pre-pends the `$path` to the user's own storage.
* | | Remove unused methodDaniel Kesselberg2021-08-181-10/+0
| | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | | Fix #20913: Check image resource before attempting to preserve alphaSimon Spannagel2021-08-181-6/+14
|/ / | | | | | | Signed-off-by: Simon Spannagel <simonspa@kth.se>