| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Ref https://github.com/owncloud/core/issues/10837#issuecomment-76516839
|
|
|
| |
Maybe it helps in the future so we won't forget it again :see_no_evil:
|
|\
| |
| | |
Revert "Updating license headers"
|
| |
| |
| |
| | |
This reverts commit 6a1a4880f0d556fb090f19a5019fec31916f5c36.
|
|\ \
| |/
|/| |
Move UTF-8 check to setup
|
| |
| |
| |
| |
| |
| |
| |
| | |
Nobody reads the warnings anyways and so we should enforce it at installation time... Also allows us to get rid of some duplicated code.
To test change the `default_charset` to something other than `utf-8` or `UTF-8`, both should work fine with that change here. An error should then get shown.
We already set those default charsets in the shipped .user.ini and .htaccess
|
|/
|
|
| |
Function is not used anymore anywhere in the code base: https://github.com/search?q=user%3Aowncloud+secureRNGAvailable&type=Code&utf8=%E2%9C%93
|
| |
|
|\
| |
| | |
Better caching for enabled apps
|
| | |
|
|\ \
| | |
| | | |
Update license headers
|
| | | |
|
|/ /
| |
| |
| |
| |
| | |
Apparently a boolean in php.ini is according to the documentation "on" or "off"…
Fixes itself.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows to check for specific values in the PHP.ini that ownCloud requires for full compatibility.
`mbstring.func_overload`: https://github.com/owncloud/core/issues/14372
`output_buffering`: http://doc.owncloud.org/server/8.0/admin_manual/configuration/big_file_upload_configuration.html#configuring-php
Fixes https://github.com/owncloud/core/issues/14372 and https://github.com/owncloud/core/issues/14412
|
|/
|
|
|
|
|
|
|
|
| |
This changeset removes the static class `OC_Request` and moves the functions either into `IRequest` which is accessible via `\OC::$server::->getRequest()` or into a separated `TrustedDomainHelper` class for some helper methods which should not be publicly exposed.
This changes only internal methods and nothing on the public API. Some public functions in `util.php` have been deprecated though in favour of the new non-static functions.
Unfortunately some part of this code uses things like `__DIR__` and thus is not completely unit-testable. Where tests where possible they ahve been added though.
Fixes https://github.com/owncloud/core/issues/13976 which was requested in https://github.com/owncloud/core/pull/13973#issuecomment-73492969
|
|
|
|
| |
loading a theme
|
|
|
|
| |
Add strtoupper() in UTF-8 check to avoid error message
|
|\
| |
| | |
add function to invalidate one opcache file, use it if possible #9885
|
| |
| |
| |
| | |
Both pointed out in submission review by @bantu, thanks.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Issue #9885 appears to be triggered by ownCloud invalidating the entire
PHP opcache. Testing indicates it can be avoided by only invalidating the
single file that was written from the opcache, instead of clearing the
whole thing. In general it is more efficient to invalidate only the single
file that was changed, rather than the whole cache.
This adds a deleteFromOpcodeCache() function which invalidates a single
file from the opcache if possible, returning true if the underlying
function returns true (which may mean 'success', or 'file does not exist',
or 'file exists but is not in opcache', all of which are OK to treat as
good for our purposes). It also changes writeData() in config.php to try
using deleteFromOpcodeCache() and only fall back on clearOpcodeCache() if
that fails.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The URL was previously encoded twice which leads to getting redirected to a 404 page when the password has been entered incorrect at least once.
Testplan:
- [ ] Opening `http://localhost/core/index.php?redirect_url=%2Fcore%2Findex.php%2Fsettings%2Fadmin` redirects to the admin page when providing the correct credentials
- [ ] Opening `http://localhost/core/index.php?redirect_url=%2Fcore%2Findex.php%2Fsettings%2Fadmin` redirects to the admin page when providing the invalid credentials and then providing valid ones.
- [ ] Logging in as admin then going to the admin page and clearing the cookies and refreshing will show the login and when repeating the above test steps you're redirected correctly.
Fixes https://github.com/owncloud/core/issues/9804
|
| |
| |
| |
| |
| |
| | |
HHVM seems to have problems with this at the moment (even setting those values in the php.ini of HHVM doesn't have helped much) and thus the unit test execution failed.
So it's better if we disable this check for now for HHVM.
|
|\ \
| | |
| | | |
Add check for `HTTP_RAW_POST_DATA` setting for >= 5.6
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
PHP 5.6 otherwise throws notices for perfectly valid code which results in broken endpoints.
Fixes https://github.com/owncloud/core/issues/13592
|
|\ \ \
| |/ /
|/| | |
Return false if the login is canceled in a hook
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ /
| |
| |
| | |
for encryption key introduced with OC8
|
| |
| |
| |
| |
| |
| |
| |
| | |
Apparently `normalizer_normalize` is not verifying itself whether the string needs to be converted or not. Or does it at least not very performantly.
This simple change leads to a 4% performance gain on the processing of normalizeUnicode. Since this method is called quite often (i.e. for every file path) this has actually a measurable impact. For examples searches are now 200ms faster on my machine. Still not perfect but way to go.
Part of https://github.com/owncloud/core/issues/13221
|
| |
| |
| |
| | |
blocking the request to itself - fixes #13153
|
|\ \
| | |
| | | |
Check for hash
|
| | |
| | |
| | |
| | | |
See https://github.com/owncloud/core/pull/13042
|
| | | |
|
|/ / |
|
| | |
|
| |
| |
| |
| | |
Make DateTimeFormatter a service and adjust tests that have been inaccurate
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Both are removed from 5.4.0
Safe Mode: http://php.net/manual/en/features.safe-mode.php
> This feature has been DEPRECATED as of PHP 5.3.0 and REMOVED as of PHP 5.4.0.
Magic Quotes: http://php.net/manual/en/security.magicquotes.php
> This feature has been DEPRECATED as of PHP 5.3.0 and REMOVED as of PHP 5.4.0.
|
| |
| |
| |
| | |
:beers:
|
| | |
|
|/
|
|
| |
This is not installed by default in all cases and will break the DAV features of ownCloud. Lot's of reports such as https://github.com/owncloud/ios-issues/issues/167#issuecomment-63798507
|
|
|
|
|
|
| |
* add addVendorScript & addVendorStyle
* refactoring of addScript and addStyle
* add shortcuts vendorScript and vendorStyle
|
|\
| |
| | |
Fix the addHeader tag attributes text methods to not ignore the text parameter
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
$text parameter
Also support closing tags with no text content given
Conflicts:
lib/private/template.php
|
| |
| |
| |
| | |
remove translation.php
|