aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* fix: replace null character when serializingbackport/49528/stable29SebastianKrupinski2024-12-132-0/+70
| | | | Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
* Merge pull request #49654 from nextcloud/backport/49551/stable29John Molakvoæ2024-12-121-2/+9
|\ | | | | [stable29] fix: don't propagate future mtimes
| * fix: don't propagate future mtimesbackport/49551/stable29Robin Appelman2024-12-041-2/+9
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | fix: fix mimetype not being updated when changing file extention on object storebackport/40394/stable29Robin Appelman2024-12-111-9/+13
|/ | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Merge pull request #49536 from nextcloud/backport/49523/stable29Joas Schilling2024-11-281-3/+29
|\ | | | | [stable29] fix(migration): Decrypt ownCloud secrets v2
| * fix(migration): Decrypt ownCloud secrets v2Christoph Wurst2024-11-281-3/+29
| | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | fix: fix availability wrapper not applyingRobin Appelman2024-11-261-2/+2
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | fix: throw correct exception type when we can't verify if an s3 bucket existsRobin Appelman2024-11-261-5/+6
|/ | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix(OCMDiscoveryService): Also cache error results during discoverybackport/49311/stable29provokateurin2024-11-251-1/+9
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix(BackgroundJobs): Adjust intervals and time sensitivitiesbackport/48600/stable29provokateurin2024-11-255-9/+10
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* fix(storage): Try to delete existing targetbackport/49315/stable29Git'Fellow2024-11-212-10/+13
| | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* fix: remove superflous linebackport/48675/stable29georglauterbach2024-11-141-1/+0
| | | | Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
* fix: do not query CNAME if A succeeded alreadygeorglauterbach2024-11-141-1/+5
| | | | Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
* Merge pull request #49097 from nextcloud/backport/48933/stable29Richard Steinmetz2024-11-131-1/+7
|\ | | | | [stable29] Clear pending two factor tokens also from configuration
| * fix: Handle exception when clearing previously removed two factor tokensbackport/48933/stable29Daniel Calviño Sánchez2024-11-051-1/+5
| | | | | | | | | | | | | | | | If a token was already removed from the database but not from the configuration clearing the tokens will try to remove it again from the database, which caused a DoesNotExistException to be thrown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * fix: Clear pending two factor tokens also from configurationDaniel Calviño Sánchez2024-11-051-0/+2
| | | | | | | | | | | | | | | | | | Otherwise as the tokens were removed from the database but not from the configuration the next time that the tokens were cleared the previous tokens were still got from the configuration, and trying to remove them again from the database ended in a DoesNotExistException being thrown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | fix: Clean-up some remaining readdir calls with undesirable false evaluation ↵Josh Richards2024-11-132-2/+2
| | | | | | | | | | | | | | | | potential Signed-off-by: Josh Richards <josh.t.richards@gmail.com> [skip ci]
* | Merge pull request #49206 from nextcloud/backport/48736/stable29Andy Scherzinger2024-11-121-0/+1
|\ \ | | | | | | [stable29] fix: log a warning when we can't build a background job
| * | fix: log a warning when we can't build a background jobbackport/48736/stable29Robin Appelman2024-11-111-0/+1
| |/ | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* / Fix Undefined variable: response notice in case of non-404 errorbackport/49146/stable29Victor Dubiniuk2024-11-081-2/+3
|/ | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix(owncloud): Fix ownCloud migration with oauth2 appbackport/49076/stable29Joas Schilling2024-11-041-7/+5
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #48998 from nextcloud/backport/47986/stable29Louis2024-10-311-0/+5
|\ | | | | [stable29] perf(ObjectStoreStorage): Improve (slow) move on same object bucket
| * perf(ObjectStoreStorage): Improve (slow) move on same object bucketChristoph Fiehe2024-10-301-0/+5
| | | | | | | | | | | | | | | | | | This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage. The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder. Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
* | fix: Shipped apps should include the Nextcloud version in the cache busterfix/cachebuster-stable30Ferdinand Thiessen2024-10-301-60/+66
| | | | | | | | | | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | Merge pull request #48488 from nextcloud/backport/48235/stable29Benjamin Gaussorgues2024-10-302-24/+85
|\ \ | |/ |/|
| * fix: rework move into object store to better preserve fileidsRobin Appelman2024-10-091-19/+58
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
| * fix: preserve fileid when moving from objectstore to non-objectstoreRobin Appelman2024-10-092-6/+27
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
| * fix: ensure source folder is removed from cache when moving to objectstoreRobin Appelman2024-10-091-0/+1
| | | | | | | | | | | | otherwise this causes confusion down the line as it's contents will be moved to the new cache Signed-off-by: Robin Appelman <robin@icewind.nl>
* | fix: Fix copying or moving from shared groupfoldersDaniel Calviño Sánchez2024-10-291-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When copying or moving between two local storages the source path (on disk) to copy or move from is got from the unjailed path of the source storage. However, if the source storage has more than one jail getting the unjailed path resolves the most external jail, but the source path needs to be got from the most internal jail instead (the one closer to the local storage). This can happen, for example, with a shared groupfolder: in that case there is an external jail for the shared storage, and one internal jail for the groupfolder storage wrapped by the shared storage. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Merge pull request #48949 from nextcloud/backport/48947/stable29Joas Schilling2024-10-282-0/+10
|\ \ | | | | | | [stable29] fix(config): Mark more configs as sensitive
| * | fix(config): Mark more configs as sensitivebackport/48947/stable29Joas Schilling2024-10-282-0/+10
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | fix: readonly removedbackport/48915/stable29yemkareems2024-10-281-1/+1
| | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
* | | fix: crypto made inline for constructor and decrypt error handled in exceptionyemkareems2024-10-281-2/+4
| | | | | | | | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com> [skip ci]
* | | fix: crypto made inline for constructor and decrypt error handled in exceptionyemkareems2024-10-281-6/+7
| | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
* | | fix: use Icrypto in place of Cyptoyemkareems2024-10-282-4/+4
| | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
* | | fix: crypto type made not nullable and tests run using ICryptoyemkareems2024-10-282-4/+4
| | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
* | | fix: encrypt and store password, decrypt and retrieve the sameyemkareems2024-10-282-2/+11
|/ / | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
* | fix(logger): Remove more parameters of other methodsbackport/48603/stable29Joas Schilling2024-10-211-2/+19
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #48709 from nextcloud/backport/48682/stable29Kate2024-10-211-0/+1
|\ \
| * | fix(AppConfig): Add external JWT private key to sensitive keysbackport/48682/stable29provokateurin2024-10-151-0/+1
| | | | | | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | | Merge pull request #48588 from nextcloud/backport/47896/stable29Ferdinand Thiessen2024-10-178-74/+259
|\ \ \ | | | | | | | | [stable29] fix: Make user removal more resilient
| * | | fix: Skip users that still exist in backendFerdinand Thiessen2024-10-153-9/+28
| | | | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
| * | | fix: Make user removal more resilientFerdinand Thiessen2024-10-158-74/+240
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently there is a problem if an exception is thrown in `User::delete`, because at that point the user is already removed from the backend, but not all data is deleted. There is no way to recover from this state, as the user is gone no information is available anymore. This means the data is still available on the server but can not removed by any API anymore. The solution here is to first set a flag and backup the user home, this can be used to recover failed user deletions in a way the delete can be re-tried. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* / / fix(share): Return empty string if no label is setbackport/48673/stable29Ferdinand Thiessen2024-10-151-2/+2
|/ / | | | | | | | | | | | | | | | | * Resolves: https://github.com/nextcloud/server/issues/48629 While the database supports NULL, the typing has always said it only returns *string*. So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix(locking): Accept mixed as value on setTTLbackport/48689/stable29Git'Fellow2024-10-141-1/+1
| | | | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* | fix(setup-checks): Ensure URL with webroot worksFerdinand Thiessen2024-10-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | We basically mock the way `URLGenerator::getAbsoluteURL` works, so we must make sure that the URL might already contain the webroot. Because `baseURL` and `cliURL` also contain the webroot we need to remove the webroot from the URL first. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Daniel <mail@danielkesselberg.de> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix: Allow overriding shouldApplyQuota check from child classesbackport/48623/stable29Julius Knorr2024-10-091-1/+1
|/ | | | Signed-off-by: Julius Knorr <jus@bitgrid.net>
* fix(config): Mark more app configs sensitivebackport/48584/stable29Joas Schilling2024-10-071-0/+9
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #48092 from nextcloud/backport/47316/stable29Kate2024-10-021-1/+1
|\
| * fix: Prevent crash when refreshing metadata for files without an ownerbackport/47316/stable29Vincent FarZz2024-09-161-1/+1
| | | | | | | | | | | | This crash was mostly happening when using external storages and for example the command "occ memories:migrate-google-takeout" Signed-off-by: Vincent FarZz <farcry69@live.fr>