aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* fix: Initialize lastConnectionCheck after first connectionbackport/50874/stable29Louis Chemineau2025-02-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases. It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time. In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];` https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L215-L221 https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L891-L893 https://github.com/nextcloud/3rdparty/blob/2b6d7bf65ff242ea050e736925f752a38d8da220/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php#L136-L139 Then, if the connection name ends up as being 'primary', the reconnect logic is skipped: https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L874-L880 Follow-up of https://github.com/nextcloud/server/pull/41819 Signed-off-by: Louis Chemineau <louis@chmn.me>
* Merge pull request #50876 from nextcloud/backport/50807/stable29Andy Scherzinger2025-02-191-2/+3
|\ | | | | [stable29] fix(files): properly forward open params from short urls
| * fix(files): properly forward open params from short urlsskjnldsv2025-02-191-2/+3
| | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | fix(Mailer): Fix sendmail binary fallbackbackport/46480/stable29Josh2025-02-171-1/+4
|/ | | | Signed-off-by: Josh <josh.t.richards@gmail.com>
* Merge pull request #50795 from nextcloud/backport/50781/stable29Andy Scherzinger2025-02-172-18/+10
|\ | | | | [stable29] perf(files): faster query to fetch incomplete directories
| * perf(files): faster query to fetch incomplete directoriesbackport/50781/stable29Benjamin Gaussorgues2025-02-142-18/+10
| | | | | | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | fix: make locked exception path relative to the viewRobin Appelman2025-02-151-16/+8
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | fix(repair): PHP8.3 deprecation warningbackport/50809/stable29Git'Fellow2025-02-151-8/+4
| | | | | | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* | fix(files): Correctly copy the cache information on copy operationsLouis Chemineau2025-02-133-11/+41
|/ | | | | | Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder. Signed-off-by: Louis Chemineau <louis@chmn.me>
* feat: Use inline password confirmation in external storage settingsLouis Chemineau2025-02-112-65/+64
| | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* fix(FediverseAction): Ensure valid fediverse links are generatedFerdinand Thiessen2025-02-091-5/+18
| | | | | | Harden also for existing values of the profile. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(AccountManager): Sanitize social media handlesFerdinand Thiessen2025-02-091-78/+125
| | | | | | Ensure to only accept valid X and fediverse handles. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(oauth2): adjust db schemas when migrating from owncloudRichard Steinmetz2025-02-062-6/+96
| | | | Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
* fix: explicitly ignore nested mounts when transfering ownershipRobin Appelman2025-02-051-3/+9
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix: translate mount move error messagesRobin Appelman2025-02-051-11/+36
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix: improve checks for moving shares/storages into other mountsRobin Appelman2025-02-051-15/+51
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix(Http): Only allow valid HTTP status code values via templatebackport/49882/stable29provokateurin2025-02-033-8/+8
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* Merge pull request #50600 from nextcloud/backport/50549/stable29Kate2025-02-011-4/+8
|\
| * fix(OC_Files): Fix error response when `event` was not setbackport/50549/stable29Ferdinand Thiessen2025-01-311-4/+8
| | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix(sharing): Move permission validation to share managerFerdinand Thiessen2025-01-311-0/+11
|/ | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Merge pull request #50563 from nextcloud/backport/50530/stable29Kate2025-01-311-7/+5
|\
| * fix(ConvertType): Read dbtype in createConnectionParams and remove safeguardbackport/50530/stable29Nils Wenninghoff2025-01-301-7/+5
| | | | | | | | Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
* | fix: Exclude non accepted shares when computing access listbackport/50519/stable29Louis Chemineau2025-01-301-0/+13
|/ | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* fix(s3): treat empty sse_c_key as not setbackport/50514/stable29Richard Steinmetz2025-01-291-1/+1
| | | | | Co-authored-by: Christian Becker <christian@dabecka.de> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
* fix(files): Do not array access null valuebackport/50437/stable29Ferdinand Thiessen2025-01-291-1/+3
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix: Correctly return app id and app version for `core` styles and imagesFerdinand Thiessen2025-01-292-8/+19
| | | | | | fix(TemplateLayout): `core` is not an app but the server itself Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(performance): use low resolution for blurhashbackport/50494/stable29Max2025-01-281-1/+1
| | | | | | | | Improve blurhash performance by using a low res image. The results are hard to destinguish visualy. It is a **blur** hash after all. Signed-off-by: Max <max@nextcloud.com>
* fix: Metadata field searchbackport/50273/stable29Louis Chemineau2025-01-271-6/+11
| | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* fix: add sse_c_key from S3 object storage properties config to list of ↵backport/49681/stable29Robert Riemann2025-01-221-0/+1
| | | | | | sensitive values Signed-off-by: Robert Riemann <robert@riemann.cc>
* Merge pull request #49990 from nextcloud/backport/49887/stable29Kate2025-01-201-2/+9
|\
| * chore: psalm fixesRobin Appelman2025-01-201-0/+2
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
| * fix: don't skip scanner users filesystem if they have a mountpoint at ↵Robin Appelman2025-01-201-2/+7
| | | | | | | | | | | | /<user>/files/ Signed-off-by: Robin Appelman <robin@icewind.nl>
* | fix(TemplateManager): Remove warning messageGit'Fellow2025-01-201-1/+0
|/ | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* Merge pull request #49675 from nextcloud/backport/49262/stable29Git'Fellow2025-01-091-1/+5
|\ | | | | [stable29] fix: don't do same-storage move optimization with encryption wrappers
| * fix: don't do same-storage move optimization with encryption wrappersRobin Appelman2025-01-091-1/+5
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | Merge pull request #49655 from nextcloud/backport/48769/stable29Git'Fellow2025-01-091-1/+8
|\ \ | | | | | | [stable29] Fix incorrect permissions when copying shared files
| * | fix: use scan_permissions when copying cache itemsRobin Appelman2024-12-091-1/+5
| | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
| * | fix: store unmaked source permissions as scan_permissions when loading share ↵Robin Appelman2024-12-091-0/+3
| |/ | | | | | | | | | | cache items Signed-off-by: Robin Appelman <robin@icewind.nl>
* | fix(preview): Do not try to parse M3U files as MP3Pauli Järvinen2025-01-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | By default, the MP3 audio files get the mimetype `audio/mpeg` and the M3U and M3U8 playlist files get the mimetype `audio/mpegurl`. PreviewManager had such a problem that it registered the MP3 preview provider with a regular expression which matched also the M3U files. This caused an error message to be logged on the info (1) level for each M3U file every time a folder with such files was viewed: "Error while getting cover from mp3 file: File /path/to/some/playlist.m3u is not mpeg/audio!". Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
* | fix: Use getRelativePath method to check if node is inside folderCôme Chilliet2024-12-191-1/+2
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | fix: Fix promotion of reshares from subsubfoldersCôme Chilliet2024-12-191-10/+17
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | chore: Add comment to make code clearerCôme Chilliet2024-12-191-0/+1
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | chore: Turn method description into phpdocCôme Chilliet2024-12-191-1/+1
| | | | | | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
* | fix(shares): Promote reshares into direct shares when share is deletedCôme Chilliet2024-12-191-6/+13
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | fix: Tidy up code for reshare deletionCôme Chilliet2024-12-191-14/+16
| | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | fix: delete re-shares when deleting the parent shareLuka Trovic2024-12-191-0/+69
| | | | | | | | | | | | | | | | Note: Removed part about fix command from original PR Signed-off-by: Luka Trovic <luka@nextcloud.com> Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> (cherry picked from commit 42181c2f490025860e22907255b6917583c798af)
* | fix: make sure we have a valid scheme when testing ocm urlsbackport/49900/stable29skjnldsv2024-12-171-0/+9
| | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | fix(View): Catch exceptions when executing mkdir for non-existent parentsprovokateurin2024-12-171-4/+11
| | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | Merge pull request #49836 from nextcloud/backport/49822/stable29Kate2024-12-161-2/+4
|\ \ | | | | | | [stable29] fix(files_sharing): Fix error messages from password policy
| * | fix(shares): Wrap exceptions from password validation to set code to 400Côme Chilliet2024-12-121-1/+7
| | | | | | | | | | | | | | | | | | | | | This fixes a regression that bad password returned 403 instead of 400 because of previous changes. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-03-25 00:32:00 +0000