aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* fix(RichObjectStrings): Make exception messages for invalid parameters more ↵backport/51442/stable31provokateurin6 days2-7/+7
| | | | | | useful for debugging Signed-off-by: provokateurin <kate@provokateurin.de>
* fix(lookup-server): disable lookup server for non-global scale setupsFerdinand Thiessen11 days1-2/+4
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(lookup-server): do not query data by defaultFerdinand Thiessen11 days1-1/+1
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(systemtags): prevent tag edition if restrictedskjnldsv2025-03-061-1/+13
| | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com> [skip ci]
* fix(login): Properly target public page with attributeLouis Chemineau2025-03-051-1/+2
| | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* Merge pull request #51251 from nextcloud/backport/50989/stable31Andy Scherzinger2025-03-051-1/+1
|\ | | | | [stable31] fix: Use case insensitive check when validating login name
| * fix: use mb_strtolower to convert login namebackport/50989/stable31Cleopatra Enjeck M.2025-03-051-1/+1
| | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
| * fix: Improve string comparisonCleopatra Enjeck M.2025-03-051-1/+1
| | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
| * fix: Use case insensitive check when validating login nameCleopatra Enjeck M.2025-03-051-1/+1
| | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
* | fix: No IFactory in constructorbackport/51259/stable31Marcel Müller2025-03-051-3/+1
| | | | | | | | Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
* | fix(files): Don't do session related work in the constructor of the ViewJoas Schilling2025-03-051-10/+10
|/ | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* feat: log query for dbal exceptionsbackport/51073/stable31Robin Appelman2025-03-042-6/+9
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Merge pull request #51197 from nextcloud/fix/51022/simpler-request-pre-upgradeAndy Scherzinger2025-03-041-49/+99
|\ | | | | [stable31] fix(userconfig): simpler db request pre-upgrade
| * fix(userconfig): simpler db request before 31 upgradefix/51022/simpler-request-pre-upgradeMaxence Lange2025-03-031-49/+99
| | | | | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* | Merge pull request #51203 from nextcloud/backport/51194/stable31Kate2025-03-041-57/+21
|\ \ | | | | | | [stable31] refactor(TempManager): Simplify and unify implementations and remove legacy behavior
| * | refactor(TempManager): Simplify and unify implementations and remove legacy ↵backport/51194/stable31provokateurin2025-03-031-57/+21
| |/ | | | | | | | | | | behavior Signed-off-by: provokateurin <kate@provokateurin.de>
* | fix(Share20\Manager): Propagate user and group deletion to remote share ↵provokateurin2025-03-041-4/+16
| | | | | | | | | | | | providers Signed-off-by: provokateurin <kate@provokateurin.de>
* | fix(Share20): Convert broken hooks to IEventListenerprovokateurin2025-03-043-20/+64
|/ | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* Merge pull request #51090 from nextcloud/backport/51051/stable31Louis2025-03-034-61/+99
|\ | | | | [stable31] feat: Close sessions created for login flow v2
| * fix(login): Support subfolder install for ephemeral sessionsbackport/51051/stable31Louis Chemineau2025-03-031-1/+4
| | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
| * fix(login): Also check legacy annotation for ephemeral sessionsLouis Chemineau2025-03-032-6/+7
| | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
| * feat: Close sessions created for login flow v2Louis Chemineau2025-02-274-61/+95
| | | | | | | | | | | | | | | | Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser. This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request. Signed-off-by: Louis Chemineau <louis@chmn.me>
* | Merge pull request #51058 from nextcloud/backport/51049/stable31Joas Schilling2025-02-272-4/+4
|\ \ | |/ |/| [stable31] fix(l10n): Improve english source strings
| * fix(l10n): Improve english source stringsJoas Schilling2025-02-262-4/+4
| | | | | | | | | | | | | | - No leading/trailing whitespace - Use asci single quote Signed-off-by: Joas Schilling <coding@schilljs.com>
* | fix: Report duplicated extra files in integrity checkbackport/51050/stable31Louis Chemineau2025-02-261-2/+2
|/ | | | | | | | The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files. For example, copying `status.php` to `status 2.php`, will only be reported with the new version. Signed-off-by: Louis Chemineau <louis@chmn.me>
* feat: support migrating an instance to shardingbackport/48795/stable31Robin Appelman2025-02-255-18/+51
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix: Initialize lastConnectionCheck after first connectionbackport/50874/stable31Louis Chemineau2025-02-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases. It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time. In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];` https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L215-L221 https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L891-L893 https://github.com/nextcloud/3rdparty/blob/2b6d7bf65ff242ea050e736925f752a38d8da220/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php#L136-L139 Then, if the connection name ends up as being 'primary', the reconnect logic is skipped: https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L874-L880 Follow-up of https://github.com/nextcloud/server/pull/41819 Signed-off-by: Louis Chemineau <louis@chmn.me>
* refactor: convert sanitize account properties repair step to background jobbackport/50985/stable31Ferdinand Thiessen2025-02-243-12/+41
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix: Optimize repair step performanceFerdinand Thiessen2025-02-241-3/+21
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix: validate account properties as a repair stepFerdinand Thiessen2025-02-243-72/+60
| | | | | | | | Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step, `ValidateAccountProperties` which validates and sanitizes all account properties. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix: Also remove digits at the start and underscore on both ends of appidbackport/50794/stable31Côme Chilliet2025-02-191-1/+1
| | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
* fix: Only keep allowed characters in appid, and flag the method as escapingCôme Chilliet2025-02-191-2/+17
| | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* Merge pull request #50797 from nextcloud/backport/50781/stable31Andy Scherzinger2025-02-192-15/+6
|\ | | | | [stable31] perf(files): faster query to fetch incomplete directories
| * perf(files): faster query to fetch incomplete directoriesbackport/50781/stable31Benjamin Gaussorgues2025-02-132-15/+6
| | | | | | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | fix(cron): Keep job class limitation when searching for the next jobbackport/50896/stable31Joas Schilling2025-02-191-1/+1
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | fix(files): properly forward open params from short urlsskjnldsv2025-02-181-2/+3
| | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | fix(repair): PHP8.3 deprecation warningbackport/50809/stable31Git'Fellow2025-02-151-8/+4
|/ | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* fix: don't use cached root info from shared cache if the watcher has ↵Robin Appelman2025-02-112-0/+16
| | | | | | detected an update Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix: make locked exception path relative to the viewRobin Appelman2025-02-111-16/+8
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix: psalm and OCP @since declarationsJohn Molakvoæ2025-02-091-2/+2
| | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
* fix: make sure we process mime extensions as stringskjnldsv2025-02-091-4/+11
| | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* fix(FediverseAction): Ensure valid fediverse links are generatedFerdinand Thiessen2025-02-061-5/+18
| | | | | | Harden also for existing values of the profile. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(AccountManager): Sanitize social media handlesFerdinand Thiessen2025-02-061-78/+125
| | | | | | Ensure to only accept valid X and fediverse handles. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Merge pull request #50675 from nextcloud/backport/50193/stable31John Molakvoæ2025-02-062-6/+96
|\ | | | | [stable31] fix(oauth2): adjust db schemas when migrating from owncloud
| * fix(oauth2): adjust db schemas when migrating from owncloudbackport/50193/stable31Richard Steinmetz2025-02-052-6/+96
| | | | | | | | Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
* | fix(TaskProcessing\Manager): Always use distributed cache and use PHP serializebackport/50640/stable31Marcel Klehr2025-02-061-0/+1
| | | | | | | | Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* | fix: lib/private/TaskProcessing/Manager.phpMarcel Klehr2025-02-061-2/+4
| | | | | | | | Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* | fix(TaskProcessing\Manager): Always use distributed cache and use PHP serializeMarcel Klehr2025-02-061-6/+3
|/ | | | Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* Merge pull request #50565 from nextcloud/backport/50530/stable31Andy Scherzinger2025-01-311-7/+5
|\ | | | | [stable31] fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard
| * fix(ConvertType): Read dbtype in createConnectionParams and remove safeguardNils Wenninghoff2025-01-301-7/+5
| | | | | | | | Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>