aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* fix(Middleware): log deprecation when annotation was actually usedfix/noid/deprecation-correct-caseArthur Schiwon2024-11-121-1/+1
| | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Merge pull request #48736 from nextcloud/joblist-build-error-logAndy Scherzinger2024-11-111-0/+1
|\ | | | | fix: log a warning when we can't build a background job
| * fix: log a warning when we can't build a background jobjoblist-build-error-logRobin Appelman2024-10-161-0/+1
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | fix(ros): Copy better typing information from Notifications appbugfix/noid/copy-better-typing-from-notifications-appJoas Schilling2024-11-111-1/+2
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #49035 from nextcloud/jtr/fix-streamer-zip64John Molakvoæ2024-11-091-1/+1
|\ \
| * | fix(streamer): zip64 should work on 32-bit env nowjtr/fix-streamer-zip64Josh2024-10-311-1/+1
| | | | | | | | | | | | | | | Since DeepDiver1975/PHPZipStreamer#11 was merged Signed-off-by: Josh <josh.t.richards@gmail.com>
* | | Merge pull request #49087 from AIlkiv/getting-default-timezone-for-local-timeJohn Molakvoæ2024-11-091-1/+1
|\ \ \
| * | | fix: Getting default timezone for local timeAndrii2024-11-051-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Andrii Ilkiv <a.ilkiv.ye@gmail.com>
* | | | Merge pull request #49146 from nextcloud/fix/undefined-responseJohn Molakvoæ2024-11-081-4/+5
|\ \ \ \
| * | | | chore: use `$this->logger` and prevent Server::getfix/undefined-responseskjnldsv2024-11-081-2/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
| * | | | Fix Undefined variable: response notice in case of non-404 errorVictor Dubiniuk2024-11-081-2/+3
| | | | | | | | | | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | | | fix(util): Correctly create Reflection of method for PHP 8.3+Joas Schilling2024-11-081-1/+6
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | fix(logger): Fix closure detection when filtering sensitive parametersJoas Schilling2024-11-081-1/+4
|/ / / / | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | feat: add iMip Request HandlingSebastianKrupinski2024-11-071-0/+83
| | | | | | | | | | | | | | | | Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
* | | | test: add some minimal testing for metadata storagemetadata-storage-idRobin Appelman2024-11-073-5/+16
| | | | | | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | fix: smuggle storage id to metadata insert queriesRobin Appelman2024-11-073-1/+33
| | | | | | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | Merge pull request #49116 from nextcloud/bugfix/noid/validate-parameter-keysJoas Schilling2024-11-071-18/+15
|\ \ \ \ | | | | | | | | | | fix(richobjectstrings): Add missing placeholder validation
| * | | | fix(richobjectstrings): Improve array typeJoas Schilling2024-11-071-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | fix(richobjectstrings): Add missing placeholder validationJoas Schilling2024-11-061-18/+15
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | Merge pull request #49114 from nextcloud/fix/qbmapper/find-entities-return-typeJoas Schilling2024-11-071-3/+3
|\ \ \ \ \ | |/ / / / |/| | | | fix(QBMapper): Fix findEntities() return type to be list<T>
| * | | | fix(QBMapper): Fix findEntities() return type to be list<T>fix/qbmapper/find-entities-return-typeprovokateurin2024-11-061-3/+3
| | | | | | | | | | | | | | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | | | | feat(appconfig): Only log lazy-appconfig when an app can do something about ittechdebt/noid/more-useful-debug-logsJoas Schilling2024-11-061-16/+18
|/ / / / | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #49039 from nextcloud/jtr/fix-ipv6-zone-ids-link-localJohn Molakvoæ2024-11-063-4/+6
|\ \ \ \
| * | | | fix(net): Add IPv6 zone handling to IpAddressClassifierJosh2024-10-311-1/+1
| | | | | | | | | | | | | | | Signed-off-by: Josh <josh.t.richards@gmail.com>
| * | | | fix(security): Handle IPv6 zone IDs used in link-local addressesJosh2024-10-311-1/+2
| | | | | | | | | | | | | | | Signed-off-by: Josh <josh.t.richards@gmail.com>
| * | | | fix(security): Handle IPv6 zone IDs used in link-local addressesJosh2024-10-311-2/+3
| | |/ / | |/| | | | | | Signed-off-by: Josh <josh.t.richards@gmail.com>
* | | | Merge pull request #49015 from nextcloud/fix/openapi/array-syntaxJohn Molakvoæ2024-11-0612-26/+31
|\ \ \ \
| * | | | fix(OpenAPI): Adjust array syntax to avoid ambiguitiesfix/openapi/array-syntaxprovokateurin2024-11-0512-26/+31
| |/ / / | | | | | | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | | | Merge pull request #48721 from nextcloud/feat/allow-getter-setter-decl-forsJohn Molakvoæ2024-11-061-10/+43
|\ \ \ \
| * | | | feat(DeclarativeSettings): Allow to implement value getter and setter ↵Ferdinand Thiessen2024-10-151-10/+43
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | directly in Form Instead of implementing the form class, a setter event listener and a getter event listener, this allows to simply write a basic class that provides `getSchema`, `setValue` and `getValue` functions. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | fix: Handle exception when clearing previously removed two factor tokensclear-pending-two-factor-tokens-also-from-configurationDaniel Calviño Sánchez2024-11-051-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a token was already removed from the database but not from the configuration clearing the tokens will try to remove it again from the database, which caused a DoesNotExistException to be thrown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | fix: Clear pending two factor tokens also from configurationDaniel Calviño Sánchez2024-11-051-0/+2
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | Otherwise as the tokens were removed from the database but not from the configuration the next time that the tokens were cleared the previous tokens were still got from the configuration, and trying to remove them again from the database ended in a DoesNotExistException being thrown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | fix(owncloud): Fix ownCloud migration with oauth2 appbugfix/noid/fix-oauth2-owncloud-migrationJoas Schilling2024-11-041-4/+2
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #47425 from ↵Côme Chilliet2024-11-041-0/+88
|\ \ \ | |_|/ |/| | | | | | | | nextcloud/fix/avoid-invalid-share-on-transfer-ownership fix: promote re-shares when deleting the parent share
| * | fix: Use getRelativePath method to check if node is inside folderfix/avoid-invalid-share-on-transfer-ownershipCôme Chilliet2024-10-141-1/+2
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | fix: Fix promotion of reshares from subsubfoldersCôme Chilliet2024-10-141-9/+16
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | chore: Add comment to make code clearerCôme Chilliet2024-10-141-0/+1
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | chore: Turn method description into phpdocCôme Chilliet2024-10-141-1/+1
| | | | | | | | | | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
| * | fix(shares): Promote reshares into direct shares when share is deletedCôme Chilliet2024-10-141-6/+14
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | fix: Tidy up code for reshare deletionCôme Chilliet2024-10-141-14/+16
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | fix: delete re-shares when deleting the parent shareLuka Trovic2024-10-141-0/+69
| | | | | | | | | | | | | | | | | | | | | Note: Removed part about fix command from original PR Signed-off-by: Luka Trovic <luka@nextcloud.com> Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix(sharding): typo in addOrderByfix/recently_active_pgsqlBenjamin Gaussorgues2024-10-301-1/+1
| | | | | | | | | | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | | fix(users): improve recently active searchBenjamin Gaussorgues2024-10-301-28/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove DISTINCT clause to fix PgSQL - Join user table only if necessary - Don't show people who never connected in active list - Add test Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | | Merge pull request #46151 from nextcloud/enh/do-not-enforce-cache-for-cliJohn Molakvoæ2024-10-291-6/+20
|\ \ \
| * | | feat(cache): CLI should not fail if APCu is not availableenh/do-not-enforce-cache-for-cliMichaIng2024-08-011-6/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | but fallback to NullCache. This can be the case if APCu is used without apc.enable_cli=1. APCu however runs within the PHP instance and hence cannot be shared between CLI and web or used as distributed cache. The CLI call can hence only create or invalidate entries for itself. For short-living CLI calls, this is theoretically a downsides regarding performance and resource usage, and Nextcloud must not have any issues using the dummy NullCache instead of an isolated freshly created and destroyed APCu instance. This partly reverts https://github.com/nextcloud/server/pull/25770. The fallback was removed, because CLI calls started to hang after https://github.com/nextcloud/server/pull/25440. The reason however was not that a cache is generally required for CLI calls, but because the previously logged warning invoked the user backend, which invoked again the caching backend, causing a loop. This commit re-adds the fallback without logging a warning, and for APCu only. For mentioned reasons, it is okay to fallback to NullCache silently. If Redis or memcached are configured but not available, then the web UI would fail as well, and it makes sense to abort and inform CLI calls as well then. The motivation is to make apc.enable_cli=1 optional, and that hence the documentation about it can be removed. We should not enforce admins to enable APCu for CLI calls, which is reasonably disabled by default. This also reduces requirements for hosting providers to support Nextcloud. Signed-off-by: MichaIng <micha@dietpi.com>
* | | | Merge pull request #47847 from ↵John Molakvoæ2024-10-291-2/+6
|\ \ \ \ | | | | | | | | | | | | | | | nextcloud/fix-copying-or-moving-from-shared-groupfolders
| * | | | fix: Fix copying or moving from shared groupfoldersDaniel Calviño Sánchez2024-10-101-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When copying or moving between two local storages the source path (on disk) to copy or move from is got from the unjailed path of the source storage. However, if the source storage has more than one jail getting the unjailed path resolves the most external jail, but the source path needs to be got from the most internal jail instead (the one closer to the local storage). This can happen, for example, with a shared groupfolder: in that case there is an external jail for the shared storage, and one internal jail for the groupfolder storage wrapped by the shared storage. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | fix(systemtags): translations and etag method casingskjnldsv2024-10-291-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | | | feat(systemtags): add cypress tests and fix a few logic issuesskjnldsv2024-10-291-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | | | feat(systemtags): add etag support and handle proppatchskjnldsv2024-10-294-2/+67
| | | | | | | | | | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>