aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | fix(files): Don't do session related work in the constructor of the ViewJoas Schilling2025-03-051-10/+10
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | fix: use mb_strtolower to convert login namecase-insensitive-loginCleopatra Enjeck M.2025-03-051-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
* | | | fix: Improve string comparisonCleopatra Enjeck M.2025-03-051-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
* | | | fix: Use case insensitive check when validating login nameCleopatra Enjeck M.2025-03-051-1/+1
| |/ / |/| | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
* | | Merge pull request #47686 from nextcloud/fix/move-email-logic-local-user-backendCôme Chilliet2025-03-043-178/+140
|\ \ \ | | | | | | | | fix: Move login via email logic to local backend
| * | | fix: Move login via email logic to local backendfix/move-email-logic-local-user-backendFerdinand Thiessen2025-03-033-178/+140
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backends can decide which names they accept for login, e.g. with user_ldap you can configure arbitrary login fields. This was a hacky approach to allow login via email, so instead this is now only handled by the local user backend. This also fixes some other related problems: Other logic relys on `backend::get()` which was not handling email, so e.g. password policy could not block users logged in via email if they use out-dated passwords. Similar for other integrations, as the user backend was not consistent with what is a login name and what not. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | Merge pull request #51073 from nextcloud/dbal-exception-queryRobin Appelman2025-03-042-6/+9
|\ \ \ \ | | | | | | | | | | feat: log query for dbal exceptions
| * | | | feat: log query for dbal exceptionsdbal-exception-queryRobin Appelman2025-02-262-6/+9
| | |_|/ | |/| | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | Merge pull request #51116 from nextcloud/enh/noid/nullable-rangeArthur Schiwon2025-03-041-1/+1
|\ \ \ \ | | | | | | | | | | feat(AppFramework): extend range check to optional parameters
| * | | | feat(AppFramework): extend range check to optional parametersenh/noid/nullable-rangeArthur Schiwon2025-02-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now it also applies when a paramater is documtend with a pending |null, but no further unionation is considered. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | | | feat(appconfig): removing pre-migration checkenh/noid/clean-migration-check-appconfigMaxence Lange2025-03-041-42/+7
| |_|/ / |/| | | | | | | | | | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* | | | Merge pull request #51000 from nextcloud/fix/federatedfilesharing/group-cleanupStephan Orbaugh2025-03-034-24/+80
|\ \ \ \ | | | | | | | | | | fix(FederatedShareProvider): Delete external shares when groups are deleted or users removed from a group
| * | | | fix(Share20\Manager): Propagate user and group deletion to remote share ↵provokateurin2025-03-031-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | providers Signed-off-by: provokateurin <kate@provokateurin.de>
| * | | | fix(Share20): Convert broken hooks to IEventListenerprovokateurin2025-03-033-20/+64
| | | | | | | | | | | | | | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | | | | refactor(TempManager): Simplify and unify implementations and remove legacy ↵refactor/tempmanagerprovokateurin2025-03-031-57/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | behavior Signed-off-by: provokateurin <kate@provokateurin.de>
* | | | | Merge pull request #51095 from nextcloud/artonge/fix/epehmeral_sessionsLouis2025-03-033-7/+11
|\ \ \ \ \ | | | | | | | | | | | | fix(login): Ephemeral sessions
| * | | | | fix(login): Support subfolder install for ephemeral sessionsartonge/fix/epehmeral_sessionsLouis Chemineau2025-02-271-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
| * | | | | fix(login): Also check legacy annotation for ephemeral sessionsLouis Chemineau2025-02-272-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* | | | | | feat(db): add truncateTable methodpulsejet/truncate-1Varun Patil2025-03-022-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Varun Patil <varunpatil@ucla.edu>
* | | | | | fix: incorrect types detected by updated stubschore/update-stubFerdinand Thiessen2025-02-271-3/+3
| |_|/ / / |/| | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | | Merge pull request #50999 from nextcloud/fix/move-away-from-oc-appCôme Chilliet2025-02-273-23/+7
|\ \ \ \ \ | |/ / / / |/| | | | fix: Replace OC_App calls by IAppManager
| * | | | fix: Remove incorrect `@throws` annotations and move away from OC_Appfix/move-away-from-oc-appCôme Chilliet2025-02-241-19/+3
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | | | fix: Replace OC_App calls by IAppManagerCôme Chilliet2025-02-242-4/+4
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | | | Merge pull request #51051 from nextcloud/artonge/fix/login_flow_v2_sessions_2Louis2025-02-274-61/+95
|\ \ \ \ \ | | | | | | | | | | | | feat: Close sessions created for login flow v2
| * | | | | feat: Close sessions created for login flow v2artonge/fix/login_flow_v2_sessions_2Louis Chemineau2025-02-264-61/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser. This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request. Signed-off-by: Louis Chemineau <louis@chmn.me>
* | | | | | Merge pull request #51050 from nextcloud/artonge/fix/extra_files_integrity_checkLouis2025-02-261-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | fix: Report duplicated extra files in integrity check
| * | | | | | fix: Report duplicated extra files in integrity checkartonge/fix/extra_files_integrity_checkLouis Chemineau2025-02-261-2/+2
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files. For example, copying `status.php` to `status 2.php`, will only be reported with the new version. Signed-off-by: Louis Chemineau <louis@chmn.me>
* / / / / / fix(l10n): Improve english source stringsJoas Schilling2025-02-262-4/+4
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - No leading/trailing whitespace - Use asci single quote Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | fix(lint): correct comment identationenh/ldap-clearer-errorsAndy Scherzinger2025-02-251-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
* | | | | Merge pull request #50764 from p1gp1g/patch-1Andy Scherzinger2025-02-251-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Update doc comment for prefixTableName
| * | | | | Update doc comment for prefixTableNameS1m2025-02-111-0/+2
| | | | | | | | | | | | | | | | | | Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com>
* | | | | | feat: support migrating an instance to shardingsharding-existingRobin Appelman2025-02-255-18/+51
| |_|_|/ / |/| | | | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | | Merge pull request #50874 from nextcloud/artonge/fix/login_flow_v2_sessionsJulius Knorr2025-02-251-2/+2
|\ \ \ \ \ | |_|/ / / |/| | | | fix: Initialize lastConnectionCheck after first connection
| * | | | fix: Initialize lastConnectionCheck after first connectionartonge/fix/login_flow_v2_sessionsLouis Chemineau2025-02-191-2/+2
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases. It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time. In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];` https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L215-L221 https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L891-L893 https://github.com/nextcloud/3rdparty/blob/2b6d7bf65ff242ea050e736925f752a38d8da220/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php#L136-L139 Then, if the connection name ends up as being 'primary', the reconnect logic is skipped: https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L874-L880 Follow-up of https://github.com/nextcloud/server/pull/41819 Signed-off-by: Louis Chemineau <louis@chmn.me>
* | | | refactor: convert sanitize account properties repair step to background jobfix/account-property-validationFerdinand Thiessen2025-02-243-12/+41
| | | | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | fix: Optimize repair step performanceFerdinand Thiessen2025-02-241-3/+21
| | | | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | fix: validate account properties as a repair stepFerdinand Thiessen2025-02-243-72/+60
|/ / / | | | | | | | | | | | | | | | | | | | | | Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step, `ValidateAccountProperties` which validates and sanitizes all account properties. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | fix(cron): Keep job class limitation when searching for the next jobbugfix/noid/keep-job-class-limitationJoas Schilling2025-02-191-1/+1
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #50864 from nextcloud/fix/fix-psalm-taint-errors-2Joas Schilling2025-02-183-37/+17
|\ \ \ | | | | | | | | fix: Fix psalm taint false-positives by small refactorings
| * | | fix: Fix psalm taint false-positives by small refactoringsfix/fix-psalm-taint-errors-2Côme Chilliet2025-02-173-37/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Mostly make it clear that we trust admin input or that we correctly escape strings. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | | fix(files): properly forward open params from short urlsskjnldsv2025-02-181-2/+3
|/ / / | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | chore: Add missing star in phpdoc commentfix/fix-psalm-taint-errorsCôme Chilliet2025-02-171-1/+1
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Fix false-positive psalm taint errors when outputting plain textCôme Chilliet2025-02-171-2/+10
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Fix psalm taint false-positive by escaping trusted inputCôme Chilliet2025-02-171-11/+11
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Correctly tag json encoding in BaseResponse to fix false-positiveCôme Chilliet2025-02-171-1/+9
| | | | | | | | | | | | | | | | | | …in psalm taint analysis Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Move config.php taint trust upstream directly in OC\Config classCôme Chilliet2025-02-172-21/+23
| | | | | | | | | | | | | | | | | | This solves some false-positive psalm taint errors Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Work around psalm taint false-positive by not using var_exportCôme Chilliet2025-02-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | var_export is listed as a taint sink because it may output stuff depending on the parameters. It was not the case here, but we can simply json_encode the result by passing it as context to the logger method rather than using var_export. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | chore: Correctly flag json encoding methods as escaping html and quotesCôme Chilliet2025-02-171-2/+3
| | | | | | | | | | | | | | | | | | | | | Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we only use it in JSON output anyway. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Fix psalm taint error in L10N factoryCôme Chilliet2025-02-171-3/+24
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix(repair): PHP8.3 deprecation warningfixPhp83DeprecationGit'Fellow2025-02-141-8/+4
| | | | | | | | | | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-05-03 03:05:23 +0000