aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* ensure home storage is initialized on first setupRobin Appelman2020-07-093-2/+6
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Use the correct mountpoint to calculateRoeland Jago Douma2020-07-091-1/+8
| | | | | | | If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix regression in return value of OC_Util::checkDataDirectoryPermissions due ↵Morris Jobke2020-07-091-2/+2
| | | | | | to #21761 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Kill another unneeded translationRoeland Jago Douma2020-07-081-7/+5
| | | | | | We should only translate things when we actually need them. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #21758 from nextcloud/fix/routes/defaultsRoeland Jago Douma2020-07-081-6/+10
|\ | | | | Fix supporting defaults for routes
| * Fix supporting defaults for routesRoeland Jago Douma2020-07-081-6/+10
| | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Only translate if we need the stringRoeland Jago Douma2020-07-081-2/+1
|/ | | | | | | | This translation was done in each call. Over and over and over again. All while it was probably not used in 99.99999% of the cases. A small gain. But still. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Do not create a RouteActionHandler object for each routeRoeland Jago Douma2020-07-072-16/+23
| | | | | | | | | | This is not required and doesn't allow us to be properly lazy. On top of it this doesnt allow us to cache the routes (since closures/objects can't be cached). This is the first small step into cleaning up the routing we have Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #21676 from J0WI/fix-chmod-on-fdMorris Jobke2020-07-071-1/+1
|\ | | | | Fix chmod on file descriptor
| * Fix chmod on file descriptorJ0WI2020-07-031-1/+1
| | | | | | | | Signed-off-by: J0WI <J0WI@users.noreply.github.com>
* | Merge pull request #21714 from nextcloud/td/remove/getAppFolderMorris Jobke2020-07-061-17/+0
|\ \ | | | | | | Remove old deprecated getAppFolder
| * | Remove old deprecated getAppFolderRoeland Jago Douma2020-07-061-17/+0
| | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | Update SecurityMiddleware.phpHolger Hees2020-07-061-1/+1
|/ / | | | | | | | | | | OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header. in other areas OC::$WEBROOT is always used together with an /
* | Cascading effect - more code that now is not used anymoreMorris Jobke2020-07-061-338/+0
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Tags.php and the old sharing mechanismMorris Jobke2020-07-063-78/+7
| | | | | | | | | | | | The old sharing mechanism isn't working anymore, because it was replaced by Share 2.0. Also it was nowhere used so this removes the code paths and reduces complexity. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #21074 from jvsalo/shared-lock-multi-releaseMorris Jobke2020-07-061-1/+5
|\ \ | | | | | | Fix releasing a shared lock multiple times
| * | Fix releasing a shared lock multiple timesJaakko Salo2020-05-241-1/+5
| | | | | | | | | | | | Signed-off-by: Jaakko Salo <jaakkos@gmail.com>
* | | Merge pull request #21238 from ↵Morris Jobke2020-07-061-0/+44
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/techdebt/noid/deferrable-notification-apps Allow notification apps to defer and flush the sending
| * | | Allow notification apps to defer and flush the sendingJoas Schilling2020-07-031-0/+44
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #21665 from nextcloud/debt/noid/job-listMorris Jobke2020-07-062-17/+9
|\ \ \ \ | | | | | | | | | | Fix wrong phpdoc for execute method
| * | | | Use formal type hints instead of informal PHPDocMorris Jobke2020-07-061-16/+6
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| * | | | Fix wrong phpdoc for execute methodDaniel Kesselberg2020-07-032-2/+4
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | | | | Merge pull request #21636 from nextcloud/lock-exception-readable-pathMorris Jobke2020-07-054-7/+8
|\ \ \ \ \ | | | | | | | | | | | | add proper paths to locking exceptions
| * | | | | add proper paths to locking exceptionsRobin Appelman2020-06-304-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | while some code paths do wrap the "raw" locking exception into one with a proper path, not all of them do by adding the proper path to the original exception we ensure that we always have the usefull information in out logs Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | | | Merge pull request #21626 from nextcloud/enhancement/injectible-callablesMorris Jobke2020-07-052-0/+73
|\ \ \ \ \ \ | | | | | | | | | | | | | | Callable parameter injection
| * | | | | | Callable parameter injectionChristoph Wurst2020-07-032-0/+73
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is like what we have to DI and classes, but for callables. The motivating factor is to get rid of *service locators* in the `boot` method of apps as a new pattern is about to emerge where we have lots of `query` calls on the app or server container in order to fetch some services. With this little helper it's possible to call another (public) method and magically have everything injected. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | | | Merge pull request #21533 from ↵Roeland Jago Douma2020-07-043-5/+25
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | | | | | | | | | | | | | nextcloud/techdebt/noid/dedicated-method-to-get-a-users-language Techdebt/noid/dedicated method to get a users language
| * | | | | Use the new method everywhereJoas Schilling2020-07-032-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | | Add a dedicated method to get the language for another userJoas Schilling2020-07-011-0/+23
| | |_|/ / | |/| | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | Fix static method call for s3 bucket compat checkChristoph Wurst2020-07-031-2/+2
| |/ / / |/| | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | Merge pull request #21360 from nextcloud/root-storage-prevent-scanningRoeland Jago Douma2020-07-023-1/+87
|\ \ \ \ | | | | | | | | | | prevent the root storage from accidentally scanning user folders
| * | | | prevent the root storage from accidentally scanning user foldersRobin Appelman2020-06-113-1/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | while this scan *should* never be triggered, it's good to have some failsafe to ensure that the users home contents don't end up getting scanned in the root storage Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | | Merge pull request #21580 from therealklanni/masterRoeland Jago Douma2020-07-021-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Add audio formats to htaccess
| * | | | | Add audio formats to htaccessKevin Lanni2020-06-241-1/+1
| | |_|/ / | |/| | | | | | | | | | | | | Signed-off-by: Kevin Lanni <therealklanni@gmail.com>
* | | | | Merge pull request #21599 from nextcloud/debt/noid/type-to-typesRoeland Jago Douma2020-07-021-3/+3
|\ \ \ \ \ | | | | | | | | | | | | Replace TYPE with TYPES
| * | | | | Replace TYPE with TYPESDaniel Kesselberg2020-06-301-3/+3
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | As TYPE::* is deprecated. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* / | | | Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validatingJoas Schilling2020-07-021-0/+6
|/ / / / | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #21588 from nextcloud/bug/21214/method-signatureRoeland Jago Douma2020-06-301-1/+2
|\ \ \ \ | | | | | | | | | | Update presign method to match with interface again.
| * | | | Update presign method to match with interface again.Daniel Kesselberg2020-06-251-1/+2
| |/ / / | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | | | Merge pull request #21589 from nextcloud/debt/noid/wrong-exception-callRoeland Jago Douma2020-06-301-1/+1
|\ \ \ \ | | | | | | | | | | Set retry = false for forbidden exception.
| * | | | Set retry = false for forbidden exception.Daniel Kesselberg2020-06-251-1/+1
| |/ / / | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | | | Merge pull request #21596 from nextcloud/debt/noid/share-return-mismatchRoeland Jago Douma2020-06-301-3/+3
|\ \ \ \ | | | | | | | | | | Replace Share with IShare and add missing return
| * | | | Replace Share with IShare and add missing return.Daniel Kesselberg2020-06-261-3/+3
| |/ / / | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* / / / Log usages of the deprecated app.php fileChristoph Wurst2020-06-301-0/+3
|/ / / | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | Merge pull request #21558 from nextcloud/part-file-rename-maskRoeland Jago Douma2020-06-241-7/+3
|\ \ \ | | | | | | | | relax permissions mask check for detecting part file rename
| * | | relax permissions mask check for detecting part file renameRobin Appelman2020-06-241-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | with files drop uploads the original file name isn't always used for the '.ocTransferId' source path Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | Fix testsJoas Schilling2020-06-241-1/+0
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Update share type constant usageJoas Schilling2020-06-2414-202/+208
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #20916 from nextcloud/feature/unified-search-apiChristoph Wurst2020-06-249-2/+304
|\ \ \ \ | | | | | | | | | | Add unified search API
| * | | | Deprecate \OCP\ISearchChristoph Wurst2020-06-245-2/+20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>