summaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* fix(comments): Use provided offset in best effort when loading commentsJoas Schilling2023-09-191-0/+16
| | | | | | | | | When we didn't find the "$lastKnownComment" the whole condition was ignored. Now we still use the ID as an offset. This is required as a fall-back for expired messages in Talk and deleted comments in other apps. Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix: Only read unencrypted_size when file is actually encryptedJulius Härtl2023-09-122-3/+3
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* fix: Only store unencrypted_size if path should be encryptedJulius Härtl2023-09-122-1/+3
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* fix(logging): user log condition featureCôme Chilliet2023-09-071-10/+12
| | | | Signed-off-by: Anna Larch <anna@nextcloud.com>
* fix(ratelimit): Only use memory cache backend for redisJoas Schilling2023-09-061-2/+2
| | | | Signed-off-by: Anna Larch <anna@nextcloud.com>
* Merge pull request #40261 from nextcloud/backport/40234/stable25Arthur Schiwon2023-09-051-0/+5
|\ | | | | [stable25] enh: skip processing for empty response
| * enh: skip processing for empty responseDaniel Kesselberg2023-09-051-0/+5
| | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | Merge pull request #40233 from nextcloud/fix/fix-video-seeking-public-linkArthur Schiwon2023-09-052-6/+16
|\ \ | | | | | | [stable25] Detect aborted connection in OC\Files\View and stop writing data to the output buffer
| * | Apply suggestions from code review in View.phpCôme Chilliet2023-09-051-4/+4
| | | | | | | | | | | | | | | | | | Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | Lower log to debug for connections aborted by the clientCôme Chilliet2023-09-042-1/+6
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
| * | Detect aborted connection in OC\Files\View and stop writing data to theCôme Chilliet2023-09-042-5/+10
| |/ | | | | | | | | | | output buffer Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | Merge pull request #40188 from nextcloud/backport/39017/stable25Arthur Schiwon2023-09-051-1/+1
|\ \ | | | | | | [stable25] fix(s3): fix handling verify_bucket_exists parameter
| * | fix(s3): fix handling verify_bucket_exists parameterThomas Citharel2023-08-311-1/+1
| |/ | | | | | | | | | | | | | | If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid verifying that the bucket exists. However empty(falsy) will always return true, so this condition would not work. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
* | Merge pull request #39731 from nextcloud/backport/39698/stable25Arthur Schiwon2023-09-051-1/+1
|\ \ | |/ |/| [stable25] Catch more invalid cache source storage paths
| * fix: simplify `sourceData` checkJohn Molakvoæ2023-08-061-1/+1
| | | | | | | | Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
| * Catch more invalid cache source storage pathsJosh Richards2023-08-061-1/+1
| | | | | | | | | | | | | | | | | | | | OC\Files\Cache\Cache::get can return string|false|null, not just string|false. - nextcloud/server#26270 added handling of false, but null is needed too. - Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason Related: nextcloud/server#19009 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
* | fix(CalDAV): check voject exists before attempting any operationAnna Larch2023-08-291-6/+35
| | | | | | | | Signed-off-by: Anna Larch <anna@nextcloud.com>
* | Merge pull request #39703 from nextcloud/cache-imcomplete-id-first-25Robin Appelman2023-08-281-3/+16
|\ \ | | | | | | [stable25] Select the fileid first when looking for incomplete files
| * | select the fileid first when looking for incomplete filesRobin Appelman2023-08-281-3/+16
| |/ | | | | | | | | | | this seems to improve mariadbs index selection Signed-off-by: Robin Appelman <robin@icewind.nl>
* / fix: don't emit Hooks when hookpaths are emptyAnna Larch2023-08-281-49/+57
|/ | | | | Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Max <max@nextcloud.com>
* Merge pull request #39438 from nextcloud/backport/39309/stable25Arthur Schiwon2023-08-021-1/+1
|\ | | | | [stable25] fix(profile): fix getUID on nullable user variable
| * fix(profile): fix getUID on nullable user variableThomas Citharel2023-07-171-1/+1
| | | | | | | | | | | | | | | | | | As per method signature, $visitingUser is nullable, so we can't be sure calling getUid() on it will work. Closes #35766 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
* | Merge pull request #39598 from nextcloud/backport/38667/stable25Arthur Schiwon2023-08-021-4/+8
|\ \ | | | | | | [stable25] fix(SystemTagManager): Use truncated tagName in getTag and updateTag
| * | fix(SystemTagManager): Use truncated tagName in getTag and updateTagMarcel Klehr2023-07-271-4/+8
| | | | | | | | | | | | Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* | | Merge pull request #39451 from nextcloud/backport/38907/stable25Arthur Schiwon2023-08-021-3/+6
|\ \ \ | | | | | | | | [stable25] Fix: ContactManager search with fullmatch
| * | | fix(mail): ContactManager search with fullmatchJohannes Merkel2023-07-181-3/+6
| | |/ | |/| | | | | | | Signed-off-by: Johannes Merkel <mail@johannesgge.de>
* | | Merge pull request #39371 from nextcloud/backport/39339/stable25Arthur Schiwon2023-08-021-0/+4
|\ \ \ | |_|/ |/| | [stable25] fix(node): non-existing folder is not searchable
| * | fix(node): non-existing folder is not searchableArthur Schiwon2023-07-131-0/+4
| |/ | | | | | | | | | | | | the previosuly introduced searchBySystemTag was not overwritten in NonExistingFolder and could run the inherited method. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | Add instance category while checking new updatesBenjamin Gaussorgues2023-07-251-14/+38
| | | | | | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | fix(apps): Fix loading info.xml fileJoas Schilling2023-07-202-5/+5
|/ | | | | | Ref: https://bugs.php.net/bug.php?id=62577 Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #39101 from nextcloud/backport/39093/stable25Arthur Schiwon2023-07-121-1/+1
|\ | | | | [stable25] Silent `imagecreatefromstring()` errors
| * Silent imagecreatefromstring() errorsGit'Fellow2023-07-041-1/+1
| | | | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* | Merge pull request #39233 from nextcloud/backport/39202/stable25Arthur Schiwon2023-07-116-34/+67
|\ \ | | | | | | [stable25] use more efficient tag retrieval on DAV report request
| * | fix: PHP 7.4 compatibilityArthur Schiwon2023-07-102-2/+2
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | refactor: adjust to unexposed searchBySystemTagArthur Schiwon2023-07-071-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - in this backport we have to drop the breaking addition in \OCP\Files\Folder - this requires adjustments in check for the existance of the method but also in testing - another change in \OCP\SystemTag\ISystemTagManager can be applied as this interface is not implemented elsewhere Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | fix: cominbation of small fixesArthur Schiwon2023-07-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | - possible null return - parameter name mismatch in implementation - incomplete unit test Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | fix: include invisible tags for adminsArthur Schiwon2023-07-073-43/+43
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | fix: favorites view and universal search against tagsArthur Schiwon2023-07-071-17/+30
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | fix: change if with conditionless else to switch; and a parameter valueArthur Schiwon2023-07-072-20/+25
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | use efficient tag retrieval on DAV report requestArthur Schiwon2023-07-073-17/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - uses DAV search approach against valid files joined by systemtag selector - reduced table join for tag/systemtag search - supports pagination - no changes to the output formats or similar Example request body: <?xml version="1.0"?> <oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns"> <d:prop> <d:getcontentlength/> <d:getcontenttype/> <d:getetag/> <d:getlastmodified/> <d:resourcetype/> <nc:face-detections/> <nc:file-metadata-size/> <nc:has-preview/> <nc:realpath/> <oc:favorite/> <oc:fileid/> <oc:permissions/> <nc:nbItems/> </d:prop> <oc:filter-rules> <oc:systemtag>32</oc:systemtag> </oc:filter-rules> <d:limit> <d:nresults>50</d:nresults> <nc:firstresult>0</nc:firstresult> </d:limit> </oc:filter-files> Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | Merge pull request #39253 from nextcloud/backport/38046/stable25Joas Schilling2023-07-101-11/+3
|\ \ \ | | | | | | | | [stable25] fix(dav): Abort requests with 429 instead of waiting
| * | | chore: fix codestyle for \OC\Files\Node\FolderDaniel Kesselberg2023-07-101-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
| * | | fix: use handleLoginFailed for invalid email addressDaniel Kesselberg2023-07-101-9/+1
| | | | | | | | | | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
| * | | fix(dav): Abort requests with 429 instead of waitingJoas Schilling2023-07-101-2/+2
| |/ / | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #39032 from nextcloud/backport/38917/stable25Arthur Schiwon2023-07-101-1/+6
|\ \ \ | | | | | | | | [stable25] fix(l10n): Fix plural issue with different locale and language
| * | | fix(l10n): Fix plural issue with different locale and languageJoas Schilling2023-06-271-1/+6
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | We need to use the language code here instead of the locale, because Symfony does not distinguish between the two and would otherwise e.g. with locale "Czech" and language "German" try to pick a non-existing plural rule, because Czech has 4 plural forms and German only 2. Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | style: satisfy code style checkerArthur Schiwon2023-07-071-1/+1
| |/ |/| | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | Merge pull request #39153 from nextcloud/backport/39115/stable25Arthur Schiwon2023-07-061-13/+21
|\ \ | | | | | | [stable25] fix(sse): don't update uncached files
| * | fix(sse): don't update uncached filesRichard Steinmetz2023-07-041-13/+21
| |/ | | | | | | Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
* | Merge pull request #39154 from nextcloud/backport/38625/stable25Arthur Schiwon2023-07-067-38/+45
|\ \ | | | | | | [stable25] fix: expect interface, not a specific implementation