summaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* Replace static call to Share::unshare with ShareManager->deleteShare in testsMorris Jobke2020-11-302-242/+0
| | | | | | And then cleanup all the code that is dead then... Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Remove now unused methods in Share.php due to the reduced code complexity in ↵Morris Jobke2020-11-291-36/+0
| | | | | | Share::getItems Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Remove unused method Share Helper::generateTargetMorris Jobke2020-11-291-41/+0
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Reduce code complexity in Share::getItems by tracing all remaining callersMorris Jobke2020-11-291-59/+20
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Remove unused Share::getItemSharedWithBySource()Morris Jobke2020-11-291-17/+0
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Remove dead method \OC\Updater::checkAppUpgradeChristoph Wurst2020-11-261-41/+0
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Merge pull request #24319 from ↵Christoph Wurst2020-11-263-16/+16
|\ | | | | | | | | nextcloud/techdebt/noid/streamline-user-creation-and-deletion-events Streamline user creation and deletion events
| * Streamline user creation and deletion eventsMorris Jobke2020-11-233-16/+16
| | | | | | | | | | | | CreateUserEvent was the only one that didn't matched the naming scheme of BeforePASTTENSEEvent and PASTTENSEEvent. The event wasn't used at all so this just removes it again as there is BeforeUserCreatedEvent that is also available since 18. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #23912 from nextcloud/objectstore-copyRoeland Jago Douma2020-11-255-5/+83
|\ \ | | | | | | use in objectstore copy
| * | use in objectstore copyRobin Appelman2020-11-245-5/+83
| | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | send expected format of cloud idArthur Schiwon2020-11-241-1/+2
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | Merge pull request #24162 from nextcloud/fix/noid/fedshares-displaynamezblizzz2020-11-243-13/+47
|\ \ \ | | | | | | | | set the display name of federated sharees from addressbook
| * | | set the display name of federated sharees from addressbookArthur Schiwon2020-11-243-13/+47
| |/ / | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | Merge pull request #24341 from nextcloud/fix/sharing-enforce-expire-checkboxblizzz2020-11-241-1/+1
|\ \ \ | |/ / |/| | Fix the config key on the sharing expire checkbox
| * | Fix the config key on the sharing expire checkboxChristoph Wurst2020-11-241-1/+1
| | | | | | | | | | | | | | | | | | | | | We don't use `shareapi_internal_enforce_expire_date` anywhere. `shareapi_enforce_internal_expire_date` is the one we want. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | Merge pull request #24323 from nextcloud/fix/comments-tab-missingRoeland Jago Douma2020-11-241-6/+6
|\ \ \ | |/ / |/| | Fix reverse registration and missing comments tab
| * | Fix reverse registration and missing comments tabChristoph Wurst2020-11-241-6/+6
| |/ | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Merge pull request #24312 from nextcloud/bugfix/noid/fix-router-aliasRoeland Jago Douma2020-11-241-1/+3
|\ \ | | | | | | Add proper alias for internal router class
| * | Add proper alias for internal router classJulius Härtl2020-11-241-1/+3
| |/ | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* / Fix typo in @deprecated PHPDoc tagMorris Jobke2020-11-243-5/+5
|/ | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Merge pull request #24267 from ↵Morris Jobke2020-11-221-0/+3
|\ | | | | | | | | nextcloud/techdebt/noid/auto-wire-encryption-app-view-dependent Auto-wire remaining encryption app services that depend on View
| * Allow View to be used via DIMorris Jobke2020-11-211-0/+3
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #24269 from nextcloud/taint-specializeRoeland Jago Douma2020-11-221-0/+2
|\ \ | | | | | | Mark getAppPath as specialized taint
| * | Mark getAppPath as specialized taintLukas Reschke2020-11-211-0/+2
| |/ | | | | | | | | | | | | | | Should remove some false positives. https://psalm.dev/docs/security_analysis/avoiding_false_positives/ Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* / Mark cleanAppId as sanitizer for includeLukas Reschke2020-11-211-0/+1
|/ | | | | | Should remove a bunch of false positive code scanning results. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* Merge pull request #24064 from nextcloud/techdebt/noid/auto-wire-encryption-appMorris Jobke2020-11-211-4/+10
|\ | | | | Auto-wire as much as possible in the encryption app
| * Auto-wire as much as possible in the encryption appMorris Jobke2020-11-201-4/+10
| | | | | | | | | | | | Also cleans up only non-classname services in the server container Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #24246 from LukasReschke/add-taint-flow-analysisMorris Jobke2020-11-211-0/+2
|\ \ | |/ |/| Add Psalm Security Analysis
| * Add Psalm Taint Flow AnalysisLukas Reschke2020-11-201-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds the Psalm Security Analysis, as described at https://psalm.dev/docs/security_analysis/ It also adds a plugin for adding input into AppFramework. The results can be viewed in the GitHub Security tab at https://github.com/nextcloud/server/security/code-scanning **Q&A:** Q: Why do you not use the shipped Psalm version? A: I do a lot of changes to the Psalm Taint behaviour. Using released versions is not gonna get us the results we want. Q: How do I improve false positives? A: https://psalm.dev/docs/security_analysis/avoiding_false_positives/ Q: How do I add custom sources? A: https://psalm.dev/docs/security_analysis/custom_taint_sources/ Q: We should run this on apps! A: Yes. Q: What will change in Psalm? A: Quite some of the PHP core functions are not yet marked to propagate the taint. This leads to results where the taint flow is lost. That's something that I am currently working on. Q: Why is the plugin MIT licensed? A: Because its the first of its kind (based on GitHub Code Search) and I want other people to copy it if they want to. Security is for all :) Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | Simple typo in commentsCarlos Ferreira2020-11-201-2/+2
| |
* | Merge pull request #24062 from ↵Morris Jobke2020-11-204-3/+50
|\ \ | |/ |/| | | | | nextcloud/revert-24060-revert-24039-faster-installation Revert "Revert "Installation goes brrrr""
| * Don't drop the table anymore when we create it againJoas Schilling2020-11-161-0/+1
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * Revert "Revert "Installation goes brrrr""Joas Schilling2020-11-113-3/+49
| |
* | Harden EncryptionLegacyCipher a bitRoeland Jago Douma2020-11-202-0/+8
| | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Merge pull request #24007 from nextcloud/select-distinct-multipleMorris Jobke2020-11-191-1/+7
|\ \ | | | | | | allow selecting multiple columns with SELECT DISTINCT
| * | allow selecting multiple columns with SELECT DISTINCTRobin Appelman2020-11-161-1/+7
| | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | Merge pull request #24103 from ↵Morris Jobke2020-11-191-1/+1
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/bugfix/noid/groupfolder-share-object-storage Only check path for being accessible when the storage is a object home
| * | | Only check path for being accessible when the storage is a object homeJulius Härtl2020-11-131-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | | | Merge pull request #24164 from nextcloud/fix/lazy-app-registrationMorris Jobke2020-11-193-13/+25
|\ \ \ \ | | | | | | | | | | Allow lazy app registration
| * | | | Allow lazy app registrationChristoph Wurst2020-11-183-13/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During app installation we run migration steps. Those steps may use services the app registers or classes from composer. Hence we have to make sure the app runs through the registration. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | | | Merge pull request #24135 from ↵Roeland Jago Douma2020-11-191-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | medical-cloud/fix/23357-nextcloud-logo-in-email-notifications-is-misaligned-in-version-20 Fix nextcloud logo in email notifications misalignment
| * | | | | Fix #23357medcloud2020-11-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: medcloud <42641918+medcloud@users.noreply.github.com>
* | | | | | missing levelMaxence Lange2020-11-181-0/+1
| |/ / / / |/| | | | | | | | | Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
* | | | | Remove some IRouter methodsRoeland Jago Douma2020-11-173-15/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not the end. IRouter needs to burn. But it is a start. 🎵 we didn't start the fire 🎵 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | Add types to function builderJoas Schilling2020-11-164-43/+20
| |_|/ / |/| | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #24069 from nextcloud/fix-default-internal-expiration-dateRoeland Jago Douma2020-11-161-3/+3
|\ \ \ \ | | | | | | | | | | Fix default internal expiration date
| * | | | Fix default internal expiration dateDaniel Calviño Sánchez2020-11-161-3/+3
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | The default expiration date for internal shares was set from the default link expiration date instead of the internal one. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | Merge pull request #24112 from ↵Christoph Wurst2020-11-161-0/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | nextcloud/bugfix/24099/setup-fs-before-query-storage-in-settings Set up FS before querying storage info in settings
| * | | | Set up FS before querying storage info in settingsVincent Petry2020-11-131-0/+3
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The personal info section of the personal settings is querying the storage quota information. For this it requires the FS to be setup which is not always guaranteed. This fixes an issue where refreshing the settings page would cause it to fail after Redis caches are full. It is likely that when Redis cache is populated, some code path is initializing the FS, so it works so far. But when the cache is populated, that code path is skipped so the FS is not guaranteed to be setup... Signed-off-by: Vincent Petry <vincent@nextcloud.com>
* / / / Don't throw on SHOW VERSION queryJoas Schilling2020-11-161-1/+2
|/ / / | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-08 16:11:40 +0000