summaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* fix(auth): Allow 2FA challenges for Ephemeral sessionsbackport/51544/stable29Joas Schilling5 days1-0/+5
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix(lookup-server): disable lookup server for non-global scale setupsFerdinand Thiessen11 days1-2/+4
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(lookup-server): do not query data by defaultFerdinand Thiessen11 days1-1/+1
| | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(login): Properly target public page with attributebackport/51280/stable29Louis Chemineau2025-03-051-1/+2
| | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* Merge pull request #51253 from nextcloud/backport/50989/stable29Andy Scherzinger2025-03-051-1/+1
|\ | | | | [stable29] fix: Use case insensitive check when validating login name
| * fix: use mb_strtolower to convert login namebackport/50989/stable29Cleopatra Enjeck M.2025-03-051-1/+1
| | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
| * fix: Improve string comparisonCleopatra Enjeck M.2025-03-051-1/+1
| | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
| * fix: Use case insensitive check when validating login nameCleopatra Enjeck M.2025-03-051-1/+1
| | | | | | | | Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
* | fix: No IFactory in constructorbackport/51259/stable29Marcel Müller2025-03-051-3/+1
| | | | | | | | Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
* | fix(files): Don't do session related work in the constructor of the ViewJoas Schilling2025-03-051-10/+10
|/ | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #51060 from nextcloud/backport/51050/stable29Louis2025-03-041-2/+2
|\ | | | | [stable29] fix: Report duplicated extra files in integrity check
| * fix: Report duplicated extra files in integrity checkbackport/51050/stable29Louis Chemineau2025-03-031-2/+2
| | | | | | | | | | | | | | | | The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files. For example, copying `status.php` to `status 2.php`, will only be reported with the new version. Signed-off-by: Louis Chemineau <louis@chmn.me>
* | Merge pull request #51201 from nextcloud/backport/51194/stable29Stephan Orbaugh2025-03-041-57/+21
|\ \ | | | | | | [stable29] refactor(TempManager): Simplify and unify implementations and remove legacy behavior
| * | refactor(TempManager): Simplify and unify implementations and remove legacy ↵backport/51194/stable29provokateurin2025-03-041-57/+21
| |/ | | | | | | | | | | behavior Signed-off-by: provokateurin <kate@provokateurin.de>
* | Merge pull request #51204 from nextcloud/backport/51000/stable29Stephan Orbaugh2025-03-044-38/+80
|\ \ | | | | | | [stable29] fix(FederatedShareProvider): Delete external shares when groups are deleted or users removed from a group
| * | fix(Share20\Manager): Propagate user and group deletion to remote share ↵provokateurin2025-03-041-4/+16
| | | | | | | | | | | | | | | | | | providers Signed-off-by: provokateurin <kate@provokateurin.de>
| * | fix(Share20): Convert broken hooks to IEventListenerprovokateurin2025-03-043-34/+64
| |/ | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | fix: psalm and OCP @since declarationsbackport/50660/stable29John Molakvoæ2025-03-041-1/+1
| | | | | | | | | | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
* | fix: make sure we process mime extensions as stringskjnldsv2025-03-041-4/+10
|/ | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* Merge pull request #51088 from nextcloud/backport/51051/stable29Andy Scherzinger2025-03-034-61/+99
|\ | | | | [stable29] feat: Close sessions created for login flow v2
| * fix(login): Support subfolder install for ephemeral sessionsbackport/51051/stable29Louis Chemineau2025-03-031-1/+4
| | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
| * fix(login): Also check legacy annotation for ephemeral sessionsLouis Chemineau2025-03-032-6/+7
| | | | | | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
| * feat: Close sessions created for login flow v2Louis Chemineau2025-03-034-61/+95
| | | | | | | | | | | | | | | | | | | | | | | | Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser. This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request. Signed-off-by: Louis Chemineau <louis@chmn.me> [skip ci] Signed-off-by: Louis Chemineau <louis@chmn.me>
* | refactor: convert sanitize account properties repair step to background jobFerdinand Thiessen2025-02-273-11/+40
| | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix: Optimize repair step performanceFerdinand Thiessen2025-02-271-3/+21
| | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix: validate account properties as a repair stepFerdinand Thiessen2025-02-273-90/+60
|/ | | | | | | | Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step, `ValidateAccountProperties` which validates and sanitizes all account properties. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(l10n): Improve english source stringsJoas Schilling2025-02-261-1/+1
| | | | | | | - No leading/trailing whitespace - Use asci single quote Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix: Initialize lastConnectionCheck after first connectionbackport/50874/stable29Louis Chemineau2025-02-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases. It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time. In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];` https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L215-L221 https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L891-L893 https://github.com/nextcloud/3rdparty/blob/2b6d7bf65ff242ea050e736925f752a38d8da220/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php#L136-L139 Then, if the connection name ends up as being 'primary', the reconnect logic is skipped: https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L874-L880 Follow-up of https://github.com/nextcloud/server/pull/41819 Signed-off-by: Louis Chemineau <louis@chmn.me>
* Merge pull request #50876 from nextcloud/backport/50807/stable29Andy Scherzinger2025-02-191-2/+3
|\ | | | | [stable29] fix(files): properly forward open params from short urls
| * fix(files): properly forward open params from short urlsskjnldsv2025-02-191-2/+3
| | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | fix(Mailer): Fix sendmail binary fallbackbackport/46480/stable29Josh2025-02-171-1/+4
|/ | | | Signed-off-by: Josh <josh.t.richards@gmail.com>
* Merge pull request #50795 from nextcloud/backport/50781/stable29Andy Scherzinger2025-02-172-18/+10
|\ | | | | [stable29] perf(files): faster query to fetch incomplete directories
| * perf(files): faster query to fetch incomplete directoriesbackport/50781/stable29Benjamin Gaussorgues2025-02-142-18/+10
| | | | | | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | fix: make locked exception path relative to the viewRobin Appelman2025-02-151-16/+8
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | fix(repair): PHP8.3 deprecation warningbackport/50809/stable29Git'Fellow2025-02-151-8/+4
| | | | | | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* | fix(files): Correctly copy the cache information on copy operationsLouis Chemineau2025-02-133-11/+41
|/ | | | | | Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder. Signed-off-by: Louis Chemineau <louis@chmn.me>
* feat: Use inline password confirmation in external storage settingsLouis Chemineau2025-02-112-65/+64
| | | | Signed-off-by: Louis Chemineau <louis@chmn.me>
* fix(FediverseAction): Ensure valid fediverse links are generatedFerdinand Thiessen2025-02-091-5/+18
| | | | | | Harden also for existing values of the profile. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(AccountManager): Sanitize social media handlesFerdinand Thiessen2025-02-091-78/+125
| | | | | | Ensure to only accept valid X and fediverse handles. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* fix(oauth2): adjust db schemas when migrating from owncloudRichard Steinmetz2025-02-062-6/+96
| | | | Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
* fix: explicitly ignore nested mounts when transfering ownershipRobin Appelman2025-02-051-3/+9
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix: translate mount move error messagesRobin Appelman2025-02-051-11/+36
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix: improve checks for moving shares/storages into other mountsRobin Appelman2025-02-051-15/+51
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* fix(Http): Only allow valid HTTP status code values via templatebackport/49882/stable29provokateurin2025-02-033-8/+8
| | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* Merge pull request #50600 from nextcloud/backport/50549/stable29Kate2025-02-011-4/+8
|\
| * fix(OC_Files): Fix error response when `event` was not setbackport/50549/stable29Ferdinand Thiessen2025-01-311-4/+8
| | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | fix(sharing): Move permission validation to share managerFerdinand Thiessen2025-01-311-0/+11
|/ | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Merge pull request #50563 from nextcloud/backport/50530/stable29Kate2025-01-311-7/+5
|\
| * fix(ConvertType): Read dbtype in createConnectionParams and remove safeguardbackport/50530/stable29Nils Wenninghoff2025-01-301-7/+5
| | | | | | | | Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
* | fix: Exclude non accepted shares when computing access listbackport/50519/stable29Louis Chemineau2025-01-301-0/+13
|/ | | | Signed-off-by: Louis Chemineau <louis@chmn.me>