aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* fix(sharding): typo in addOrderByfix/recently_active_pgsqlBenjamin Gaussorgues2024-10-301-1/+1
| | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* fix(users): improve recently active searchBenjamin Gaussorgues2024-10-301-28/+37
| | | | | | | | | - Remove DISTINCT clause to fix PgSQL - Join user table only if necessary - Don't show people who never connected in active list - Add test Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* Merge pull request #46151 from nextcloud/enh/do-not-enforce-cache-for-cliJohn Molakvoæ2024-10-291-6/+20
|\
| * feat(cache): CLI should not fail if APCu is not availableenh/do-not-enforce-cache-for-cliMichaIng2024-08-011-6/+20
| | | | | | | | | | | | | | | | | | | | | | | | but fallback to NullCache. This can be the case if APCu is used without apc.enable_cli=1. APCu however runs within the PHP instance and hence cannot be shared between CLI and web or used as distributed cache. The CLI call can hence only create or invalidate entries for itself. For short-living CLI calls, this is theoretically a downsides regarding performance and resource usage, and Nextcloud must not have any issues using the dummy NullCache instead of an isolated freshly created and destroyed APCu instance. This partly reverts https://github.com/nextcloud/server/pull/25770. The fallback was removed, because CLI calls started to hang after https://github.com/nextcloud/server/pull/25440. The reason however was not that a cache is generally required for CLI calls, but because the previously logged warning invoked the user backend, which invoked again the caching backend, causing a loop. This commit re-adds the fallback without logging a warning, and for APCu only. For mentioned reasons, it is okay to fallback to NullCache silently. If Redis or memcached are configured but not available, then the web UI would fail as well, and it makes sense to abort and inform CLI calls as well then. The motivation is to make apc.enable_cli=1 optional, and that hence the documentation about it can be removed. We should not enforce admins to enable APCu for CLI calls, which is reasonably disabled by default. This also reduces requirements for hosting providers to support Nextcloud. Signed-off-by: MichaIng <micha@dietpi.com>
* | Merge pull request #47847 from ↵John Molakvoæ2024-10-291-2/+6
|\ \ | | | | | | | | | nextcloud/fix-copying-or-moving-from-shared-groupfolders
| * | fix: Fix copying or moving from shared groupfoldersDaniel Calviño Sánchez2024-10-101-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When copying or moving between two local storages the source path (on disk) to copy or move from is got from the unjailed path of the source storage. However, if the source storage has more than one jail getting the unjailed path resolves the most external jail, but the source path needs to be got from the most internal jail instead (the one closer to the local storage). This can happen, for example, with a shared groupfolder: in that case there is an external jail for the shared storage, and one internal jail for the groupfolder storage wrapped by the shared storage. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | fix(systemtags): translations and etag method casingskjnldsv2024-10-291-1/+1
| | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | feat(systemtags): add cypress tests and fix a few logic issuesskjnldsv2024-10-291-1/+1
| | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | feat(systemtags): add etag support and handle proppatchskjnldsv2024-10-294-2/+67
| | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | feat(core): add index to systemtag objecttypeskjnldsv2024-10-291-0/+15
| | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | fix(config): Mark more configs as sensitivebugfix/noid/mark-more-configs-as-sensitiveJoas Schilling2024-10-282-0/+10
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-passwordKate2024-10-282-3/+15
|\ \ \
| * | | fix: crypto made inline for constructor and decrypt error handled in exceptionfix/encrypt-decrypt-passwordyemkareems2024-10-281-2/+4
| | | | | | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
| * | | fix: crypto made inline for constructor and decrypt error handled in exceptionyemkareems2024-10-281-6/+7
| | | | | | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
| * | | fix: use Icrypto in place of Cyptoyemkareems2024-10-282-4/+4
| | | | | | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
| * | | fix: crypto type made not nullable and tests run using ICryptoyemkareems2024-10-282-4/+4
| | | | | | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
| * | | fix: encrypt and store password, decrypt and retrieve the sameyemkareems2024-10-282-2/+11
| | | | | | | | | | | | | | | | Signed-off-by: yemkareems <yemkareems@gmail.com>
* | | | Merge pull request #48912 from ↵Ferdinand Thiessen2024-10-281-0/+11
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | nextcloud/bugfix/exception-appscreenshot-notstring fix(apps-store): Fix exception on generating preview url for installed app screenshot
| * | | | fix(appinfo): Make sure screenshot, author and category are always arraysbugfix/exception-appscreenshot-notstringJoas Schilling2024-10-281-0/+11
| |/ / / | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | Merge pull request #48614 from nextcloud/refactor/storage/constructorsKate2024-10-2821-68/+68
|\ \ \ \ | |/ / / |/| | |
| * | | refactor(Storage): Align all Storage constructorsrefactor/storage/constructorsprovokateurin2024-10-2321-68/+68
| | | | | | | | | | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | | | feat(bruteforce): Allow forcing the database throttlerbugfix/noid/allow-to-force-db-throttlerJoas Schilling2024-10-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the database is most likely worse for performance, but makes investigating issues a lot easier as it's possible to look directly at the table to see all logged remote addresses and actions. Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | feat(textprocessing): factorize taskProcessingCompatibleTaskTypesJulien Veyssier2024-10-241-22/+11
| | | | | | | | | | | | | | | | Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
* | | | fix(textprocessing): also list types that are available in task processingJulien Veyssier2024-10-241-0/+29
| | | | | | | | | | | | | | | | Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
* | | | fix: $uid type in Encryption streamartonge/fix/uid_typeLouis2024-10-231-1/+1
|/ / / | | | | | | | | | | | | | | | | | | As explained by the comment. Signed-off-by: Louis <louis@chmn.me> Signed-off-by: Louis Chemineau <louis@chmn.me>
* | | chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixerdependabot/composer/vendor-bin/cs-fixer/nextcloud/coding-standard-1.3.2dependabot[bot]2024-10-1915-60/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: nextcloud/coding-standard dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: provokateurin <kate@provokateurin.de>
* | | Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-supportFerdinand Thiessen2024-10-187-30/+48
|\ \ \ | | | | | | | | feat(AppFramework): Add full support for date / time / datetime columns
| * | | fix: Adjust Entity typesfeat/add-datetime-qbmapper-supportFerdinand Thiessen2024-10-172-8/+10
| | | | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
| * | | fix: Prevent breaking change in IQueryBuilderFerdinand Thiessen2024-10-175-22/+22
| | | | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
| * | | fix: Adjust parameter type usage and add SQLite supportFerdinand Thiessen2024-10-174-12/+28
| | | | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
| * | | feat(AppFramework): Add full support for date / time / datetime columnsFerdinand Thiessen2024-10-171-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added. But especially those types are the important ones, as our **Entity** class works by detecting changes through setters. Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here. Similar the parameter types needed to be added. `Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity. Also added more tests, especially to make sure the mapper really serializes the values correctly. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | Merge pull request #48765 from nextcloud/dbQueriesExecStmt2Kate2024-10-1814-156/+116
|\ \ \ \
| * | | | chore(db): Apply query prepared statementsdbQueriesExecStmt2Git'Fellow2024-10-1714-156/+116
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix: psalm fix: bad file fix: bug chore: add batch chore: add batch chore: add batch fix: psalm
* | | | fix(comments): Document supported types and provide psalm typingJoas Schilling2024-10-171-19/+21
| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | feat(comments): Support mentioning emailsJoas Schilling2024-10-171-1/+5
|/ / / | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | chore(db): Correctly apply query typesGit'Fellow2024-10-1713-154/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix: psalm fix: error fix: add batch fix: fatal error fix: add batch chore: add batch chore: add batch fix: psalm fix: typo fix: psalm fix: return bool fix: revert Manager
* | | refactor(encryption): Migrate away from Hooks to typed eventsFerdinand Thiessen2024-10-151-9/+12
| | | | | | | | | | | | | | | | | | | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Louis <louis@chmn.me> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | Merge pull request #48682 from ↵Kate2024-10-151-0/+1
|\ \ \ | | | | | | | | | | | | nextcloud/fix/appconfig/sensitive-keys-external-jwt-private-key
| * | | fix(AppConfig): Add external JWT private key to sensitive keysfix/appconfig/sensitive-keys-external-jwt-private-keyprovokateurin2024-10-141-0/+1
| | | | | | | | | | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | | | Merge pull request #48206 from nextcloud/feat/systemtags-publicJohn Molakvoæ2024-10-151-2/+16
|\ \ \ \
| * | | | feat: make systemtags public visiblefeat/systemtags-publicJohn Molakvoæ (skjnldsv)2024-10-111-2/+16
| |/ / / | | | | | | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* | | | Merge pull request #48673 from nextcloud/fix/null-labelFerdinand Thiessen2024-10-141-2/+2
|\ \ \ \ | | | | | | | | | | fix(share): Return empty string if no label is set
| * | | | fix(share): Return empty string if no label is setFerdinand Thiessen2024-10-141-2/+2
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Resolves: https://github.com/nextcloud/server/issues/48629 While the database supports NULL, the typing has always said it only returns *string*. So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | Merge pull request #48687 from nextcloud/chore/gender-neutral-languageFerdinand Thiessen2024-10-146-6/+6
|\ \ \ \ | | | | | | | | | | chore: Use more gender neutral language
| * | | | chore: Use more gender neutral languageprovokateurin2024-10-146-6/+6
| |/ / / | | | | | | | | | | | | Signed-off-by: provokateurin <kate@provokateurin.de>
* | | | Merge pull request #48650 from nextcloud/fix/shipped-app-versionFerdinand Thiessen2024-10-141-47/+57
|\ \ \ \ | | | | | | | | | | fix: Shipped apps should include the Nextcloud version in the cache buster
| * | | | fix: Shipped apps should include the Nextcloud version in the cache busterfix/shipped-app-versionFerdinand Thiessen2024-10-141-47/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | | Merge pull request #48604 from nextcloud/bugfix/noid/fix-tainted-file-appinfoJoas Schilling2024-10-143-19/+29
|\ \ \ \ \ | |/ / / / |/| | | | fix(appmanager): Fix tainted file path when loading appinfos
| * | | | fix(appmanager): Fix tainted file path when loading appinfosbugfix/noid/fix-tainted-file-appinfoJoas Schilling2024-10-143-19/+29
| |/ / / | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* / / / fix(locking): Accept mixed as value on setTTLmixedSetTTLGit'Fellow2024-10-141-1/+1
|/ / / | | | | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-05 14:39:28 +0000