aboutsummaryrefslogtreecommitdiffstats
path: root/lib/private
Commit message (Collapse)AuthorAgeFilesLines
* drop dead code - ref #13301Morris Jobke2015-01-131-4/+0
|
* Merge pull request #13291 from owncloud/node-searchcommonbasepathfixThomas Müller2015-01-131-0/+1
|\ | | | | Fix searchCommon to properly match path name
| * Fix searchCommon to properly match path nameVincent Petry2015-01-121-0/+1
| | | | | | | | | | | | | | The internal path was matched without the last "/" which caused "files_trashbin" to also match when the internal path was "files". This adds the missing slash for the comparison.
* | Merge pull request #13301 from owncloud/drop-etag-messageVincent Petry2015-01-131-3/+0
|\ \ | | | | | | drop useless "!!! No reuse of etag" - fixes #13187
| * | drop useless "!!! No reuse of etag" - fixes #13187Morris Jobke2015-01-131-3/+0
| | |
* | | Merge pull request #13305 from owncloud/remove-stray-minus-and-use-json-encodeRobin McCorkell2015-01-131-1/+1
|\ \ \ | | | | | | | | Use json_encode on string
| * | | Use json_encode on stringLukas Reschke2015-01-131-1/+1
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's better to encode the string to prevent possible (yet unknown) bugs in combination with PHP's type juggling. Previously the boolean statements evaluated to either an empty string (false) or a not empty one (true, then it was 1). Not it always evaluates to false or true. This also removes a stray - that was not intended there but shouldn't have produced any bugs. Just to increase readability. Thanks @nickvergessen for spotting. Addresses https://github.com/owncloud/core/pull/13235/files#r22852319
* | | Merge pull request #13271 from owncloud/fix-table-prefix-oracle-masterMorris Jobke2015-01-135-8/+30
|\ \ \ | |_|/ |/| | Use a special filter expression for Oracle to filter the prefix - fixes ...
| * | Use a special filter expression for Oracle to filter the prefix - fixes #13220Thomas Müller2015-01-125-8/+30
| |/
* / Adding repair step to fix missing etags - fixes #12172Thomas Müller2015-01-121-1/+3
|/
* Merge pull request #13224 from ↵Morris Jobke2015-01-101-1/+1
|\ | | | | | | | | owncloud/simplify-is-valid-path-and-add-unit-tests Simplify isValidPath and add unit tests
| * Simplify isValidPath and add unit testsLukas Reschke2015-01-101-1/+1
| | | | | | | | | | | | The check for invalid paths is actually over-complicated and performed twice resulting in a performance penalty. Additionally, I decided to add unit-tests to that function. Part of https://github.com/owncloud/core/issues/13221
* | Merge pull request #13223 from owncloud/optimize-normalize-unicodeMorris Jobke2015-01-101-5/+8
|\ \ | | | | | | Verify whether value is already normalized
| * | Verify whether value is already normalizedLukas Reschke2015-01-101-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | Apparently `normalizer_normalize` is not verifying itself whether the string needs to be converted or not. Or does it at least not very performantly. This simple change leads to a 4% performance gain on the processing of normalizeUnicode. Since this method is called quite often (i.e. for every file path) this has actually a measurable impact. For examples searches are now 200ms faster on my machine. Still not perfect but way to go. Part of https://github.com/owncloud/core/issues/13221
* | | Merge pull request #13236 from owncloud/use-isset-for-performanceMorris Jobke2015-01-101-2/+4
|\ \ \ | | | | | | | | Use isset() instead of strlen()
| * | | Use isset() instead of strlen()Lukas Reschke2015-01-101-2/+4
| |/ / | | | | | | | | | | | | | | | Isset is a native language construct and thus A LOT faster than using strlen() On my local machine this leads to a 1s performance gain for about 1 million paths. Considering that this function will be called a lot for every file operation this makes a noticable difference.
* / / Cache results of `normalizePath`Lukas Reschke2015-01-101-1/+12
|/ / | | | | | | | | | | | | | | `normalizePath` is a rather expensive operation and called multiple times for a single path for every file related operation. In my development installation with about 9GB of data and 60k files this leads to a performance boost of 24% - in seconds that are 1.86s (!) - for simple searches. With more files the impact will be even more noticeable. Obviously this affects every operation that has in any regard something to do with using OC\Files\Filesystem. Part of https://github.com/owncloud/core/issues/13221
* / Cache responses from the AppStore serverLukas Reschke2015-01-091-1/+1
|/ | | | | | | | | | Otherwise every time the AppStore was opened a lot of connections to the AppStore server were made which resulted in a terrible performance. This changeset will cache the response for a sensible time so that only the first request will be somewhat slow. Performance changes: - Loading a category took previously more than 3 seconds on my machine. Now for every follow-up request it takes less than 200ms, resulting in a performance gain of 1950% - Loading the category list took previously about 750ms - now it takes 154ms, a total performance gain of 395%
* Merge pull request #13192 from owncloud/cache_binary_pathThomas Müller2015-01-093-4/+45
|\ | | | | Use memcache for findBinaryPath
| * Memcache binary executable searchingRobin McCorkell2015-01-091-2/+8
| | | | | | | | It's slow, this makes it fast!
| * Add Null memcacherRobin McCorkell2015-01-092-2/+37
| |
* | Merge pull request #13181 from owncloud/filecache-preventleadingslashRobin McCorkell2015-01-092-2/+2
|\ \ | | | | | | Trim leading or trailing slashes in file cache paths
| * | Fix cache jail to not duplicate slashesVincent Petry2015-01-091-1/+1
| | |
| * | Trim leading or trailing slashes in file cache pathsVincent Petry2015-01-081-1/+1
| | |
* | | Merge pull request #12011 from owncloud/reuse-etag-defaultMorris Jobke2015-01-091-2/+2
|\ \ \ | |_|/ |/| | Default to reusing etags in the scanner
| * | Default to reusing etags in the scannerRobin Appelman2014-11-061-2/+2
| | |
* | | Merge pull request #12995 from owncloud/tbelau666-masterThomas Müller2015-01-095-30/+43
|\ \ \ | | | | | | | | Use Doctrines filter by table name
| * | | add default for dbtableprefixMorris Jobke2014-12-233-4/+4
| | | |
| * | | use injected config object and fix typosMorris Jobke2014-12-223-10/+24
| | | |
| * | | inject \OCP\IConfig instance in migratorMorris Jobke2014-12-223-23/+13
| | | |
| * | | Use Doctrines filter by table nametbelau6662014-12-224-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Doctrine's SchemaManager can filter table names by regular expression. On this way it picks up only ownClouds's tables in a database. by tbelau666
* | | | Merge pull request #13179 from ↵Lukas Reschke2015-01-091-2/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | owncloud/fix-fatal-php-error-for-not-existing-files Verify whether type is correct
| * | | | Verify whether type is correctLukas Reschke2015-01-081-2/+3
| | | | | | | | | | | | | | | | | | | | `$this->info` can very well contain an empty array or possibly other values. This means that when this code path is called a PHP Fatal error might get thrown which is not what we want.
* | | | | Merge pull request #12988 from owncloud/logfile_downloadMorris Jobke2015-01-091-1/+8
|\ \ \ \ \ | |/ / / / |/| | | | Logfile download
| * | | | add Download logfile button to admin settingsGeorg Ehrke2015-01-071-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add logSettingsController add download logfile button move getEntries to LogSettingsController move set log level to logsettingscontroller.php add warning if logfile is bigger than 100MB add unit test for set log level fix typecasting, add new line at EoF show log and logfile download only if log_type is set to owncloud add unit test for getFilenameForDownload
* | | | | Add version to .htaccessLukas Reschke2015-01-082-2/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently if a user does not replace the .htaccess file with the new update this can lead to serious problems in case Apache is used as webserver. This commit adds the version to the .htaccess file and the update routine fails in case not the newest version is specified in there. This obviously means that every release has to update the version specified in .htaccess as well. But I see no better solution for it. Conflicts: lib/private/updater.php
* | | | | check for working htaccess will result in a dead lock because the server is ↵Thomas Müller2015-01-081-0/+5
| | | | | | | | | | | | | | | | | | | | blocking the request to itself - fixes #13153
* | | | | Merge pull request #13016 from owncloud/sharing_fixesMorris Jobke2015-01-071-4/+4
|\ \ \ \ \ | |_|_|_|/ |/| | | | don't delete share table entries for the unique name if re-share permission was removed
| * | | | don't delete share table entries for the unique name if re-share permission ↵Bjoern Schiessle2015-01-071-4/+4
| | | | | | | | | | | | | | | | | | | | was removed
* | | | | Merge pull request #13132 from aptivate/improve_debug_logging_messagesMorris Jobke2015-01-072-9/+9
|\ \ \ \ \ | | | | | | | | | | | | Improve debugging for ServiceUnavailable exceptions
| * | | | | Improve debugging for ServiceUnavailable exceptionsChris Wilson2015-01-062-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was getting a lot of these in my logs for no apparent reason, and file uploads were failing: {"app":"webdav","message":"Sabre\\DAV\\Exception\\ServiceUnavailable: ","level":4,"time":"2015-01-06T15:33:39+00:00"} In order to debug it, I had to add unique messages to all the places where this exception was thrown, to identify which one it was, and that made the logs much more useful: {"app":"webdav","message":"Sabre\\DAV\\Exception\\ServiceUnavailable: Encryption is disabled","level":4,"time":"2015-01-06T15:36:47+00:00"}
* | | | | | Merge pull request #13063 from AdamWill/assets-relocateThomas Müller2015-01-072-6/+8
|\ \ \ \ \ \ | | | | | | | | | | | | | | allow css/js asset directory to be relocated ('assetdirectory')
| * | | | | | allow css/js asset directory to be relocated (#13053)Adam Williamson2015-01-052-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows the directory where CSS/JS asset collections are written to be changed, in case SERVERROOT is not writeable. Note it does *not* allow the expected URL to be changed: whatever directory is used, the server must be configured to serve it at WEBROOT/assets. It may be possible to add another config parameter to allow the admin to specify a custom asset URL, but I thought I'd keep the first implementation simple.
* | | | | | | Merge pull request #13131 from owncloud/db-connect-stacktraceMorris Jobke2015-01-071-0/+10
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Prevent leaking db connection info in the stacktrace
| * | | | | | | Prevent leaking db connection info in the stacktraceRobin Appelman2015-01-061-0/+10
| | |/ / / / / | |/| | | | |
* | | | | | | Merge pull request #13130 from owncloud/getstoragestats-error-handlingLukas Reschke2015-01-061-0/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add error handling to getstoragestats.php
| * | | | | | | Add error handling to getstoragestats.phpRobin Appelman2015-01-061-0/+3
| |/ / / / / /
* | | | | | | Merge pull request #12653 from owncloud/full_content_search_resultsMorris Jobke2015-01-063-3/+31
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Full content width search results
| * | | | | | move search results below filelist, show hint when results are off screen, ↵Jörn Friedrich Dreyer2015-01-021-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | use js plugin mechanism
| * | | | | | ajax paging, some js cleanupsJörn Friedrich Dreyer2015-01-021-1/+3
| | | | | | |