| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
|
|
|
|
| |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
|
|
|
| |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
|
|
|
| |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
|\
| |
| | |
chore: update php intl stub and fix type issues
|
| |
| |
| |
| | |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
| |
| |
| |
| | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
|\ \
| |/
|/| |
chore: Adjust `OCP\Server::get` annotation to work with phpstan
|
| |
| |
| |
| | |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
|\ \
| | |
| | | |
fix: Replace OC_App calls by IAppManager
|
| | |
| | |
| | |
| | | |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
|\ \ \
| | | |
| | | | |
feat: Close sessions created for login flow v2
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser.
This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request.
Signed-off-by: Louis Chemineau <louis@chmn.me>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
|\ \ \ \
| | | | |
| | | | | |
fix: Report duplicated extra files in integrity check
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files.
For example, copying `status.php` to `status 2.php`, will only be reported with the new version.
Signed-off-by: Louis Chemineau <louis@chmn.me>
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
- No leading/trailing whitespace
- Use asci single quote
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
|
|\ \ \
| | | |
| | | | |
Update doc comment for prefixTableName
|
| | | |
| | | |
| | | | |
Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
|\ \ \ \
| | | | |
| | | | | |
fix: Initialize lastConnectionCheck after first connection
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases.
It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time.
In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];`
https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L215-L221
https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L891-L893
https://github.com/nextcloud/3rdparty/blob/2b6d7bf65ff242ea050e736925f752a38d8da220/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php#L136-L139
Then, if the connection name ends up as being 'primary', the reconnect logic is skipped:
https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L874-L880
Follow-up of https://github.com/nextcloud/server/pull/41819
Signed-off-by: Louis Chemineau <louis@chmn.me>
|
| |_|/
|/| |
| | |
| | | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
|\ \ \
| | | |
| | | | |
fix: Change UserAgent to *cloud
|
| |/ /
| | |
| | |
| | |
| | | |
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
|/ /
| |
| |
| | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
| |
| |
| |
| | |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
| |
| |
| |
| | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
|\ \
| | |
| | | |
fix: Fix psalm taint false-positives by small refactorings
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Mostly make it clear that we trust admin input or that we correctly
escape strings.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
|
|/ /
| |
| |
| | |
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
| |
| |
| |
| | |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| |
| |
| |
| | |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| |
| |
| |
| | |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| |
| |
| |
| |
| |
| | |
…in psalm taint analysis
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| |
| |
| |
| |
| |
| | |
This solves some false-positive psalm taint errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
var_export is listed as a taint sink because it may output stuff
depending on the parameters. It was not the case here, but we can
simply json_encode the result by passing it as context to the logger
method rather than using var_export.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| |
| |
| |
| |
| |
| |
| | |
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we
only use it in JSON output anyway.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
| |
| |
| |
| | |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|