aboutsummaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Fix(l10n): Update translations from TransifexNextcloud bot12 days4-20/+20
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | | | fix(lint): correct comment identationenh/ldap-clearer-errorsAndy Scherzinger12 days1-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
* | | | | | Merge pull request #50764 from p1gp1g/patch-1Andy Scherzinger12 days1-0/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update doc comment for prefixTableName
| * | | | | | Update doc comment for prefixTableNameS1m2025-02-111-0/+2
| | | | | | | | | | | | | | | | | | | | | Signed-off-by: S1m <31284753+p1gp1g@users.noreply.github.com>
* | | | | | | feat: support migrating an instance to shardingsharding-existingRobin Appelman12 days5-18/+51
| |_|_|_|/ / |/| | | | | | | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | | | Merge pull request #50874 from nextcloud/artonge/fix/login_flow_v2_sessionsJulius Knorr13 days1-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | fix: Initialize lastConnectionCheck after first connection
| * | | | | | fix: Initialize lastConnectionCheck after first connectionartonge/fix/login_flow_v2_sessionsLouis Chemineau2025-02-191-2/+2
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases. It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time. In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];` https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L215-L221 https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L891-L893 https://github.com/nextcloud/3rdparty/blob/2b6d7bf65ff242ea050e736925f752a38d8da220/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php#L136-L139 Then, if the connection name ends up as being 'primary', the reconnect logic is skipped: https://github.com/nextcloud/server/blob/60711ea4cfde6f53d0b18bcd7e166a34a43056a5/lib/private/DB/Connection.php#L874-L880 Follow-up of https://github.com/nextcloud/server/pull/41819 Signed-off-by: Louis Chemineau <louis@chmn.me>
* | | | | | Fix(l10n): Update translations from TransifexNextcloud bot13 days2-8/+8
| |_|/ / / |/| | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | | refactor: convert sanitize account properties repair step to background jobfix/account-property-validationFerdinand Thiessen13 days5-14/+45
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | | fix: Optimize repair step performanceFerdinand Thiessen13 days1-3/+21
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | | fix: validate account properties as a repair stepFerdinand Thiessen13 days5-74/+62
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step, `ValidateAccountProperties` which validates and sanitizes all account properties. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* | | | Fix(l10n): Update translations from TransifexNextcloud bot14 days2-0/+2
| | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | Fix(l10n): Update translations from TransifexNextcloud bot2025-02-232-144/+144
| | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | Fix(l10n): Update translations from TransifexNextcloud bot2025-02-222-0/+354
| | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | Merge pull request #50053 from nextcloud/fix/noid/thudnerbird-addon-useragentStephan Orbaugh2025-02-211-1/+1
|\ \ \ \ | | | | | | | | | | fix: Change UserAgent to *cloud
| * | | | fix: Change UserAgent to *cloudfix/noid/thudnerbird-addon-useragentJohannes Endres2025-02-191-1/+1
| |/ / / | | | | | | | | | | | | | | | | Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de> Signed-off-by: Johannes Endres <je@johannes-endres.de>
* | | | feat(SystemTag): Make MapperEvent webhook compatibleenh/make-tag-event-webhook-compatibleMarcel Klehr2025-02-201-1/+15
| | | | | | | | | | | | | | | | Signed-off-by: Marcel Klehr <mklehr@gmx.net>
* | | | Fix(l10n): Update translations from TransifexNextcloud bot2025-02-202-2/+2
|/ / / | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | fix(cron): Keep job class limitation when searching for the next jobbugfix/noid/keep-job-class-limitationJoas Schilling2025-02-191-1/+1
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Fix(l10n): Update translations from TransifexNextcloud bot2025-02-198-8/+40
| | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | Merge pull request #50864 from nextcloud/fix/fix-psalm-taint-errors-2Joas Schilling2025-02-183-37/+17
|\ \ \ | | | | | | | | fix: Fix psalm taint false-positives by small refactorings
| * | | fix: Fix psalm taint false-positives by small refactoringsfix/fix-psalm-taint-errors-2Côme Chilliet2025-02-173-37/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Mostly make it clear that we trust admin input or that we correctly escape strings. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | | fix(files): properly forward open params from short urlsskjnldsv2025-02-181-2/+3
| | | | | | | | | | | | | | | | Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
* | | | Fix(l10n): Update translations from TransifexNextcloud bot2025-02-186-12/+370
|/ / / | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | chore: Add missing star in phpdoc commentfix/fix-psalm-taint-errorsCôme Chilliet2025-02-171-1/+1
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Fix false-positive psalm taint errors when outputting plain textCôme Chilliet2025-02-171-2/+10
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Fix psalm taint false-positive by escaping trusted inputCôme Chilliet2025-02-171-11/+11
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Correctly tag json encoding in BaseResponse to fix false-positiveCôme Chilliet2025-02-171-1/+9
| | | | | | | | | | | | | | | | | | …in psalm taint analysis Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Move config.php taint trust upstream directly in OC\Config classCôme Chilliet2025-02-172-21/+23
| | | | | | | | | | | | | | | | | | This solves some false-positive psalm taint errors Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Work around psalm taint false-positive by not using var_exportCôme Chilliet2025-02-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | var_export is listed as a taint sink because it may output stuff depending on the parameters. It was not the case here, but we can simply json_encode the result by passing it as context to the logger method rather than using var_export. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | chore: Correctly flag json encoding methods as escaping html and quotesCôme Chilliet2025-02-172-2/+6
| | | | | | | | | | | | | | | | | | | | | Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we only use it in JSON output anyway. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | fix: Fix psalm taint error in L10N factoryCôme Chilliet2025-02-171-3/+24
| | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | Merge pull request #50791 from nextcloud/perf/remove-filecache-indexKate2025-02-172-0/+2
|\ \ \ | | | | | | | | chore(filecache): remove index fs_id_storage_size
| * | | chore(filecache): remove index fs_id_storage_sizeperf/remove-filecache-indexBenjamin Gaussorgues2025-02-132-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Index is outdated by PR 50781 Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | | | Merge pull request #50809 from nextcloud/fixPhp83DeprecationGit'Fellow2025-02-151-8/+4
|\ \ \ \ | | | | | | | | | | fix(repair): PHP8.3 deprecation warning
| * | | | fix(repair): PHP8.3 deprecation warningfixPhp83DeprecationGit'Fellow2025-02-141-8/+4
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
* | | | | Fix(l10n): Update translations from TransifexNextcloud bot2025-02-152-0/+2
|/ / / / | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | Fix(l10n): Update translations from TransifexNextcloud bot2025-02-144-4/+10
| | | | | | | | | | | | | | | | Signed-off-by: Nextcloud bot <bot@nextcloud.com>
* | | | Merge pull request #48738 from nextcloud/perf/log-high-memory-requestsJulius Knorr2025-02-131-0/+16
|\ \ \ \ | | | | | | | | | | perf: Log requests using high amount of memory as warning
| * | | | perf: Log requests using high amount of memory as warningperf/log-high-memory-requestsJulius Knorr2025-02-131-0/+16
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Julius Knorr <jus@bitgrid.net>
* | | | | Merge pull request #50794 from nextcloud/fix/fix-appmanager-cleanappidCôme Chilliet2025-02-132-4/+26
|\ \ \ \ \ | | | | | | | | | | | | fix: Only keep allowed characters in appid, and flag the method as escaping
| * | | | | fix: Also remove digits at the start and underscore on both ends of appidfix/fix-appmanager-cleanappidCôme Chilliet2025-02-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
| * | | | | fix: Only keep allowed characters in appid, and flag the method as escapingCôme Chilliet2025-02-132-4/+26
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | | | | Merge pull request #50781 from nextcloud/perf/improve-incomplete-scanBenjamin Gaussorgues2025-02-132-15/+6
|\ \ \ \ \ \ | |/ / / / / |/| | | | | perf(files): faster query to fetch incomplete directories
| * | | | | perf(files): faster query to fetch incomplete directoriesperf/improve-incomplete-scanBenjamin Gaussorgues2025-02-132-15/+6
| | |/ / / | |/| | | | | | | | | | | | | Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
* | | | | fix: Replace getInstalledApps calls with getEnabledAppsfix/clarify-app-manager-methodsCôme Chilliet2025-02-136-6/+6
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | | | fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUserCôme Chilliet2025-02-134-8/+8
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | | | chore: Improve naming of methods and properties in AppManagerCôme Chilliet2025-02-131-21/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove all references to installed apps where it’s about enabled apps Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | | | fix(ocp): Deprecate getInstalledApps and replace with clearer method nameCôme Chilliet2025-02-132-3/+21
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
* | | | | fix(ocp): Deprecate isInstalled and add isEnabledForAnyone insteadCôme Chilliet2025-02-132-3/+13
|/ / / / | | | | | | | | | | | | | | | | | | | | The method name was really confusing Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>