summaryrefslogtreecommitdiffstats
path: root/tests/acceptance
Commit message (Collapse)AuthorAgeFilesLines
* Verify WaitFor::element... results with an assertionDaniel Calviño Sánchez2021-03-055-11/+74
| | | | | | | | WaitFor::element... calls only perform the waiting and return whether the condition succeeded or not, but that result needs to be explicitly checked to prevent further steps from being executed if the wait failed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add missing waits when finding elements in the acceptance testsDaniel Calviño Sánchez2021-03-053-7/+7
| | | | | | | | As no timeout was specified the elements were tried to be found just once. This caused the steps to fail if the elements did not appear yet in the page when they were tried to be found. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add "composer.lock" for acceptance tests to gitDaniel Calviño Sánchez2021-01-172-3/+2774
| | | | | | | | | | As "composer.lock" was not versioned the dependencies had to be resolved everytime that the acceptance tests run, which took some precious time. Besides that the dependency versions were also tightened for better control. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add acceptance tests for reshares by link when resharing is disabledDaniel Calviño Sánchez2020-11-112-0/+111
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add acceptance tests for reshares when resharing is disabledDaniel Calviño Sánchez2020-11-113-0/+194
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Merge pull request #23614 from ↵Morris Jobke2020-10-221-42/+43
|\ | | | | | | | | nextcloud/tests/22305/unreliable-app-files-sharing-338 Disable unreliable app-files-sharing.feature:108
| * Disable unreliable app-files-sharing.feature:108Morris Jobke2020-10-211-42/+43
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Disable unreliable app-files.feature:108Morris Jobke2020-10-211-6/+7
|/ | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Set status is also there nowJoas Schilling2020-10-021-2/+4
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Adjust acceptance tests to changes in @nextcloud/vue 2.6.3Daniel Calviño Sánchez2020-09-031-75/+136
| | | | | | | | | | | | | | | | The menu button and the menu of a share are no longer direct childs of the actions of the share row. The menu button is now a child of a ".trigger" element, while the menu is a direct child of the body and has an id defined in the "aria-describedby" attribute of the ".trigger" element. In XPath 1.0 it does not seem possible to "backreference" a value or create variables, so when the share menu or one of its item is needed now the ".trigger" element is first found and then its XPath expression is used to compose its "aria-describedby" attribute in the XPath expression for the menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix clicks on actions menu of non opaque file rows in acceptance testsDaniel Calviño Sánchez2020-08-291-7/+37
| | | | | | | | | | | | | | | | When a row is added to the file list the opacity of the file row is animated from transparent to fully opaque. As the file actions menu is a descendant of the row but overflows it when the row is not fully opaque clicks on the menu entries "fall-through" and are received instead by the rows behind. The opacity animation is a CSS animation, and it is not possible to know if a row is appearing or not except from its opacity (the row will have the "appear" CSS class even after the animation ended). Therefore it should be waited until the row of the file is fully opaque before using the menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Dashboard app is disabled and there is no need to redirect to files appMorris Jobke2020-08-051-1/+1
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Redirect to files app after login in acceptance testsJulius Härtl2020-08-052-1/+3
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Merge pull request #21940 from ↵Morris Jobke2020-07-242-14/+14
|\ | | | | | | | | nextcloud/fix/14541/fix-fragile-acceptance-tests-part1 Revert "Disable fragile tests for now" partially
| * Revert "Disable fragile tests for now"Morris Jobke2020-07-212-14/+14
| | | | | | | | | | | | This reverts commit 40e04c83914e960b5aff739900d887f0e7a44d63. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Hide share link menu before copying the share link in acceptance testsDaniel Calviño Sánchez2020-07-221-0/+11
| | | | | | | | | | | | | | | | | | | | | | The (old) Firefox version used in the acceptance tests does not properly render the share link menu. As the menu is taller than it should sometimes it covers the copy link button, so it is not possible to click it without hiding the share link menu. Moreover, in those cases the share menu button is also covered by the share menu, so the menu needs to be closed by pressing the "Esc" key. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Fix breaking changes of nc/vue updateGeorg Ehrke2020-07-225-10/+10
|/ | | | Signed-off-by: Georg Ehrke <developer@georgehrke.com>
* Merge pull request #21379 from ↵Roeland Jago Douma2020-06-242-9/+216
|\ | | | | | | | | nextcloud/fix-share-permission-checkboxes-enabled-when-permissions-can-not-be-set Fix share permission checkboxes enabled when permissions can not be set
| * Add acceptance test for disabling create permission after sharingDaniel Calviño Sánchez2020-06-111-0/+43
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Add acceptance test for sharing a folder without create permissionDaniel Calviño Sánchez2020-06-112-0/+75
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Add acceptance test for sharing a file without edit permissionDaniel Calviño Sánchez2020-06-112-0/+75
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Generalize functions to get locators for share permission checkboxesDaniel Calviño Sánchez2020-06-111-9/+23
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | acceptence tests shall specify which branch to pick when cloning appsArthur Schiwon2020-06-191-1/+2
|/ | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Merge pull request #20419 from nextcloud/dependabot/npm_and_yarn/variousJohn Molakvoæ2020-04-111-4/+4
|\ | | | | Bump p-limit from 2.2.2 to 2.3.0, @nextcloud/auth from 1.2.2 to 1.2.3, @babel/preset-env from 7.8.7 to 7.9.5, @nextcloud/event-bus from 1.1.3 to 1.1.4, @nextcloud/password-confirmation from 1.0.0 to 1.0.1, @nextcloud/l10n from 1.2.2 to 1.2.3, @nextcloud/initial-state from 1.1.1 to 1.1.2, core-js from 3.6.4 to 3.6.5 …
| * Bump acceptance testsJohn Molakvoæ (skjnldsv)2020-04-101-4/+4
| | | | | | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* | Format control structures, classes, methods and functionChristoph Wurst2020-04-1034-60/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Use elseif instead of else ifChristoph Wurst2020-04-101-1/+1
|/ | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Remove trailing whitespaces from commentsChristoph Wurst2020-04-094-6/+6
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Remove trailing and in between spacesChristoph Wurst2020-04-091-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Unify function spacing to PSR2 recommendationChristoph Wurst2020-04-096-18/+18
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Fix (array) indent style to always use one tabChristoph Wurst2020-04-092-13/+13
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* tests: fix failing header acceptance testAzul2020-04-071-1/+1
| | | | | | The username is listed in a div with class `fullname` now. Signed-off-by: Azul <azul@riseup.net>
* Merge pull request #20139 from ↵Roeland Jago Douma2020-04-042-0/+55
|\ | | | | | | | | nextcloud/unify-default-value-for-restricting-user-enumeration-with-settings Unify default value for restricting user enumeration with settings
| * Add acceptance test for restricting user enumeration to groupsDaniel Calviño Sánchez2020-03-242-0/+55
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Merge pull request #20170 from nextcloud/techdebt/remove-unused-importsChristoph Wurst2020-03-271-1/+0
|\ \ | | | | | | Remove unused imports
| * | Remove unused importsChristoph Wurst2020-03-251-1/+0
| |/ | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* / Use the short array syntax, everywhereChristoph Wurst2020-03-264-18/+18
|/ | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Add acceptance test for accepting an incoming shareDaniel Calviño Sánchez2020-03-202-0/+71
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix timeout cappingDaniel Calviño Sánchez2020-03-201-1/+1
| | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Revert (partially) "Accept incoming shares in acceptance tests"Daniel Calviño Sánchez2020-03-202-23/+18
| | | | | | | | | This reverts commit f402e234480cd9d18c6c90ef011968eb7abcd5dc. Since eb4c42d3d1fda02895d35a360bceb08379f328c2 now shares are accepted by default, so no notification is shown to accept them. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Force compatible dependency versions in acceptance testsDaniel Calviño Sánchez2020-03-201-2/+2
| | | | | | | | | | | | behat/mink 1.8 and behat/mink-selenium2-driver 1.4 introduced behaviour changes that broke the acceptance tests. Until the tests are updated to work with the newer versions the last known versions are forced. Note that some acceptance tests still fail after enforcing the compatible versions, although that is caused by changes in the Nextcloud server itself. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* fix the folder shareGretaD2019-12-191-4/+4
| | | | | Signed-off-by: GretaD <gretadoci@gmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
* Move users management to multi lineGreta Doci2019-12-122-36/+73
| | | | Signed-off-by: Greta Doci <gretadoci@gmail.com>
* Adjust tags acceptance tests to moved admin sectionJulius Härtl2019-11-281-3/+3
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Make phpunit8 compatibleRoeland Jago Douma2019-11-272-2/+2
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Accept incoming shares in acceptance testsDaniel Calviño Sánchez2019-11-205-18/+128
| | | | | | | | | | | | | | | | | Incoming shares are no longer automatically added to the file list of the sharee. Instead, the user now needs to explictly accept the share. Currently shares can be accepted only from the Notifications app, so it must be explicitly cloned before installing Nextcloud if it is not found in the "apps" directory. Note that the development branches are already built, so there is no need to explicitly build the app. With the new sharing behaviour the "share a skeleton file with another user before first login" scenario is no longer valid (as the user will need to log in to accept the share, so at that point the skeleton is already created), so it was removed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Rename "Notification" to "Toast"Daniel Calviño Sánchez2019-11-202-11/+11
| | | | | | | | Since Nextcloud 17 the proper name for the old built-in notifications is "Toast". Moreover, this will reduce ambiguity when using the "notification" term to refer to elements in the Notifications app. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Adjust acceptance tests to new OCA.SidebarJohn Molakvoæ (skjnldsv)2019-10-294-46/+53
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* Run acceptance tests on PHP 7.3Daniel Calviño Sánchez2019-10-221-1/+1
| | | | | | | | There is no difference (as far as I know) between running the acceptance tests on PHP 7.1 or on PHP 7.3; this is simply a preparatory step to be ready when PHP 7.1 support is dropped in Nextcloud server. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix tag acceptance tests after #16682John Molakvoæ (skjnldsv)2019-10-042-3/+19
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>