summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* ensure mounts are scanned during testsRobin Appelman2020-07-092-1/+7
| | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* Use the correct mountpoint to calculateRoeland Jago Douma2020-07-091-0/+9
| | | | | | | If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #21498 from lmamane/stable17-21285-onelinerMorris Jobke2020-07-071-5/+6
|\ | | | | fix #21285 as oneliner
| * adapt testGetLoginCredentialsInvalidTokenLoginCredentials() unit test to uid ↵Lionel Elie Mamane2020-06-201-5/+6
| | | | | | | | | | | | != loginname Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
* | Merge pull request #21669 from nextcloud/revert-21097-backport/21090/stable17Roeland Jago Douma2020-07-061-2/+3
|\ \ | | | | | | Revert "[stable17] Do not read certificate bundle from data dir by de…
| * | Revert "[stable17] Do not read certificate bundle from data dir by default"Roeland Jago Douma2020-07-031-2/+3
| | |
* | | Merge pull request #21389 from nextcloud/backport/21380/stable17Roeland Jago Douma2020-07-041-7/+7
|\ \ \ | |/ / |/| | [stable17] Increase timeout of the appstore requests
| * | Increase timeout of the appstore requestsJoas Schilling2020-07-031-7/+7
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #21552 from nextcloud/backport/21535/stable17Roeland Jago Douma2020-07-021-12/+26
|\ \ \ | | | | | | | | [stable17] Fix language in share notes email for users
| * | | Fix language in share notes email for usersJoas Schilling2020-06-241-12/+26
| |/ / | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* / / Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validatingJoas Schilling2020-07-021-0/+28
|/ / | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #21158 from ↵Joas Schilling2020-06-081-9/+247
|\ \ | |/ |/| | | | | nextcloud/backport/21143/stable17-fix-password-changes-in-link-and-mail-shares [stable17] Fix password changes in link and mail shares
| * Fix disabling send password by Talk without new password in mail sharesDaniel Calviño Sánchez2020-06-011-5/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When "send password by Talk" was disabled in a mail share it was possible to keep the same password as before, as it does not pose any security issue (unlike keeping it when "send password by Talk" is enabled, as in that case the password was already disclosed by mail). However, if a mail share is updated but the password is not set again only the hashed password will be available. In that case it would not make sense to send the password by mail, so now the password must be changed when disabling "send password by Talk". Note that, even if explicitly setting the same password again along with the "send password by Talk" property would work, this was also prevented for simplicity. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix enabling send password by Talk with same password in mail sharesDaniel Calviño Sánchez2020-06-011-4/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | When "send password by Talk" is enabled in a mail share a new password must be also set. However, when the passwords of the original and the new share were compared it was not taken into account that the original password is now hashed, while the new one is not (unless no new password was sent, in which case the password of the original share was set in the new share by the controller, but that was already prevented due to both passwords being literally the same), so it was possible to set the same password again. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix enabling send password by Talk with empty password in link sharesDaniel Calviño Sánchez2020-06-011-0/+69
| | | | | | | | | | | | | | When "send password by Talk" is enabled in a link share now a non empty password is enforced. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Prevent harder to share your rootJoas Schilling2020-06-041-2/+4
|/ | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #21110 from nextcloud/backport/19793/stable17Roeland Jago Douma2020-05-281-18/+0
|\ | | | | [stable17] Fix resharing of federated shares that were created out of links
| * Remove unneeded test since links have resharing permissions by defaultJulius Härtl2020-05-261-18/+0
| | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | use the loginname to verify the old password in user password changesArthur Schiwon2020-05-261-5/+27
| | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | Do not read certificate bundle from data dir by defaultMorris Jobke2020-05-251-3/+2
|/ | | | | | | | | | | Before the resources/config/ca-bundle.crt was only used when the list of custom certificates was empty and the instance was not installed. But it should also be used when the list is empty and the instance is installed. This is inverting the logic to stop if the instance is not installed to use the default bundle. And it also does this when the list is empty. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Merge pull request #20986 from nextcloud/backport/20955/stable17Roeland Jago Douma2020-05-251-3/+3
|\ | | | | [stable17] Proxy server could cache http response when it is not private
| * Fix http testCacheSecondsClement Wong2020-05-231-2/+2
| | | | | | | | Signed-off-by: Clement Wong <git@clement.hk>
| * Fix http cache testClement Wong2020-05-151-1/+1
| | | | | | | | Signed-off-by: Clement Wong <git@clement.hk>
* | Merge pull request #20966 from nextcloud/backport/20033/stable17Morris Jobke2020-05-252-2/+18
|\ \ | | | | | | [stable17] Enable fseek for files in S3 storage
| * | add basic tests for s3 seeking and add some error handling if reopen return ↵Robin Appelman2020-05-222-2/+18
| |/ | | | | | | | | | | the wrong range Signed-off-by: Robin Appelman <robin@icewind.nl>
* | Compress the appstore requests by defaultMorris Jobke2020-05-201-5/+42
| | | | | | | | | | | | In test it reduced the transfered data from 5 MB to 2 MB. This should reduce the load on the appstore significantly. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Cache appstore requests for 60 instead of 5 minutesMorris Jobke2020-05-201-7/+7
|/ | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Use random_bytesRoeland Jago Douma2020-05-111-1/+8
| | | | | | | Since we don't care if it is human readbale. The code is backwards compatible with the old format. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix Argon2 options checksMichaIng2020-05-011-0/+5
| | | | | | | | | | | The minimum for memory cost is 8 KiB per thread. Threads must be checked and set first to allow checking against the correct memory cost mimimum. Options are now applied the following way: - If config.php contains the setting with an integer higher or equal to the minimum, it is applied. - If config.php contains the setting with an integer lower than the minimum, the minimum is applied. - If config.php does not contain the setting or with no integer value, the PHP default is applied. Signed-off-by: MichaIng <micha@dietpi.com> Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #20513 from nextcloud/backport/20246/stable17Roeland Jago Douma2020-04-203-4/+11
|\ | | | | [stable17] Provide the proper language to the mailer
| * Provide the proper language to the mailerRoeland Jago Douma2020-04-203-4/+11
| | | | | | | | | | | | | | Else we can't properly translate the footer in the recipients e-mail language. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | add DB tests for credentials managerArthur Schiwon2020-04-161-0/+3
|/ | | | | | | these are actually expected to FAIL, because NULL as a userid is not allowed in the schema, but documented to be used on the source Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Fix absolute redirectJohn Molakvoæ (skjnldsv)2020-04-151-3/+3
| | | | Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
* Check the user on remote wipeJoas Schilling2020-03-252-15/+34
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Remove admin_notifications since it is obsolete since Nextcloud 14Julius Härtl2020-03-241-1/+0
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Force compatible dependency versions in acceptance testsDaniel Calviño Sánchez2020-03-201-2/+2
| | | | | | | | | | | | behat/mink 1.8 and behat/mink-selenium2-driver 1.4 introduced behaviour changes that broke the acceptance tests. Until the tests are updated to work with the newer versions the last known versions are forced. Note that some acceptance tests still fail after enforcing the compatible versions, although that is caused by changes in the Nextcloud server itself. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Add message for DoesNotExistExceptionDaniel Kesselberg2020-03-061-0/+17
| | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* Strip of users home path from share api messageJoas Schilling2020-02-221-0/+3
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* when we receive intentional empty whats new info, do not try to show itArthur Schiwon2020-02-141-0/+4
| | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* Make sure to catch php errors during job executionDaniel Kesselberg2020-02-031-0/+21
| | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* Do not encode contacts menu mailto linksChristoph Wurst2020-01-301-1/+1
| | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* AppFetcher: Distinguish between fileName and endpointNameGeorg Ehrke2020-01-271-1305/+1387
| | | | | | Signed-off-by: Georg Ehrke <developer@georgehrke.com> (cherry picked from commit 2f89f5fd13334506ee5f137697149a237f1c2919)
* Restore old behavior allowing to set custom appstoreGeorg Ehrke2020-01-062-1/+18
| | | | Signed-off-by: Georg Ehrke <developer@georgehrke.com>
* Update the unit test to dataProvidersJoas Schilling2019-12-121-42/+77
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Move overwritehost check to isTrustedDomainJulius Härtl2019-12-091-1/+16
| | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* Handle token insert conflictsChristoph Wurst2019-12-021-11/+44
| | | | | | | | | | | | | | | | Env-based SAML uses the "Apache auth" mechanism to log users in. In this code path, we first delete all existin auth tokens from the database, before a new one is inserted. This is problematic for concurrent requests as they might reach the same code at the same time, hence both trying to insert a new row wit the same token (the session ID). This also bubbles up and disables user_saml. As the token might still be OK (both request will insert the same data), we can actually just check if the UIDs of the conflict row is the same as the one we want to insert right now. In that case let's just use the existing entry and carry on. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* Do not check for updates if we have no internetRoeland Jago Douma2019-11-201-24/+64
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Harden middleware checkRoeland Jago Douma2019-10-251-4/+85
| | | | | | | These annotations will allow for extra checks. And thus make it harder to break things. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* fix oauth client redirectSergej Nikolaev2019-10-071-1/+2
| | | | Signed-off-by: Sergej Nikolaev <kinolaev@gmail.com>
* fix updating and deleting authtokensSergej Nikolaev2019-10-051-0/+45
| | | | Signed-off-by: Sergej Nikolaev <kinolaev@gmail.com>