summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Use ::class in test mocks of encryption appMorris Jobke2017-10-267-15/+24
| | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Merge pull request #6939 from nextcloud/class-usage-in-mocks-dav-appMorris Jobke2017-10-267-11/+14
|\ | | | | Use ::class in test mocks of dav app
| * Use ::class in test mocks of dav appMorris Jobke2017-10-267-11/+14
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #6709 from ↵Morris Jobke2017-10-252-7/+57
|\ \ | |/ |/| | | | | nextcloud/show-checkbox-where-the-favourite-icon-is-now Show checkbox where the favourite icon is now
| * Solve acceptance test failure due to clicks on covered elementsDaniel Calviño Sánchez2017-10-192-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Firefox and Chrome drivers for Selenium refuse to click on an element if the point to be clicked is covered by a different element, throwing an UnknownError exception with message "Element is not clickable at point ({x}, {y}). Other element would receive the click: {element}". Although in general that would be a legit error (as the user would not be able to click on the element) due to a bad layout, sometimes this can be just a temporal issue caused by an animation, in which case there would be no problem once the animation finished and the elements are all in their final location. Unfortunately, automatically handling those situations in which the problem is caused by an animation by just retrying a few times if the element to be clicked is covered before giving up would probably cause confusion instead of easing test writing. The reason is that if the center of the element is covered by another one the Firefox driver for Selenium tries to click on the corners of the element instead. The problem is that the coordinates used for the click are integer values, but Firefox has sub-pixel accuracy, so sometimes (depending on which corner is not covered and whether the left, top, width or height properties of the element to be clicked have a decimal component or not) the clicks silently land on a different HTML element (and that is with squared borders; with round borders they always land on a different HTML element. That was partially addressed for Selenium 3.0 by clicking first on the edges, but it would still fail if the middle point of the edges is covered but not the corners). It is not possible to fix or even detect all that from the tests (except maybe with some extreme hacks involving accessing private PHP members from Mink and bypassing or replacing the standard JavaScript executed by the Firefox driver with a custom implementation...), so it is not possible to ensure that clicks during an animation will land on the right element (in fact it is not possible even on static elements, although except when the layout is wrong there should be no problem); sometimes retrying a click when the element is covered would solve the problem, sometimes it would cause a different element to be clicked (and sometimes there would be even no retry, as the first click would have silently landed on a different element than the expected one). Therefore, a different approach must be used. Instead of trying to automatically handle clicks during animations the tests must be written being aware of the problem and thus waiting somehow for the animations that can cause a problem to end before performing the clicks. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Replace inline favorite action with just a favorite iconDaniel Calviño Sánchez2017-10-191-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a preparatory step for a following commit in which the position of the favorite icon and the checkbox will be swapped; in that new design the favorite icon is no longer expected to be an action but just a simple mark on whether the file is favorited or not (the action is expected to be triggered then only from the file actions menu). The favorite icon is now fully shown or completely hidden depending on whether the file is favorited or not. As the icon is just informative but no longer an action now it does not change when hovered or focus. In the same way, the alternative text when the file is not favorited now it is not "Favorite" (an action) but "Not favorited" instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Update acceptance tests to favorite files through the file actions menuDaniel Calviño Sánchez2017-10-191-2/+20
| | | | | | | | | | | | | | | | | | Currently a file can be favorited either through the inline action or through the file actions menu. However, the inline action will be removed in a following commit and then it will be possible to do it only through the file actions menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Merge pull request #6921 from nextcloud/appmanager-securitymiddlewareRoeland Jago Douma2017-10-241-1/+9
|\ \ | | | | | | Use proper DI for security middleware for app enabled check
| * | Use proper DI for security middleware for app enabled checkMorris Jobke2017-10-241-1/+9
| |/ | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Use ::class in test mocksMorris Jobke2017-10-2458-208/+257
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #6919 from nextcloud/di-appmanager-encryption-migrationMorris Jobke2017-10-241-0/+6
|\ \ | | | | | | Use DI for IAppManager to encryption migration
| * | Use DI for IAppManager to encryption migrationMorris Jobke2017-10-241-0/+6
| |/ | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* / Provide tests for future timestamp formattingMorris Jobke2017-10-231-0/+9
|/ | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Set the data from the templateJoas Schilling2017-10-182-52/+29
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* fix urlBjoern Schiessle2017-10-171-2/+2
| | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* Merge pull request #6602 from nextcloud/s3-multipart-uploadRobin Appelman2017-10-111-4/+17
|\ | | | | Add multipart upload for s3
| * Add tests for multipart uploadRobin Appelman2017-09-211-4/+17
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | App management: add update sectionJulius Härtl2017-10-101-0/+6
| | | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* | Allow multiple settings and sections per appJoas Schilling2017-10-052-2/+8
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #6328 from nextcloud/split-sharees-api-logicblizzz2017-10-046-0/+2059
|\ \ | | | | | | Splits off the logic from sharees endpoint thus making it available from within Nc/via PHP.
| * | add tests for Lookup PluginArthur Schiwon2017-09-263-2/+180
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | move splitUserRemote unit testsArthur Schiwon2017-09-261-0/+75
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | split off former searchSharee unit testArthur Schiwon2017-09-261-0/+219
| | | | | | | | | | | | | | | | | | also moves registering default plugins to Server for proper unit testing Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | split off getEmail testsArthur Schiwon2017-09-261-0/+337
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | split off getRemote unit testsArthur Schiwon2017-09-261-0/+314
| | | | | | | | | | | | | | | | | | adds two small fixes → they actually work \o/ Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | split off getGroups unit testsArthur Schiwon2017-09-261-0/+491
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
| * | split off getUsers unit testsArthur Schiwon2017-09-261-0/+445
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | dont run invalid path repair step when upgrading from 11.0.5.2 and laterRobin Appelman2017-10-031-0/+30
| | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | Fix bigint handling on postgresJoas Schilling2017-09-291-0/+74
|/ / | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #6544 from nextcloud/fix/duplicate-session-tokenMorris Jobke2017-09-251-0/+8
|\ \ | | | | | | Fix duplicate session token after remembered login
| * | Fix duplicate session token after remembered loginChristoph Wurst2017-09-201-0/+8
| |/ | | | | | | | | | | | | | | | | On a remembered login session, we create a new session token in the database with the values of the old one. As we actually don't need the old session token anymore, we can delete it right away. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Handle SameSiteCookie check for index.php in AppFramework MiddlewareRoeland Jago Douma2017-09-242-2/+145
| | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Merge pull request #6605 from nextcloud/oc_ocs_response_is_depMorris Jobke2017-09-211-4/+4
|\ \ | | | | | | OC_OCS_Response is deprecated
| * | OC_OCS_Response is deprecatedRoeland Jago Douma2017-09-211-4/+4
| |/ | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* / Fix testsRoeland Jago Douma2017-09-211-0/+9
|/ | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #5462 from nextcloud/add-frameancestor-supportLukas Reschke2017-09-181-0/+41
|\ | | | | Add CSP frame-ancestors support
| * Add CSP frame-ancestors supportThomas Citharel2017-09-151-0/+41
| | | | | | | | | | | | Didn't set the @since annotation yet. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
* | Add filter for `shareapi_allow_share_dialog_user_enumeration`Lukas Reschke2017-09-151-32/+125
| | | | | | | | | | | | | | | | This adjusts the contacts menu to also support searching by email address which is relevant in scenarios where no UID is known such as LDAP, etc. Furthermore, if `shareapi_allow_share_dialog_user_enumeration` is disabled only results are shown that match the full user ID or email address. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | Add testsTobia De Koninck2017-09-151-0/+129
| | | | | | | | Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
* | Fix testsTobia De Koninck2017-09-151-1/+19
|/ | | | Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
* Fix AppPassword 2FA authRoeland Jago Douma2017-09-121-1/+16
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Merge pull request #6414 from nextcloud/share-notification-wrong-languageMorris Jobke2017-09-081-0/+11
|\ | | | | Use the language of the recipient for the share notification
| * Use the language of the recipient for the share notificationJoas Schilling2017-09-081-0/+11
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Improve text: 'you have now' -> 'you now have'Leon Klingele2017-09-089-15/+15
|/ | | | Signed-off-by: Leon Klingele <leon@struktur.de>
* Merge pull request #6247 from nextcloud/oauth-state-undefinedMorris Jobke2017-09-061-0/+12
|\ | | | | Fix undefined index oauthState
| * Fix testsMorris Jobke2017-09-061-0/+12
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #6364 from nextcloud/fix_login_loopMorris Jobke2017-09-061-1/+5
|\ \ | |/ |/| Fix login with basic auth
| * Fix login with basic authRoeland Jago Douma2017-09-051-1/+5
| | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | Merge pull request #6358 from nextcloud/fix-mixup-of-id-and-nameMorris Jobke2017-09-053-3/+7
|\ \ | |/ |/| Set the meta data before everything
| * Fix testsMorris Jobke2017-09-052-2/+6
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-14 17:16:51 +0000