summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Return the user id in case of an errorJoas Schilling2017-08-291-1/+1
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #6177 from nextcloud/properly-add-slo-urlMorris Jobke2017-08-262-5/+15
|\ | | | | Properly allow \OCP\Authentication\IApacheBackend to specify logout URL
| * Inject \OCP\IURLGenerator to make tests workLukas Reschke2017-08-181-1/+11
| | | | | | | | Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
| * Properly allow \OCP\Authentication\IApacheBackend to specify logout URLLukas Reschke2017-08-182-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Any `\OCP\Authentication\IApacheBackend` previously had to implement `getLogoutAttribute` which returns a string. This string is directly injected into the logout `<a>` tag, so returning something like `href="foo"` would result in `<a href="foo">`. This is rather error prone and also in Nextcloud 12 broken as the logout entry has been moved with 054e161eb5f4a5c5c13ee322ae8e93ce66f01b13 inside the navigation manager where one cannot simply inject attributes. Thus this feature is broken in Nextcloud 12 which effectively leads to the bug described at nextcloud/user_saml#112, people cannot logout anymore when using SAML using SLO. Basically in case of SAML you have a SLO url which redirects you to the IdP and properly logs you out there as well. Instead of monkey patching the Navigation manager I decided to instead change `\OCP\Authentication\IApacheBackend` to use `\OCP\Authentication\IApacheBackend::getLogoutUrl` instead where it can return a string with the appropriate logout URL. Since this functionality is only prominently used in the SAML plugin. Any custom app would need a small change but I'm not aware of any and there's simply no way to fix this properly otherwise. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | Merge pull request #5870 from nextcloud/generate-system-wide-key-pairBjörn Schießle2017-08-241-15/+66
|\ \ | | | | | | extend the identity proof manager to allow system wide key pairs
| * | add prefix to user and system keys to avoid name collisionsBjoern Schiessle2017-08-101-5/+5
| | | | | | | | | | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
| * | extend the identity proof manager to allow system wide key pairsBjoern Schiessle2017-08-101-11/+62
| | | | | | | | | | | | Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* | | Merge pull request #6164 from nextcloud/dont-show-error-message-when-sql-failedRoeland Jago Douma2017-08-231-1/+20
|\ \ \ | | | | | | | | Prevent SQL error message in case of error
| * | | Prevent SQL error message in case of errorLukas Reschke2017-08-171-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `\OC\User\Database::createUser` can throw a PHP exception in case the UID is longer than permitted in the database. This is against it's PHPDocs and we should cast this to `false`, so that the regular error handling triggers in. The easiest way to reproduce is on MySQL: 1. Create user `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` in admin panel 2. Create user `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` in admin panel again 3. See SQL exception as error message Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | | | No password reset for disabled usersJoas Schilling2017-08-181-0/+29
| |_|/ |/| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #6161 from nextcloud/drone-s3Morris Jobke2017-08-172-355/+1
|\ \ \ | | | | | | | | Enable S3 tests on drone again
| * | | Enable object storage tests againMorris Jobke2017-08-171-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| * | | Remove windows config settings in testsMorris Jobke2017-08-172-354/+0
| |/ / | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* / / Always log cron executionMorris Jobke2017-08-171-8/+2
|/ / | | | | | | | | | | | | | | | | | | | | There was a setting to disable the last execution of cron. There is no known problem with this write access and it was also questioned when this feature was build in https://github.com/owncloud/core/pull/7689#issuecomment-38264707 Recently there was also a bug report about a non-visible last cron execution (#6088) - let's better remove this. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Cleanup unused methodsMorris Jobke2017-08-153-15/+15
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Merge pull request #6123 from nextcloud/cleanup-shareItemMorris Jobke2017-08-153-22/+22
|\ \ | | | | | | Cleanup usage of shareItem in internal code base
| * | Cleanup usage of shareItem in internal code baseMorris Jobke2017-08-153-22/+22
| | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | Merge pull request #6121 from nextcloud/cleanup-registerBackendMorris Jobke2017-08-153-4/+4
|\ \ \ | | | | | | | | Use proper methods for registerBackend
| * | | Use proper methods for registerBackendMorris Jobke2017-08-153-4/+4
| |/ / | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* / / Use proper methods for checkPasswordProtectedShareMorris Jobke2017-08-151-1/+1
|/ / | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Cleanup unused methodsMorris Jobke2017-08-151-880/+0
| | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | Add acceptance tests for setting the color in the Theming appDaniel Calviño Sánchez2017-08-103-0/+178
| | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Add getter for the timeout multiplierDaniel Calviño Sánchez2017-08-101-0/+9
|/ | | | | | | | | In some cases the acceptance tests have to explicitly wait for something to happen without using the "find" method from the actor; in those cases the timeout multiplier needs to be taken into account too, so the test cases must be able to retrieve it from the actor. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* Fix SessionTestRoeland Jago Douma2017-08-091-0/+11
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix RepairMimeTypeTestRoeland Jago Douma2017-08-091-4/+10
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix CacheTestRoeland Jago Douma2017-08-091-2/+2
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix LostControllerTestRoeland Jago Douma2017-08-091-0/+4
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix encryption testRoeland Jago Douma2017-08-091-2/+3
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix LoginControllerRoeland Jago Douma2017-08-091-0/+4
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Use symfony/translation for L10N pluralsRoeland Jago Douma2017-08-071-27/+0
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Move pre_shared and post_shared events to EventDispatcherRoeland Jago Douma2017-08-032-86/+237
| | | | | | | | * Now listeners for those events get proper share objects. * Legacy hooks still fired * Updated tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix last failures with oracleJoas Schilling2017-08-022-3/+8
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Fix querybuilder and functionbuilder testsJoas Schilling2017-08-022-25/+33
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Can not insert auto increment on oracleJoas Schilling2017-08-022-43/+48
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Fix missing escape on column and table nameJoas Schilling2017-08-021-1/+1
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Remove explicit type hints for ControllerLukas Reschke2017-08-011-4/+4
| | | | | | This is public API and breaks the middlewares of existing apps. Since this also requires maintaining two different code paths for 12 and 13 I'm at the moment voting for reverting this change. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* Merge pull request #5907 from nextcloud/add-metadata-to-throttle-callMorris Jobke2017-08-013-2/+11
|\ | | | | Add metadata to \OCP\AppFramework\Http\Response::throttle
| * Add metadata to \OCP\AppFramework\Http\Response::throttleLukas Reschke2017-07-273-2/+11
| | | | | | | | | | | | Fixes https://github.com/nextcloud/server/issues/5891 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | Merge pull request #5877 from nextcloud/typehint_middlewareMorris Jobke2017-08-015-71/+82
|\ \ | | | | | | Prop argument type for Middleware
| * | Fix testsRoeland Jago Douma2017-07-314-67/+77
| | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| * | Fix middleware implementations signaturesRoeland Jago Douma2017-07-311-4/+5
| | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | Merge pull request #5897 from nextcloud/add-share-mail-for-user-shareRoeland Jago Douma2017-08-011-7/+40
|\ \ \ | | | | | | | | Send an email once a file/folder is shared with a user
| * | | Send an email once a file/folder is shared with a userMorris Jobke2017-07-281-7/+40
| | |/ | |/| | | | | | | | | | | | | | | | * only if user has set an email address * only for user shares (no group shares for now) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | Update the URLs in tests to use example.orgMorris Jobke2017-08-012-14/+14
| | | | | | | | | | | | Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* | | Fix testsRoeland Jago Douma2017-08-012-4/+4
| | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | Replace wrong PHPDocsLukas Reschke2017-08-011-2/+3
| | | | | | | | | | | | Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | | Fix settings/Controller/Lukas Reschke2017-08-011-2/+2
| | | | | | | | | | | | Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | | Stricter phan config fixesLukas Reschke2017-08-011-3/+3
| | | | | | | | | | | | Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* | | Merge pull request #5890 from nextcloud/fix-403-and-404-redirectRoeland Jago Douma2017-07-311-20/+0
|\ \ \ | |_|/ |/| | Fix 403 and 404 redirect
| * | Fix 403 and 404 redirectMorris Jobke2017-07-261-20/+0
| | | | | | | | | | | | | | | | | | | | | | | | * Nextcloud is not properly loaded in the standalone version (especially the theming) * it is already not listed anymore in the Nginx config (see nextcloud/documentation#392) * the index.php-free version doesn't support this Signed-off-by: Morris Jobke <hey@morrisjobke.de>