| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
|\
| |
| | |
Properly allow \OCP\Authentication\IApacheBackend to specify logout URL
|
| |
| |
| |
| | |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Any `\OCP\Authentication\IApacheBackend` previously had to implement `getLogoutAttribute` which returns a string.
This string is directly injected into the logout `<a>` tag, so returning something like `href="foo"` would result
in `<a href="foo">`.
This is rather error prone and also in Nextcloud 12 broken as the logout entry has been moved with
054e161eb5f4a5c5c13ee322ae8e93ce66f01b13 inside the navigation manager where one cannot simply inject attributes.
Thus this feature is broken in Nextcloud 12 which effectively leads to the bug described at nextcloud/user_saml#112,
people cannot logout anymore when using SAML using SLO. Basically in case of SAML you have a SLO url which redirects
you to the IdP and properly logs you out there as well.
Instead of monkey patching the Navigation manager I decided to instead change `\OCP\Authentication\IApacheBackend` to
use `\OCP\Authentication\IApacheBackend::getLogoutUrl` instead where it can return a string with the appropriate logout
URL. Since this functionality is only prominently used in the SAML plugin. Any custom app would need a small change but
I'm not aware of any and there's simply no way to fix this properly otherwise.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
|\ \
| | |
| | | |
extend the identity proof manager to allow system wide key pairs
|
| | |
| | |
| | |
| | | |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
|
|\ \ \
| | | |
| | | | |
Prevent SQL error message in case of error
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`\OC\User\Database::createUser` can throw a PHP exception in case the UID is longer than
permitted in the database. This is against it's PHPDocs and we should cast this to `false`,
so that the regular error handling triggers in.
The easiest way to reproduce is on MySQL:
1. Create user `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` in admin panel
2. Create user `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` in admin panel again
3. See SQL exception as error message
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
| |_|/
|/| |
| | |
| | | |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
|\ \ \
| | | |
| | | | |
Enable S3 tests on drone again
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
| |/ /
| | |
| | |
| | | |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There was a setting to disable the last execution of cron. There is no known
problem with this write access and it was also questioned when this feature
was build in https://github.com/owncloud/core/pull/7689#issuecomment-38264707
Recently there was also a bug report about a non-visible last cron execution
(#6088) - let's better remove this.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
| |
| |
| |
| | |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
|\ \
| | |
| | | |
Cleanup usage of shareItem in internal code base
|
| | |
| | |
| | |
| | | |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
|\ \ \
| | | |
| | | | |
Use proper methods for registerBackend
|
| |/ /
| | |
| | |
| | | |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
|/ /
| |
| |
| | |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
| |
| |
| |
| | |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
| |
| |
| |
| | |
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
|/
|
|
|
|
|
|
|
| |
In some cases the acceptance tests have to explicitly wait for something
to happen without using the "find" method from the actor; in those cases
the timeout multiplier needs to be taken into account too, so the test
cases must be able to retrieve it from the actor.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
|
|
|
| |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
|
|
| |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
|
|
| |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
|
|
| |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
|
|
| |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
|
|
| |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
|
|
| |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
|
|
|
|
|
|
| |
* Now listeners for those events get proper share objects.
* Legacy hooks still fired
* Updated tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|
|
|
| |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
|
|
|
| |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
|
|
|
| |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
|
|
|
| |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
|
|
|
|
|
| |
This is public API and breaks the middlewares of existing apps. Since this also requires maintaining two different code paths for 12 and 13 I'm at the moment voting for reverting this change.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
|\
| |
| | |
Add metadata to \OCP\AppFramework\Http\Response::throttle
|
| |
| |
| |
| |
| |
| | |
Fixes https://github.com/nextcloud/server/issues/5891
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
|\ \
| | |
| | | |
Prop argument type for Middleware
|
| | |
| | |
| | |
| | | |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
|\ \ \
| | | |
| | | | |
Send an email once a file/folder is shared with a user
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
* only if user has set an email address
* only for user shares (no group shares for now)
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
|\ \ \
| |_|/
|/| | |
Fix 403 and 404 redirect
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Nextcloud is not properly loaded in the standalone version (especially the theming)
* it is already not listed anymore in the Nginx config (see nextcloud/documentation#392)
* the index.php-free version doesn't support this
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|