summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Escape filename in Content-DispositionLukas Reschke2021-06-021-11/+25
| | | | | | We should escape all occurences of ' and \ in here. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
* Merge pull request #26792 from nextcloud/user-delete-cleanup-filesJohn Molakvoæ2021-06-021-0/+3
|\ | | | | better cleanup of user files on user deletion
| * better cleanup of user files on user deletionRobin Appelman2021-04-271-0/+3
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | Merge pull request #25658 from ↵Christoph Wurst2021-06-011-45/+60
|\ \ | | | | | | | | | | | | nextcloud/dav-respect-disallow-sharing-with-groups Dav respect disallow sharing with groups
| * | Make dav respect disallowing sharing with groupsThomas Citharel2021-05-261-45/+60
| | | | | | | | | | | | | | | | | | Closes #25390 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
* | | Rewrite requesttoken.spec.js with JestFrançois Freitag2021-05-301-0/+26
|/ / | | | | | | | | | | | | | | | | | | | | [Jest](https://jestjs.io/) is a test runner that focuses on simplicity. It instruments babel to transform modules and test them. Using Jest simplifies the existing configuration and allows dropping a bunch of workarounds, as well as following the shared Babel configuration for new code. Signed-off-by: François Freitag <mail@franek.fr>
* | Merge pull request #27035 from ↵blizzz2021-05-253-18/+40
|\ \ | | | | | | | | | | | | nextcloud/techdebt/26866/userscontroller-accountmanager-api do not use private AccountManager in UsersController
| * | do not use private AccountManager in UsersControllerArthur Schiwon2021-05-253-18/+40
| | | | | | | | | | | | | | | | | | | | | | | | - extends IAccountProperty for verificationData getters and setters - implementation thereof ^ - and of course adaption of UsersController Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | Merge pull request #26600 from hosting-de/feature/occ-tagsMorris Jobke2021-05-254-0/+552
|\ \ \ | |/ / |/| | Add commands to manage tags via OCC
| * | Add commands to manage tags via OCCJohannes Leuker2021-05-254-0/+552
| | | | | | | | | | | | | | | | | | list, add, delete, edit Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
* | | Merge pull request #26727 from nextcloud/group-exclude-link-shareMorris Jobke2021-05-212-59/+23
|\ \ \ | | | | | | | | Add option to exclude groups from creating link shares
| * | | load share settings from the share manager in more placesRobin Appelman2021-05-122-59/+23
| | | | | | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | l10n: Fix testValdnet2021-05-201-23/+23
| | | |
* | | | Merge pull request #26322 from nextcloud/recent-searchJulius Härtl2021-05-181-0/+13
|\ \ \ \ | | | | | | | | | | Use file search for recent files and optimize getting share types
| * | | | adjust testsRobin Appelman2021-04-211-0/+13
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | | Merge pull request #26626 from J0WI/strict-securityRoeland Jago Douma2021-05-1822-0/+64
|\ \ \ \ \ | | | | | | | | | | | | Make Security module strict
| * | | | | Make Security module strictJ0WI2021-04-1922-0/+64
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: J0WI <J0WI@users.noreply.github.com>
* | | | | | Merge pull request #26679 from ↵blizzz2021-05-131-50/+49
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | nextcloud/bugfix/noid/fix-unauthorized-ocs-status-in-provisioning Fix unauthorized OCS status in provisioning
| * | | | | Fix unauthorized OCS status in provisioningJoas Schilling2021-05-121-50/+49
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | | allow to set valid scopes only in AccountPropertyArthur Schiwon2021-05-122-7/+25
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | the auto-fallback to v2-local is removed as well to react on wrong input Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | | | Merge pull request #26758 from J0WI/more-strictChristoph Wurst2021-04-281-0/+2
|\ \ \ \ \ | | | | | | | | | | | | Some more strict_types
| * | | | | Use strictJ0WI2021-04-261-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: J0WI <J0WI@users.noreply.github.com>
* | | | | | Merge pull request #26591 from nextcloud/techdebt/noid/less-iloggerChristoph Wurst2021-04-2718-77/+81
|\ \ \ \ \ \ | | | | | | | | | | | | | | Less ILogger
| * | | | | | Fix unit testsJoas Schilling2021-04-2718-77/+81
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | | Merge pull request #26718 from nextcloud/bugfix/noid/fix-ratelimit-templateJoas Schilling2021-04-271-11/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix ratelimit template
| * | | | | | Fix ratelimit templateJoas Schilling2021-04-271-11/+9
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | | Merge pull request #26572 from ↵Joas Schilling2021-04-271-4/+5
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | nextcloud/bugfix/noid/throw-401-when-authentication-is-provided-and-invalid Throw "401 Unauthenticated" when authentication is provided but invalid
| * | | | | Fix Authentication testJoas Schilling2021-04-221-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | | Merge pull request #26259 from ↵Joas Schilling2021-04-261-0/+26
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | nextcloud/feature/noid/validate-website-to-be-valid Validate the website field input to be a valid URL
| * | | | | Validate the website field input to be a valid URLJoas Schilling2021-04-221-0/+26
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | Merge pull request #26375 from ↵Morris Jobke2021-04-223-2/+30
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | nextcloud/techdebt/noid/symfony-component-translation-pluralization-rules-is-deprecated "Symfony\Component\Translation\PluralizationRules" is deprecated
| * | | | Fix test by defining pluralsJoas Schilling2021-04-201-1/+5
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
| * | | | Correctly replace all PHP placeholders with the parametersJoas Schilling2021-04-202-1/+25
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | Merge pull request #23529 from Simounet/feat/23397-settings-new-user-modalJohn Molakvoæ2021-04-211-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Settings: new user row replaced by a modal
| * | | | | Settings: new user row replaced by a modalSimounet2021-04-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Simounet <contact@simounet.net>
* | | | | | set mimetype for objects uploaded to object storagesRobin Appelman2021-04-213-4/+4
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | | | Merge pull request #26669 from nextcloud/nickvergessen-patch-1Morris Jobke2021-04-211-3/+0
|\ \ \ \ \ | |_|_|/ / |/| | | | Fix PHP CS
| * | | | Update CredentialsManagerTest.phpJoas Schilling2021-04-211-3/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | Merge pull request #25991 from nextcloud/update-acceptance-tests-to-selenium3John Molakvoæ2021-04-218-8/+57
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Add automatic handling of "ElementNotInteractable" exceptionsDaniel Calviño Sánchez2021-04-191-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the WebDriver protocol, when a command fails because it can not interact with the target element, an "element not interactable" error is generated. It can be a transitive issue (for example, due to an animation), so when the error is received the command should be tried again, just like done, for example, with "ElementNotVisible" exceptions. However, the last version of the "instaclick/php-webdriver" library compatible with the Selenium Driver of Mink did not support yet that WebDriver error. And even if Chrome is run using the old protocol an unknown "element not interactable" error can be received anyway in some cases. When an unknown error is received by the "instaclick/php-webdriver" library it is thrown as a generic Exception so, until the library can be updated, the message of generic exceptions is checked and the command is retried if it matched. For the time being "element not interactable" errors are handled like "ElementNotVisible" exceptions; this may need to change once the error is better understood. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | Update acceptance tests to Selenium 3Daniel Calviño Sánchez2021-04-162-2/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The acceptance tests used the last Selenium 2 Docker container available, which provides a rather old Firefox version (Firefox 47). Nevertheless, despite some rendering issues, most things still worked as expected due to the JavaScript files being built with support for older browsers. However, now that support for Internet Explorer 11 and older browsers will be dropped things could start to fail, so a newer browser (and thus a newer Selenium version) should be used in the acceptance tests. Selenium has been standardized by the W3C, and the protocol to communicate between the Selenium server and the browser has changed due to that. Firefox >= 48 only supports the new W3C protocol, but the Selenium driver for Mink does not support it yet. The old protocol can still be used in recent Chromium/Chrome versions by explicitly forcing it, so for the time being the acceptance tests will need to be run on Chrome instead (although Firefox provides some interesting features like the fake streams that would be needed to test calls in Talk, so they should be moved again to Firefox once possible). Finally, the default shm size of Docker is 64 MiB. This does not seem enough to run newer Chrome releases and causes the browser to randomly crash during the tests ("unknown error: session deleted because of page crash" is shown in the logs). Due to this "disable-dev-shm-usage" needs to be used so Chrome writes shared memory files into "/tmp" instead of "/dev/shm" (the default shm size of Docker could have been increased instead using "docker run --shm-size...", but that seems to be problematic when the container is run in current Drone releases). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | Replace carriage return with WebDriver "ENTER" constantDaniel Calviño Sánchez2021-04-162-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the value is set in some input fields a carriage return was sent to simulate pressing the enter key and thus confirming the input. However, different browsers use different keys (Firefox uses "\r", but Chrome uses "\n"), so the carriage return was replaced with the WebDriver "ENTER" constant which is common to both browsers. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | | | Do not send "enter" key when not neededDaniel Calviño Sánchez2021-04-163-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sending the "enter" key is not needed in those input fields that auto save while the user is typing or when the focus is lost (which since version 1.4.0 the Selenium driver for Mink is automatically done after setting the value). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | | | | Merge pull request #26654 from ↵Morris Jobke2021-04-201-18/+11
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | nextcloud/bugfix/noid/fix-security-credentials-manager-test Fix security credentials manager test
| * | | | | Fix security credentials manager testJoas Schilling2021-04-201-18/+11
| | |/ / / | |/| | | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | | Move 2FA registration to IBootstrapRoeland Jago Douma2021-04-201-1/+38
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | | Fix support testsJoas Schilling2021-04-201-2/+5
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #0 (35, 15, 2, false) Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist 3) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #1 (35, 45, 15, false) Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist 4) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #2 (35, 45, 5, true) Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist 5) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #3 (35, 45, 55, false) Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist Had to use the Database user backend, as using multiple interfaces is deprecated: https://github.com/sebastianbergmann/phpunit/issues/3955 > This functionality should be deprecated as "having to use it" is almost always a symptom of bad design. > More importantly, though, the support for the creation of test doubles that implement multiple interfaces > resulted in code that is hard to maintain. Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | | save a whitespace todayblizzz2021-04-201-1/+1
| | | | | | | | | | | | | | | | | | | | Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | | ignore mail shares of related remote share resultsArthur Schiwon2021-04-201-22/+75
| |/ / |/| | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | Merge pull request #26555 from nextcloud/techdebt/noid/run-migrator-tests-on-OCIJoas Schilling2021-04-191-3/+49
|\ \ \ | |/ / |/| | Run migrator tests on OCI