summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #21759 from nextcloud/enh/lazy_subscriptionRoeland Jago Douma2020-07-092-2/+75
|\ | | | | Make the subscription registry lazy
| * Add DummySubscription for testsDaniel Kesselberg2020-07-092-0/+68
| | | | | | | | Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
| * Make the subscription registry lazyRoeland Jago Douma2020-07-091-2/+7
| | | | | | | | | | | | | | This will allow to do lazy registration here which should allow for loading less (or at least only when needed!). Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | ensure mounts are scanned during testsRobin Appelman2020-07-092-1/+7
| | | | | | | | Signed-off-by: Robin Appelman <robin@icewind.nl>
* | Use the correct mountpoint to calculateRoeland Jago Douma2020-07-091-0/+9
|/ | | | | | | If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Fix supporting defaults for routesRoeland Jago Douma2020-07-081-14/+10
| | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Do not create a RouteActionHandler object for each routeRoeland Jago Douma2020-07-071-4/+3
| | | | | | | | | | This is not required and doesn't allow us to be properly lazy. On top of it this doesnt allow us to cache the routes (since closures/objects can't be cached). This is the first small step into cleaning up the routing we have Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* Update SecurityMiddleware.phpHolger Hees2020-07-061-1/+1
| | | | | | OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header. in other areas OC::$WEBROOT is always used together with an /
* Tags.php and the old sharing mechanismMorris Jobke2020-07-061-36/+0
| | | | | | The old sharing mechanism isn't working anymore, because it was replaced by Share 2.0. Also it was nowhere used so this removes the code paths and reduces complexity. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* Merge pull request #21626 from nextcloud/enhancement/injectible-callablesMorris Jobke2020-07-052-3/+90
|\ | | | | Callable parameter injection
| * Callable parameter injectionChristoph Wurst2020-07-032-3/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is like what we have to DI and classes, but for callables. The motivating factor is to get rid of *service locators* in the `boot` method of apps as a new pattern is about to emerge where we have lots of `query` calls on the app or server container in order to fetch some services. With this little helper it's possible to call another (public) method and magically have everything injected. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Merge pull request #21439 from ↵Joas Schilling2020-07-031-3/+3
|\ \ | |/ |/| | | | | nextcloud/feature/noid/move-autocomplete-filter-event-to-new-dispatcher-and-class Move AutoComplete::filterResults to new event dispatcher and GenericE…
| * Move AutoComplete::filterResults to new event dispatcher and GenericEventJoas Schilling2020-07-011-3/+3
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #21360 from nextcloud/root-storage-prevent-scanningRoeland Jago Douma2020-07-021-0/+59
|\ \ | | | | | | prevent the root storage from accidentally scanning user folders
| * | prevent the root storage from accidentally scanning user foldersRobin Appelman2020-06-111-0/+59
| | | | | | | | | | | | | | | | | | | | | while this scan *should* never be triggered, it's good to have some failsafe to ensure that the users home contents don't end up getting scanned in the root storage Signed-off-by: Robin Appelman <robin@icewind.nl>
* | | Merge pull request #21599 from nextcloud/debt/noid/type-to-typesRoeland Jago Douma2020-07-021-3/+3
|\ \ \ | | | | | | | | Replace TYPE with TYPES
| * | | Replace TYPE with TYPESDaniel Kesselberg2020-06-301-3/+3
| | |/ | |/| | | | | | | | | | | | | As TYPE::* is deprecated. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
* | | Merge pull request #21653 from ↵Roeland Jago Douma2020-07-021-0/+28
|\ \ \ | | | | | | | | | | | | | | | | nextcloud/bugfix/noid/fix-ipv6-remote-addresses-from-x-forwarded-for-header Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating
| * | | Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validatingJoas Schilling2020-07-021-0/+28
| |/ / | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* / / Fix unit testsJoas Schilling2020-06-262-9/+9
|/ / | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Fix robots "noindex, nofollow" signalsJoas Schilling2020-06-253-3/+6
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #21379 from ↵Roeland Jago Douma2020-06-242-9/+216
|\ \ | | | | | | | | | | | | nextcloud/fix-share-permission-checkboxes-enabled-when-permissions-can-not-be-set Fix share permission checkboxes enabled when permissions can not be set
| * | Add acceptance test for disabling create permission after sharingDaniel Calviño Sánchez2020-06-111-0/+43
| | | | | | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | Add acceptance test for sharing a folder without create permissionDaniel Calviño Sánchez2020-06-112-0/+75
| | | | | | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | Add acceptance test for sharing a file without edit permissionDaniel Calviño Sánchez2020-06-112-0/+75
| | | | | | | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * | Generalize functions to get locators for share permission checkboxesDaniel Calviño Sánchez2020-06-111-9/+23
| |/ | | | | | | Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Fix testsJoas Schilling2020-06-241-1/+0
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Update share type constant usageJoas Schilling2020-06-2415-393/+395
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Add unified search APIChristoph Wurst2020-06-241-0/+6
| | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Fix language in share notes email for usersJoas Schilling2020-06-231-12/+29
| | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | Merge pull request #21452 from ↵Joas Schilling2020-06-231-37/+47
|\ \ | | | | | | | | | | | | nextcloud/bugfix/21451/allow-autocomplete-by-displayname-again Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on
| * | Fix unit testsJoas Schilling2020-06-181-37/+47
| | | | | | | | | | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* | | Merge pull request #21479 from nextcloud/fix/21474/allow_specifying_cookie_typeblizzz2020-06-221-6/+13
|\ \ \ | | | | | | | | Allow to specify the cookie type for appframework responses
| * | | Allow to specify the cookie type for appframework responsesRoeland Jago Douma2020-06-221-6/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In general it is good to set them to Lax. But also to give devs more control over them is not a bad thing. Helps with #21474 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | | Fix unit test of the ResponseTestRoeland Jago Douma2020-06-211-3/+3
|/ / / | | | | | | | | | Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
* | | acceptence tests shall specify which branch to pick when cloning appsArthur Schiwon2020-06-191-1/+2
| | | | | | | | | | | | Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
* | | Allow crash reporters registration during app bootstrapChristoph Wurst2020-06-192-5/+49
|/ / | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Add dedicated API for apps' bootstrapping processChristoph Wurst2020-06-173-0/+345
| | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | Merge pull request #21416 from nextcloud/fix/user-deleted-token-cleanupChristoph Wurst2020-06-161-0/+117
|\ \ | | | | | | Clean up auth tokens when user is deleted
| * | Clean up auth tokens when user is deletedChristoph Wurst2020-06-151-0/+117
| | | | | | | | | | | | Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
* | | Avoid duplicate matches in wide and exact resultsJulius Härtl2020-06-151-10/+31
|/ / | | | | | | Signed-off-by: Julius Härtl <jus@bitgrid.net>
* / Increase timeout of the appstore requestsJoas Schilling2020-06-121-3/+3
|/ | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Remove dropped " ON " when join has no conditionJoas Schilling2020-06-081-6/+6
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Prevent harder to share your rootJoas Schilling2020-06-031-2/+4
| | | | Signed-off-by: Joas Schilling <coding@schilljs.com>
* Merge pull request #21143 from ↵Roeland Jago Douma2020-05-291-9/+244
|\ | | | | | | | | nextcloud/fix-password-changes-in-link-and-mail-shares Fix password changes in link and mail shares
| * Fix disabling send password by Talk without new password in mail sharesDaniel Calviño Sánchez2020-05-291-5/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When "send password by Talk" was disabled in a mail share it was possible to keep the same password as before, as it does not pose any security issue (unlike keeping it when "send password by Talk" is enabled, as in that case the password was already disclosed by mail). However, if a mail share is updated but the password is not set again only the hashed password will be available. In that case it would not make sense to send the password by mail, so now the password must be changed when disabling "send password by Talk". Note that, even if explicitly setting the same password again along with the "send password by Talk" property would work, this was also prevented for simplicity. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix enabling send password by Talk with same password in mail sharesDaniel Calviño Sánchez2020-05-281-4/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | When "send password by Talk" is enabled in a mail share a new password must be also set. However, when the passwords of the original and the new share were compared it was not taken into account that the original password is now hashed, while the new one is not (unless no new password was sent, in which case the password of the original share was set in the new share by the controller, but that was already prevented due to both passwords being literally the same), so it was possible to set the same password again. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
| * Fix enabling send password by Talk with empty password in link sharesDaniel Calviño Sánchez2020-05-281-0/+69
| | | | | | | | | | | | | | When "send password by Talk" is enabled in a link share now a non empty password is enforced. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
* | Move the systemtags to core/srcRoeland Jago Douma2020-05-281-0/+1
|/ | | | | | | * Move to the handlebar loader from webpack Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
* Add lazy events for the Node APIRoeland Jago Douma2020-05-281-38/+97
| | | | | | | | | | | Right now if you want to get events via the Node API you have to have a real instance of the Root. Which in turns sets up the whole FS. We should make sure this is done lazy. Else enabling the preview generator for example makes you setup the whole FS on each and every authenticated call. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>