From 5f0887c1d58690fe3fe7db451746e448a10914af Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Wed, 10 Oct 2018 10:40:30 +0200 Subject: Fix a misleading setup check for .well-known/caldav & carddav The problem is that the version without the slash is the correct one. Signed-off-by: Morris Jobke --- core/js/tests/specs/setupchecksSpec.js | 8 ++++---- settings/js/admin.js | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/js/tests/specs/setupchecksSpec.js b/core/js/tests/specs/setupchecksSpec.js index 4c0545b7b4f..6170a427241 100644 --- a/core/js/tests/specs/setupchecksSpec.js +++ b/core/js/tests/specs/setupchecksSpec.js @@ -62,13 +62,13 @@ describe('OC.SetupChecks tests', function() { describe('checkWellKnownUrl', function() { it('should fail with another response status code than 207', function(done) { - var async = OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav/', 'http://example.org/PLACEHOLDER', true); + var async = OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav', 'http://example.org/PLACEHOLDER', true); suite.server.requests[0].respond(200); async.done(function( data, s, x ){ expect(data).toEqual([{ - msg: 'Your web server is not properly set up to resolve "/.well-known/caldav/". Further information can be found in the documentation.', + msg: 'Your web server is not properly set up to resolve "/.well-known/caldav". Further information can be found in the documentation.', type: OC.SetupChecks.MESSAGE_TYPE_INFO }]); done(); @@ -76,7 +76,7 @@ describe('OC.SetupChecks tests', function() { }); it('should return no error with a response status code of 207', function(done) { - var async = OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav/', 'http://example.org/PLACEHOLDER', true); + var async = OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav', 'http://example.org/PLACEHOLDER', true); suite.server.requests[0].respond(207); @@ -87,7 +87,7 @@ describe('OC.SetupChecks tests', function() { }); it('should return no error when no check should be run', function(done) { - var async = OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav/', 'http://example.org/PLACEHOLDER', false); + var async = OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav', 'http://example.org/PLACEHOLDER', false); async.done(function( data, s, x ){ expect(data).toEqual([]); diff --git a/settings/js/admin.js b/settings/js/admin.js index 6ac569f2a37..de5bc2b9537 100644 --- a/settings/js/admin.js +++ b/settings/js/admin.js @@ -248,8 +248,8 @@ $(document).ready(function(){ // run setup checks then gather error messages $.when( OC.SetupChecks.checkWebDAV(), - OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav/', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true), - OC.SetupChecks.checkWellKnownUrl('/.well-known/carddav/', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true), + OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true), + OC.SetupChecks.checkWellKnownUrl('/.well-known/carddav', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true), OC.SetupChecks.checkSetup(), OC.SetupChecks.checkGeneric(), OC.SetupChecks.checkDataProtected() -- cgit v1.2.3